- 02 Oct, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55b66b22475b..64ba5a302bf0 Created with: gclient setdep -r src-internal@64ba5a302bf0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: Iaecadef1d4ea85fafb88c1be040d565c29c8399b Reviewed-on: https://chromium-review.googlesource.com/c/1257611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596015}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: If0224229b2bb6c6c848aba716cfc7faf89f34383 Reviewed-on: https://chromium-review.googlesource.com/c/1258054 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596014}
-
Christopher Cameron authored
All mojo interfaces that manipulate NSViews need to be associated (for example, adding an NSView as a child of another requires that the parent NSView be in a known state -- each NSView has its own interface, and so they all need to be associated to the same pipe). Also change all bindings to use ui::WindowResizeHelperMac's task runner. This task runner is used to pump a nested run loop inside a Cocoa resize function (for smooth resize). All bindings on the same associated connection need to use that task runner (otherwise, all messages will be blocked behind any un-handled message). Change BridgeFactoryHost to not assign a new host id, but take one in the constructor (just because the logic is easier to follow that way). R=domonickn TBR=avi (for content/ OWNERship) Bug: 821651 Change-Id: Ifb6aff292187b340d144d29ffe1258bb8d501267 Reviewed-on: https://chromium-review.googlesource.com/c/1253561 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#596013}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20afd180cccb..8775060263d6 git log 20afd180cccb..8775060263d6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 saklein@chromium.org cros_sdk_lib: remove unused command. 2018-10-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8775060263d6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4f8a747ceac10257f943585db9cbec8cd04789e5 Reviewed-on: https://chromium-review.googlesource.com/c/1257711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596012}
-
Henrique Nakashima authored
OpenActions that navigate to URIs are going to be blocked when https://pdfium-review.googlesource.com/c/pdfium/+/42731 relands. It was reverted because this test was breaking and blocking the pdfium roll into chromium. The test will now click on a link in the PDF that navigates to the URI. Bug: 851821 Change-Id: I49853e99de7b989858b1962ad4a92a4168d4c2db Reviewed-on: https://chromium-review.googlesource.com/c/1244367 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596011}
-
Christian Fremerey authored
The video capture service is designed to release resources and shut down when not in use. However, this leads to information about supported formats of the available devices, which is otherwise cached, having to be re-queried. On some platforms, in particular on Android, querying these formats can take a long time (i.e. several seconds). This CL changes the video capture service such that it holds on to the cached formats until the service is shut down. Before, this cache would be released as soon as the last client has disconnected, even if a client reconnects within the service shutdown timeout of 5 seconds. This fixes increased delay of camera capture start observed on Android. Bug: 878304, 792621 Change-Id: I8279e73d093006cf46f64c3a8cb02591bd4f4a59 Reviewed-on: https://chromium-review.googlesource.com/c/1228776Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596010}
-
Fady Samuel authored
In software draw, the entire app is a single software buffer, but webview is just drawing its content in a subrect, then the origin of the webview is not the origin of the bitmap. The rect within the full app software buffer is called the external viewport. In the case of a full viewport damage signal, when the device viewport doesn't intersect with the actual viewport, LayerTreeHostImpl::OnDraw thinks there is no damage and skips the whole frame, and then webview just appears missing or black. This CL fixes the issue by dropping the offset within the software buffer when specifying damage. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1291e96f2e1d1a04ec0ae9940bda1409eb59cd6 Bug: 877436 Reviewed-on: https://chromium-review.googlesource.com/c/1257555Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596009}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a115d8de1c98..cb192dee19d4 git log a115d8de1c98..cb192dee19d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 sadrul@chromium.org pinpoint: Include the metric name in the report. 2018-10-02 jbudorick@chromium.org devil: remove devil_arm.gni. Created with: gclient setdep -r src/third_party/catapult@cb192dee19d4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887888 TBR=sullivan@chromium.org Change-Id: I2efdf81816c6a740372cbb95eeabed8612cc605c Reviewed-on: https://chromium-review.googlesource.com/c/1257608Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2a88bcbaff3e..d73b9d8dfbf7 git log 2a88bcbaff3e..d73b9d8dfbf7 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jaebaek@google.com [Validator] AMD_gpu_shader_half_float_fetch allow float16 (#1393) 2018-10-02 jaebaek@google.com Validator: OpImageQuerySize validation (#1538) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d73b9d8dfbf7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaeeafccb8a03d4b9c3f86ec83e5e8963f3b84ddb Reviewed-on: https://chromium-review.googlesource.com/c/1257609Reviewed-by:
-
Varun Khaneja authored
This will be useful for the test team to verify that the feature is turned on or off. Bug: 747428 Change-Id: I7aba957453a5c52cdfcdec64bec778e0d2be2cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1258208Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596006}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /media. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=dalecurtis@chromium.org, tommi@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I223baa18f0318bb4c97570705d94bd9bc17c435b Reviewed-on: https://chromium-review.googlesource.com/c/1257886Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596005}
-
Eric Roman authored
Bug: 882019 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5c8f62c7615708e2b1019e11e9639552b9b267ae Reviewed-on: https://chromium-review.googlesource.com/c/1244101Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596004}
-
Joel Hockey authored
When a user opens files within Downloads using a crostini app, show a dialog for the user to give permission to share the directory that the files are in with crostini. * Move handling of 'crostin-files' flag checking into foreground/js/crostini.js * Change FileTasks.executeInternal to detect files that can be shared with crostini and do sharing before execute. * UI Test verifies share dialog is shown before execute. * ConvertFileSystemURLToPathInsideCrostini maps path from within Downloads to '/ChromeOS/Downloads/...' Bug: 878324 Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 Reviewed-on: https://chromium-review.googlesource.com/c/1243871Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596003}
-
Findit authored
This reverts commit 43ffa309. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595899 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDNmZmEzMDliZjMxMWNhODI5NzgwOTg4NmY1MmE1YWU0NzQ5ZGM0MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14146 Sample Failed Step: browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestIntermediateSliding Original change's description: > Top-chrome slide: Fix and test intermediate sliding > > Gesture scrolling starts before top-chrome starts > sliding. During that small period, the > `DoBrowserControlsShrinkRendererSize` bit should > remain unchanged. > > This CL fixes this issue and adds a test to verify > the state of the browser while top-chrome sliding > is in progress. > > BUG=884440, 867063 > TEST=Added new test > > Change-Id: I0737b5b38c727dd77fc522d9a52537f70abb16bd > Reviewed-on: https://chromium-review.googlesource.com/c/1249729 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595899} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=884440, 867063, 891516 Change-Id: I5acaddebf8b9aade85e0371dbf8b6933dcaae18c Reviewed-on: https://chromium-review.googlesource.com/c/1258215 Cr-Commit-Position: refs/heads/master@{#596002}
-
Marina Ciocea authored
In default sandbox policy handles to kernel drivers are closed [1][2]. In order to allow audio service to access device properties (such as friendly name as reported by linked bug), disable default policy for audio sandbox and configure a customized default policy on audio sandbox PreSpawn. [1] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=418 [2] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=932 Bug: 883326 Change-Id: I676f6820a0c1a4e5bd02bf7e66bec9764fc36731 Reviewed-on: https://chromium-review.googlesource.com/c/1256828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596001}
-
Ted Choc authored
This is a bulk (and rather gross) move out of LocationBar into a Coordinator. The coordinator is still the full collection of view and business logic, but this is the first attempt at the split and further refinement will be behind the coordinator API. BUG=843596 Change-Id: I435943e79d34573f3f229710470a91107d8ff5cc Reviewed-on: https://chromium-review.googlesource.com/c/1252540Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596000}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bfff4bac826c..d2650d1a2851 git log bfff4bac826c..d2650d1a2851 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 peah@webrtc.org AEC3: Reseting the ERLE at pre-amplifier gain changes 2018-10-02 saza@webrtc.org Move rtc_json code from API dir, enable unit test, unmark testonly Created with: gclient setdep -r src/third_party/webrtc@d2650d1a2851 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I53746c05d8df628d22edeb2877af651a0ea06f91 Reviewed-on: https://chromium-review.googlesource.com/c/1257704Reviewed-by:
-
Min Qin authored
This CL exposes more details on the notification for failed downloads. BUG=888786 Change-Id: I1c98621a33977359eea0636fa1120c65f3080a7f Reviewed-on: https://chromium-review.googlesource.com/c/1242040 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595998}
-
Kevin McNee authored
We currently call preventDefault on two finger touchmoves to prevent the browser's native pinch zoom from interfering with the PDF viewer's own pinch zoom implementation. However, an intervention may prevent such an event from being cancelable. It also doesn't consider the case of touchscreen double-tap on Chrome OS in tablet mode. touch-action is now able to prevent touchscreen pinches in an OOPIF/BrowserPlugin, so we now use touch-action for the viewer. Bug: 786419 Change-Id: I4eeb3be4566db3c48f0b2ad461cafe0568379fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1247040Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#595997}
-
Robbie McElrath authored
This CL migrates notifier::Login from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 887035 Change-Id: Idb43bd5b3159e53d8a3a5f4050d8f4e56db43dee Reviewed-on: https://chromium-review.googlesource.com/c/1235131 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595996}
-
Chong Zhang authored
Triaged failings tests with --enable-pixel-output-in-tests to give more context. Bug: 881976 Change-Id: I086bbc5d367adb695dfa494b21a82de9d8149aa4 Reviewed-on: https://chromium-review.googlesource.com/c/1252586Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/13fd627449cefbae7576d4b145cb24fac303fc7d..ce00828c89df3d4c40de7d715b1a032eb03c525c The following commits have Chromium bugs associated: 9e97c022e Bring Mac and iOS builders back to the CQ. 7c3ce519e Actually disable RandTest.Fork on iOS. 52483994c Mostly fix undefined casts around STACK_OF's comparator. fb4e2e0f0 Fix undefined casts in sk_*_pop_free and sk_*_deep_copy. cbc3e076f Take iOS builders out of the CQ rotation too. 792c1dc43 Rewrite PEM_X509_INFO_read_bio. 419144adc Fix undefined function pointer casts in {d2i,i2d}_Foo_{bio,fp} 217bfd3c9 Fix undefined function pointer casts in IMPLEMENT_PEM_*. I've also updated the roll_boringssl.py script to print the above message and the below bug list, so we don't need to manually attach things to rolls. Bug: 785442, 888687, 890115, 890351 Change-Id: If08496fcff132e71052a89c60aefb609d28ad3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1257561 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595994}
-
Robbie McElrath authored
This CL migrates CloudPolicyRefreshScheduler from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883124 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I455250e60d94347da2fcb8ecc752dbf958bc2abd Reviewed-on: https://chromium-review.googlesource.com/c/1220241 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595993}
-
Dan Sanders authored
This reverts commit 8e249e73. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=890629 Original change's description: > v4l2_SVDA, Vaapi_VDA: Support VP9 show_existing_frame feature. > > For VP9 video, when the flag "show_existing_frame" is set, the decoder > should output the specified reference picture which is decoded > previously. Originally V4L2 slice VDA and Vaapi VDA didn't handle this > situation that the reference picture is sent to client but not > returned back. > This CL supports this feature at these two VDA. If the reference picture > is sent to client side, then VDA just sends it directly. > > BUG=755887 > TEST=./video_decode_accelerator_unittest --ozone-platform=gbm > --test_video_data=vp90_2_10_show_existing_frame2.vp9.ivf:352:288:16:16:35:150:12 > on Kevin and Eve device. > TEST=Run AppRTC on Scarlet successfully > TEST=Pass media:media_unittests > > > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9876fa5aabaf15e9dff813ff5efd564d8991eee1 > Reviewed-on: https://chromium-review.googlesource.com/1119726 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595286} TBR=posciak@chromium.org,bbudge@chromium.org,johnylin@chromium.org,haraken@chromium.org,sandersd@chromium.org,akahuang@chromium.org,emircan@chromium.org,hiroh@chromium.org,acourbot@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 755887 Change-Id: I126684a435364cbf677092ad2c97b371fb105054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1257862Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595992}
-
Florent Castelli authored
This parameter is used to set parameters at the creation of the sender, and later to setup simulcast, though simulcast isn't supported right now by WebRTC. Bug: 891117 Change-Id: I3c6695bb94c846c4868a235d381bddf885b3a370 Reviewed-on: https://chromium-review.googlesource.com/c/1255944 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#595991}
-
Xing Liu authored
This CL fixes an issue that missing SD card snackbar may show for users without SD card. The reason is the target path of the download can be empty if the user kill the browser while download location dialog is showing. Bug: 890867 Change-Id: I2ed13acae1e4eface9703053506ef91b0b4d4110 Reviewed-on: https://chromium-review.googlesource.com/c/1257668 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595990}
-
Ben Pastene authored
And hard-code enable_nacl, which needs to be set to deploy nacl libs to the VM. Change-Id: Iffa9d62c02e33e1822a20f85a5ee2a4c11a7907d Reviewed-on: https://chromium-review.googlesource.com/c/1258056Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595989}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/extensions. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 890902 Change-Id: Ic5efd3b6eefa2c950dcb85793e824835e6f79c32 Reviewed-on: https://chromium-review.googlesource.com/c/1257903Reviewed-by:
-
Lei Zhang authored
Change-Id: I29e12d4a1084e3f0a4c2bdb84932f17498ed0d35 Reviewed-on: https://chromium-review.googlesource.com/c/1256229 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#595987}
-
Dmitry Gozman authored
This patch shuffles the code a bit, so that DevToolsSession does not have to know about render process id and frame host anymore. Bug: 775132 Change-Id: I3a3f778ebb42769c8ebb7c165f4343a9940afa42 Reviewed-on: https://chromium-review.googlesource.com/c/1255147 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595986}
-
Joshua Bell authored
Document and allow the [Serializable] and [Transferable] IDL extended attributes. They don't influence code generation (custom code is required), but should be allowed if the spec has them so that spec/tests/code can match. Add those attributes to .idl files that need them, and also clean up a few other IDL extended attribute documentation nits. Change-Id: I241d257c2d8cd4eacfb32354772daa54002cf878 Reviewed-on: https://chromium-review.googlesource.com/c/1255595 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595985}
-
Sorin Jianu authored
The test is failing consistently on Linux ChromiumOS MSan. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests TBR: achuith Bug: 891484 Change-Id: Ibcc0a19dec3775cc11704158c1fb1d5bbc014dc0 Reviewed-on: https://chromium-review.googlesource.com/c/1258061Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595984}
-
Gabriel Marin authored
Based on original CL: - https://codereview.chromium.org/8570023 Add a guard page in front of metadata allocations. BUG=104752 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112260 Code has been modified to create the guard page inside MetaDataAlloc, once per 8MB chunk. BUG=724399,b:70905156 Change-Id: I527fbfe5e258cc052e205d01bfe2dd30e21b9f13 Reviewed-on: https://chromium-review.googlesource.com/c/1130794Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#595983}
-
Aaron Krajeski authored
Now it always uses a ResourceProvider. Make a FakeResourceProvider for testing Bug: 866090 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0a6eeb85c9cc0634d72f277d1045d6df440b8eef Reviewed-on: https://chromium-review.googlesource.com/c/1195826Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595982}
-
Jun Choi authored
BluetoothAdapter randomizes device address for unpaired devices while pairing. As so, handle BluetoothDevice address change so that FidoBleDevice advertising on a different address on pairing mode is not recognized as a new FidoBleDevice. Bug: 877344 Change-Id: Ie1dca3d01bbe4c0ca751062b1fa6f446e7055aaa Reviewed-on: https://chromium-review.googlesource.com/c/1239202Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595981}
-
Jun Cai authored
This CL removes SensorThread from platform_sensor_provider_win.cc and uses the //base/task/post_task.h APIs instead. Bug: 883877 Change-Id: Icd3632f33e58b2577c2f2d6925d9ce5c3469e4d0 Reviewed-on: https://chromium-review.googlesource.com/c/1246063 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This CL deletes WebRequestEventRouterDelegate and its implementation ChromeExtensionWebRequestEventRouterDelegate. It's only method, NotifyWebRequestWithheld is replaced with a method on the ExtensionsAPIClient. This will make it easier to share the implementation with the Declarative Net Request API. This CL should have no behavior change. BUG=809680 Change-Id: I696dbf8d3a34ae546342eb7ba98a1dd9e26fe3aa Reviewed-on: https://chromium-review.googlesource.com/c/1256218 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Justin DeWitt authored
The country code comes from the first place in the following list with a non-empty country code: * Field Trial parameter "country_override", configurable by Finch server * Finch permanent country, which is updated when the Finch configs are updated (by default once per Chrome version). Permanent country may not be available in the first run of Chrome. * Finch latest country, which is available on every run of Chrome. Bug: 867488 Change-Id: I0e407a50a4020882152dda85935ecf843a000cb0 Reviewed-on: https://chromium-review.googlesource.com/c/1256110 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595978}
-
Bill Orr authored
This reverts commit 5c87a0a4. Reason for revert: Re-enabling processing of WebVR Origin Trial tokens. BUG=891425 Original change's description: > Remove the WebVR Origin Trial. > > As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial. > > WebVR can still be manually enabled through chrome://flags. > > BUG=758265 > > Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245 > Reviewed-on: https://chromium-review.googlesource.com/1144278 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576732} TBR=ddorwin@chromium.org,dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758265 Change-Id: Ic1be18fa173aa9a5ec90c3f5c8b388cc610c76d1 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1257670 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595977}
-
Khushal authored
This change adds the basic framework for using SurfaceControl to manage the buffer queue for the DisplayCompositor on Android. This includes the following additions. 1) Adding the ABI for loading functions for the SurfaceControl API at runtime in base::android::SurfaceComposer. This allows us to create transactions for presenting buffers parented to the ANativeWindow in the GPU process. 2) Use GLOutputSurfaceBufferQueue to maintain a queue of buffers in the viz display compositor that are sent as overlays to the GPU main thread. This is used based on whether the GLSurface is marked surfaceless, set by the ImageTransportSurfaceOverlayAndroid. 3) Add an implementation of GLSurface for Android which collects a list of overlays to send to the framework and sends it in a single transaction to ensure the updates are made atomically. A few capabilities are missing in the implementation, for instance setting a transform on the overlay, getting transaction acks for correctly synchronizing reuse of buffers, as these are still a WIP on the NDK API. R=ericrk@chromium.org, piman@chromium.org, yfriedman@chromium.org Bug: 889328 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1634e379626ac7b2a08c96dccc6cd767c9dce154 Reviewed-on: https://chromium-review.googlesource.com/c/1250212Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595976}
-
