GitLab

There is now a TranslateManager per tab.
TranslateManager is owned by TranslateTabHelper.

This changes simplifies all the tracking of WebContents objects,
since there is now one and only one WebContents per TranslateManager.
This allows to get rid of all the |web_contents| parameters as well as the
PendingRequest type.

Users of the TranslateManager now get a manager from a WebContents
object, through the associated TranslateTabHelper.

BUG=332736
TBR=brettw

Review URL: https://codereview.chromium.org/166963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252098 0039d316-1c4b-4281-b951-d872f2087c98

Make ScrollByContentsOffset() work as intended after resize.
contents_scroll_offset_ was not being updated on Update().
Add a test that fails without this fix. Fix an Aura include.

BUG=344490
TEST=Click page icon, click "Show cookies and site data". Expand a node to make a scrollbar appear, scroll down; collapse the node, re-expand the node; scrolling down should work.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/171423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252097 0039d316-1c4b-4281-b951-d872f2087c98

We use unittest.cc suffix for tests that use gtest and are not
interactive ui tests or browser tests. This is also more consistent with
the files around.

BUG=180681
TEST=unit_tests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/169013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252096 0039d316-1c4b-4281-b951-d872f2087c98

The SystemPolicyRequestContext wraps the system request context and is used
to make cloud policy requests that shouldn't be related to a particular user.

Some tests intercept requests sent via the system request context. By
copying the job factory, those interceptors will also see the requests going
through the SystemPolicyRequestContext.

BUG=None

Review URL: https://codereview.chromium.org/172463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252095 0039d316-1c4b-4281-b951-d872f2087c98

This flag is redundant with --disable-gpu which causes us to fall into
software compositing mode.

Depends on: https://codereview.chromium.org/167973003/

R=piman@chromium.org, piman
BUG=

Review URL: https://codereview.chromium.org/166163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252093 0039d316-1c4b-4281-b951-d872f2087c98

ChromeOS always sets this value to 1. Other Aura platforms don't use
the cc scheduler yet so they don't care about this value. Once they
do, they'll want to use 1 as well. So set it to 1 always.

R=piman@chromium.org, piman
BUG=344094

Review URL: https://codereview.chromium.org/168073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252091 0039d316-1c4b-4281-b951-d872f2087c98

Follow up from ShellWindow -> AppWindow rename in http://crbug.com/343591

BUG=344084
TBR=jamescook@chromium.org chrome/browser/ui/ash/*
TBR=benwells@chromium.org chrome/browser/ui/{cocoa,gtk,views}*

Review URL: https://codereview.chromium.org/171593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664
R=kinuko@chromium.org, dgrogan@chromium.org

Review URL: https://codereview.chromium.org/168833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252089 0039d316-1c4b-4281-b951-d872f2087c98

This change is part of eliminating the signin-related notifications in favor of
having clients observe SigninManager.

BUG=333997

Review URL: https://codereview.chromium.org/170383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339878
NOTRY=True
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/170263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252086 0039d316-1c4b-4281-b951-d872f2087c98

The views::LinuxUI* object is global across profiles. However, it stored
profile specific state in the form of a |use_gtk_| variable. This fixes
Gtk2Borders so that they ask their owning view for a ThemeProvider and
expands the ui::ThemeProvider interface so that it exposes the
UsingNativeTheme() call from the ThemeService layer, instead of asking
the views::LinuxUI provider directly, which will likely return stale state.

BUG=340805, 340799

Review URL: https://codereview.chromium.org/171413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252085 0039d316-1c4b-4281-b951-d872f2087c98

This is a small reorganization before a bigger one.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/163023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252082 0039d316-1c4b-4281-b951-d872f2087c98

Public session pods are placed first so this should be reflected in UserManager::EnsureUsersLoaded() because UserManager::GetUsers() user list is used to determine first user wallpaper.

BUG=344858

Review URL: https://codereview.chromium.org/172353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252080 0039d316-1c4b-4281-b951-d872f2087c98

Add some basic perftests that track how long a given WebTouchEvent or
WebGestureEvent takes to propagate through the InputRouter.  This includes both
the time to send and the time to ack a given event, averaged over a typical
touch swipe or scroll gesture sequence.

BUG=339877
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/170913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252079 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug where global_instance_ was not set to zero.
Fix MockRenderThread to call OnChannelClosing properly.

Review URL: https://codereview.chromium.org/169063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252078 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the extension install UI has a profile available to use for image loading, even if the prompt is opened before any browser window are available.

This bug is currently crashing Clusterfuzz ~100 times per hour and polluting the crash statistics.

BUG=344199
TEST=see bug
TBR=miket@chromium.org

Review URL: https://codereview.chromium.org/168823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344938
R=waffles@chromium.org

Review URL: https://codereview.chromium.org/172883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252076 0039d316-1c4b-4281-b951-d872f2087c98

Filter out GestureDoubleTap events on elements with touch-actions
other than auto. When GestureDoubleTap is being filtered out,
we also eliminate the tap delay.

BUG=337534
TEST=TouchActionFilterTest.DoubleTap,
  TouchActionFilterTest.DoubleTapWithTouchActionAuto

Review URL: https://codereview.chromium.org/170603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252073 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> cd src/chrome/app
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/171673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252072 0039d316-1c4b-4281-b951-d872f2087c98

Currently the observer is only removed if the overlay is closed.
Also remove it in case we switch to the create profile overlay.
This fixes an assertion.

BUG=344813
TEST=Switch between import overlay and create profile overlay.
TBR=pam@chromium.org

Review URL: https://codereview.chromium.org/165943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252071 0039d316-1c4b-4281-b951-d872f2087c98

The ui flag is always true on ChromeOS and off elsewhere. The other is
never on and we're not planning to turn it on.

R=piman@chromium.org, piman
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538

Review URL: https://codereview.chromium.org/164183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252069 0039d316-1c4b-4281-b951-d872f2087c98

Changes
r251855: Fix compilation of NSPR and NSPR for aarch64

BUG=314720
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/172143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252068 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=344693

Review URL: https://codereview.chromium.org/171783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252067 0039d316-1c4b-4281-b951-d872f2087c98

Unifies the Path Service's base::DIR_HOME on Posix and base::DIR_PROFILE on Windows to just be base::DIR_HOME everywhere, and DIR_HOME will now work on Mac.

This removes the AssertIOAllowed check in the Posix implementation because that was only executed in a fallback case that no developer is likely to ever hit. In addition, the we do call this type of function on the UI thread, so either we need to promote the assertion to be at the top of the function or delete it. It seemed unreasonable to disallow using this one key of the path service on the UI thread (the other ones are OK) so I just went for deleting the assertion.

R=benwells@chromium.org

Review URL: https://codereview.chromium.org/159833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252066 0039d316-1c4b-4281-b951-d872f2087c98

Updates all rebase_path calls to use the new parameter ordering.

Use the new getenv function and delete the Python script we had to get the home directory.

Takes advantage of the new ability to have the default value of declare_args blocks be dependent on other values. This simplifies some code.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/164773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252065 0039d316-1c4b-4281-b951-d872f2087c98

This resubmission fixes a memory leak that was causing ASAN bots to fail.

Original code review: https://codereview.chromium.org/163953007

BUG=227247
R=jennyz@chromium.org
TBR=jamescook, jennyz

Review URL: https://codereview.chromium.org/165393013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252064 0039d316-1c4b-4281-b951-d872f2087c98

The IPC in question was in
PasswordGenerationManager::SendAccountCreationFormsToRenderer. This is now done
through PasswordManagerDriver.

Most of this patch was developed by vabr@chromium.org.

BUG=335028

Review URL: https://codereview.chromium.org/156173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252063 0039d316-1c4b-4281-b951-d872f2087c98

It is ok for SafeGetImageInfo to fails to get the image info, so catch
exceptions instead of dying.

BUG=343925

Review URL: https://codereview.chromium.org/171153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=325685
R=bulach@chromium.org, pliard@chromium.org

Review URL: https://codereview.chromium.org/172193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252061 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of the flag clean up effort.
The flags is enabled by default for a while and working pretty well. We won't
go back any more.

BUG=344738

Review URL: https://codereview.chromium.org/166273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252060 0039d316-1c4b-4281-b951-d872f2087c98

All tests listed in chromium_swarm_tests are going to be run on the CI
infrastructure. Sadly, sync_integration_tests_run is currently failing on all
OSes, so commenting it out in the meantime until we focus on adding back more
tests.

R=csharp@chromium.org
BUG=157234
NOTRY=true

Review URL: https://codereview.chromium.org/170283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252057 0039d316-1c4b-4281-b951-d872f2087c98

UNPROXIED_API() no longer does anything. This change removes that macro, since
it serves no purpose.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/167943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344808

Review URL: https://codereview.chromium.org/172113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252055 0039d316-1c4b-4281-b951-d872f2087c98

ImageView.setImageAlpha is available only since JB. Use setAlpha preJB.

NOTRY=true

Review URL: https://codereview.chromium.org/165953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252054 0039d316-1c4b-4281-b951-d872f2087c98

Removing the autofill enum from blink side and moving it to
browser side in components/autofill/core/common/autofill_enums.h.
This patch is only adding of enum in browser side. Removing of
enum from blink side is done in another patch.

BUG=302489
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/159853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252053 0039d316-1c4b-4281-b951-d872f2087c98

When recording a page, we identify it by its "display name" (name if it has one,
otherwise URL unless it's a file). When replaying a page, however, we always use
its URL to look up the correct WPR file. So pages with names cannot be found.

R=tonyg@chromium.org
BUG=344380

Review URL: https://codereview.chromium.org/169873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252052 0039d316-1c4b-4281-b951-d872f2087c98

This will allow changing, adding, and removing tests without two-sided
patches.

The list format can be extended in the future, for now keeping it as simple
and static as possible.

BUG=332239
R=darin@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/166663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252050 0039d316-1c4b-4281-b951-d872f2087c98

Do not call InsertText() if there is no focused text input client or the text input type is TEXT_INPUT_TYPE_NONE.

BUG=343875

Review URL: https://codereview.chromium.org/166823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252049 0039d316-1c4b-4281-b951-d872f2087c98

Currently browser dialogs are centered relatively to the main
webcontents. If one has docked devtools which occupy 90% of the browser
window, the dialog is hardly seen.

This patch makes dialogs to be centered with respect to open devtools,
which means centering to the container of both inspected webcontents
and and devtools.

BUG=

Review URL: https://codereview.chromium.org/169403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252048 0039d316-1c4b-4281-b951-d872f2087c98