- 24 Jul, 2019 40 commits
-
-
Rayan Kanso authored
This reverts commit 885aa020. Reason for revert: Builders are failing again Bug: 987226 Original change's description: > Reland "ProGuard: Move -checkdiscard for Log.* into @RemovableInRelease annotation" > > Was reverted in: 54f75614. > > Reason for reland: Includes fix for downstream targets. > > Change-Id: I2a5f77cdbd40934ae206dd91b2e12e7b5e6553e1 > Bug: 986693, 986693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715004 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680307} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I210a6fde9d3a37b8e2ea0f7766a127fd95e8616c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715492Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#680392}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ae30cc2e6e0..1cd1ed8976c4 git log 3ae30cc2e6e0..1cd1ed8976c4 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 robertphillips@google.com Stop using GrBackendSurface's pixel config Created with: gclient setdep -r src/third_party/skia@1cd1ed8976c4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I3b020acbbaaa8ac276a1d5a8d645cc49ef53a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680391}
-
Anders Hartvoll Ruud authored
When creating a CSSVariableReferenceValue with a reference to a variable which actually exists, we crash because CSSVariableReferenceValue objects created through Typed OM don't have a CSSParserContext. This was missed by our existing test suite, because we only covered a similar case where the referenced variable *didn't* exist, avoiding the broken code path. For now, fixed by using StrictCSSParserContext. Bug: 986710, 985028 Change-Id: If51e34a77e5433849e0602f297909027fc743798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713627 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93c16af35dfb..0ad42169cb4d Created with: gclient setdep -r src-internal@0ad42169cb4d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I16bf35453580949f2a8182830a9f5143b4db379e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715337Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680389}
-
Anders Hartvoll Ruud authored
According to a recent spec change, the syntax of a registered custom property must be ignored until computed-value time. This means that setProperty may not inspect the PropertyRegistry and reject values based on that. This CL also removes the PropertyRegistry parameter in many places, to avoid incorrectly using it in the future. Bug: 641877 Change-Id: I99c58775e800500862378420118d81fe3186e739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714590Reviewed-by:
-
Richard Knoll authored
This is a reland of d3cda01a Original change's description: > Show Click to Call dialog if sync is disabled. > > We want to show the Click to Call dialog even if sync is disabled to > show the user some help text on how to enable sync. > > Bug: 986273 > Change-Id: I5f920822f21761ee5f167af0622b11304140cda4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713533 > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680351} Bug: 986273 Change-Id: I893519f08aded6c5e04bac53b272aaafd33ed329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715268Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680387}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3855447d93eb..c9190a54da56 git log 3855447d93eb..c9190a54da56 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 stevenperron@google.com SSA rewriter: Don't use trivial phis (#2757) 2019-07-23 alanbaker@google.com Fix block depth rule priority (#2755) 2019-07-23 alanbaker@google.com Case validation with repeated labels (#2689) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c9190a54da56 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Idf93d418d9f1926772194679e082c093edde3d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716591Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/098b545f..e53b8284 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60d9e33120f7bd64ec77445f973b9f3f84121740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715417Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680385}
-
Stephen Nusko authored
We don't know if tracing is needed before we connect to the system service. However the PerfettoTracedProcess is only set up when a local trace is started. If the feature is enabled we make sure we construct (and thus connect) the SystemProducer. Bug: 979576 Change-Id: I547772d071ac9c4a09a3b5f8993090a380a97579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715190Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680384}
-
Lowell Manners authored
To avoid the complexity of caching and restoring still-loading pages, for now simply don't cache pages that haven't finished loading. Long term this logic will probably need to be extended to be more complicated/permissive, to increase back-forward cache coverage. Change-Id: Ic06d9b3d425d3df95b8d09bea1561c000a96acc4 Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692414Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#680383}
-
Aleksi Lindeman authored
HasPendingActivity is called during blink unified heap marking phase and GC allocation is not allowed during this phase. There is a DCHECK in ThreadHeap::AllocateOnArenaIndex that checks this. TimeRanges member functions allocate using MakeGarbageCollected. This change moves TimeRanges logic to WebTimeRanges to allow use of it without GC and TimeRanges now uses WebTimeRanges. Bug: 970150 Change-Id: Idcceb61cb4506e50f0839c87be9b9d803e04b947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663133 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#680382}
-
Ilya Bizyaev authored
This adds a user policy (VmManagementCliAllowed), a corresponding preference (crostini.vm_management_cli_allowed_by_policy) and wires them. The policy will be used for an experimental feature that limits access to vmc and vsh (potentially other commands as well). Test: compile, run unit tests Bug: 983996 Change-Id: Ib53e4f180f3436da86cfe04ec5bd14f7337c58ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702262Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Cr-Commit-Position: refs/heads/master@{#680381}
-
Jessica Tallon authored
Bug: 959650 Change-Id: Iddaddd4de70a3fb80ca6b21a9d9e0a7238e06162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715369Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#680380}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0cf661b2a81d..fd3e53d52cec git log 0cf661b2a81d..fd3e53d52cec --date=short --no-merges --format='%ad %ae %s' 2019-07-24 treehugger-gerrit@google.com Merge "protozero: Add post-increment operator for repeated fields" Created with: gclient setdep -r src/third_party/perfetto@fd3e53d52cec The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic351719e8e107623420424780a8342140f7f3858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715334Reviewed-by:
-
A Olsen authored
The largest is that all 3 dialogs are now modal - this gives them a black background and makes it hard to mess with things behind it (although ChromeOS doesn't seem to be perfect at modal dialogs). And, 2 of the dialogs no longer have a title bar / x button. These 2 are the urgent password expiry notification, and the confirm password change dialog. Both of these dialogs are also changed in line with the latest UI spec. The other dialog, the hosted password change dialog, still needs more work. The screenshots of these changes are visible internally here: http://go/insessionpwchange-screenshots Bug: 930109 Change-Id: I1712e93a1fa924e7729cd837606398662c2067ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715344 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680378}
-
Ivan Šandrk authored
From an email discussion: marcuskoehler: May I ask you to add ppkfnjlimknmjoaemnpidmdlfchhehel to the MGS whitelist so that it doesn't cause the full warning? TBR=mnissler@chromium.org Change-Id: I1c98cdc3318475a04c7e342897dd1009bd595079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716744 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#680377}
-
Rafał Godlewski authored
Change-Id: Iedf6401d6017d2d8d04749ef5f58f27f84cdfcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702261 Auto-Submit: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/master@{#680376}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40355312..098b545f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic59f9b234302d59195cfaa3b157b9c755046aba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715890Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fbd94ccd66ee..9f89d086a26b git log fbd94ccd66ee..9f89d086a26b --date=short --no-merges --format='%ad %ae %s' 2019-07-24 dberris@chromium.org PinpointScheduler: Allow cancellation in job page 2019-07-24 dberris@chromium.org PinpointScheduler: Support cancelling running jobs Created with: gclient setdep -r src/third_party/catapult@9f89d086a26b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:977488,chromium:977488 Change-Id: I7ac0df176ce59d14a42e9c7527552af923d2b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716240Reviewed-by:
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/283, this CL makes sure *loadOp and clear* are consolidated into an unioned field in GPURenderPassColorAttachmentDescriptor and GPURenderPassDepthStencilAttachmentDescriptor. Bug: 877147 Change-Id: I4a676e8cfa52844f2df54b6201e6db453c1d9e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715267Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#680373}
-
dpapad authored
Specifically: - Replace var with let/const (using lebab) - Fix missing/extra semicolon violations - Fix missing curly braces violations - Fix double quotes violations - Fix JS naming violations - clang-format - Add PRESUBMIT to catch these automatically moving forward. Bug: 986001,792774 Change-Id: I1d180fd3557243e08b0009c4fdc122ffa742b505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716094 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#680372}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/532f86826d5c..93c16af35dfb Created with: gclient setdep -r src-internal@93c16af35dfb The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Ib56716af9669443d219d172ab8c330df20b757e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716197Reviewed-by:
-
Jenny Blessing authored
Also stores the domains of the deleted cookies for later use in removing additional storage for these domains. Bug: 987177 Change-Id: I600be2dcdbe4fdacd52cf6cdba65de049f9d4bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699668 Commit-Queue: Jenny Blessing <jblessing@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#680370}
-
Makoto Shimazu authored
Previously ServiceWorkerNewScriptLoader returns kErrorExists when the main worker script was just truncated because it calls CommitCompleted() when the Mojo data pipe is closed. However, it's a problem because it doesn't tell the cache writer about the end of the body so that the cache writer isn't aware of the truncation. This CL is to trigger MaybeWriteData() at connection close for the cache writer to give a chance to run script comparison at the end of the body. Bug: 986688 Change-Id: I8a816ab1ab1a2e236c1a21c1f0950437cd1e50ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714584Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680369}
-
Marc Treib authored
Previously, https://crrev.com/c/1681768 added migration logic from the old "SyncSuppressed" pref to a new "SyncRequested" pref (which better matches what it means, and has the correct default value). However, the migration code was only triggered on non-iOS platforms, leaving iOS Sync users in a bad state (new pref is used, but has no value). The fix is simply to trigger the migration logic also in iOS's version of browser_prefs. This also bring users back into a good state. Bug: 906034 Change-Id: Ib52ea658bf616ca47e947980d2ddc1fb50f02b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715285Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#680368}
-
Pâris MEULEMAN authored
This merges signin_manager_android_wrapper.* into signin_manager_android.* and updates the factory accordingly. This is in the scope of a change of strategy regarding the identityManager implementation on Android, using a layering strategy similar to what was done on iOS. Due to this, the wrapper is no longer required. Change-Id: Ic4ecd68b07c07c77fb1d8a2756dd30103eeb4434 Bug: 985256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703410Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680367}
-
Findit authored
This reverts commit 68335421. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 680135 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjgzMzU0MjEzMGQyODg4YzMxNDQ2ZjI0MGQxNjkwOGY0NWFiNjhjYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/13542 Sample Failed Step: browser_tests Sample Flaky Test: PromiseResolverModuleTest.All Original change's description: > Web UI Polymer 3: Port tests for shared JS Modules > > Port tests for the shared JS resources migrated to modules in > https://crrev.com/c/1682889. > > Note: Tests only run if optimize_webui is false, since these > resources only exist in this case. > > Bug: 965770 > Change-Id: Ia45584f59617165b3d230d551351ea51f3385add > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703424 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680135} Change-Id: I90be6d4a72a24e15a0bbf7f7004aed32153b65a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716636 Cr-Commit-Position: refs/heads/master@{#680366}
-
Richard Knoll authored
To reach devices in doze mode, we need to send sharing messages with high urgency. Bug: 966037 Change-Id: I5521a2bb97727b9b1077e82e4ec3e6167c5e789c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710318 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680365}
-
Ricky Liang authored
We only need to map and unmap the JPEG buffers when the video capture stack uses GpuMemoryBuffer-based buffers from the buffer pool. BUG=b:138274061 TEST=Manually on device Change-Id: I64a2bf8a7fc26bab684a28e8a5ddd971a393cbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716449Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680364}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/67440068b934..0cf661b2a81d git log 67440068b934..0cf661b2a81d --date=short --no-merges --format='%ad %ae %s' 2019-07-24 primiano@google.com Merge "Client API: Expose Flush() method" 2019-07-24 treehugger-gerrit@google.com Merge "client api: Support data sources across translation units" 2019-07-24 treehugger-gerrit@google.com Merge "client api: Select a tracing backing automatically" Created with: gclient setdep -r src/third_party/perfetto@0cf661b2a81d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I1131acc82f1a3c6bc3ee6dbf57aabe89887a7f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716593Reviewed-by:
-
Clemens Arbesser authored
Before this patch, we would wait for AA to be shown before invoking the espresso check. This would sometimes fail on slower devices, because asynchronous events on the native side might not have finished processing at that point. This CL instead continuously polls the UI thread until the specified condition is matched or the default timeout is reached. Bug: b/986026 Change-Id: I311f94dd8fd4383dfcce35656299bddce366b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712564 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#680362}
-
David Jean authored
TBR=rockot@google.com Bug: 987155 Change-Id: I72c9a3d235acbc76012d6dee78832ce8ca89f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715368Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#680361}
-
Yasmin authored
Bug: 980542 Change-Id: I02a499fc4c1878be3ad25ff62d5f9b437988e510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715345Reviewed-by:
-
Joel Hockey authored
Change running check from VM to container. Bug: 968060 Change-Id: I8340931a4cdfea205b52ef40162e6e99120ec8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715760 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Also rsorokin@ takes over ownership. Bug: 969925 Change-Id: I18d8885b5ea0db420095dcc346969e5e28de389b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713509 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#680358}
-
Xinglong Luan authored
This reverts commit 69753f33. Reason for revert: crashes reported https://crbug.com/987045 and https://crbug.com/987007 Original change's description: > Reland "Refactor Smart Dim, making it a D-Bus service" > > This is a reland of 1b42c60c > > Fix the failure of the reverted CL on the chromeos-amd64-generic-rel trybot. > The reason of failure is that in chromeos-amd64-generic-rel vm, DEVICETYPE is > empty, which fails the constructor of UserActivityController. > Add an if statement to MachineLearningDecisionServiceProvider::ShouldDeferScreenDim > to get around this. > > Original change's description: > > Refactor Smart Dim, making it a D-Bus service > > > > Add a Chrome D-Bus service, export ShouldDeferScreenDim method for > > powerd to call > > > > Bug: 933199 > > Change-Id: I275f4eb5f406d6ecdd1fca3590a00c2a0618eb4d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598921 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > > Commit-Queue: Xinglong Luan <alanlxl@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#671533} > > Bug: 933199, 977830 > Test: Tested on local vm and trybots. > Change-Id: Icff1edda1c81a655ad99fc717625914af1dae6bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675364 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Xinglong Luan <alanlxl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675470} TBR=derat@chromium.org,stevenjb@chromium.org,achuith@chromium.org,mnissler@chromium.org,amoylan@chromium.org,jiameng@chromium.org,alanlxl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933199, 977830 Change-Id: Icae53c14e913d0ae7abd9e7cef763ef2a41730f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715507Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#680357}
-
Domenic Denicola authored
Follows https://github.com/WICG/kv-storage/pull/71. Bug: 931263 Change-Id: I19abd6bc26ef29870a4ed45e7a65ddbc724d5584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712950Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680356}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f9c660aa939..3ae30cc2e6e0 git log 0f9c660aa939..3ae30cc2e6e0 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 02407743bd72..8bb46c5b9ffc (3 commits) Created with: gclient setdep -r src/third_party/skia@3ae30cc2e6e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:None Change-Id: Iff7dc2ff04d4904d35294f3850914d97a201d6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716587Reviewed-by:
-
David Munro authored
install-build-deps requires lsb_release, add a note for Crostini to install lsb-release before running install-build-deps Bug: None Test: sudo apt install lsb-release; install-build-deps.sh --no-arm Change-Id: I642275a4aa6ac22ff9c71733a4b4911db23bc392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716605 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680354}
-
Mike West authored
We realized in a conversation around issue 951540 that we don't have settings UI that allows users to reconsider decisions they've made around external protocol support. Until we work that out, and make longer-term decisions about the permission model around the feature generally, we should stop making the problem worse by removing that checkbox from the UI. Based on existing telemetry (`BrowserDialogs.ExternalProtocol.HandleState`), this will affect ~8% of users who interact with the dialog, which itself is a fairly small group of Chrome's users overall. Bug: 982341, 987149 Change-Id: I723979aab9606d1c2337a36a8f5a0686b95bb9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708070 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680353}
-
