- 14 Jun, 2018 40 commits
-
-
edchin authored
History coordinator can now be started on top of the tab grid. This history coordinator was not properly being dismissed inside main_controller's |-dismissModalDialogsWithCompletion:|. As part of fixing dismissal, this CL also fixes a bookkeeping flaw in main_controller. Previously, main_controller conflated the existence of |self.currentBVC| with the BVC being presented and active. This CL changes that logic to use |-isTabSwitcherActive| instead. Bug : 852243 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I93d5efb33a2de8eaed7b0472fa2994c14603d11a Reviewed-on: https://chromium-review.googlesource.com/1098555 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567172}
-
Morten Stenshorne authored
Maintaining both a BFC offset and a container offset was a bit cumbersome and error-prone, and it turns out we don't need to store both. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I51ea857e979384d89fb7a97f68f1a243fad9e2a1 Reviewed-on: https://chromium-review.googlesource.com/1097756Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567171}
-
Morten Stenshorne authored
This affects auto-positioned out-of-flow nodes that are handled as part of inline layout, and other things too. This fix will also make it possible to use the position of the last child fragment to calculate the block size of a block (which I happen to be working on). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie3f99d850de81bd349e89c624f86cce95b38eede Reviewed-on: https://chromium-review.googlesource.com/1098925 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567170}
-
Hiroshige Hayashizaki authored
To remove indirect layers around Modulator. Bug: 842553 Change-Id: Ie307c9f91ead00e260da156d6ae283131316d7eb Reviewed-on: https://chromium-review.googlesource.com/1080032 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#567169}
-
Oscar Johansson authored
In Jumbo build, the member NONE in the enum VerifyStatus in install_verifier.cc conflicts with the same member in the enum Transformation inactivity_log/activity_log.cc. This commit solves the issues by defining VerifyStatus as a strongly typed enum. Bug: 850484 Change-Id: Idc3cab01b96073b20adf6fcd87e01cdf9b02a739 Reviewed-on: https://chromium-review.googlesource.com/1098664Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567168}
-
Oscar Johansson authored
When building using Jumbo, the using-declaration of api::webrtc_logging_private::RequestInfo results in a conflict, since a declaration of RequestInfo exists in both api/webrtc_logging_private.h and api/webrtc_audio_private.h. This commit solves the conflict by removing the using-declaration. Bug: 850484 Change-Id: I9bc25994cccdfd2e9ae19ecdacde06ed7780b1b2 Reviewed-on: https://chromium-review.googlesource.com/1098658Reviewed-by:
-
Oscar Johansson authored
The function g_shown is defined in every bubble delegate. When building using Jumbo those functions conflict with each other. This commit fixes this by renaming the functions to something more file specific. Bug: 850484 Change-Id: I9df3a8e90ed77e95649cdb734cc4d7364b5fc310 Reviewed-on: https://chromium-review.googlesource.com/1096945Reviewed-by:
-
Oscar Johansson authored
When using Jumbo build, there are conflicts between dashboard_private_api.cc and webstore_private_api.cc. The conflicts are the variable kUserCancelledError and the function WebstoreInstallHelperResultToApiResult. This commit solve the issues by renaming the variable and function to something more file specific. Bug: 850484 Change-Id: I600a036505ef731124ac6e4c3ea2f750a50ccad5 Reviewed-on: https://chromium-review.googlesource.com/1098958Reviewed-by:
-
Oscar Johansson authored
When using Jumbo build, the namespace alias Create in /api/context_menus/context_menus_api.cc conflicts with the function Create called from api/desktop_capture/desktop_capture_base.cc. This commits solves the issue by removing the namespace alias. It also removes the namespace aliases Update and Remove in the same file to avoid this issue in the future. Bug: 850484 Change-Id: Ibdb940e153a89b7120c670e806be34fc4e95ab90 Reviewed-on: https://chromium-review.googlesource.com/1099062Reviewed-by:
-
Allen Vicencio authored
Adds GetResolvedUrl to SmbShareFinder to resolve hosts found with NetworkScanner Bug: 757625 Change-Id: Ia9050358c8aba1bc0354f7f3a961d25f002673b2 Reviewed-on: https://chromium-review.googlesource.com/1091228 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567163}
-
Becca Hughes authored
Notify the browser process when the frame owning the current fullscreen element is changed. Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 BUG=838400 Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 Reviewed-on: https://chromium-review.googlesource.com/1054441Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567162}
-
Ramin Halavati authored
Another test is activated for win-annotator-rel bot. Bug: 844014 Change-Id: I5b7cc780fa88de7051324ac2e5585c90774c1ea3 TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100456Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#567161}
-
Christopher Lam authored
This CL adds an Interface type for concrete implementations to @implement and makes the Mojo interface non-nullable to avoid needing an assert. Bug: 836128 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2f1d07966f734a47c8bc724a11641d0cab67daf Reviewed-on: https://chromium-review.googlesource.com/1088355 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
It has been enabled on the finch config. This CL enables the switch by default on the chromium src. resource_scheduler_unittests.cc is largely affected by the change. This CL removes some cases and modifies some cases to keep it green. Bug: 794073, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie49e5f0261a70f581ca766c3eeeae8a8f0e4e66b Reviewed-on: https://chromium-review.googlesource.com/1075916Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The test was added in https://chromium-review.googlesource.com/1082931 for the bug, then was reverted. I forgot to add back the test in the new fix https://chromium-review.googlesource.com/1097558. TBR=trchen@chromium.org Bug: 848730 Change-Id: I3823a408819a2d8acdb7e41060d2fafd22fbb6de Reviewed-on: https://chromium-review.googlesource.com/1100486Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567158}
-
Chris Harrelson authored
Previously, we computed which paint layer was topmost (but not negative z-index) in CompositingLayerAssigner. This led to complications in invalidation, and makes it hard to optimize that class to avoid recursions. Now compute the same thing through smarter code in GraphicsLayerTreeBuilder and CompositingInputsUpdater. Bug:814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4c68e8622dde86be4870505696db6b453b4ab0e9 Reviewed-on: https://chromium-review.googlesource.com/1097559 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567157}
-
Ke He authored
Before moving //device/geolocation into //services, we have to make sure all the clients can only depends on //device/geolocation/public. Clients shouldn't visit internal parts of the geolocation. So, we move internal interface LocationProvider out of LocationProviderFactory to public/java, as it is needed by clients for testing purpose. We also public the MockLocationProvider.java by moving it into public/java, and add a LocationProviderOverrider.java to hide the LocationProviderFactory.java. In next step, we'll remove all external dependencies on "//device/geolocation", after that the geolocation can be moved to //services in a clean way. BUG=800659 Change-Id: I0bdef4244fe77d0b611cebb195ada2121ee77c42 Reviewed-on: https://chromium-review.googlesource.com/1079857 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567156}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/402795d084bf..17b4574e14a3 git log 402795d084bf..17b4574e14a3 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 chrome-bot@chromium.org Update config settings by config-updater. 2018-06-14 dgarrett@google.com master-full: Add better master/slave support for FULL_TYPE. 2018-06-14 bpastene@chromium.org cros_run_vm_test: Fix --host-cmd and --autotest cmd args. 2018-06-14 lannm@chromium.org Make FindOverlays output have deterministic ordering 2018-06-14 lannm@chromium.org Fix cros_mark_as_stable for CLs that create overlays 2018-06-13 ihf@chromium.org chromeos_config: make betty-arcnext important. 2018-06-13 bmgordon@chromium.org cros_sdk_lib: Reduce version warning to debug 2018-06-13 bmgordon@chromium.org cros_sdk: Add a --unmount action Created with: gclient setdep -r src/third_party/chromite@17b4574e14a3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851183,chromium:None,chromium:851059,chromium:851059,chromium:834412,chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I247744af7bf25889f89c57eee10cf8568af22542 Reviewed-on: https://chromium-review.googlesource.com/1100319Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567155}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/657edbede4e3..28252da5cf0a git log 657edbede4e3..28252da5cf0a --date=short --no-merges --format='%ad %ae %s' 2018-06-14 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 41320521bd3f..170766a36bd7 (1 commits) Created with: gclient setdep -r src/third_party/skia@28252da5cf0a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ie475c34114c8bd900fb44bee931f4e8aa0383baf Reviewed-on: https://chromium-review.googlesource.com/1100575Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567154}
-
Ben Pastene authored
This includes: cc_unittests display_unittests ipc_tests jingle_unittests latency_unittests pdf_unittests printing_unittests Bug: 840967 Change-Id: I0e0cc44ab2f1ce79aeddefd2cbc2d6ff22fa5d69 Reviewed-on: https://chromium-review.googlesource.com/1100375Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#567153}
-
Fabio Tirelo authored
Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 Bug: 852094 Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590 Reviewed-on: https://chromium-review.googlesource.com/1099560Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567152}
-
Tatsuhisa Yamaguchi authored
Bug: 845805 Change-Id: I2c17eab602db7b45d6c140a4da5a1a1f5248926b Reviewed-on: https://chromium-review.googlesource.com/1082188 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#567151}
-
Yue Cen authored
Bug: 835029 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1562850b50d873d68c0bd1586f2eab1ec9a14e9 Reviewed-on: https://chromium-review.googlesource.com/1034112Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#567150}
-
Patrick Noland authored
Now that root layer scrolling and scroll anchoring are on unconditionally, it no longer makes sense to check FrameView's ShouldPerformScrollAnchoring. This inadvertently turned ScrollAnchorSerialization off even when the flag was turned on. Change-Id: I56f5224bb2aef6d06e4d0086b76a6122d4ac4ad3 Reviewed-on: https://chromium-review.googlesource.com/1100068Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#567149}
-
Khushal authored
Use same limits for GrContext cache limits in OOP and GPU raster, which is tuned based on system memory. R=piman@chromium.org TBR=sadrul@chromium.org Bug: 844207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a0ae83a4b1ff14d2a9b5f14f6568a9c9cf25dc1 Reviewed-on: https://chromium-review.googlesource.com/1100008 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567148}
-
Matt Falkenhagen authored
Factoring out pure code health changes from a CL to add UMA to loaders https://chromium-review.googlesource.com/c/chromium/src/+/1098855. Bug: 762357 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6af1a5c9ce410b84404c182d835702891138bdc8 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1099095Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567147}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4cc753e01054..d668be9ce66f git log 4cc753e01054..d668be9ce66f --date=short --no-merges --format='%ad %ae %s' 2018-06-13 jmadill@chromium.org Vulkan: Use push constants in PipelineLayoutCache. Created with: gclient setdep -r src/third_party/angle@d668be9ce66f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I93e46cd15179fb7a391e121db6adec95effabde0 Reviewed-on: https://chromium-review.googlesource.com/1100317Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567146}
-
Zhongyi Shi authored
It is not useful to keep V1 tests as V1 experimental option was deprecated in https://chromium-review.googlesource.com/1060285. Bug: 843299 Change-Id: I914c41e8ce209eb6f847717912b100bbb5e1481f Reviewed-on: https://chromium-review.googlesource.com/1100305 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567145}
-
Zhongyi Shi authored
Bug: 843299 Change-Id: I6bdeecc0ba2498400a6f064e14013b37d09cb996 Reviewed-on: https://chromium-review.googlesource.com/1100380 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Blake O'Hare authored
Thanks to http://crrev.com/c/1006742 ui/keyboard only builds for OS_CHROMEOS and so it is safe to remove these checks now. Change-Id: Ifedc08f863e3356490a85ec8c3f1749ad1e9081e Reviewed-on: https://chromium-review.googlesource.com/1100357Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567143}
-
Bence Béky authored
Call SpdyWriteQueue::ChangePriorityOfWritesForStream() when the priority of an HTTP or WebSocket request backed by an HTTP/2 stream changes to ensure that already enqueued writes for the stream are moved to the correct write queue. This applies to both active and not-yet-activated streams. Also send HTTP/2 PRIORITY frames if the stream is already active. Add unittest for the case of two requests, the second one with higher priority (but no priority change), to test that the higher priority one will be sent to the wire first. Add unittest for priority change of inactive streams (ones with no assigned stream ID yet) to test that they are activated in priority order. Add unittest for priority change of active streams to test that PRIORITY frames are sent. Bug: 166689, 500673, 846541 Change-Id: I1f598f8d9179facf81a5cd4ee8bffda4ec98b3b3 Reviewed-on: https://chromium-review.googlesource.com/1098628 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41ff7a035785..425d9ce2d32c git log 41ff7a035785..425d9ce2d32c --date=short --no-merges --format='%ad %ae %s' 2018-06-14 nodir@google.com Allow CheckPatchFormatted to cause a failure 2018-06-13 tandrii@chromium.org gclient recipe: use env_suffixes insetad of custom ENV manipulation. Created with: gclient setdep -r src/third_party/depot_tools@425d9ce2d32c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6d8bfb14dac38c9328cb037f16eca589f2850056 Reviewed-on: https://chromium-review.googlesource.com/1100318Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567141}
-
Han Leon authored
This CL removes all legacy IPCs related things from EmbeddedWorkerTestHelper and do clean up accordingly. BUG=773193 Change-Id: I01efcb3847fa8eac998918a89e2855f87761e2ad Reviewed-on: https://chromium-review.googlesource.com/1098682Reviewed-by:
-
Tom Anderson authored
> This CL removes all absolute paths to src and all usages of the out directory > name from all ninja files on most Linux builds. > > This means it's possible to mount your src directory at different locations and > still have incremental builds work. You can also rename your out directory. > > BUG=None > R=dpranke,caitkp,rockot > > Reviewed-on: https://chromium-review.googlesource.com/1091457 > Reviewed-by: Cait Phillips <caitkp@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567020} This reland includes a fix for the breakage on Google Chrome Linux [1]. The issue was listing a relative path in the gn "inputs" variable. For some reason, despite inputs = [ "../../chrome/android/profiles/afdo.prof" ] ninja errored with '../../build/chrome/android/profiles/afdo.prof' ... missing and no known rule to make it It's unclear why "build" was added in the path, but simply using the non-rebased path for inputs fixes the issue. [1] https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/32416 R=dpranke TBR=rockot,caitkp BUG=None Change-Id: I2c5f9148ea8b1a8354a31f6bcc8ae4b8924c0b45 Reviewed-on: https://chromium-review.googlesource.com/1100168Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
Bug: 850902 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b55358e69fdf297cbd3079c20f8a3fe6585355d Reviewed-on: https://chromium-review.googlesource.com/1099768Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567138}
-
Evan Stade authored
Clients can send an image over mojo once and then reference it by its unique token. Apply this to the browser frame theme image. Bug: 836992 Change-Id: I91bbb060eead928780dc3d4d78dda9e5ba1b96d3 Reviewed-on: https://chromium-review.googlesource.com/1088235 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#567137}
-
Xi Cheng authored
Change-Id: Ifbfd63387c1060f664530ce54963303ff3146fd0 Reviewed-on: https://chromium-review.googlesource.com/1100109Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#567136}
-
Reilly Grant authored
Three new services: - mesh_provisioning - mesh_proxy - reconnection_configuration Eighteen new characteristics: - exact_time_100 - secondary_time_zone - time_broadcast - battery_power_state - battery_level_state - temperature_celsius - temperature_fahrenheit - position_2d - position_3d - removable - service_required - scientific_temperature_celsius - string - network_availability - digital_output - analog_output - pulse_oximetry_control_point - date_utc Bug: 517115 Change-Id: I036374fa5d750c072af238f1e35bff4eef43e1ac Reviewed-on: https://chromium-review.googlesource.com/1100126Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567135}
-
Trent Apted authored
Crashes show a task coming from -[NSWindow _endWindowBlockingModalSession:returnCode:] (before 10.13) or NSWindowEndWindowModalSession() (10.13 and later). This attempts to access the |modalDelegate| argument given to -[NSApp beginSheet:...], which is not retained, and can be destroyed in some lifetimes. The task is likely the one posted via an asynchronous Close() on a sheet, attempting to close the sheet using [NSApp endSheet:]. If a parent window of a sheet then triggers a more abrupt close, the sheet gets closed via -[NSWindow close] as well. Normally, the delegate would be retained to also end the sheet (to unblock the sheet machinery on the parent). However, this only happens if the sheetParent is non-nil. It appears that under some racy teardown paths the sheet's sheetParent can be nil at this point. To fix, pass the NSWindow itself as |modalDelegate| to permit WeakPtr-like semantics on the ViewsNSWindowDelegate. This allows some confusing lifetimes in ViewsNSWindowDelegate to be tightened up, as well as cleanly handle the mixed close codepaths that we have to cater for. Bug: 851376 Change-Id: I1954dc76f7cff5dc3f54f879aaad51fec12b623f Reviewed-on: https://chromium-review.googlesource.com/1096593 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567134}
-
Koji Ishii authored
In the current layout engine, PreviousBreakOpportunity is used only when mid-word break (break-all or break-word), but it is much more heavily used in LayoutNG. LazyLineBreakIterator is designed for forward only. PreviousBreakOpportunity is implemented by repeatedly calling NextBreakablePosition, but since NextBreakablePosition look for the next break opportunity until the end of the string, when a very long word without break opportunity is given, PreviousBreakOpportunity is O(n!). This patch changes it to O(n) by limiting the end position NextBreakablePosition can look for. blink/perf_tests/layout/word-break-break-word.html consumes 78% of the total time in LayoutNG. The average run is: Current engine: 469ms LayoutNG: 26,644ms This patch: 2,250ms It's still 4-5 times slower, more improvements will be in following patches. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I814e2c45c8030aa682c7f5e3a3b785b3c0733c84 Reviewed-on: https://chromium-review.googlesource.com/1095894 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567133}
-
