- 19 Jul, 2019 2 commits
-
-
Yi Xu authored
Added Canvas.TextMetrics.MeasureText and OffscreenCanvas.TextMetrics.MeasureText to measure TextMetrics calculation for Canvas2D and OffscreenCanvas, respectively. Bug: 982019 Change-Id: Idc9f21b9c0552deaa0594eff1bb6918885cc537a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687346 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678899}
-
Derek Schuff authored
GetExtensionSystem uses a KeyedServiceFactory that must be called on the UI thread (we have been calling in on the IO thread and blocking pool threads). Previously the NaClBrowserDelegate was getting the extension info from the profile directory on every call to MapUrlToLocalFilePath or IsNonSfiModeAllowed. Instead, we now get the extension system on the UI thread once (after the NaClHostMessageFilter is installed) and pass that into the NaClBrowserDelegate. TEST= all existing tests pass with the inclusion of the DCHECKs in https://codereview.chromium.org/2775753002 Change-Id: I9dff9e41babdd80424d6a92cbaf3e89582dda3e1 Bug: 701326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708751 Auto-Submit: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#678898}
-
- 18 Jul, 2019 38 commits
-
-
Rohit Rao authored
The system share menu now presents fullscreen when apps are compiled with the iOS 12 SDK. This causes the "Export Passwords" button to be completely removed from the view hierarchy rather than just disabled. BUG=983143 Change-Id: If02a5782679d376a1e232869add89f794c97f9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708840Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678897}
-
Eric Roman authored
Change-Id: Ie254d89ee283713459dff7c611e2b160ecd62b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707952 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#678896}
-
Kevin Qin authored
Bug: 984166 Change-Id: I68136fb5aa982f242261b9771d30b31c9a3ac386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707391 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678895}
-
Jeffrey Cohen authored
Bug: 984381 Change-Id: I94feb31085d0843ba2549379f5d19070af8fd6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703068 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#678894}
-
Jamie Madill authored
This moves the bar from M77 to M90. These histograms are effectively always needed. It also drops a couple of histograms that were no longer needed. Bug: 975166 Change-Id: I6f1dc8ac8028a0af5336c25ae599f09f5c49b3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706451Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#678893}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24ba8447..ad244143 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6eb09368236a4b270eb66423c36538a2c2b4e4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708710Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678892}
-
Piotr Bialecki authored
Change-Id: Ia32ffac25792cee7216e677bb94fced3a8be9c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695962 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#678891}
-
tby authored
This is a directory for our team's CrOS ML UKM logging, so it would be useful to have an OWNER on the team. Change-Id: Idd845ebc8a1c4107e6a1651dc3908efaa58f6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708129Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#678890}
-
Nick Harper authored
The trie used for the HSTS preload list is a series of dispatch tables, each starting with a prefix of zero or more characters. The length of that prefix was previously encoded in unary, so the number of bits required to encode a length was one larger than the value of that length. This changes the format to use a slightly more complicated prefix code (https://en.wikipedia.org/wiki/Prefix_code) which based on the current distribution of lengths encoded in the trie reduce the size of the encoded trie by about 18 KB. Change-Id: I3ff03c613bd266010b3ff1d8c69f9eae73474e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708248 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678889}
-
Adam Langley authored
The QR code display will, in the future, allow pairing of phones as security keys. This CL adds initial support for generating and displaying the QR codes. This UI is not yet reachable in any way but allows and is only intended for experimentation. Change-Id: I3c3696f0e680a4d1de415a83c18e4e5ff50f66f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659133 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#678888}
-
Yuwei Huang authored
We have introduced a new exit code kHostDeletedExitCode = 106 but it hasn't been added to Linux and Mac host daemon scripts. This CL adds it to the scripts. Change-Id: I7c09801e0571f42d4fcf6b7c5dbc6ba7920a86f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707953 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#678887}
-
Koji Ishii authored
This patch moves |LowerUnicode| and |UpperUnicode| to |CaseMap|, a new class to do the full Unicode case mapping. This patch does not change behavior, except: 1. Is a preparation to add text offset support for issue 985201. 2. Split the algorithm from |String|. 3. Make the locale-normalization cacheable, and cache it in |LayoutLocale|. Most code is just moved, other than changes noted above. This class needs to stay in |wtf| because |DeprecatedLower()| needs part of this code. See crbug.com/627682. Bug: 926003, 985201 Change-Id: I7b5036b2cf610156c44a11f6a4950120d8349fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707996Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678886}
-
Daniel Rubery authored
While testing, we allocate raw pointers, but never freed them. Change the raw pointers to unique_ptrs to ensure they are freed correctly. Change-Id: I5a0642392b1c7f9fde87a2aca821ec180a875eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709351 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#678885}
-
Johannes Henkel authored
Change-Id: I7f3018810b295f09d65d7bd306f15adfee0d51dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705394Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Auto-Submit: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#678884}
-
Tibor Goldschwendt authored
ModuleInstaller calls ModuleInstallerImpl at startup of each process. Therefore, make sure ModuleInstallerImpl is part of the main DEX. Before this CL, ModuleInstallerImpl was in a secondary DEX and, thus, multidex Chrome builds crashed at startup on Android K. + Enable a VR test that was disabled due to the crash described above. Bug: 984943, 981084 Change-Id: Ibb508a53b470a65c0cdde6ed7ccc78dad1fbf173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709632 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678883}
-
Chase Phillips authored
Bug: 984374 Change-Id: I47829925197a08fb58469418a7f392d350dd52ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652747 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#678882}
-
Natalie Chouinard authored
Migrate the SingleWebsitePreferences Preference fragment from deprecated Framework preferences to the preferences Support Library. Note that in the transition from framework preferences to support library preferences, DialogPreferences are now composed of two separate classes (DialogPreference for the preferences itself, and PreferenceDialogFragmentCompat for actually presenting the dialog view associated with the DialogPreference). Both are abstract classes that must be extended in order to be instantiated, hence the new introduction of ClearWebsiteStorageDialog in this CL. Bug: 968592 Change-Id: I26023389c0366115d51227e134e36470e7ece645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707429 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678881}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9c78f592fcee..3d4dfa671d07 git log 9c78f592fcee..3d4dfa671d07 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 ynovikov@chromium.org doc: Update TestResults.qpa location on Android Created with: gclient setdep -r src/third_party/angle@3d4dfa671d07 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Id4c05c48e0c48c29d95753fc18216d70aa61dd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678880}
-
Josh Nohle authored
Handles the SyncMetadata portion of the CryptAuth v2 DeviceSync protocol, which consists of one or two SyncMetadata request/response interactions with the CryptAuth servers. The output of a successful flow is: - A map from Instance ID to DeviceMetadataPacket, which contains device metadata encrypted with the group public key. - (Optional) A new group public and private key created by the client or a new group public key provided by CryptAuth. - (Optional) A group private key, encrypted with the local device's CryptAuthKeyBunde::kDeviceSyncBetterTogether public key. Neither the device nor key registries change; all relevant data is sent as callback parameters. Verified 100% code coverage aside from different flavors of network request errors. Bug: 951969 Change-Id: I54c4a3afd72d751e7dc95545ac64ce9f811d939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703070Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#678879}
-
Aaron Colwell authored
This ensures that the default SiteInstance's process doesn't accumulate file:// URL access grants over time, where any other non-isolated site might abuse them. - Refactor default SiteInstance logic so new conditions only need to be added in one place. - Added a new condition that excludes file: URLs from being allowed in the default SiteInstance. Bug: 958060 Change-Id: Id97785790c14bb0d5469089f4ce6cd2786665b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699242Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#678878}
-
Zhenyao Mo authored
Currently we didn't clamp level values when computing which level actually have images, therefore leading to out-of-bounds access. BUG=983938 TEST=gpu_unittests R=piman@chromium.org Change-Id: Ia4c143f271cfc5142a34ade5f3163e29d9be7033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708008Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678877}
-
liberato@chromium.org authored
VideoFrameFactoryImpl can call CodecImage::Initialize when it gets the CodecImage from the SharedImageVideoProvider. Previously, it forwarded the output buffer, etc., to the provider instead. The reason that the provider was responsible for it was to hide the fact that a CodecImage was involved at all; this is an implementation detail of the current SharedImageVideo. However, since VideoFrameFactory already has to have the CodecImage for early rendering, it might as well handle initialization too. If we can deprecate early rendering, then we could just provide a callback in the ImageRecord instead, to hide CodecImage entirely. When we introduce image pooling, it's convenient to allocate images from a provider without actually initializing them at all; the pool can handle it when it hands them out to clients. Change-Id: I6a7c9d61306fd126cb77ba087f82e5a6ccb8d968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707549 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#678876}
-
Marijn Kruisselbrink authored
Rather than just having a comma-separated list instead summarize the first few items and have a expand button to see the rest of the items in a list. Collapsed state: https://storage.cloud.google.com/chromium-translation-screenshots/ffb37a66f0880ebe32ce86a2c17c9c5cd21e6212 Expanded state: https://storage.cloud.google.com/chromium-translation-screenshots/06fb9e7b615e10bedbcf54d217a1b502536931b8 Bug: 985147 Change-Id: Ieb5bac3f6e5c05def2e27e89ebf8dd49015f515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709133 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#678875}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=asanka@chromium.org NOTRY=true Bug: 977050 Change-Id: Ie8838980e9d35fc74d2a41917735b97476a1465a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700869Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678874}
-
John Emau authored
This change adds two error messages to the EditFileSystemView: - When a user inputs a duplicate excluded folder path, show: "Enter a unique path" - When a user inputs an empty excluded folder path, show: "Enter a path" This meets ARIA WCAG 3.3.1 Error Identification and 3.3.3 Error Suggestion. See: - https://www.w3.org/WAI/WCAG21/quickref/#error-identification - https://www.w3.org/WAI/WCAG21/quickref/#error-suggestion Note that the EditFileSystemView is only used by the Workspace settings tab. Screenshot: https://i.imgur.com/2W4dhpi.png Bug: 963183 Change-Id: I57582ae536c34ecf9bdef8e8f80e422f663664f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688649 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#678873}
-
Jenna Himawan authored
Bug: 981909 Change-Id: I14e3febda4f40d21a8428832568e825724bab5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703084 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678872}
-
Toby H authored
SupervisedUserTestBase Bug: 943208 Change-Id: Icef0c2c3aec596c802ec912a0912cba5104b6608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701059 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#678871}
-
Kevin Bailey authored
from this routine. This CL simply makes sure that it is initialized. WebThemeEngine: :Paint() is reading one uninitialized bool that comes Change-Id: Ida7431e676d0451373c8957f641b2e57f81f24b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708414Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678870}
-
Etienne Pierre-doray authored
This CL implements logic in ThreadGroup to track min priority below which tasks should yield. Bug: 839091 Change-Id: I401240facd4ab590d99538cbd0d5b5f387f2db89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698344 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#678869}
-
John Budorick authored
Bug: 983367 Change-Id: I06e6a7d890f3f0b36a34fa69047de40aa8a96126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709510Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678868}
-
John Lee authored
https://imgur.com/a/e6TBx8J Bug: 973674 Change-Id: I51f05827616f679feca047df00321b6fcb4ef88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707651 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#678867}
-
Xing Liu authored
These metrics for media parser record all critical events for the download video thumbnail and media metadata flow, and should be kept as stability metrics. Bug: 974938,974936,974934 Change-Id: I8910252fbbdfa7c2b6fe88e035a7e8f762419c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707871Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678866}
-
Mehran Mahmoudi authored
This moves the text selection cursor to the end of the text in 'add to my apps' dialog. Bug: 985044 Change-Id: I9cfdbc818513e00e758548d3a442475ab1dfc2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708427Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678865}
-
Edward Jung authored
Bug: 984497 Change-Id: Ic93c9fe766924e35e89df37c85ec1f81276dfd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706524Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#678864}
-
Jacques Newman authored
All delegates that inherit from AXPlatformNodeDelegateBase do not implement the GetIndexInParent method. This makes generic GetNextSibling/GetPreviousSibling impossible on the delegate. To mitigate, I have implemented a generic GetIndexInParent on AXPlatformNodeDelegateBase. It has a complexity of O(n), but this is not different that the various platform implementations of AXPlatformNode::GetIndexInParent. Change in browser_accessibility_mac was necessary to avoid using a const cast as GetIndexInParent is not const. (Relies on non-const method: GetParent) The other option would be to make GetParent const, which is trivial to do, but requires changes to an additional 20 or so files. Bug: 984995 Change-Id: If061c212eee974534aad588b9d225f7cff9b00df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707132Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678863}
-
Mehran Mahmoudi authored
Bug: 984004 Change-Id: Id87703d503c5018b41785112833abd1b06e58e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704749Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11451f9550a7..91d2c3938fa5 Created with: gclient setdep -r src-internal@91d2c3938fa5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I28159676efcf4b62d4cebf619714181ac84c1b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709397Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678861}
-
Owen Min authored
Metrics Enterprise.PolicyUpdatePeriod.MachineLevelUser now expires in M84. Bug: 975865 Change-Id: Idc74172b1abb70775ee4615ce07d09e8317c02c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699278Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678860}
-