- 10 Dec, 2019 40 commits
-
-
Jérôme Lebel authored
Fully splitting ":test_support" and ":fake_chrome_identity". ":test_support" should never be included in eg_test_support+eg2 targets. Updating all targets using "browser/signin" to choose either ":test_support", ":fake_chrome_identity", or both if needed. Bug: 987646 Change-Id: Ie90f4a73283fc1e2fe9b231a3f6de9a2e15e52c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954482 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723340}
-
Mikel Astiz authored
displayKeyRetrievalDialog() is now implemented in the most basic form. It relies on a backend (embedder-specific) providing an Intent that will upon completion expose the newly-fetched keys via fetchKeys(). In this simplest form, key retrieval will only take effect after the browser is restarted, which is suboptimal, but TODOs have been added to improve such behavior in the future. Bug: 1012659 Change-Id: I6b1974916f5d94cfcdc0507e0dcdf5746ccf2314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951006 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#723339}
-
Matt Menke authored
URLLoaderInterceptors take net error codes, not URLRequestStatuses (which is deprecated, and shouldn't be used anywhere). Both, unfortunately have values of 0. Bug: 651119 Change-Id: Ic0bc52c1f1c338b18449f2c684ad481f526d72e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955904Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#723338}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d00dfe493098..4cf92db35cb9 git log d00dfe493098..4cf92db35cb9 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 bclayton@google.com Vulkan/Debug: Add ID Created with: gclient setdep -r src/third_party/swiftshader@4cf92db35cb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I617e9bc9649f3b29c6e2c2f97ccb48c2ee5a965c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723337}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3e4e569cd257..808d9949c3eb git log 3e4e569cd257..808d9949c3eb --date=short --first-parent --format='%ad %ae %s' 2019-12-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@808d9949c3eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia24ceb173a2110ef2cd63f76a3304f94946ba799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960133Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00d0f178c2e0..ded86c1ad80b git log 00d0f178c2e0..ded86c1ad80b --date=short --first-parent --format='%ad %ae %s' 2019-12-10 peah@webrtc.org Remove remaining settings for using legacy AEC 2019-12-10 jonasolsson@webrtc.org Ensure loss-based controller is always enabled. 2019-12-10 yvesg@webrtc.org [UBSan] Remove suppression for opus. 2019-12-10 daniel.l@hpcnt.com Fix nullablity on CameraCapturer 2019-12-10 anderskl@microsoft.com Remove MessageBoxA UI API call from socket code 2019-12-09 mellem@webrtc.org Add VideoTimingExtension to kFecOrPaddingExtensionSizes. 2019-12-09 anderskl@microsoft.com Don't try to load kernel32.dll in RWLockWin class 2019-12-09 yvesg@webrtc.org Roll chromium_revision 34a43a35..59395671 (722057:722888) 2019-12-09 kron@webrtc.org Revert "Distinguish between send and receive video codecs" 2019-12-09 kron@webrtc.org Distinguish between send and receive video codecs 2019-12-09 yinwa@webrtc.org Add directive to make webrtc metrics optional. Created with: gclient setdep -r src/third_party/webrtc@ded86c1ad80b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737,chromium:941413 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1f76257a2d3a37f0e26ff5e4b6d88f53797a0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960132Reviewed-by:
-
Balazs Engedy authored
Even if displaying notification permission requests using the quiet UI is enabled on all sites, the NotificationPermissionUiSelector should still check the crowd deny state. If crowd deny prescribes triggering, QuietUiReason::kTriggeredByCrowdDeny should be returned instead of kEnabledInPrefs, so that the less-prominent version of the UI and the correct string is shown. Bug: 1032043 Change-Id: I29f6b1773131f74952ef5816ffd2518c0d91fc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958137 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#723334}
-
Bartek Nowierski authored
This change adds use counters for counting V8 function calls in detached windows. They aren't emitted the usual way, because the use counter infrastructure doesn't work on detached windows. Instead they're plumbed through instance counters to be emitted via UKM. NOTE! This re-introduces the following change (but without web feature definitions, which were redundant): https://chromium-review.googlesource.com/c/chromium/src/+/1925839 TBR=rkaplow@chromium.org,asvitkine@chromium.org rkaplow or asvitkine: Please approve changes to ukm.xml and process_memory_metrics_emitter.cc; these files haven't changed since 1925839, which Robert approved before. Bug: chromium:1018156 Change-Id: If16c3a85bfe539c202561d435576f1df80f060bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958487 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#723333}
-
Philipp Hancke authored
visualizes headerBytesSent/Received similar to bytes sent/received BUG=webrtc:10525 Change-Id: I0b7d4b52b00c8fc0b6a4b11244fd08e313a4f823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953741 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723332}
-
Jeremy Roman authored
Without this, the Portal could be notified of its owned WebContents' destruction while it is running its own destructor, causing to to reenter its destructor, leading to all manner of badness. Bug: 1031677 Change-Id: I89d8737e2c30ffb0d67c04ea0ccad577575d9a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958597 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723331}
-
Alex Chau authored
Bug: 1029747, 1029483 Change-Id: I21df2348104a96771cbce39065a430c48bca734b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960268Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#723330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43e0973176a3..4984ca9a203f Created with: gclient setdep -r src-internal@4984ca9a203f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9578e19c0dd45dda38de9c3d36b5773327e45a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960129Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723329}
-
Xianzhu Wang authored
- Paint VisualViewport after all other contents, to make sure the scrollbars appear on the top; - When device emulation transform node exists, the scrollbars' transform space should be the device emulation transform; - Should repaint VisualViewport when its paint property nodes are created or removed. Device emulation transform node is the only case. One android render test is rebaselined: chrome/test/data/android/render_tests/ReturnToChromeTest.10_web_tabs-select_last.Nexus_5-19.png.sha1 See https://storage.cloud.google.com/chromium-result-details/b1cb5fb6fee47559ba4cac31a006bc6c2cdc40eb for the difference. The new result has scrollbars in the thumbnails in the tab grid view. Bug: 1028079 Change-Id: Ic52179014e2538025c74ba47112a2b307dd2943e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956968 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#723328}
-
Stepan Khapugin authored
Subj, and fix all plumbing Change-Id: I191ba099f8e1431208e0a21cf39ecfa0dedbf6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951013 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#723327}
-
Nazerke authored
This CL adds all signin settings tests to EG2 target and updates headers and adds eg2_test source_set in build file. New app interface for signin settings tests is being introduced. [updated]. Bug: 987646 Change-Id: Ie6bc67b68ad2c68769911863f75f622249465517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950944Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#723326}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31d0fa9a..3f57d6f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd75806cea04ff95b2bee4710468741b78659b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959608Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723325}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: Ibe3992158398f77f692d6e965f2535cbd424f72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950988Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723324}
-
Balazs Engedy authored
Bug: 1953713 Change-Id: I97fb1594a6e42b9406ff16765a0300c11f51d123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955560Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Show EulaLoadingScreen by default, hide when the webform is uploaded. Bug: 1014070 Change-Id: Ie327f30ac9ed921bc6b368ca03eb2751fe340d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859792Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#723322}
-
Finnur Thorarinsson authored
When all chips are deselected, there's no point in having the Done button enabled, as no data will be sent to the web page. This is much like when no selection has been made (the Done button becomes enabled only when more than one contact has been selected). Bug: 988273, 860467 Change-Id: I16cdc8506d1c00f24a4cbb431765c734dcf666be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953086 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Robert Liao authored
Clang-Tidy performed all of the transformations in this change. BUG=1030028 Change-Id: I3205dca208a648943aeae72630dc1166427beb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959647 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#723320}
-
Sergio Villar Senin authored
It was only used internally so it does not make sense to expose it. Bug: 919392 Change-Id: I6a8efb4a4060ec5cd164d84d788c13824000938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955554Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#723319}
-
Thomas Tellier authored
Bug: 1026644 Change-Id: Ib4196b0edf85d114909124d7a2f1f7af1d36c948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948942 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#723318}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7c08c78. With Chromium commits locally applied on WPT: a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" 1b891ab3 "PerformAction API supports two pointer up actions in different ticks" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ia428a9011bba12bb5fe9fd4811813b1a3bc093d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959607Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723317}
-
Edward Jung authored
setting Change-Id: If772f72e557cd8bad7d1c08144ab42608f2b3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953624Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mvanouwerkerk@chromium.org Bug: 1023677 Change-Id: I796751a83efe4844a317f9dd7692beff7feadd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957562 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723315}
-
Andreas Haas authored
This CL replaces calls to DeprecatedByteLengthAsUnsigned by calls to ByteLengthAsSizeT. Unfortunately the content of the ArrayBuffer is copied into a WTF::Vector, whose maximum size is smaller than the maximum size of an ArrayBuffer. Therefore I reject the incoming ArrayBuffer with a kNotSupportedError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=reillyg@chromium.org Bug: chromium:1008840 Change-Id: I9bdc703fe112159bc6fb54b4c3aeb7035d6ae130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954517Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#723314}
-
Mathias Carlen authored
This patch adds a static direct action for "find in page" to the set of already existing static actions (e.g. new tab, go back, etc). In order to be consistent the FindInPageManager is used to show the UI and the TextField for the search term is then populated with the search query passed in by an assist app using Android's direct action API. There is no voice support planned for moving to the next/previous match or close the "find in page" UI again. Bug: b/145106813 Change-Id: Ieaee42f039cc77b7f03bdbba0b110aaa0887e039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944396Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723313}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ed7593767f4..43e0973176a3 Created with: gclient setdep -r src-internal@43e0973176a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia500188830539635b6d42fb8c88c7d31a51d451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960127Reviewed-by:
-
Rune Lillesveen authored
Flakily timing out on multiple platforms. Bug: 1032318 Change-Id: Iff758bd9bc37f99355482004ccfe5b3b04bb6e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960147Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#723311}
-
Robbie Gibson authored
This extracts the presentation code for this UI element out of the find bar controller. This is most useful because the same UI will be used for Text Zoom. Bug: 1028938 Change-Id: I753a42c0831b51856457d7bce4460f76b0ebb95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943182 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9138bb30. Reason for revert: Suspect to cause: https://crbug.com/1032504 Original change's description: > [web tests] Add layout-test-results/ prefix to all artifact relative paths in json results > > This will make the artifacts paths consistent with the isolate output directory paths. All > test runners should follow this standard for outputting artifact paths in the JSON results. > > Bug: chromium:1026494 > Change-Id: I36dbbb2a9bec507182610e959edf55f1819d2ca7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925687 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#723270} TBR=sky@chromium.org,nodir@chromium.org,jchinlee@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: I33865144510d196e7275e19893f5be344695449b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1026494,chromium:1032504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960266Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#723309}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5a1c64fa5bc9..763d0d38ddae git log 5a1c64fa5bc9..763d0d38ddae --date=short --first-parent --format='%ad %ae %s' 2019-12-10 thestig@chromium.org Revert "Properly write floats in CFX_PSRenderer." 2019-12-10 tsepez@chromium.org Add JavaScript tests for file select fields. 2019-12-10 tsepez@chromium.org Cover cfxjs_engine.cpp's CallHandler() success case. 2019-12-09 tsepez@chromium.org Provide some diversity of arguments in mouse_events.in. 2019-12-09 thestig@chromium.org Properly write floats in CFX_PSRenderer. Created with: gclient setdep -r src/third_party/pdfium@763d0d38ddae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1d43209d0c42c153f63165847035dde0bfbdaf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959780Reviewed-by:
-
Omer Katz authored
Bug: 986235 Change-Id: Iea1e84d739ce38295a3fb590ca1c53a2509d5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954021 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be77fa8b..31d0fa9a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I877f665ee23116cd710cf33337705d0fc821dff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959606Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f6ac2feb1de..3e4e569cd257 git log 2f6ac2feb1de..3e4e569cd257 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 petermarshall@chromium.org Remove asParsedURL on the String prototype Created with: gclient setdep -r src/third_party/devtools-frontend/src@3e4e569cd257 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47332f45a17d6733ba917cd064c65359483442e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959784Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I29c0113218f1214fd438f04c1c45d3945601b8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955000 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#723304}
-
Takashi Toyoshima authored
Enum names, CorsAccessCheckError and CorsAccessCheckResult, were mistakenly swapped, and this results in showing wrong annocations in the metrics dashboard. Change-Id: Ia7adcde73bfd6c7f0e9cf9370c46fe114b6e1c7c TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958265 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#723303}
-
Miyoung Shin authored
This CL converts MediaPerception mojom interface clients for extensions in chrome to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ib1f8d59906d255e94540a111d8bf0e406366acfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954820 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#723302}
-
Miyoung Shin authored
This reverts commit 3b0537d2. Reason for revert: relanding since this CL fixes the build error Original change's description: > Revert "Convert InputEngineManager client to use BrowserInterfaceBroker" > > This reverts commit 328e5c36. > > Reason for revert: compile failed on https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/10375?blamelist=1#blamelist-tab, https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-google-rel/3538 and https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-google-rel/16026?blamelist=1#blamelist-tab > > Original change's description: > > Convert InputEngineManager client to use BrowserInterfaceBroker > > > > This CL converts InputEngineManager mojom interface clients for > > extensions in chrome to use BrowserInterfaceBroker. > > > > Bug: 936482 > > Change-Id: Iecc57f2a8c15a9523f08e4ab49156273a2ba4677 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952623 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Reviewed-by: Sam McNally <sammc@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#723261} > > TBR=rockot@google.com,sammc@chromium.org,oksamyt@chromium.org,myid.shin@igalia.com > > Change-Id: I28cc7789bbedb8cb7dc9c46b60d6620105379ba2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 936482 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959240 > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723266} TBR=rockot@google.com,sammc@chromium.org,oksamyt@chromium.org,mxcai@chromium.org,myid.shin@igalia.com Change-Id: I5e667f043a4b3dda4c3b432bb2711e167e3409d8 Bug: 936482 Change-Id: I5e667f043a4b3dda4c3b432bb2711e167e3409d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959241Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#723301}
-
