- 04 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aeba7fa1fd36..6be3ea7a7d72 git log aeba7fa1fd36..6be3ea7a7d72 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 bungeman@google.com [pdf] Disable default width calculation. Created with: gclient setdep -r src/third_party/skia@6be3ea7a7d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I22403944dbe5a3c13f854823962d1c9fe3ffdcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692993}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I15d79cc3e9e8689486e8d7d164b00757b40032dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784097Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692992}
-
Fergus Dall authored
We currently have metrics for the installer, but no way to tell how many people are experiencing errors starting crostini after that. Bug: 977201 Change-Id: If828e4cefc10197ddc9dbdc5b867f68184975f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773999 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#692991}
-
Jeevan Shikaram authored
This is a reland of 2fd01309 Original change's description: > [App Management] Enable App Management by default. > > Enable App Management by default. Current entry points are about:settings > and about:app-management. > > Bug: 906508 > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659341} Bug: 906508 Change-Id: I08def499ce0c87ff44ac722b3bdcd8a238938959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782363 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#692990}
-
dalyk authored
Uses a hardcoded mapping to upgrade insecure DNS and DoT services to associated DoH services. The mapping is preliminary and will be adjusted before we run an experiment. Whether upgrade is attempted is controlled by the new kDnsOverHttpsUpgrade feature, which is enabled by default on ChromeOS, MacOS, Android, and Windows. Problematic providers can be excluded from the mapping using the kDnsOverHttpsUpgradeDisabledProvidersParam feature. Example usage: --enable-features="DnsOverHttpsUpgrade<DoHTrial" \ --force-fieldtrials="DoHTrial/Group1" --force-fieldtrial-params=\ "DoHTrial.Group1:DisabledProviders/Google" Bug: 985589 Change-Id: Ife81913bf5b7aade66cace1d3d8ad87d55b11ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638928 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#692989}
-
Jinsuk Kim authored
Favicon callbacks can be invoked after the navigation sheet is already closed. There is a null check against |mModelList| but it never becomes null. Its state should have been checked instead. This CL checks such case correctly. Bug: 1000220 Change-Id: I724b7c3a7d79e36a99d6c102849312e8010f2548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783680 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#692988}
-
Glen Robertson authored
Only implemented for extensions for now. Will be used in subsequent CL. Bug: 989792 Change-Id: I9d15f7c007ecdf655c060d858122a7b3b3ed768a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783679 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#692987}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I54ef7e914cc427136c9f43fc9ecbccf4c8985af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783998Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b56e61af91f..f4e32bb25503 Created with: gclient setdep -r src-internal@f4e32bb25503 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8d73466a5eae34c7572b2bbdf69295fb76b75817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783997Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692985}
-
Takashi Sakamoto authored
This reverts commit 206ddf5d. Reason for revert: causes compile failure on android-archive-rel bot Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4265 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903288806742935296/+/steps/compile/0/stdout?format=raw --- lib.java/android_webview/support_library/callback/callback_java.jar lib.java/android_webview/glue/glue.jar lib.java/android_webview/support_library/support_lib_glue_java.jar lib.java/build/android/buildhooks/build_hooks_android_impl_java.jar ) In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizationpasses In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizations Item boolean org.chromium.base.library_loader.LibraryLoaderConfig.areTestsEnabled() was not discarded. boolean org.chromium.base.library_loader.LibraryLoaderConfig.areTestsEnabled() |- is invoked from: | void org.chromium.content.app.ContentChildProcessServiceDelegate.onConnectionSetup(android.os.Bundle,java.util.List) |- is reachable from: | org.chromium.content.app.ContentChildProcessServiceDelegate |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:29:1 Item boolean org.chromium.base.library_loader.LibraryLoaderConfig.useChromiumLinker() was not discarded. boolean org.chromium.base.library_loader.LibraryLoaderConfig.useChromiumLinker() |- is invoked from: | void org.chromium.content.app.ContentChildProcessServiceDelegate.onConnectionSetup(android.os.Bundle,java.util.List) |- is reachable from: | org.chromium.content.app.ContentChildProcessServiceDelegate |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:29:1 Error: Discard checks failed. Compilation failed --- Original change's description: > Reland: Android: Make Linker.java optimized out when use_chromium_linker=false > > This reverts commit f6e84797. > > Reason for reland: Removed -checkdiscards. > > TBR=agrieve # Trivial rename > > Change-Id: I8924fb2ef16ba1a1704e33634c45471c56d84e21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780955 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692947} TBR=agrieve@chromium.org,lizeb@chromium.org,smaier@chromium.org Change-Id: I99b31d3eb3ee630e5270fe9c9f747a9867d8e57e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784019Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#692984}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e576e759..6b931165 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5055c5db61e3fa9a7e0e981e595d2df0f2cb0b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783216Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692983}
-
Julie Jeongeun Kim authored
This CL converts BlobPtr from Write in native_file_system_file_writer.mojom and Register in blob_url_store.mojom and updates methods and members to implement them. Bug: 955171, 978694 Change-Id: If254a289988e7a7eb852988cb99a3a2e9a254e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757946Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#692982}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a9881e19baa..ac9e322afcdc git log 1a9881e19baa..ac9e322afcdc --date=short --no-merges --format='%ad %ae %s' 2019-09-04 lgoodby@google.com config: Remove hwtests from Jetstream release builders Created with: gclient setdep -r src/third_party/chromite@ac9e322afcdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I89f642de4d1e059b97c5e1c1bbb02273e78fe42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783675Reviewed-by:
-
Kurt Horimoto authored
This metric will help us understand how users interact with the non- modal dialog feature. Bug: 999356 Change-Id: I563be6a26d05c622828c33d57cc7966a847e094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776714 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692980}
-
Darwin Huang authored
Change-Id: I18866d9a69a846ebc5aed73200d643c386717d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776930 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#692979}
-
Gyuyoung Kim authored
This CL converts the old Mojo types to the new Mojo types in CppSideConnection class. Additionally, this CL needs to add EnableTestingMode to Receiver in order to continue calling EnableTestingMode after replacing mojo::Receiver. Lastly, js_side() is removed because nobody calls it. Bug: 955171, 978694 Change-Id: I17f7aa4cb2a83826902e3818c3c88008f46cb059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778892 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Simon Que authored
CI/Try migrated: - Win ASan Release - Win ASan Release Media Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I496c7e6a5c9d31733bdfdfda5178ff015768805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778900Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#692977}
-
Timothy Loh authored
This CL reduces the code duplication for calling DBus methods in concierge_client.cc. Change-Id: Id5a9ca03f7faad049460f047c6f1ca63c2ea847f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778442Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692976}
-
Yutaka Hirano authored
This reverts commit a689aa50. Reason for revert: suspected to break content_unittests. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14863. Original change's description: > [scheduler] Relanding registering the task executor in TLS. > > I am attempting to reland > https://chromium-review.googlesource.com/c/chromium/src/+/1751251 > with a fix. The race condition which triggered the revert is test-only, > I have now marked it as benign and it shouldn't fail TSAN anymore. > > TBR=alexclarke@chromium.org,tedchoc@chromium.org > > Bug: 968047 > Change-Id: Iafbc31a80144371b22c0cd4ef6547c2ef2adfd62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781596 > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Karolina Soltys <ksolt@chromium.org> > Auto-Submit: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692708} TBR=tedchoc@chromium.org,alexclarke@chromium.org,ksolt@chromium.org Change-Id: I3c65ae5ae5ff3e8ecf3f990bb4464d3c6cab34ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784017Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#692975}
-
Kurt Horimoto authored
activity_services::RetrieveCanonicalUrl() is used to fetch the URL to add a page to the reading list, but this function requires JavaScript execution, which is paused while JavaScript dialogs are presented. This CL disables the "Read Later" button in the popup menu while overlay UI is displayed in OverlayModality::kWebContentArea. Bug: 986760 Change-Id: I6fef342a740846fe849ed38d8f25ec90228cc54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752288 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#692974}
-
Manu Cornet authored
The issue was that we were calculating centering coordinates according to the whole screen rather than each individual display. Add a test for this. This change also fixes a bug in ash/screen_util where the shelf bounds were not returned in terms of the whole screen's coordinates. A few unit tests in ash/wm also needed fixing in that sense. Bug: 997768 Change-Id: I91ab6ef2f85601edc115743dd0ab0ae83076be94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773891 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692973}
-
Andrew Grieve authored
And also rename to "waitForFirst()" to distinguish them. This should remove a source of flakes in tests. The bug is that code looked like this: CallbackHelper helper = new CallbackHelper(); someAsyncStuff(helper); helper.waitForCallback(); But if someAsyncStuff() happened before waitForCallback(), then waitForCallback() would wait forever since it was setting currentCallCount=getCallCount(). The only way the waitForCallback() methods make sense when not given an explicit "currentCallCount" parameter, is to assume currentCallCount==0. Bug: 1000510 Change-Id: Ife495efda5cac6e826e8ee184245026af5ba8a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777023 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692972}
-
Naoki Fukino authored
Enabling the flag allows per-device setting for external storage in Settings > Device > Storage management > External storage preferences. Bug: 954228 Change-Id: I4fa197d768df02a76375c9a101bcde691a1db004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782207Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#692971}
-
Yulun Wu authored
Bug: 999376 Change-Id: Ib47b1e86a147a0292ba0a0f11dfa2983de8da562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776856Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/feb8507f4b52..c3f7873b9a3a git log feb8507f4b52..c3f7873b9a3a --date=short --no-merges --format='%ad %ae %s' 2019-09-03 lujc@google.com Use TransformFeedbackID in place of GLuint handle Created with: gclient setdep -r src/third_party/angle@c3f7873b9a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I7c8f9a8bd4296501aa23128fd17ae4eb4e12f9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783671Reviewed-by:
-
Miyoung Shin authored
This CL converts WakeLockObserverPtr and WakeLockObserverRequest in chromeos and services to the new Mojo types, and uses pending_remote<WakeLockObserver> in wake_lock_provider.mojom. Bug: 955171 Change-Id: I64737987808d286ae0c15ab50f2250f7cd503ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771225Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#692968}
-
Miyoung Shin authored
This CL converts FontUniqueNameLookupPtr in blink and FontUniqueNameLookupRequest in content to the new Mojo types. Bug: 955171, 978694 Change-Id: Icbd653cc33242172aca2dd77f37c8adc5d26ac7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781909Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#692967}
-
Zhongyi Shi authored
Session will migrate to the new port after probing succeeds. BUG: 999285 Change-Id: I115a6a7eede4c027bb666288c1a838a6b1323549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775744 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692966}
-
Dominik Röttsches authored
Disable this configuration until bot testing stability issues are addressed. Bug: 999787 Change-Id: I82f3803d9def9ca13fbf991a1752d0e384024552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778613 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692965}
-
Manas Verma authored
Changing CreditCardAccessManager::OnCVCAuthenticationComplete() to take in a struct. Eventually will need to include an authorization token as part of the response, so changing this to a struct will keep things clean. Bug: 949269 Change-Id: I682c6abfe474427c36b035e3416168f08aed2c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761368Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#692964}
-
Antonio Gomes authored
This is a reland of 19c2d0e4 This CL has no changes compared to the original one. The error was on CL https://crrev.com/c/1778671 (already relanded in https://crrev.com/c/1782514). Original change's description: > Onion soup content/renderer/media/webrtc/rtc_video_encoder_factory.cc|h > > This is phase 2.3 on the design document [1]. > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: I32628d84aaba9eba9bde7c9484f8984517b9abf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778673 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692762} TBR=guidou@chromium.org Bug: 787254 Change-Id: Ia59c58a57dc84322408f64181057819adf4bdad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783208Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#692963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a9114f34ad3..0b56e61af91f Created with: gclient setdep -r src-internal@0b56e61af91f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I38d3efcca91593930cf30cd13e00ccee2ea194ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783740Reviewed-by:
-
Yutaka Hirano authored
TBR=alph@chromium.org Bug: 1000512 Change-Id: I0d7a4a777c8dd193284308bab5a35e394c947d40 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782189Reviewed-by:
-
Andrew Xu authored
Bug: 918024 Change-Id: I81fa612bb3313da87787cc5cd10463da2b352594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782989 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Hesen Zhang authored
- This CL glues native to Java side for icon data. Bug: 963290 Change-Id: Iba99a50c21b75e8f0a123171cb5362880dc35e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783229 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692959}
-
Henry Jian authored
Previously, we set is_primary_icon_maskable to true if the primary icon has a "maskable" purposes in it. Turns out it's not necessary and makes server code more complex. This CL makes Chrome directly send the image purpose to server (an image may contain multiple purposes, Chrome may not send all purposes, but just one of them). The purpose field existed in webapk.proto since a long time ago, but was reserved because it wasn't being used. This CL un-reserves it Bug: 977173 Change-Id: I6793d836a2f993862c191b1bc301151bdf64a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782015 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692958}
-
Lorne Mitchell authored
The localization system was correctly discovering the modules.json file and added the titles to a .grdp file, but ls() was not being called on the property. The fix was to call ls() on the quick open help provider's title descriptor. Screenshot of the quick open available commands menu (i.e. Ctrl+p+?): https://imgur.com/a/7fIWw8f Bug: 941561 Change-Id: I8c4659a76a0e2b9291aa13aa4014016efaf340d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775755Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#692957}
-
Paul Dyson authored
These metrics count the number of apps that are successfully ranked by Top Cat and the number not able to be ranked by Top Cat. Bug: 991433 Change-Id: Icf05a35552d4648784f90b05bf2b8deb49fef133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772208Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f790aa521cc6..e7c719c3e85f git log f790aa521cc6..e7c719c3e85f --date=short --no-merges --format='%ad %ae %s' 2019-09-03 simonhatch@chromium.org Pinpoint - Display better error on incorrect git hash Created with: gclient setdep -r src/third_party/catapult@e7c719c3e85f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1000302 Change-Id: I58da7a2f77a65e863d7db403c6c670631a8018d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783742Reviewed-by:
-
Toni Barzic authored
When drawing items in the folder icon, folder image first calculated intended position of the item icons, then resizes them and adds a drop shadow. The drop shadow adds some padding the the resulting image, so FolderImage drawing logic offsets the resulting image so the original image stays in the intended bounds. The offset is calculated by subtracting original image size from the shadowed image size. This works for scale factor 1x, but given that the actual shadow margins are not integers, their calculation introduces rounding error that can disappear at other scale factors. In particular example, the shadow margin is 2.5, which gets rounded up to 3. With scale factor, the shadow margin is 5, i.e. has no rounded error. Given that FolderImage draws the icon with offset 3, at scale factor 2 the offset becomes 6, which is 1 more than the actual shadow margin added to the image, and the actual item icon is drawn 1 pixel off. This cl updates the drawing logic to use actual scaled shadow margins when calculating required offset, and draws the shadowed image rep for the target scale factor with the calculated offset to the unscaled canvas. BUG=999775 Change-Id: I1bf2532f7114e3c5993b84c11d8900a49bb23783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779670 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
