GitLab

Review URL: https://chromiumcodereview.appspot.com/13913010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193419 0039d316-1c4b-4281-b951-d872f2087c98

Previous change only affected Notification Center, this one adds popups.

Replacing TYPE_WINDOW_FRAMELESS with TYPE_POPUP seems to be equivalent in the context of notifications. On Windows, it adds a WS_EX_TOOLWINDOW style that removes the window from taskbar and Alt-Tab.

BUG=223685

Review URL: https://chromiumcodereview.appspot.com/13861029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193418 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the ComponentCloudPolicyUpdater class use a
ExternalPolicyDataUpdater as its backend, removing code duplicated between
the two classes and completing the refactor that makes
ExternalPolicyDataUpdater available for other consumers.

BUG=152957, 220418, 225960
TEST=unittests


Review URL: https://chromiumcodereview.appspot.com/13792003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193417 0039d316-1c4b-4281-b951-d872f2087c98

This makes it so if isolate.py is modified, all the foo_tests_run steps are
re-run.

R=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13947028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193415 0039d316-1c4b-4281-b951-d872f2087c98

This patch also deprecate recursive enumeration support in
IsolatedFileUtil as we no longer need it (http://crbug.com/176443)
and adding symlink fix in the dead code doesn't sound productive.

BUG=176443,229849
TEST=IsolatedFileUtilTest.ReadDirectoryTest


Review URL: https://chromiumcodereview.appspot.com/13850004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193413 0039d316-1c4b-4281-b951-d872f2087c98

I was originally put in that file for ease of modification of the
downloads public content API during the downloads refactor.  The
refactor has quieted down, and I'm no longer working on downloads, so 
I'm removing myself to get away from getting other
content/public/browser reviews from people who don't read the note in
the file :-}.


Review URL: https://chromiumcodereview.appspot.com/13912005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193412 0039d316-1c4b-4281-b951-d872f2087c98

If we send the available callback before we've finished loading
the current cached shaders off disk there is a potential race condition
where we do a cache clear while reading. This causes an issue with
the iterators and the cache does not get cleared.

This patch delays the signaling of the available cache until after
we have finished iterating over the cache and loading the old shaders.

BUG=176289


Review URL: https://chromiumcodereview.appspot.com/13730005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193411 0039d316-1c4b-4281-b951-d872f2087c98

In r186079, local invalidations and acknowledgements were fully
implemented. This means that if an InvalidationHandler doesn't
acknowledge invalidations that it receives, it will receive wake up
pings periodically afterwards.

BUG=180693


Review URL: https://chromiumcodereview.appspot.com/13913018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193410 0039d316-1c4b-4281-b951-d872f2087c98

When we update a compositor resource from a media::VideoFrame,
try to reuse resources from previous frames that were returned
to us by the ResourceProvider.

R=piman,enne
BUG=179729
Depends on: https://codereview.chromium.org/13445009/

Review URL: https://chromiumcodereview.appspot.com/13959005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193409 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193408 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r11143: (phosek) Fix version selection in toolchain download script
r11144: (khim) Fix lucid-64-newlib-dbg-valgrind bot.
r11145: (dschuff) Stop running pnacl glibc tests on toolchain bots.
r11146: (jvoung) Turn on -strip-metadata in pnacl-finalize.
r11147: (mseaborn) Thread suspension: Return untrusted register state during context switches
r11148: (phosek) Provide mprotect syscall wrapper in newlib
r11149: (mseaborn) Remove warning that is now too noisy on x86-64 Mac
r11150: (jvoung) Update llvm test-suite rev to build tests with pnacl-finalize.
r11151: (petarj) [MIPS] Small updates after LLVM merge

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/13811023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193407 0039d316-1c4b-4281-b951-d872f2087c98

Update test expectations for OmniboxViewTest.SelectAllOnClick:
(CrOS used to show/retain unfocused (grey highlight) Omnibox selections)
(My http://crrev.com/183239 made it save/restore selections like Windows)
Don't expect unfocused selections; check that clicking anew selects all.

Move the base omnibox click offset over to the right a little.
(fixes the test for OmniboxViewWin's slightly different hit-test area)
Enable previously USE_AURA-limited code on all TOOLKIT_VIEWS.

Update NativeTextfieldViews::OnMouseDragged to only handle left-click.
(it was incorrectly and incompletely handling right- and middle-drag)
Make NativeTextfieldViews::HandleMousePressEvent focus on right-click.
(it was selecting all and showing the context menu without taking focus)

Use ui_test_utils::IsViewFocused() instead of GetFocusView()->HasFocus(); 
Inline the last remaining GetFocusView call; some refactoring.

BUG=128556,139069
TEST=None; OmniboxViewTest.SelectAllOnClick passes.
R=derat@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13896002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193404 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/13534002/ caused the search result snippet to
be misaligned in the history page.

R=dubroy@chromium.org
BUG=228818


Review URL: https://chromiumcodereview.appspot.com/13811015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155363
R=msw@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13991002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193402 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13993007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229840


Review URL: https://chromiumcodereview.appspot.com/14063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193400 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193399 0039d316-1c4b-4281-b951-d872f2087c98

Caused crashes on scrolling_benchmark.

BUG=229923

> Update V8 to version 3.17.16.1
> 
> 
> R=danno@chromium.org
> BUG=
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13820010

TBR=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/14077002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180463
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13689003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193397 0039d316-1c4b-4281-b951-d872f2087c98

This is done with a multiple choice because later we will add another option:
"choose the cache backend at random", and make it the default.

BUG=173390,173381

Review URL: https://chromiumcodereview.appspot.com/13862014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180082
TEST=Open chrome://settings/languages and add Portuguese(Brazil)


Review URL: https://chromiumcodereview.appspot.com/13702003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193395 0039d316-1c4b-4281-b951-d872f2087c98

Reserve 4 new experiment IDs for a refresh of our dev experiments, as the old IDs still haven't converged after the accidental user shuffle.


BUG=


Review URL: https://chromiumcodereview.appspot.com/13863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/13879008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193393 0039d316-1c4b-4281-b951-d872f2087c98

The delegate makes sure that the keyboard window does not get focus,
and that events are not consumed by the container window itself.

BUG=226986

Review URL: https://codereview.chromium.org/13726015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193392 0039d316-1c4b-4281-b951-d872f2087c98

Also make both backends use the same directory for files, and the same name for
the index file. Using the index file each backend will detect if the index
belongs to it. Hence, easier to make sure that both cache trees on disk are
mutually exclusive.

BUG=229437


Review URL: https://chromiumcodereview.appspot.com/13813015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193391 0039d316-1c4b-4281-b951-d872f2087c98

Name the parameters and comment on their meaning. I was adding another
one of these for checksums, and I found it was getting
confusing. These comments should help.

R=rvargas@chromium.org,pasko@chromium.org,felipeg@chromium.org
BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193056

Review URL: https://chromiumcodereview.appspot.com/13757005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193390 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring is underway to notify client of P2P socket that network is
congested. In the mean time pending packet limit is too small and causes
huge amount of packet loss, this makes WebRTC unusable.

This is a temporary fix to increase this pre-defined value to 32 pending
packets which accomodates 720p streams up to 5Mb/s.

BUG=228956, 229737

Review URL: https://codereview.chromium.org/13992004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193389 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows us to have larger objects passed into the trace
framework which, at the point when we output tracing data, will
request they be converted to TraceFormat by calling the
AppendAsTraceFormat method.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13590005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/12722002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193387 0039d316-1c4b-4281-b951-d872f2087c98

Currently we report computed vsync intervals based on if they are in
an expected range and silently drop otherwise. The disadvantage with this
is that we're probably reporting noise caused by configuration changes
(monitor reconfiguration or moving a window between monitors). We may
also be papering over driver bugs.

Instead, we look for consistency between successive computed intervals
as a way of validating that there hasn't been a configuration change. In
this case, we can be more aggressive in error reporting to find driver bugs
(crash instead of silently drop).

BUG=221701


Review URL: https://chromiumcodereview.appspot.com/13861016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193386 0039d316-1c4b-4281-b951-d872f2087c98

GetResourceList is being deprecated along with Drive API v2 migration.
This CL replaces it with new methods Schedule and ContinueGetResourceList.

BUG=160932
TEST=Ran unit_tests and tested manually.


Review URL: https://chromiumcodereview.appspot.com/13913012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193385 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Temporarily disable tile grid optimization
> 
> Tile grid currently introduces clipping problems which causes some parts
> of the canvas to not be rastered to, which causes slivers of odd looking
> content on the screen.
> 
> R=reveman@chromium.org
> BUG=224419
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13581011

TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/13879005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193384 0039d316-1c4b-4281-b951-d872f2087c98

The failure job was based on broken revision.
The root problem is already solved, so this re-enables the test.

BUG=229639
TEST=Ran try bot.


Review URL: https://chromiumcodereview.appspot.com/13907003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193383 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193382 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/13834006/
Review URL: https://codereview.chromium.org/13834007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193381 0039d316-1c4b-4281-b951-d872f2087c98

In this case, the databases was actually corrupted but the database classes did not try to repair.
After this CL lands, these corruption should be repaired correctly.

TEST="content_unittests: FileSystemDirectoryDatabaseTest.TestRepairDatabase_MissingManifest & FileSystemOriginDatabaseTest.DatabaseRecoveryForMissingManifestTest"
BUG=229773

Review URL: https://chromiumcodereview.appspot.com/13946004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193380 0039d316-1c4b-4281-b951-d872f2087c98

Introduces ui/keyboard/ which contains generic code for the control of the keyboard (right now, just creation of the container window).

Also includes the necessary changes to ash so that the keyboard is (always) displayed on ChromeOS builds when the --enable-virtual-keyboard flag is present.

BUG=226986

Review URL: https://codereview.chromium.org/13164002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193378 0039d316-1c4b-4281-b951-d872f2087c98

The actual CLs that contain the corresponding code are here:

https://codereview.chromium.org/13441008/
https://codereview.chromium.org/13619014/

This goes in first so that the code can be validated running try jobs.

BUG=chromium:186445
TEST=None

Review URL: https://codereview.chromium.org/13839026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193375 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell

Review URL: https://codereview.chromium.org/13936004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193374 0039d316-1c4b-4281-b951-d872f2087c98