GitLab

Revert of Use ScaleToEnclosingRect when converting the viewport to window. (patchset #1 id:1 of https://codereview.chromium.org/2258493002/ )

Reason for revert:
This seems to have broken virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html.

Original issue's description:
> Use ScaleToEnclosingRect when converting the viewport to window.
>
> This guarantees that the viewport is always contained in the window.
>
> BUG=none
>
> Committed: https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23
> Cr-Commit-Position: refs/heads/master@{#414452}

TBR=oshima@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2279873002
Cr-Commit-Position: refs/heads/master@{#414469}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b02b5193532977e75ea91ec9d011a6561f43e158 Chromium trybots on linux: kill git fetch after 20 minutes. (tandrii@chromium.org)

R=tandrii@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2279593003
Cr-Commit-Position: refs/heads/master@{#414468}

This file was added as part of https://codereview.chromium.org/2211473003
but looks like it was done so by mistake. Remove it again.

TBR=fdoray@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2276423002
Cr-Commit-Position: refs/heads/master@{#414467}

Behind --enable-experimental-web-platform-features flag.
Not yet hooked up on Android Marshmallow or below, which
use custom layouts for notifications.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discussion

Screenshot: https://imgur.com/a/SM3tq

Depends on https://codereview.chromium.org/2261283002

BUG=614456

Review-Url: https://codereview.chromium.org/2273033002
Cr-Commit-Position: refs/heads/master@{#414466}

Revert of Remove MessageLoop::current() from base::win::ObjectWatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2125763003/ )

Reason for revert:
Breaks Win10 builder. crbug.com/632184

Original issue's description:
> Remove MessageLoop::current() from base::win::ObjectWatcher.
>
> Why? The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads are migrated to
> base/task_scheduler, tasks will no longer have access to a MessageLoop
> but they will be able to get the current ThreadTaskRunnerHandle.
>
> Before this CL, ObjectWatcher implemented
> WillDestroyCurrentMessageLoop() to stop the watch when the
> MessageLoop responsible for running the callback was destroyed.
> This prevented the watch callback from being sent to a destroyed
> MessageLoop.
>
> Now that ObjectWatcher keeps a reference to a TaskRunner, this is
> no longer required. The TaskRunner can't be deleted while there are
> references to it. If the underlying MessageLoop has been deleted
> when the watch callback is posted, the callback will simply not run.
>
> Note that the watch will still be stopped when the ObjectWatcher is
> deleted.
>
> TBR=ben@chromium.org
> BUG=616447
>
> Committed: https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce
> Cr-Commit-Position: refs/heads/master@{#407874}

TBR=grt@chromium.org,ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=616447

Review-Url: https://codereview.chromium.org/2277333002
Cr-Commit-Position: refs/heads/master@{#414465}

https://pdfium.googlesource.com/pdfium.git/+log/cae6bdfff7e4..43cbe9ea0ff1

$ git log cae6bdfff..43cbe9ea0 --date=short --no-merges --format='%ad %ae %s'
2016-08-25 npm Remove unused methods in CPDF_TextPage and nits
2016-08-25 tonikitoo Drop CPDFSDK_PageView::Annot_HasAppearance
2016-08-25 tsepez Tidy up CFX_PathData

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2278793004
Cr-Commit-Position: refs/heads/master@{#414464}

https://codereview.chromium.org/2272713004/ breaks
official builders so this CL ensures the offical build scripts work as
they used to.

BUG=640877
TBR=dpranke@chromium.org, brettw@chromium.org

Review-Url: https://codereview.chromium.org/2278983002
Cr-Commit-Position: refs/heads/master@{#414463}

Add a reference to the chromestatus entry regarding document level
passive event listeners.

BUG=627104

Review-Url: https://codereview.chromium.org/2272993004
Cr-Commit-Position: refs/heads/master@{#414462}

BUG=640857

Review-Url: https://codereview.chromium.org/2282493002
Cr-Commit-Position: refs/heads/master@{#414461}

svg/W3C-SVG-1.1/filters-composite-02-b.svg and svg/custom/use-clipped-hit.svg
are failing on Win10, and the latter may be flaky. But the flaky one is
mostly failing and only occasionally passing, which would be better reversed.
The former test seems to be always failing, so rebase to see if it's really flaky.

TBR=pdr@chromium.org
BUG=636311,632217

Review-Url: https://codereview.chromium.org/2278683002
Cr-Commit-Position: refs/heads/master@{#414460}

This reverts commit b8df2228 due to a link error on the "Android Builder" main waterfall bot.

TBR=yhirano@chromium.org,tsepez@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2279763003
Cr-Commit-Position: refs/heads/master@{#414459}

loadable_modules are quite commonly used in tests and for plugins, yet
it is barely mentioned in GN's docs.

Add it to the cookbook so people porting their projects away from gyp
know that the construct also exists in GN.

R=brettw@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2276943005
Cr-Commit-Position: refs/heads/master@{#414458}

Implements GetInquiryRSSI and GetInquiryTxPower on macOS and Android.

BUG=568135

Review-Url: https://codereview.chromium.org/2248913002
Cr-Commit-Position: refs/heads/master@{#414457}

DidDisconnectPeripheral is not always called with an error, for example
when we've initiated the disconnection. This could cause a crash when
we try to log the error.

BUG=625209

Review-Url: https://codereview.chromium.org/2276213002
Cr-Commit-Position: refs/heads/master@{#414456}

Revert of Support server categories in NTPSnippetsService. (patchset #13 id:240001 of https://codereview.chromium.org/2255783002/ )

Reason for revert:
Following tests failing:
NTPSnippetsServiceTest.GetDismissed
NTPSnippetsServiceTest.LogNumArticlesHistogram
NTPSnippetsServiceTest.DismissShouldRespectAllKnownUrls
NTPSnippetsServiceTest.ImageReturnedWithTheSameId
NTPSnippetsServiceTest.Dismiss

on bots:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/45385
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27331
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/16271

Original issue's description:
> Support server categories in NTPSnippetsService.
>
> BUG=633613
>
> Committed: https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f
> Cr-Commit-Position: refs/heads/master@{#414443}

TBR=treib@chromium.org,tschumann@chromium.org,sfiera@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633613

Review-Url: https://codereview.chromium.org/2277323003
Cr-Commit-Position: refs/heads/master@{#414455}

Revert of On asan/win bots building with goma, don't accidentally emit DWARF (patchset #1 id:1 of https://codereview.chromium.org/2224073003/ )

Reason for revert:
We have now rolled past r278139 and this shouldn't be necessary any more.

Original issue's description:
> On asan/win bots building with goma, don't accidentally emit DWARF
>
> This happens to work around a bug we don't yet understand, but seems
> like a good change in its own right too.
>
> BUG=635715
> R=rnk@chromium.org
>
> Committed: https://crrev.com/314120a8cfd5df331d825566d25db1ba1a1983fe
> Cr-Commit-Position: refs/heads/master@{#410785}

TBR=rnk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635715

Review-Url: https://codereview.chromium.org/2281583002
Cr-Commit-Position: refs/heads/master@{#414454}

BUG=622716

Review-Url: https://codereview.chromium.org/2111673004
Cr-Commit-Position: refs/heads/master@{#414453}

This guarantees that the viewport is always contained in the window.

BUG=none

Review-Url: https://codereview.chromium.org/2258493002
Cr-Commit-Position: refs/heads/master@{#414452}

slectionDirection wrongly returned "none" on non-Mac platforms in such
case. This CL

- makes sure that selection operations are done by setSelectionRange().
- moves direction normalization code from setSelectionRangeForBinding() to
  setSelectionRange().

Also, this makes cacheSelection() private. Only HTMLTextFormControlElement calls
it.

BUG=640861

Review-Url: https://codereview.chromium.org/2277903003
Cr-Commit-Position: refs/heads/master@{#414451}

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none

Review-Url: https://codereview.chromium.org/2278723003
Cr-Commit-Position: refs/heads/master@{#414450}

TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2224713002
Cr-Commit-Position: refs/heads/master@{#414449}

https://pdfium.googlesource.com/pdfium.git/+log/156de02596e9..cae6bdfff7e4

$ git log 156de0259..cae6bdfff --date=short --no-merges --format='%ad %ae %s'
2016-08-25 jaepark Remove unused IPDFSDK_AnnotHandler::GetName().

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2278163002
Cr-Commit-Position: refs/heads/master@{#414448}

Review-Url: https://codereview.chromium.org/2269043003
Cr-Commit-Position: refs/heads/master@{#414447}

The computation of auto repeat tracks was incorrectly recursively triggering
a layout in order to compute the available size. That was happening whenever
the width was indefinite. In such cases we should treat the width always as
indefinite without having to run any extra code. During the layout phase
we'll have the actual width available.

This partially reverts commit 49bc5ba1 which
was a quick fix for a security issue but that was not actually fixing the
real problem behind.

BUG=633474

Review-Url: https://codereview.chromium.org/2263213002
Cr-Commit-Position: refs/heads/master@{#414446}

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
Review-Url: https://codereview.chromium.org/2272703008
Cr-Commit-Position: refs/heads/master@{#414445}

Add a move constructor and move assignment operator to local, global and
weak references to reduce reference churn (saves a small number of bytes).
Allow weak references to be constructed from JavaRef.
Replace NULL with nullptr in jni_weak_ref code.

BUG=

Review-Url: https://codereview.chromium.org/2268553002
Cr-Commit-Position: refs/heads/master@{#414444}

BUG=633613

Review-Url: https://codereview.chromium.org/2255783002
Cr-Commit-Position: refs/heads/master@{#414443}

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2211473003
Cr-Commit-Position: refs/heads/master@{#414442}

Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument (patchset #4 id:60001 of https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fimages%2Fpng-partial-load-as-document.html&testType=webkit_tests

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
>
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
>
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
>
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
>
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
>
> BUG=632495
>
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495

Review-Url: https://codereview.chromium.org/2278953002
Cr-Commit-Position: refs/heads/master@{#414441}

BUG=611672

Review-Url: https://codereview.chromium.org/2269633002
Cr-Commit-Position: refs/heads/master@{#414440}

Adds CodeAndMetadata measurements to the v8_browsing telemetry benchmarks.
Modifes the memory dumper to dump these stats on light dumps, if requested.
Also adds an Ignition variant for v8_browsing benchmarks.

BUG=v8:4280,v8:5019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;

Review-Url: https://codereview.chromium.org/2257173003
Cr-Commit-Position: refs/heads/master@{#414439}

Cleanup: PhotoCapabilities is starting to have too many
parameters, so this CL adds a builder for it.

BUG=518807

Review-Url: https://codereview.chromium.org/2272653004
Cr-Commit-Position: refs/heads/master@{#414438}

BUG=451546

Review-Url: https://codereview.chromium.org/2273103002
Cr-Commit-Position: refs/heads/master@{#414437}

The tests reflect the changes in https://codereview.chromium.org/2264163002

Review-Url: https://codereview.chromium.org/2268073007
Cr-Commit-Position: refs/heads/master@{#414436}

Extend the GPU workaround exception list to enable CMAA on all Broadwell
and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2165553002
Cr-Commit-Position: refs/heads/master@{#414435}

This patch fixes ScriptCustomElementDefinition::createElementSync to
create an element with its ownerDocument set to the given document by
using the construction stack.

Before this fix, V8HTMLElement::constructorCustom assumed it matches to
window.document. The assumption does not stand when custom elements are
created in import documents.

BUG=640465

Review-Url: https://codereview.chromium.org/2274883005
Cr-Commit-Position: refs/heads/master@{#414434}

BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
is flaky on android.

It failed at builds [30767, 30786, 30834, 30835, 30843, 30851, 30868, 30909,
30910, 30919, 30923] of
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests
amongst other failures.

NOTREECHECKS=true
NOTRY=true
BUG=639706
TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2272293003
Cr-Commit-Position: refs/heads/master@{#414433}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..b5763ff333c8

$ git log 06af11370..b5763ff33 --date=short --no-merges --format='%ad %ae %s'
2016-08-25 ulan [Perf Impact] Make frame time discrepancy absolute.
2016-08-25 achuith Error message for guest login.
2016-08-25 ksakamoto Fix metrics_debugger_app after moving MRE to tracing
2016-08-24 aiolos Revert of Update chrome ref builds (patchset #1 id:1 of https://codereview.chromium.org/2264243002/ )
2016-08-24 eakuefner [Results2] Fix results2.html
2016-08-24 aiolos Update the Chrome Stable channel reference builds.
2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected
2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram

BUG=631640,630300

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2275283002
Cr-Commit-Position: refs/heads/master@{#414432}

When generating C++ bindings, ensure all commands have a method which
takes a full parameters object and returns a return value object. This
ensures the API for experimental commands is retained even if that
command is made stable.

BUG=640919

Review-Url: https://codereview.chromium.org/2278123002
Cr-Commit-Position: refs/heads/master@{#414431}

It's been on by default for a long time.

BUG=441916
R=dcheng@chromium.org

Review URL: https://codereview.chromium.org/2267713003 .

Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Original-Commit-Position: refs/heads/master@{#413546}
Cr-Commit-Position: refs/heads/master@{#414430}