- 27 May, 2020 40 commits
-
-
Andrew Xu authored
Re-enable HotseatShelfAppBrowserTest.TappingAppIconsHidesHotseat. Fix one things: In ShelfWidget, contextual nudge related function should not be called when the contextual nudge feature is disabled. Verify this CL with MSAN test. Bug: 1021011 Change-Id: Iff1755001e41e28cfe0490e014502ad711e0b90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207613 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772081}
-
Shakti Sahu authored
This CL fixes 1 - If we get redundant calls to the TileSuggestionProcessor, ignore them and don't update the underlying widget. This will prevent the previous suggestion from flashing up momementarily before new tile set is loaded. 2 - Default ItemAnimator is removed to prevent the jank 3 - Only reload the tile if NTP is reloaded via home button. For regular page load, don't animate query tiles (fixes submit query flow jank) 4 - Fix for international languages - ASCII comparison is not enough for non-english languages. string16 is used for comparison purposes, which fixes the omnibox flow for query tiles (Bug 1086672) Bug : 1086672, 1081557 Change-Id: I8536759fb3f7a9c9c00ddb56f5c12f40df26a114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211661 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#772080}
-
Jonah Chin authored
Using RasterInterface's CopySubTexture() proved costly. Reverting to replaceBackendTexture in non OOP-R mode to regain lost perf. OOP-R mode will continue to use RasterInterface for copy-on-write. Bug: 1082399, 1082403 Change-Id: I80e1b285e4d7c4336a706d1e5f006afd676f0b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216591Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772079}
-
Rouslan Solomakhin authored
Before this patch, the C++ payment_app.h interface exposed a gfx::ImageSkia type icon, which is difficult to pass to Java. This patch changes payment_app.h interface from gfx::ImageSkia to SkBitmap. After this patch, the C++ payment_app.h interface exposes an SkBitmap type icon, which is easier to pass to Java. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I506bec37b1bb298452e1ebe51cc4bd1731d8d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212495 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772078}
-
Asanka Herath authored
The hash function originally picked was SuperFastHash(), but we are running into a few limitations. Justification for the new function is explained in identifiability_metrics.cc. Bug: 973801 Change-Id: I6743d72c5b18dc86cf9fe3d4a8d98ef49fbcd7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213403Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#772077}
-
Jiewei Qian authored
This CL makes `default-src 'self';` the default Content Security Policy for chrome-untrusted:// URLDataSource. This stops chrome-untrusted:// from using resources from a different origin, unless CSP explicitly allows them. To prevent breakage of existing chrome-untrusted:// WebUIs, we override their default-src to an empty value, and create bug tracker issues for relevant teams to update their CSP. This is a preparation for enabling Fetch API for chrome-untrusted:// scheme. Bug: 1023741 Change-Id: I2e5cfe3877c1e996a678e04aacd378f044332bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208588 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#772076}
-
Erik Anderson authored
The enums.xml had grown stale due to multiple net errors getting added without also running update_net_error_codes.py. Change-Id: I176da2ddb72567e0c15b46e11392f9140b03c6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216703 Commit-Queue: Erik Anderson <Erik.Anderson@microsoft.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Erik Anderson <Erik.Anderson@microsoft.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772075}
-
Xida Chen authored
Bug: None Change-Id: Iab10726bf0aa4e4aa13803dbec856a0d52142bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198683Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772074}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24f3a385a38c..0c7d654c7474 2020-05-27 iannucci@chromium.org [bb] Update bb tool to contain latest protos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181,chromium:1086729 Tbr: agable@chromium.org Change-Id: I9dbb2ac1121a2d68b43edb4ab03fc7301d6beaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772073}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590508570-0988b56e609cb55046e696ff8ca55766d5b1565c.profdata to chrome-win32-master-1590537495-1aec0e09840eb111f0a85749393637fa50872c10.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieaa1041592710b382eefed1221a8a151c27dfb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217075Reviewed-by:
-
Ben Joyce authored
Switched robolectric to be located in android_deps. Local modifications are handled by creating a local_robolectric_jar, and then having the target depend on that, local_robolectric_jar while using a jar_exclude_patterns to remove the original class (to avoid a duplicate class issue.) See design doc: https://docs.google.com/document/d/1fTW40HEoqKvVyuOTWqwhJDK8OL0zX0AHpN-oZ7Wi2GM/edit?usp=sharing After this lands and doesn't cause any breakages, will remove the unnecessary robolectric jars in third_'party/robolectric. Bug: 1060721 Change-Id: I7ec486177795ac1b0bf8fad6a52e63b815a61dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186743 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#772071}
-
Karandeep Bhatia authored
Do this by introducing a new entry to the LoadRulesetResult enum which is logged to metrics. Also, since the enum is now not solely bound to the RulesetMatcher::CreateVerifiedMatcher result, move it outside the RulesetMatcher scope and change it to be an enum class. Also introduce a version of GetBucketCount to HistogramTester which supports enum classes. BUG=754526 Change-Id: Ib3a626d4f43581a0e875f3c9b66cc6704b77f550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205116 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#772070}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/934b9996ee4d..64391c4a55c7 2020-05-26 herb@google.com Reland "generate vertex data in onPrepare" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I6a48a492950ccef2792e3c0b00a7a12d09e9aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214996Reviewed-by:
-
Regan Hsu authored
Add missing "Google Drive Search Suggestion" ("Chrome [browser] will access your drive to make search suggestions in the address bar") toggle to "Sync and Google Services". SplitSettingsSync must be disabled and "Omnibox Google drive document suggestions" flag must be enabled to see this change. When both flags are set to default, there is no visible impact. https://screenshot.googleplex.com/NPiR2gTUVKT Bug: 1083029 Change-Id: Idbfcb7bb3f287fbcc5ffa8a333f39c2aef9cdc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213931 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772068}
-
Katie D authored
Bug: 1047957 Change-Id: Ied78b3132b920698f7e5178c72e1583627f10b49 AX-Relnotes: Fixes crash when dragging STS box and doing a mousewheel. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216376Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772067}
-
Shakti Sahu authored
This CL tries to fix the multiline text for query tiles. It also tries to make the tile wider so that longer text can fit in. Bug: 1085110 Change-Id: I4de898920435ed96fe3c2811db1e6b8544cefbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210663 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772066}
-
Dominic Farolino authored
Bug: N/A Change-Id: I60d6097499d49c178d0da83197bb2316a2240e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215257Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#772065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be61a7c024b6..aef138255c4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039904,chromium:1083349 Tbr: mpearson@google.com Change-Id: I9bfe0c5001ba69ab37c4f45e43c114c4b4982d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216762Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772064}
-
nancylingwang@google.com authored
Ash(ShelfController) should observe AppRegistryCache to get the app notification badging information. Ash can't depend on chrome/*, so move AppRegistryCache to components directory to split AppRegistryCache from chrome. BUG=1068884 Change-Id: I215d02203a25f61a0b1dcb9a1a92d69768b4bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210208Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d4647dffe2f..a5e07cc3db44 2020-05-26 tommi@webrtc.org Rename more death test to *DeathTest 2020-05-26 handellm@webrtc.org AsyncResolver: remove dependency on SignalThread. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8e869fb068956b083336956da9edadc9a125c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214997Reviewed-by:
-
Nidhi Jaju authored
ServiceWorkerDatabase for a OOM crash investigation Bug: 848194 Change-Id: Ie6f08af06575c024fe4f81e5725f3235b286d086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215652Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772061}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of an extensions/ test that didn't expect a change of RenderFrameHosts etc. on same-site navigations. This CL does not include fixes for other tests in chrome/ content/, components/, and layout tests (they're fixed in other CLs) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I8b1d61ab107b6cead501fee669f90aeca6c7a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212224 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Eric Willigers authored
The flag MediaSessionSeeking has been stable since 2019-08. Bug: 977375 Change-Id: I626de5ee229586f729681825e74d3d57e8c3b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209938Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772059}
-
Chong Gu authored
These tests will add a total of ~6 minutes to bot time and run time per builder run. Bug: 1086742 Change-Id: I29e42d62dc92569f86e941e1417cab6bd3a991a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217011Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#772058}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3393ea589ec..a03bec408ff6 2020-05-26 sadrul@chromium.org [tests] Re-enable some scroll-related unit-tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:934649 Tbr: eseckler@google.com Change-Id: I17f18f967db52a9a0e6a0f93d44881e8b65bcee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214998Reviewed-by:
-
En-Shuo Hsu authored
Add UMA to log the return event from a socket connecting to the Bluetooth device through SCO. This will be used to monitor how frequent the underlying SCO connection setups fail and if our fixes address the issue. The CL on CRAS side: http://crrev.com/c/2198851 BUG=b:2198851 TEST=Deploy adhd and chrome on DUT and verify the event is recorded at chrome: //histogram/Cras Change-Id: I84a817bb01b033e7250c1f5d9e7c4915d5d95851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208793Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772056}
-
Gabriel Charette authored
Note to QA: This CL is purely mechanical and shouldn't be blamed for future regressions on touched files. Only migrate explicit usage of content::BrowserThread in step #1 as these are the only ones that clearly map to a fully qualified call to content::Get(UI|IO)ThreadTaskRunner(). Script @ https://crbug.com/1026641#c91 Will make BrowserTaskTraits optional when empty in a follow-up (can't before end of migration because of cyclic dependency between browser_thread.h and browser_task_traits.h). (will TBR fdoray@ post-review for mechanical change) TBR=fdoray@chromium.org AX-Relnotes: n/a. Bug: 1026641 Change-Id: I27615773472c97d9bfd981c8c9e783c26525b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211138Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772055}
-
Victor Hugo Vianna Silva authored
This CL introduces a new frontendId field to chrome.passwordsPrivate types for passwords and exceptions. This field will be used to group existing duplicates across stores in future CLs. Bug: 1049141 Change-Id: Ib856778e0a06043e44d2d624d4440c38a3358527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210462Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#772054}
-
Xianzhu Wang authored
Extracted from pdr@'s https://chromium-review.googlesource.com/c/chromium/src/+/2209993/3. For testing non-composited-scrolling without depending on volatile composited-scrolling trigger rules based on style. Change-Id: I173e517da6539ca42336704c0a20942ef1c1e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213323 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772053}
-
Eric Willigers authored
The flag IntersectionObserverV2 has been stable since 2019-01. Bug: 827639 Change-Id: I31e4e6b5a0cdae99a0a3c56d504a99216cc653b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208802Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772052}
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I1ce62770cc27561d577a1508a87d677fad9da043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210350 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772051}
-
Anastasia Helfinstein authored
In an effort to better share test infrastructure, the first step is to move the currently shared files into a shared directory. AX-Relnotes: n/a. Bug: 1078119 Change-Id: I68240eea961dd6ca733cca483332dbd6caaa230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772050}
-
Nate Chapin authored
Bug: 1086668 Test: images/enable-images-then-detach-crash.html Change-Id: Id685d3fe1283efa2d3695a81c4154031f860b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216792 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772049}
-
Andres Pico authored
In the past, we've checked for the presence of the kNoSandbox switch when initializing sandbox_info, and if a child process was unsandboxed we would avoid initializing sandbox_info at all. However, the kNoSandbox switch is only meant to be used as a browser level flag for testing purposes only. There exist other ways to denote an unsandboxed process too, as in the case of the unsandboxed utility process which uses the switch service-sandbox-type=none instead of --no-sandbox. Similarly, there's also an unsandboxed GPU process which makes use of the --disable-gpu-sandbox switch instead of the --no-sandbox switch. This has resulted in having unsandboxed processes initializing their sandbox_info as if they were brokers, and as a consequence, having the same process mitigations applied to them. This last behavior is certainly an unintended side-effect that could manifest as a bug eventually. In this CL, we're updating the way in which we check whether a process is unsandboxed to ensure that no unsandboxed processes have their sandbox_info initialized as brokers, and to prevent applying the same process mitigations accidentally. Bug: 1066258 Change-Id: Ifdc14b0e29f9505edeec93417bd9cc7ab73e94c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208189 Auto-Submit: Andres Pico <anpico@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772048}
-
Anastasia Helfinstein authored
This is the (hopefully) penultimate change in the process of changing to a views-based menu for Switch Access, as part of implementing the visual specification. This change rewrites the menu manager to use the new menu, rather than the old menu. A clean-up change (to remove code for the old menu) will follow this. AX-Relnotes: n/a Bug: 973719 Change-Id: I596d47a8f976a531e545bc56555f9f8da80efbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176611 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Pete Williamson authored
As part of a three sided change, remove the old version of the API now that it is no longer in use. Bug: 1080884 Change-Id: If344fbbedadad6c5c807baad3443a3811860cdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199981Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#772046}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates the print dialog navigation test that previously didn't expect a change of RenderFrameHosts etc. on same-site navigations - we're now changing the test to do a same document navigation (which is what GMail is doing). For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: Ifeb972f92f86d45385545f84d27d53784d7abe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212287 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#772045}
-
Yue Li authored
Check the enrollment status before calling stop enrollment call. Also restore a JS method that was removed accidentally recently. Bug: 1084388, b/157268233 Test: Manual Test Change-Id: I86826951ee2185ca0b1635278ef5b2a84358ac35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213241Reviewed-by:
-
Greg Thompson authored
When loading a .pak file, allow other entities on the machine to open the file for deleting but not for writing. This is closer to the way an executable is mapped into memory for process creation. With any luck, this will reduce startup crashes resulting from an inability to map in the locale's pak file. This change also adds DataPack.Load to the Chromium metrics description files (it has historically been in the Google internal one). BUG=1076423 R=asvitkine@chromium.org Change-Id: I3039922d0edab047e48cf03699f93bcb2c2f0673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215241 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Add a WebEngineRenderFrameObserver object whose lifespan is bound to the RenderFrame. This class owns other objects whose lifespand is also bound to the RenderFrame and that need to be accessed through WebEngineRenderContentClient. * This is a preliminary refactor to add more objects to this class, particularly for the Cast Streaming Receiver. Bug: 1042501 Change-Id: I1b8ba1de47be717e1ce28a3fcd40ebccb7a2f4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209752 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772042}
-
