- 10 Jan, 2020 40 commits
-
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the PartnerBrowserCustomizationsUnitTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: I61fe3e37bbf4986b93e1a47d9ee348f19e97372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991736 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#730249}
-
Eric Karl authored
Adds tracking to detect this issue earlier and CHECK with a more informative error message. Also fixes one known case of incorrect destruction order. Bug: 1040275 Change-Id: Id611b56a605b738bd1088940460a5a62182bfefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993671 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730248}
-
Zentaro Kavanagh authored
- This disables the feature by default - Updates tests based on changed feature state - Fixes a race condition checking the sensor status via powerd - Support for ambient EQ is now going to be gated on a cros config value because some devices have the sensor but can't support the feature - The cros config value will enable the feature only on explicitly supported devices - This is a partial revert of [1] which can't be cleanly reverted because the pref value on unsupported devices may have already been set [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1974815 BUG=1034068,1036038,1036546 TEST=NightLightTest.*,manual Change-Id: If51ec1b6a8ae787fb64b89f2f536eec0087b09af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992183Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#730247}
-
Elly Fong-Jones authored
It seems that either r728531 (disable shadows altogether on bots) or r726087 (disable frame-resize shadow invalidation hack on bots) have sufficiently mitigated the windowserver crash everywhere except 10.10. Since browser_tests are disabled altogether on 10.10 as of r726124, we can stop filtering browser_tests suites. Bug: 899286 Change-Id: I55b7a5e76ff095c6c3d1abeba17e6056a9fe510b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994421Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#730246}
-
Tommy Li authored
Currently, for elided HTTPS URLs, (omnibox displays 'google.com' instead of 'https://www.google.com'), when the user mouse clicks into the omnibox and presses Enter, we make a request to http://google.com. This is a regression introduced in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1854501 This CL is a partial revert of that CL. I think the reverted part wasn't necessary to fix the original bug in the first place, and was likely included by mistake. This CL does the partial revert and also enhances our existing unit test to make sure it won't happen again. Bug: 1037889 Change-Id: Ia5e742c02ac35f7b013ce42bc01c1217304ab303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990253 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730245}
-
Sadrul Habib Chowdhury authored
It is possible for a WebContents to be destroyed while it is being activated in response to a mouse-click. Handle such case gracefully. BUG=1040725 Change-Id: Ic73e631bf04e170bc8b1cd818da8d39f1963e006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994394 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#730244}
-
kylechar authored
SkBitmap allocations were using allocPixels() which will crash on OOM. In order to indicate the crash is due to OOM use tryAllocPixels() and then call base::TerminateBecauseOutOfMemory() on failure. This will improve crash reports. If SkBitmap allocation fails for a CopyOutputRequest we can handle the OOM gracefully, since the caller has to be able to handle failed requests regardless. Bug: 995411 Change-Id: Ifad190badca49c948e5ae612dd33df39ef5923f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993667Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#730243}
-
Kouhei Ueno authored
Bug: None Change-Id: I789f71a6ce8154d63b1feb61ebf46b43415c48ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986651 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730242}
-
Clark DuVall authored
This reverts commit 6b59fe72. Reason for revert: Crash has been fixed. Original change's description: > Add crash keys to debug WebRequest request ID collision > > This should help figuring out where the duplicate IDs are coming from. > > Bug: 996940 > Change-Id: I3e3611e83ed563cf883729f307bbe2b66ac6b74d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977186 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728258} TBR=thestig@chromium.org,karandeepb@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 996940 Change-Id: Iac7064d7c080cc078dbbfb9c1c249175f924c310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994303Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#730241}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 546640 Change-Id: I6d29caeda4e1b42e6e9fc71e71106ff30a0cd063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991714 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730240}
-
Gary Kacmarcik authored
Change-Id: I453e48c84bba191a63f524d81a3817c3c4f5a961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994673 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#730239}
-
Elly Fong-Jones authored
This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the 10.15 SDK. Bug: 1023913 Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#725141} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723 Cr-Commit-Position: refs/heads/master@{#730238}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13928b7e7f1a..fc132e61dbe4 git log 13928b7e7f1a..fc132e61dbe4 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 jmadill@chromium.org git-cl: Fix format --dry-run not working with --full. Created with: gclient setdep -r src/third_party/depot_tools@fc132e61dbe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6d0d22d3d0cadd1257fc2dc88180de01f7c9ec78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730237}
-
Demetrios Papadopoulos authored
Also move corresponding tests to os_settings_browsertest.js. This UI is already available on the OS Settings, and does not need to be shown in the browser settings. Bug: 986596 Change-Id: Ia8043cd0a97e4142e62766a5576b4f232fc6cdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992818 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#730236}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/920683437e19..d11cba30bb52 git log 920683437e19..d11cba30bb52 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 fmayer@google.com Merge "Store cumulative size in heap_graph_allocation." 2020-01-10 primiano@google.com Merge "tools/heap_profile: fix SHA1 of mac prebuilt" 2020-01-10 lalitm@google.com Merge "trace_processor: make gpu slice table a true child of slice table" Created with: gclient setdep -r src/third_party/perfetto@d11cba30bb52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idadd42720ae846f535a22acc20628debb3a2674a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730235}
-
Dominic Battre authored
Bug: 1037578,1037190,1037577 Change-Id: Id0ce80ce4e97049e2c63275c66b6401a7fadd958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989078 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#730234}
-
Jeroen Dhollander authored
This crash is hard to reproduce, but what happened was: - User sent a query ('volume up'). The response for this is rendered. - User sent another query (click in suggestion chip). This means we start fading out the response of the first query. - The response of the new query arrives before the fade-out is complete,so the response is postponed until the fade out is complete. - Now close the Assistant UI. Due to the bug, the previous response was not cleared but it remained queued. - Open the UI again, and send another query ('volume down'). - This fades out the initial text. If that completes before the new response arrives, the previous queued response was animated in. - When this animate in completed, the ui_element_container_view tried to access the current response, which is a nullptr and caused a crash. Note that this is not the crash described in the bug report. However I failed to reproduce that crash, and because it is a related area I am hoping that both have the same root cause. This will need to be monitored to ensure the bug is actually fixed. complexity involved I abandoned the effort. Bug: b:145136105 Change-Id: Ia512eb370c2b9f8ab506575f2252dc520471793a Tests: Manually tested. I tried adding unittests but given the Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993114 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#730233}
-
Nick Burris authored
Fixes the field trial config as required for cl/285264679 Bug: 978139 Change-Id: Iade5a7f945d8363ca274a0f61cfe34e5a0bb0e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993942 Auto-Submit: Nick Burris <nburris@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#730232}
-
Reilly Grant authored
They report that they are no longer on the Chrome team. Change-Id: Ib08b05ac2770420f5d0347bfd13c876c925fd94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994276 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#730231}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f1bd1b88a31..ccb2c9dc1358 Created with: gclient setdep -r src-internal@ccb2c9dc1358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: I836d030061fdc85d4ef6c5fdd81c69031b7c4ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730230}
-
Carlos IL authored
This CL adds safe browsing committed interstitials to fieldtrial_testing_config.json (for non webview platforms) in preparation for launch to beta. Bug: 755632, 1039367, 1039443 Change-Id: Id80302b653f3bc7359e2015184922ae5c7373481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988511Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730229}
-
Omer Katz authored
Adding an Allocator template parameter to ListHashSetNodeBasePointer so that atomic writes/reads are only used when the collection is garbage collection. This is an optimization to reduce performance regressions (see Bug). Bug: 1040437 Change-Id: I76f69614071bb023b2879c600533cffd0f60a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995175Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730228}
-
Robert Phillips authored
These should be working again with: https://skia-review.googlesource.com/c/skia/+/263558 (Move GrVkFormatColorTypePairIsValid assert back into GrVkGpu::check_image_info) TBR=kbr@chromium.org Bug: 1037949 Change-Id: I739ef867cf1ef12086eb52a1f3666d602840474f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989138Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#730227}
-
Vladimir Levin authored
This patch relocks elements that have scrolled far enough off-screen when viewport activatability is present. Note that this affects only the CSS version of render-subtree. This depends on both of the following patches: https://chromium-review.googlesource.com/c/chromium/src/+/1993433 https://chromium-review.googlesource.com/c/chromium/src/+/1993389 R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I09beb63ccde16b6abd592891fb75367e321577d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993620Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730226}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaacb72383ba..2ef3661d276c git log eaacb72383ba..2ef3661d276c --date=short --first-parent --format='%ad %ae %s' 2020-01-10 tvanderlippe@chromium.org Migrate mobile_throttling/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate heap_snapshot_model/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate console_counters/ to ESM internally 2020-01-10 sigurds@chromium.org [coverage] Refactor backlogging in the CoverageModel Created with: gclient setdep -r src/third_party/devtools-frontend/src@2ef3661d276c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1022031 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0aaefb5dff89b86e171195ce1c46921e1e219192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730225}
-
Marc Treib authored
When a subscription request failed, PerUserTopicSubscriptionManager used to call BackoffEntry::InformOfRequest(false) twice, i.e. it'd back off more than expected. This CL fixes that and adds a test for proper backoff. Bug: 1020117 Change-Id: I248f3fc3a1e44b9e6f542b9c45d7fc1b187a9345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991426Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#730224}
-
Francois Doray authored
The histogram has not been used for a long time. Current data from the histogram is available at: https://docs.google.com/document/d/18uYnVwLly7C_ckGsDbqdNs-AgAAt3AmUmn7wYLkyBN0/edit?usp=sharing Bug: 1037312 Change-Id: Icde8c827a4ef3eaac9de1d95f09c2f0e8a8c412b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988825 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#730223}
-
Alexander Timin authored
Mojo messages are already covered by toplevel.flow. Move legacy IPC there as well to centralise tracing for all async work in a single place. R=skyostil@chromium.org,rockot@google.com Change-Id: Iba3d3a25bbb8bb05a8a7e5617312415e15126371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985970Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#730222}
-
Sasha McIntosh authored
This flag shoulld already be enabled for virtual web tests, since crrev.com/c/1798523 Additionally disable JPEG YUV decoding for non-yuv gpu rasterization tests. Bug: 1037798 Change-Id: I80c8ea7eb54478b54f14145f18fb1b90023db395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982628Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730221}
-
Luca Hunkeler authored
Bug: 1034952, 1022108 Change-Id: Ie9515b495f541f632b94d24553a16abc6ab6c58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993812 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#730220}
-
Eric Robinson authored
This parameter will be used when the backend changes its underlying key representation, making previous keys invalid. Rather than retaining all the old keys in the cache, an empty cache is created in its place. Right now this is primarily used for many of our Finch experiments. This CL detects and stores this state in prefs and then passes the appropriate reset parameter to the cache. Change-Id: Ifd466dc902e6368df8122223ed34272e2e9db848 Bug: 1002220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918392 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#730219}
-
Reilly Grant authored
This change implements support for filtering serial ports based on a USB vendor and product ID. The naming of the filter properties comes from the Serial API polyfill library where I felt it was important to be specific that this filter will only apply to USB devices and so also implies that the device being requested by the page will be a USB device. This is useful for applications which are targeting a particular model of serial device that is known to be connected over USB and advertises a recognizable vendor ID/product ID pair. Bug: 884928 Change-Id: Ie6a2674911c449ed48d58ea82175fe03bc14c572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994262Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#730218}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2076b04d153f..504032e57526 git log 2076b04d153f..504032e57526 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 brianosman@google.com SkRuntimeEffect: Fix 'in' variables in CPU backend 2020-01-10 nifong@google.com Add vis of android device clip restriction, fix regular clip vis on gpu 2020-01-10 jlavrova@google.com Ellipsis attached to cluster, not word 2020-01-10 reed@google.com Revert "new virtuals for canvas ctm" Created with: gclient setdep -r src/third_party/skia@504032e57526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I0e998c35838db7f9739c1bed8feb63fb8038af5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730217}
-
Joe Mason authored
Reland "Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled" This is a reland of 2dd4658f with a fixed unit test. The original was using CHECK_DEATH to test a code path that called DCHECK. Original change's description: > Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled > > R=fdoray > > Bug: 947576 > Change-Id: I1f901367e6fcc5243f34f50e5704b68727a40731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990135 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729802} R=fdoray Bug: 947576 Change-Id: If83301ccc260f5ca6911c7ee787eb7719ef2c064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993842Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#730216}
-
Xianzhu Wang authored
We have been correctly ignoring occlusion from outside of the subtree of a pixel-moving filter in the stack of OcclusionTracker (which leads to correct occlusion inside of the subtree), but when we get the occlusion of a render surface, previously we returned the current occlusion of the parent render surface even if the current render surface has pixel-moving filter, causing the render surface incorrectly occluded. Now add a flag in the stack indicating that the render surface doesn't inherit parent occlusion, and OcclusionTracker::GetCurrentOcclusionForContributingSurface() should not return the parent occlusion when the flag is set. Bug: 1040288 Change-Id: I505b079d62186a404b1be1c83c6cbccc89c10b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994102Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#730215}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I919bee18e72049473723bbbf42783e4213dee7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730214}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a19e6092..d2cad713 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I94a9189f5f5559c5d0bdfbfcf5fbee0872103a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730213}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Iadffe6c5d4a91ad5fde9cc481aaf9048e132d217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992912 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#730212}
-
Raymond Toy authored
Update the histograms to expire after 2021-01-06, 6 mo after the current expiration; these were set to expire after M81. These histograms still contain useful information on how people use WebAudio. Bug: 1037364, 1037365, 1037366, 1037367, 1037368, 1037369, 1037370, 1037371 Change-Id: I83d7254187d5ec2c60d00513fb54561f83ad60fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993432 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730211}
-
Nicolás Peña Moreno authored
LargestContentfulPaint (aggregating both image and text) is the one we will be using, so we remove the image/text versions from UKM. Change-Id: I0bcca50da7ffb3338ec4f73bf89a9179f4c2b51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988594 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#730210}
-