- 28 Aug, 2020 40 commits
-
-
yiyix authored
In OffscreenCanvasRenderingContext::DrawTextInternal(), |paint_canvas| can be freed in the draw command in BaseRenderingContext. We then use the |paint_canvas| causes the security bug that we are using a resource after it's freed. Looking at how |paint_canvas| is used in the method DrawTextInternal(), restore a cleared |paint_canvas| is not really necessary. So I removed it's only restored if the canvas is not cleared (i.e. canvas is not freed). Bug: 1111737 Change-Id: I699b855434f7ddfbc678d2a9cfe25fe4938a798a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358574 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#802508}
-
Will Harris authored
This CL disables: BookmarkBarViewTest10.KeyEvents BookmarkBarViewTest23.ContextMenusKeyboard BookmarkBarViewTest24.ContextMenusKeyboardEscape TouchEventsRecursiveViewTest.CheckWindowsRecursiveHandler TouchEventsViewTest.CheckWindowsNativeMessageForTouchEvents This is because the ui_controls::SendTouchEvents used in these tests has proven flaky on latest versions of Windows. BUG=1108551,523255 Change-Id: Ia1baa719a4baa2dc29b78ebcac7d3a71070c0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380811Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#802507}
-
Findit authored
This reverts commit aefd23ef. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 802479 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FlZmQyM2VmMTYxZTBmYWRmYjQ5M2U1MDZjZDEyNzA0NzY4MWYxMzcM Sample Failed Build: https://ci.chromium.org/b/8870760402429459936 Sample Failed Step: compile Original change's description: > [mojo] Better import header includes > > There are two problems addressed here: > > - Forward headers were unnecessarily including extra (i.e. traits) > public headers; but fixing that revealed a second problem: > - The logic to decide whether a transitive import requires a full > header or only a forward header was incorrect. > > So this fixes the logic which decides whether to import with a full > header or forward header, and it removes the inclusion of public traits > headers from forward headers. > > Also fixes tons of IWYU and forward declaration deficiencies > revealed by these changes. > > Fixed: 1111156 > Change-Id: I181b62c605581a1f303f07257471277d178e9e06 > Tbr: tsepez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375889 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Auto-Submit: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#802479} Change-Id: Ib3230cd9c950be0307fd7844c108da6d511d7d03 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381032 Cr-Commit-Position: refs/heads/master@{#802506}
-
Zhuoyu Qian authored
As the comment left in inline_box_traversal.h|cc by xiaochengh, rename the files to bidi_adjustment.h|cc. Change-Id: I66e2205588b078509858409002849db1b4312ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1312177Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#802505}
-
Adam Langley authored
I broke caBLEv1 twice (because I can't test it) with 99900ffc: having any caBLEv2 pairings saved would cause a crash (this is very rare) and, more importantly, the client and authenticator EID got mixed up so all the handshakes would fail. Bug: b/166334693 Change-Id: Idecb57cd44a14b9a689b7f67263e7b59bf2f88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378139 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#802504}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9ede33deef5..f27dc62ae63d 2020-08-28 landrey@webrtc.org Create token for 50% of webrtc requests 2020-08-27 jleconte@google.com RunWebRtcTest: Use execution_timeout_secs property instead of the class member. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246,chromium:1114061 Tbr: oysteine@google.com Change-Id: Ibe5ada2c600f538805f326438083ca1b26c8d4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802503}
-
Timothy Loh authored
We currently use the 32px icon for the shelf, which ends up looking blurry, so switch to the 192px icon. Bug: b:162516302 Change-Id: I96dbd62a287e70dc0d20ab0872c640b3ecf2bc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379463 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#802502}
-
Justin DeWitt authored
These were temporarily disabled to allow a multi-sided merge. Tbr: bialpio@chromium.org Bug: 1113301 Change-Id: I1d9ef778868e89547ef42117cfb804304558890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376028Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#802501}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e068e1dbb62..a1d05e35a865 2020-08-27 bsheedy@chromium.org Workaround GN bug 2020-08-27 jonahr@google.com Fix badly formatted dEQP test expectation 2020-08-27 courtneygo@google.com Revert "Vulkan: restore mContentDefined at endRP()" 2020-08-27 ianelliott@google.com Vulkan: Fix whitebox test to end render pass 2020-08-27 tobine@google.com Vulkan:Clean up best practices exceptions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122621 Tbr: courtneygo@google.com Change-Id: Ife3937cadf7a4765313027ab9ec0507da4c98524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380879Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/df4b3fe83ab2..701020f385de 2020-08-27 jalyn@microsoft.com Sources: Restore breakpoints on formatted code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:930334 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a28a78a2035b910155ad25d4e0da9d2ec5439de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380838Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I8de391c577d2371a8ffdbc97344f2ff04f29f1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381057Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802498}
-
Dylan Sleeper authored
This is a reland of 81bbe1e6. ChromeOS did not compile because three files: clipboard_history_resource_manager.cc , clipboard_history_item_view.cc, and clipboard_history_item_builder.cc all contain switch statements that do not check the SVG format. In this reland, the SVG format is added to the three files. Original change's description: > Browser Clipboard: Implements read and write SVG on the browser side > > Implements the SVG format for the clipboard on all blink platforms. The > implementation is very similar to HTML and plain text. Initially we will > put this feature behind a flag before it is exposed to the Web Platform. > > Design Doc: https://docs.google.com/document/d/1jq8QSCQRdNy99rnPusmW8is62c22PVuq-Sk-tMT2tRk/edit# > > Bug: 1110511 > Change-Id: I6d405a9704c431a31995bb50a17dfc309b49b74b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313961 > Reviewed-by: Jarryd Goodman <jarrydg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800774} TBR=dcheng@chromium.org Bug: 1110511 Change-Id: I0b88c161e155eccd4d71a0c432401017c4ec6238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373018 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802497}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed2e4739280f..33a6332a9232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iab413996e60b5c50116bda6738283e117846212c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381090Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/autofill/core/browser This CL was uploaded by git cl split. R=parastoog@google.com Bug: 1110266 Change-Id: Ie4d572b106e4dbf0a93dc26ecc113dce8a3f776e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371285 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#802495}
-
sauski authored
Bug: 1110888 Change-Id: I98f68943de1abd226016d04083ac351de3fe1bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379673Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#802494}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed2e4739280f..33a6332a9232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c2f4cbcc24e848981865d714a43ff0cb0f9a8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380958Reviewed-by:
-
Daniel Cheng authored
An HTTP status code of 204/205 indicates that no document should actually be committed. Since this should all be handled by PlzNavigate on the browser side, CHECK-fail if this somehow reaches the renderer. Content-Disposition: attachment has the same behavior, so also CHECK-fail if this somehow reaches the renderer. Bug: 1117282 Change-Id: I83a04f4a68963da0ffebede327380365e6f9852e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380604Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802492}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/webrtc This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 1110266 Change-Id: I6e48d5cc5ddc73cc16f90975b8467e9ea7d42b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371291Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#802491}
-
Yuki Yamada authored
This is a follow up for https://crrev.com/c/2134039 which removes a HashArg param of LinkedHashSet in stub. Bug: 1100257 Change-Id: Ib43fd54fa553b7228f97c128598e385020feeaf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377533Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802490}
-
David Munro authored
Bug: None Test: None Change-Id: If32ba431a5404b80cd5cf58f03b6b57906254f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379452 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#802489}
-
Xinghui Lu authored
The SafeBrowsingProtectionLevel policy is supported on desktop platforms since M83. We should support this policy on Android as well. Bug: 1111457 Change-Id: I822dc410a7951fb11f9e17df718f2f1246bba3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380739 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802488}
-
Josh Nohle authored
Ensure that the local device has 3 valid private certificates for each visibility mode. Perform this check when the expiration scheduler informs the certificate manager that a private certificate has expired. When private certificates change, notify observers and upload the local device certificates (converted to public certificates) to the Nearby Share server. Bug: b/166112705 Change-Id: I367ed1df0ca3b4c5eb044795539f05ba24b5311f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377506 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#802487}
-
Yulun Wu authored
Opacity calculation has also been extracted into a helper function. Bug: 1110757 Change-Id: Ib383b33a330b3471d1034126330fc0963f737597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378890Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802486}
-
Brandon Wylie authored
This CL will enforce DEPS restrictions for any class trying to depend on ChromeActivity. Valid dependencies should add their own DEPS file to the relevant directory. Other cases should seek other means of dependency acquisition. Bug: 1055811 Change-Id: Iba5e0514743c3f887cdf645106cca2d747b524cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349413 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#802485}
-
Orin Jaworski authored
As more errors are found in localization data, it made sense to expand the unit test to cover at least one trigger for each pedal in each language. This enhanced test revealed yet another failure mode in the source data, and this CL includes correction. Bug: 893183 Change-Id: I5f13ce99affd4fe4ec39e90c947e759aacab27c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380325 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802484}
-
Xianzhu Wang authored
This CL (temporarily) explicitly enable CompositingOptimizations for web tests. This is to separate the change of web test expectations from crrev.com/c/2375886 which will enable the feature for web tests by adjusting the application order of blink feature status and chromium feature status. Bug: 1121839 Change-Id: I55ef951dd6a18731b33cf18496551cd9c993162e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380213 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802483}
-
Arthur Wang authored
R=hypan@google.com, liaoyuke@google.com Bug: 1096656 Change-Id: Ibce2ea98386e70601caaf9ddf8b56b17130931a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377551Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802482}
-
Austin Tankiang authored
Bug: 1007662 Change-Id: Ic5fd080c23e8e09bfc0450998c2fe8d9524aa53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375006Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#802481}
-
Avi Drissman authored
The Mac version of the Shape Detection code goes through a lot of trouble to weak-link the API it uses, in a way that it could be built with macOS SDKs before the 10.13 SDK. Given that Chromium requires the 10.15 SDK, do cleanup. Bug: 1122152 Change-Id: I5598db83ba2eddce4a23ab472f66428e198253b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378750 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802480}
-
Ken Rockot authored
There are two problems addressed here: - Forward headers were unnecessarily including extra (i.e. traits) public headers; but fixing that revealed a second problem: - The logic to decide whether a transitive import requires a full header or only a forward header was incorrect. So this fixes the logic which decides whether to import with a full header or forward header, and it removes the inclusion of public traits headers from forward headers. Also fixes tons of IWYU and forward declaration deficiencies revealed by these changes. Fixed: 1111156 Change-Id: I181b62c605581a1f303f07257471277d178e9e06 Tbr: tsepez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375889Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#802479}
-
Luciano Pacheco authored
Tests that Files app can open image in Backlight in normal and guest modes. Add a new test suite for Files app that installs the SWAs. Add a new test message to check if a SWA has started. Bug: 1122379, 1121553 Change-Id: I38313691e71e2d825ae605ecc5b4525e35c499fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377765Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#802478}
-
Jesse McKenna authored
Change-Id: I77c4c3431de10e702d9e1e522ce202cb519ba936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380953Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802477}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/716e281185b5..952f088d41e1 2020-08-27 bsalomon@google.com Experiment to see if ANGLE ES2 vs ES3 perf is related to GLSL ver If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I2e9e46c31eeb8efe9ebec1c7ba114cfb83d946fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380883Reviewed-by:
-
Angela Yoeurng authored
Bug: 1117639 Change-Id: I86a92c006ec77ad174bbad3bb78c1e867135c122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380493 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802475}
-
Xiaoqian Dai authored
We'll not have them in M88. Bug: 1115153 Change-Id: Ia7d9e59343a1e7eb0131c3e18cda76ddeeb95f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380581Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#802474}
-
David Grogan authored
Give real bug numbers to some tests. Move some lines around. Change-Id: I9996504335cbb8aa39f3af702e0c6da391bb7dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378755 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802473}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/be71f6d9f008..f9ede33deef5 2020-08-27 jleconte@google.com Fix crbug.com link and layout on group report page. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: oysteine@google.com Change-Id: I03b6888457692a7cde4c6b33535c7b56fb9ccfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380878Reviewed-by:
-
Taylor Bergquist authored
Bug: 1116929 Change-Id: I4a000adf69fd1fb8715db4718f7333bc2ab15b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369266Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#802471}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecf0d2c0f651..cba56d2d3c09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com,sclittle@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093354,chromium:1098447,chromium:1105693,chromium:1115073,chromium:1115361,chromium:1117143,chromium:1119885,chromium:1122685 Tbr: melzhang@google.com,sclittle@google.com Change-Id: Ia1d588461041ca3a987cc213dcad29872ae32199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380875Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802470}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aac228ce1bbf..df4b3fe83ab2 2020-08-27 jalyn@microsoft.com Sources: Use Ctrl+W to close active tab on mac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110877 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5c25b8a28073203b95ba986567040db7bf491409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380209Reviewed-by:
-
