GitLab

Control with use_openssl, not with per-platform special-cases.

BUG=416683

Review URL: https://codereview.chromium.org/569683003

Cr-Commit-Position: refs/heads/master@{#297211}

- kEmptyPakContents was malformed; fix it
- chrome.pak was deleted half a year ago for iOS Chrome; don't try to load it

BUG=410411
TEST=no visible change

Review URL: https://codereview.chromium.org/611103002

Cr-Commit-Position: refs/heads/master@{#297210}

FrameBuffer::GetStatus() was spending most of the time doing in printf,
I've modified it to generate signatures using a binary representation
instead. Now most of the time is spent allocating memory. If further
optimization is necessary we can precalculate the signature size
as well.

BUG= https://code.google.com/p/chromium/issues/detail?id=338035
TEST= profile FrameBuffer::GetStatus()

Review URL: https://codereview.chromium.org/593233002

Cr-Commit-Position: refs/heads/master@{#297209}

Remove loss detection from QuicConfig now that connection options has
replaced it.

Merge internal change: 75952172

Chromium specific changes:
+ Deleted enable_quic_time_based_loss_detection from
  NetworkSession params.
+ Deleted enable-quic-time-based-loss-detection and
  disable-quic-time-based-loss-detection command line
  switches.

https://codereview.chromium.org/591323003/

Do not timeout QUIC connections when settings the timeouts from
InitializeSession(). Protected by FLAG_quic_timeouts_only_from_alarms

Removes FLAG_quic_timeouts_require_activity which was somewhat broken.

Merge internal change: 75927669
https://codereview.chromium.org/605903002/

Factor out the QUIC timeout alarm setting logic from the CheckForTimeout
method into a new SetTimeout method.

- no behavior change, simply moving QUIC timeout alarm code.

Merge internal change: 75915264
https://codereview.chromium.org/593193005/

Add a timestamp field to QUIC's CachedNetworkParams proto message.

Context in b/17357338, follow-up CL will store CachedNetworkParams and
copy into newly created STKs.

Merge internal change: 75897792
https://codereview.chromium.org/604173002/

Call QuicSentPacketManager's OnPacketSent method and make
OnRetransmittedPacket and OnSerializedPacket private.

Merge internal change: 75830237
https://codereview.chromium.org/593193004/

Change the return type of QuicConnection::CheckForTimeout from bool to
void since it is unused.

Merge internal change: 75724127
https://codereview.chromium.org/604163002/

Test-only.  Remove calls to OnSerializedPacket from
QuicSentPacketManagerTest, in preparation for OnSerializedPacket to be
removed.

Merge internal change: 75716236
https://codereview.chromium.org/600823006/

R=rch@chromium.org, sky@chromium.org

Added sky@ for OWNERS approval for chrome/browser and chrome/common
changes

Review URL: https://codereview.chromium.org/605733006

Cr-Commit-Position: refs/heads/master@{#297208}

BUG=

Review URL: https://codereview.chromium.org/603273003

Cr-Commit-Position: refs/heads/master@{#297207}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4ceb039..47c548a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/613773002

Cr-Commit-Position: refs/heads/master@{#297206}

BUG=417528
TEST=bots

Review URL: https://codereview.chromium.org/604423006

Cr-Commit-Position: refs/heads/master@{#297205}

Record the number of loaded profiles when a profile is erased from the profiles map kept by profile manager.

The reason behind is, UMA is observing a significant amount of times when GetLoadedProfiles returns an empty list (multiple times during one session). We hope that recording such a histogram would help to find out the reason for it, or at least eliminate one possibility.

BUG=412794

Review URL: https://codereview.chromium.org/605333002

Cr-Commit-Position: refs/heads/master@{#297204}

BUG=

Review URL: https://codereview.chromium.org/612753005

Cr-Commit-Position: refs/heads/master@{#297203}

We want the invalidations code to exist as a component
independent of sync (see bug). This CL seeks to move toward
that for the Android invalidations codebase.

Generally, things moved from //chrome/browser/invalidation
to //components/invalidation, even if git didn't mark them
as moves.

To accomplish this, I had to unify where the JNI occurred.
In Java, InvalidationService was renamed to
InvalidationClientService as the class that communicates
with GCM.

A new InvalidationService class was introduced to handle JNI
and other Java entry points to the component. Several
methods from ProfileSyncService and InvalidationController
moved to it.

InvalidationController is now the bridge between sync and
the invalidation component, and has no JNI nor C++
counterpart.

InvalidationServiceFactory was added to assist in the
creation and management of InvalidationService objects
across the JNI boundary.

BUG=259559

Review URL: https://codereview.chromium.org/459513002

Cr-Commit-Position: refs/heads/master@{#297202}

This rolls to a version of our mesa library that does not have the
CL, GLES2, EGL or VG headers.  We should never use CL/VG headers, we
should always use GLES2 and EGL headers from khronos.

Review URL: https://codereview.chromium.org/612523002

Cr-Commit-Position: refs/heads/master@{#297201}

Unset LDFLAGS before building. Otherwise we override the default LDFLAGS in the
makefile, breaking the build. We want to append our flags to the default flags
instead.

BUG=418175
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/611083003

Cr-Commit-Position: refs/heads/master@{#297200}

This fixes a DCHECK failure on chrome://print, where no handler was
registered to handle chrome.send("dialogClose").

BUG=416783

Review URL: https://codereview.chromium.org/614683002

Cr-Commit-Position: refs/heads/master@{#297199}

If the fling update is close to the final state, then stop the fling. The
threshold for this used to be 1e-5f, but change it to 1e-1f, since there
won't be any visual changes for subsequent fling-update steps.

BUG=none
R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/606093002

Cr-Commit-Position: refs/heads/master@{#297198}

It is a proprietary extension of the Web Manifest.

BUG=414873

Review URL: https://codereview.chromium.org/580513002

Cr-Commit-Position: refs/heads/master@{#297197}

Also, remove pepper_31 (the current oldest SDK) such
that the total number of SDKs we publish stays constant.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/615573002

Cr-Commit-Position: refs/heads/master@{#297196}

Issue like 121085 or 320427 could be caused by writing request on busy sockets.

BUG=121085

Review URL: https://codereview.chromium.org/603783002

Cr-Commit-Position: refs/heads/master@{#297195}

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/612113002

Cr-Commit-Position: refs/heads/master@{#297194}

While writing the unit tests I have found problems and fixed them. Since I am not sure when the unit tests will land however (they come with the new Athena Browser test framework) I created this patch to get a workable version for Sadrul's Overview mode work.

BUG=408837
TEST=tests are in different CL which introduces Browser Tests for Athena

Review URL: https://codereview.chromium.org/611773002

Cr-Commit-Position: refs/heads/master@{#297193}

Revert of Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #1 id:1 of https://codereview.chromium.org/609033002/)

Reason for revert:
scoped_ptr nullptr support was un-reverted.

Original issue's description:
> Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #2 id:20001 of https://codereview.chromium.org/610083002/)
>
> Reason for revert:
> scoped_ptr nullptr support was reverted.
>
> Original issue's description:
> > Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}.
> >
> > R=jamesr@chromium.org
> >
> > Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052
> > Cr-Commit-Position: refs/heads/master@{#297095}
>
> TBR=jamesr@chromium.org,viettrungluu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/3f8f6ea2347da4437dfd56b567c7daddfb9d8940
> Cr-Commit-Position: refs/heads/master@{#297108}

TBR=jamesr@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/613673004

Cr-Commit-Position: refs/heads/master@{#297192}

Revert of Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/593313006/)

Reason for revert:
scoped_ptr nullptr support was un-reverted.

Original issue's description:
> Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/606143003/)
>
> Reason for revert:
> scoped_ptr nullptr support was reverted.
>
> Original issue's description:
> > Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder.
> >
> > R=jamesr@chromium.org
> >
> > Committed: https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71
> > Cr-Commit-Position: refs/heads/master@{#297093}
>
> TBR=jamesr@chromium.org,viettrungluu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/76577a68922585f5621db8c63ba2ab6d5aa03f69
> Cr-Commit-Position: refs/heads/master@{#297109}

TBR=jamesr@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/612923002

Cr-Commit-Position: refs/heads/master@{#297191}

* Making sure GCMAccountTracker is only depenedent on the GCMDriver
* Replacing GCMDesktopDriver.SetAccountsForCheckin with
  virtual GCMDesktop.SetAccountTokens
* Producing a vector of AccountTokenInfo in GCMAccountTracker

BUG=374969
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/594383003

Cr-Commit-Position: refs/heads/master@{#297190}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c06d9a7..4ceb039

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/611003003

Cr-Commit-Position: refs/heads/master@{#297189}

When a volume is unmounted, while it was selected, then the list model is
updated, and since there is no selection anymore, the current entry from the
directory model is selected. However, the corresponding VolumeInfo is gone
so we can't call resolveRootEntry().

This patch adds a check. If the volume is gone, then the selection is aborted.

TEST=Tested manually with FSP.
BUG=418513

Review URL: https://codereview.chromium.org/595903003

Cr-Commit-Position: refs/heads/master@{#297188}

And replaces with a callback. Also renames SetBounds to SetSize.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/607233002

Cr-Commit-Position: refs/heads/master@{#297187}

NOTRY=true
BUG=418600

Review URL: https://codereview.chromium.org/613693003

Cr-Commit-Position: refs/heads/master@{#297186}

According to specs hr tag should have xml role as separator.

BUG=384723

Review URL: https://codereview.chromium.org/610973002

Cr-Commit-Position: refs/heads/master@{#297185}

In order for CrOS Core services to speak Mojo, the mojo_shell will need to be able to accept incoming connections from externally-managed processes.

POR is to have the shell listen on a unix domain socket and convert incoming connections to a proper Mojo MessagePipe and then wire it to an InterfaceImpl<ExternalApplicationRegistrar>, which will make the appropriate calls on ApplicationManager.

BUG=418289
TEST=mojo_external_application_tests
STATUS=Fixed

Review URL: https://codereview.chromium.org/522443003

Cr-Commit-Position: refs/heads/master@{#297184}

On Debug ChromeOS bot, this takes 5 minutes.

BUG=414808
TBR=sky

Review URL: https://codereview.chromium.org/612673002

Cr-Commit-Position: refs/heads/master@{#297183}

Adding this handler will make authoring tests which exercise cross-site navigations much easier. This is harder in the current codebase, because testserver runs on a random port each time it is ran which requires boilerplate code in each test that needs it. Instead of computing the real URL in C++ code, just navigate using "/cross-site/hostname/path/and/more" and the server will redirect to the new host.
This requires browser tests to map all hosts to localhost, which is done by adding 'host_resolver()->AddRule("*", "127.0.0.1");' to the beginning of the test.

BUG=418236

Review URL: https://codereview.chromium.org/612533002

Cr-Commit-Position: refs/heads/master@{#297182}

This patch removes low quality mode for low resolution tiles. It also
cleansup some logic with tile versions, since there's only one now.

As a follow-up we can see if we should move the tile version stuff
onto tile directly, although I kind of prefer having a separate class
just for managing what mode we're drawing.

BUG=417876
R=enne, reveman, danakj

Review URL: https://codereview.chromium.org/603683006

Cr-Commit-Position: refs/heads/master@{#297181}

BUG=392145
TBR=benm

Review URL: https://codereview.chromium.org/459953002

Cr-Commit-Position: refs/heads/master@{#297180}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c13bc57..c06d9a7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/612883002

Cr-Commit-Position: refs/heads/master@{#297179}

Quick Report reports they have fixed the issue and the dll now works
correctly with chromium.

BUG=382561

Review URL: https://codereview.chromium.org/617453002

Cr-Commit-Position: refs/heads/master@{#297178}

One (1!) line fix to remove Valgrind issue. Original review https://codereview.chromium.org/543753002/

Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.

BUG=387751
TBR=blundell
TEST=ImageManagerTest,ImageFetcherBrowserTest

Review URL: https://codereview.chromium.org/607183002

Cr-Commit-Position: refs/heads/master@{#297177}

Fix issue with method with empty response.
Fix issue with local variable shadowing user parameters.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/607933002

Cr-Commit-Position: refs/heads/master@{#297176}

Mojom targets containing files referencing imported entities need to
depend on targets containing the imported .mojom files. This patch fixes
existing omissions.

BUG=417289

Review URL: https://codereview.chromium.org/611023002

Cr-Commit-Position: refs/heads/master@{#297175}

BUG=418258
TBR=pfeldman

Review URL: https://codereview.chromium.org/615533002

Cr-Commit-Position: refs/heads/master@{#297174}

This gets Put() closer to the cache spec.

Downstream of: https://codereview.chromium.org/606843002/

BUG=392621

Review URL: https://codereview.chromium.org/608593003

Cr-Commit-Position: refs/heads/master@{#297173}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/607413004

Cr-Commit-Position: refs/heads/master@{#297172}