- 25 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ba6346fe507c..47bbd64428c2 git log ba6346fe507c..47bbd64428c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 mikenichols@chromium.org OWNERS: Add Ned as a CI owner Created with: gclient setdep -r src/third_party/chromite@47bbd64428c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8d3aaa15c9d01389c46402e0b7ea943ef4c8208d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709532}
-
Ulan Degenbaev authored
This reverts commit 023e6975. Reason for revert: The underlying Chrome bug was fixed. See the linked bug. Original change's description: > Disable a flaky perf test > > Disable flaky system_health.memory_desktop/browse:news:hackernews:2018 > on desktop perf bots. > > TBR=crouleau@chromium.org > NOTRY=true > > Bug: 1008028 > Change-Id: I15b7f313a9c409c1b7a107c4a1f22f5f057d9570 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826995 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700309} TBR=crouleau@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008028 Change-Id: Iff1b183c08092f6727fc884186f082063619a892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849891Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709531}
-
Matt Menke authored
Also make it modifiable at runtime. GroupPolicy effectively doesn't support system policies on ChromeOS, nor does it have much support for static policies. Also move the feature over to services/network, so it can be enabled on all NetworkContexts when set. The Chrome-side logic to enable/disable based on policy+field trials will only be per Profile, and not all NetworkContexts are associated with a profile. Also, this will allow the field trial to work on AndroidWebView, too. Bug: 993806 Change-Id: Ie09575b5f83a3cb454dd358bd8e3b7e6b7e4cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876798 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709530}
-
Ben Mason authored
Bug: 1010749 Change-Id: Iec84f253224384fb4e94906109c520a120042a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880703Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#709529}
-
Xiaohui Chen authored
Bug: None Test: locally build and run Change-Id: I843f45f2056e5fb8b61ccf5f27e6ff8f25595c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876795 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709528}
-
Yutaka Hirano authored
Current the following requests have ResourceLoadPriority::kVeryLow. - beacon - a ping - csp report This CL introduces a flag. When it's enabled those requests will have ResourceLoadPriority::kLow. Bug: 1018081 Change-Id: I68d5df324739999aaebfee6a1d7fa9c065c93013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880897Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e663c7caf23c..88d9a552a4b7 git log e663c7caf23c..88d9a552a4b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 lalitm@google.com Merge "trace_processor: migrate callsite table to new macro tables" 2019-10-25 lalitm@google.com Merge "trace_processor: enforce ordering by ts on counters table" 2019-10-25 fmayer@google.com Merge "Mention Perfetto UI in heapprofd docs." 2019-10-25 treehugger-gerrit@google.com Merge "Fix parsing of HTML files" Created with: gclient setdep -r src/third_party/perfetto@88d9a552a4b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I9d0edc5caeff37222943a96ce7c094fdd1dae6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880458Reviewed-by:
-
Natalie Chouinard authored
Add generic getString and setString methods to PrefServiceBridge, making use of the prefs.h enums. Migrate Contextual Search related pref methods to use the generic methods, and move the wrapper functions to ContextualSearchManager. Bug: 1016957 Change-Id: I0da10f579f4021885929f99e16f6a949c1c5af9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879954 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#709525}
-
Toni Barzic authored
Adds a new overview enter/exit type that fades in/out overview items (without slide animation). They're intended to be used to transition from home (where all windows are minimized) to overview and from overview to home - similar to slide in and out transitions, but does not animate item widgets transform to slide them in position. Instead the items are immediately positioned in the target bounds, and just faded in or out. Also, updates timing of when item header visibility is set and blur animation starts (as waiting for starting animations to end before doing this looks a bit janky). Bug: 1005366 Change-Id: Ib364b1950ac3138b6b25f8dfebbc7b19ac6f0625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875518 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#709524}
-
Himanshu Jaju authored
Issue - If a user has two instances of Chrome, one being M78- and the other being M79+, we show the local device in list of device candidates in M79 instance. This is because the deduplication logic is based on the new device naming which is based on hardware info which is available only on M79+ devices. Fix - Add PersonalizableDeviceName to list of names used for deduplication. Bug: 1018159 Change-Id: Ie34b0ad0c1b99a745b088211480b419674b45f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879914Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709523}
-
Andrew Grieve authored
We never added support to the test infra for having "additional_apks" be incremental apks. Change-Id: I51ec92db0eeb807fcd8daad3760bb309d50cba8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881309 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#709522}
-
Gauthier Ambard authored
OmniboxWidth and OmniboxWidthBetween are moved to the egtest.mm file directly to avoid having a more complicated interface. Suggestions() uses are replaced by -addNumberOfSuggestions: additionalSuggestionsURL:. Bug: 987646 Change-Id: I58535b52919fbd1d907c8a72c611e2fbb7f63f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871888 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709521}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/38f98ead10af..59c3eac20665 git log 38f98ead10af..59c3eac20665 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 bsheedy@chromium.org Fix newer system VrCore removal Created with: gclient setdep -r src/third_party/catapult@59c3eac20665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: Id71915e85320f8d8008da8943b958e96a5876f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880456Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16cec3be2c96..67ac9e8ecb89 git log 16cec3be2c96..67ac9e8ecb89 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 sprang@webrtc.org Prepares RTPSender for extracting RtpSenderEgress 2019-10-25 saza@webrtc.org Make rtc_json poisonous in WebRTC 2019-10-25 terelius@webrtc.org Fix MemoryLogWriter so that it always writes the full data. 2019-10-25 ivoc@webrtc.org Introduce injectable NetEqController interface. Created with: gclient setdep -r src/third_party/webrtc@67ac9e8ecb89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:895814 Change-Id: I73150892148ac28c445598d6701b634b8fbd892d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880457Reviewed-by:
-
Andrew Grieve authored
Static analysis will have already run on non-official bots, so these checks don't need to be run again on official bots. Both steps are a bit slow, so they are meaningful to disable. Change-Id: I8d56c0046f88c0746e1e8129721e49b0325419f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880157Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709518}
-
Sammie Quon authored
This was because the label was previous parented to AlwaysOnTop container. This was fine before when there was no scrolling, but now with scrolling, the label should be parented to the same container as the regular windows, so that it snapped window can be stacked ontop of it as well. Test: added test, manual Bug: 1017882 Change-Id: I8b3d2d50f814e1b1c631372478d6ddd16bcc5608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880177Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/008243fd..2ab3f107 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4700096e2b16a7ac5c705da5b4376aea40efc3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709516}
-
Natalie Chouinard authored
Add a generic getInteger method to PrefServiceBridge, making use of the prefs.h enums. Migrate usages of the Prompt for Download pref to use the generic methods, and move wrapper function with feature-specific type annotations to DownloadUtils. Bug: 1016957 Change-Id: I46f9f33f14467aa628767f722c099a39b813dee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879552Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Justin Cohen authored
Change-Id: Ibf2479334f25f993c8b683144d766ccd07291714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860520Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709514}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/b38e63550203..91ae3918387e $ git log b38e63550..91ae39183 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 fkastenholz Remove empty if statement 2019-10-24 rch gfe-relnote: n/a - Rephrase obsolete TODO which was left over from when v40 was added. 2019-10-24 rch Remove an obsolete TODO from quic_framer.cc about changing the public packet header format for post v32 versions. This todo was adding in the fallout from the PAN drama. But I think it's not worth the risk of touching the header format again so let's just leave it alone and it'll be moot once v43 is removed. 2019-10-24 rch gfe-relnote: n/a - Remove useless DVLOG from quic_crypto_server_config.cc 2019-10-24 renjietang Fix Reset logic in PendingStream. 2019-10-24 fayang gfe-relnote: Add QuicPacketCreator::SerializeCoalescedPacket function. Not used yet. Not protected. 2019-10-24 wub Fix 26 ClangTidy - Readability findings in //depot/google3/third_party/quic/. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I83cb08ce6451c90222ed40536fd29fa9a60d8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879198 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#709513}
-
Willie Koomson authored
This change adjusts the call to ArcAppLaunchThrottleObserver::OnLaunchedOrRequestExpired so that it always runs in the current thread. This prevents crashes resulting from SetArcCpuRestriction being called on different thread. and build/flash/run. Ensure no crashes when a launch request expires. Bug: 1017211 Test: Test launch request expiration by setting kAppLaunchTimeout to 0 Change-Id: I2430471aa5d69344a879a2c312764d810a03aa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879332Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Auto-Submit: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#709512}
-
Ulan Degenbaev authored
Bug: 953371 Change-Id: Ib274517dc70df08c84e6d12d1a87cf329b678a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789227Reviewed-by:
-
Sorin Jianu authored
This CL takes the Google Update/Omaha UI (https://github.com/google/omaha/tree/master/omaha/ui) and rewrites to work for this updater. Several original data structures are kept mostly as they were. The code will need to be further cleaned up as several edge cases and related TODOs are going to be addressed. The purpose of this CL includes: * bringing in most of the UI that is going to be necessary to have for a drop in replacement of Google Update/Omaha * figure out what update_client features are needed * understanding the threading and message loop issues * understanding some of the i18n issues * understanding dependencies, including WTL dependencies. Bug: 1017307 Change-Id: I10a7a103cdad86c049a08b3546df404a6d2e01b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876874Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709510}
-
Vladimir Levin authored
This patch keep track of whether the logical bounding box of an object was empty in fragmentainer iterator. If it was, then it is likely to be placed in the first column (since typically empty rects are 0,0 0x0). The first column doesn't have the top edge clip so we might end up painting contents outside of the container (see testcase). By using the portion rect, we ensure that the fragment clip we put in place is bounded on all sides. R=pdr@chromium.org, wangxianzhu@chromium.org Bug: 1017599 Change-Id: I436802f7410124ab2251bfff13ce7dcff49b335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879564 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709509}
-
Philip Rogers authored
This patch makes pdr and wangxianzhu owners of the blink paint tests. Benchmark owner list: go/chrome-benchmarks How to update benchmark owners: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark/benchmark_ownership.md Change-Id: I38a588ade93d2a3181691df920d7ba168a218717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879149 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709508}
-
Adam Kallai authored
Observed that sometimes a VS2017 and a VS2019 directory are present, but the VS2019 directory is empty (probably because VS2019 was installed then uninstalled). In this case we should not identify VS2019 as a valid installation. Bug: None Change-Id: I517cf3debc430e949529d06cd5cb281477d5281a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871990Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709507}
-
Ramin Halavati authored
To unused feature_list_ variable (remaining from former clean ups) are removed. Change-Id: Id2213500f45bfd1a2907516281a4962ce3f15f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881152Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709506}
-
Aran Gilman authored
Bug: 952034, 1016608 Change-Id: I45335ca96f0c33b4b553663ba796aced1f216767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863851Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#709505}
-
Miyoung Shin authored
This CL converts AudioInputStreamObserverPtr and Binding<T> in content to the new Mojo type. Bug: 955171 Change-Id: I8dae882be3afbe37ed2a4ff25e6c876b42ac2b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866749 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709504}
-
Elly Fong-Jones authored
Instead, use SetExtraView. The create method is renamed to avoid conflict with the deprecated parent method it used to override, but left as a method on the clsas because it sets up some of the class's internal state. The tests for this class were calling CreateExtraView manually, which is not allowed by the contract of DialogDelegate::CreateExtraView, but happened to work on this class. This change therefore introduces an accessor DialogDelegate::GetExtraView() that pulls the extra view out of the DialogClientView and uses that in these tests to access the existing extra view. Bug: 1011446 Change-Id: I8ad2f3d20d94b461d78b02f3b2a671b2a15a6a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876789 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709503}
-
nancy authored
In CL:1847698, the ShowInSearchChecking is removed because the recommendable Internal/Built-in apps should be involved in the search result. However, it causes the issue that more apps are list in search result for the guest user. Actually, only the two suggested apps should be search out for the recommend searching result, other apps, if should not shown in search, should still be filled out. So the ShowInSearch checking is added back and add !IsSuggestionChip(update.AppId()) checking. BUG=1017631 Change-Id: I1397e11ba5b8162e0d2986705b990fb054855c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880493Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709502}
-
Toni Barzic authored
We should not have to call AppListView::SetState with the current state in ParentWindowBoundsChanged if the app list window bounds remained the same. This avoids unnecessary work when display metrics change without affecting app list window bounds (e.g. when work area is changed due to a change in shelf height). Change-Id: Ic9555d95ae4479a8310ecbe7a9ba6431d60c2503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880450Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#709501}
-
David Dorwin authored
Also, move time zone-related code to a single location and ensure it is called by all InitializeICU* paths. Change-Id: Ibd3f129a098e9610ed8fb5152d84e7de200b246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869231Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709500}
-
Maks Orlovich authored
We are going to be asking cookies accessible in 3rd party contexts to be secure. Bug: 1006816 Change-Id: Ibdbd145e52b5ee03acbe730ffd1814c9236c71bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863634 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709499}
-
Livvie Lin authored
Replaces kInsecure with kInsecureBroken so that styling for non-secure connections can later be downgraded from kNeutral to kInsecure. This is a follow-up to crrev.com/c/1874787 (protocol change) and crrev.com/c/1880092 (frontend change). Bug: 1008218 Change-Id: Iacfb79b94c1c7622749e95cd204d598b6e3c81b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879498Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709498}
-
Stepan Khapugin authored
Introduces a temporary interface connecting the Scene and the Main controllers, and exposes a bunch of internals of MainController through a MainControllerGuts protocol (obviously temporary). Uses this interface to implement ApplicationCommands in SceneController and updates the use of the commands endpoint to be SceneController. Note also: - Updates a bunch of ivar use in MainController to properties. - Moves a Deferred Initialization constant to a shared file as it's used in both SceneCtrl and MainCtrl. It seems like this is semantically correct for it to be used in both places, so it probably is a permanent change. - Removes a DCHECK(_localStatePrefObserverBridge) in showSettingsFromViewController, as keeping it would mean exposing MainController->_localStatePrefObserverBridge to SceneController. Bug: None Change-Id: Idd45bc0850eaabca068e59e3843d901c9a0c780b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845976 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709497}
-
Lukasz Anforowicz authored
This CL removes |uses_post| from OpenURLParams and NavigateParams and replaces reads of that field with checks if |post_body| is non-null. Similarily, |uses_post| is removed from FrameHostMsg_OpenURL_Params. FWIW, |uses_post| and |browser_initiated_post_data| were introduced together in https://chromiumcodereview.appspot.com/21378002/. I don't understand why two fields (rather than one) were used (one hypothesis is that for renderer-initiated navigations only |uses_post| was preserved while dropping |post_data|). |browser_initiated_post_data| was renamed to |post_data| (and support for renderer-side POST navigations was added) in https://codereview.chromium.org/2038233002/. Bug: 1007041 Change-Id: I6d0bbfc683d2e2e9d3de425d7895e6ef0c2f84b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873156 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709496}
-
Imranur Rahman authored
MediaSessionAction sets are guaranteed to be small. So we are using base::flat_set instead of std::set for MediaSessionAction sets. Bug: 1003847 Signed-off-by:
Imranur Rahman <i.rahman@samsung.com> Change-Id: I2672cd26443c62940da2c168e4563a341ea74158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824723 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Kevin Bailey authored
This CL removes a structure that was missed while removing the respective flag. No behavior change is possible since it's not referenced. Change-Id: I3e735126d1d1439b10b00049a1a01bfcd8656f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879203Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709494}
-
Xiaoqian Dai authored
Hotseat is placed differently in overview and out overview, thus can cause jumping when overview is opened behind the dragged window. Make sure it's not jumping during dragging. Bug: 997885 Change-Id: Idc9d96cda431b6a1a3a0e039a918bcfb2f493776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879823Reviewed-by:
-
