GitLab

There are actually two changes here:
. Convert HTMLViewerApplication to use an ApplicationImpl rather than
  be an Application.
. Make HTMLDocument use services from the application it was created
  for rather than HTMLViewer's application.

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1165013005

Cr-Commit-Position: refs/heads/master@{#333050}

Previously OverscrollWindowDelegate sometimes would call OnOverscrollModeChange on its delegate even if the overscroll mode didn't change. Specifically this happened for OVERSCROLL_NONE when an overscroll-cancelling condition such as a mouse move would occur.

This could confuse OverscrollWindowAnimation and make it cancel the overscroll animation which shouldn't have been cancelled. On Windows there is currently a mouse event dispatched after each swipe on the touch screen, so this caused crbug.com/493672.

BUG=493672

Review URL: https://codereview.chromium.org/1167013002

Cr-Commit-Position: refs/heads/master@{#333049}

TEST=FocusControllerApiTest.DuplicateActivationEvents
TEST=FocusControllerApiTest.ActivationEvents
TEST=FocusControllerMouseEventTest.DuplicateActivationEvents
TEST=FocusControllerMouseEventTest.ActivationEvents
TEST=FocusControllerGestureEventTest.DuplicateActivationEvents
TEST=FocusControllerGestureEventTest.ActivationEvents
TEST=FocusControllerHideTest.ActivationEvents
TEST=FocusControllerDestructionTest.ActivationEvents
TEST=FocusControllerRemovalTest.ActivationEvents

BUG=489813, 489814

Review URL: https://codereview.chromium.org/1151133003

Cr-Commit-Position: refs/heads/master@{#333048}

This reverts commit 5d18b249.

Reason: Broke iOS build: http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/27843

NOTRY=true
NOTREECHECKS=true
BUG=465354
TBR=sievers@chromium.org,nick@chromium.org

Review URL: https://codereview.chromium.org/1153503009

Cr-Commit-Position: refs/heads/master@{#333047}

Several bots occasionally fail commands immediately following calls to
DeviceUtils.EnableRoot with "device not found" errors. I think this may
be because adb wait-for-device can come back before the device is
completely available. Switching to WaitUntilFullyBooted should ensure
that the device has returned to a usable state (or is actually gone).

BUG=493900

Review URL: https://codereview.chromium.org/1167903006

Cr-Commit-Position: refs/heads/master@{#333046}

As |GaiaAuthFetcher::CreateAndStartGaiaFetcher| can already be
specialized by a subclass, |GaiaAuthFetcher::CancelRequest| should as
well, to allow specialized fetchers to be cancelled.

BUG=495597

Review URL: https://codereview.chromium.org/1153293004

Cr-Commit-Position: refs/heads/master@{#333045}

The results of this test will improve dramatically when
crbug.com/317007 is fixed.

BUG=317007

Review URL: https://codereview.chromium.org/1157093002

Cr-Commit-Position: refs/heads/master@{#333044}

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/1159623009

Cr-Commit-Position: refs/heads/master@{#333043}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f54e04d..ea9a19d

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1143333007

Cr-Commit-Position: refs/heads/master@{#333042}

WebRTC 9381:9384
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/020eb8a..b125ba2

Libjingle 9381:9384
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/34e6126..78b410b

TBR=
BUG=

Review URL: https://codereview.chromium.org/1160203005

Cr-Commit-Position: refs/heads/master@{#333041}

Link map's l_addr field should contain the load bias:
- https://android-review.googlesource.com/#/c/46470/2/linker/linker.cpp

It currently contains the load address.  Where the min vaddr of LOAD
segments is zero, the load address and load bias are the same, and the
problem remains hidden.  Android's relocation packer generates a
non-zero min vaddr, and this exposes the problem on arm64 platforms.

The symptom is abort in uw_init_context_1, where uw_frame_state_for
returns _URC_END_OF_STACK rather than (expected) _URC_NO_REASON.
gcc's stack unwinding code does not find correct unwinding information
after an incorrect l_addr has been used to convert from virtual to
physical addresses.  Arm32 does not show the problem because it uses
dl_unwind_find_exidx in place of _Unwind_IteratePhdrCallback.

See also line 196 of:
- https://android.googlesource.com/platform/bionic/+/
      lollipop-mr1-release/linker/linker.cpp

BUG=385553

Review URL: https://codereview.chromium.org/1155973005

Cr-Commit-Position: refs/heads/master@{#333040}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b1cb1e9..f54e04d

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1157863010

Cr-Commit-Position: refs/heads/master@{#333039}

BUG=481955

Review URL: https://codereview.chromium.org/1160293004

Cr-Commit-Position: refs/heads/master@{#333038}

This replaces the only "onUserNavigation" callback with
"onUserNavigationStarted" and "onUserNavigationFinished", and delivers
it.

Note: this change modifies the Service AIDL file, so this is an
incompatible change for the client applications.

BUG=484639

Review URL: https://codereview.chromium.org/1153133004

Cr-Commit-Position: refs/heads/master@{#333037}

This CL adds GetInstalledExtension() method to ExtensionRegistry and
uses it instead of deprecated ExtensionService::GetInstalledExtension()
in chrome/browser/ui/app_list/.

Part of removing the deprecated GetInstalledExtension() call
from the ExtensionService.

BUG=489687

Review URL: https://codereview.chromium.org/1130353010

Cr-Commit-Position: refs/heads/master@{#333036}

They both are totally same and TimeSource is removed.

BUG=494892
R=skyostil@chromium.org, mithro@mithis.com

Review URL: https://codereview.chromium.org/1163143002

Cr-Commit-Position: refs/heads/master@{#333035}

BUG=483467
TBR=ccameron@chromium.org,primiano@chromium.org

Review URL: https://codereview.chromium.org/1148813005

Cr-Commit-Position: refs/heads/master@{#333034}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/454514b..b1cb1e9

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1164903003

Cr-Commit-Position: refs/heads/master@{#333033}

WebRTC 9354:9381
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/13eda41..020eb8a

Libjingle 9354:9381
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/9329d80..34e6126

TBR=tommi,pbos

Review URL: https://codereview.chromium.org/1165723007

Cr-Commit-Position: refs/heads/master@{#333032}

For updates, don't write the main script to disk until a change with the
incumbent script is detected. The incumbent script is progressively
compared with as the new script is read from network. Once a change is
detected, copy everything matched up until now to disk, and from then on
write to disk as the script continues to be read from network.

BUG=457013

Review URL: https://codereview.chromium.org/1166433003

Cr-Commit-Position: refs/heads/master@{#333031}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83034c6..454514b

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1164113002

Cr-Commit-Position: refs/heads/master@{#333030}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/45f16061..607696b0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1170573002

Cr-Commit-Position: refs/heads/master@{#333029}

This was supposed to land in https://codereview.chromium.org/1142153002/ but I forgot to commit and upload the last change set :(

This removes two fields no one uses anymore from the navigation details struct.  It also eliminates some using statements from infobar_service.cc and inlines a helper into its now-lone caller.

BUG=none

Review URL: https://codereview.chromium.org/1160443010

Cr-Commit-Position: refs/heads/master@{#333028}

- "Hit rate": Whether the application predicted correctly.
- "Lead time": How much time between the prediction and the actual launch.

BUG=493170

Review URL: https://codereview.chromium.org/1155423008

Cr-Commit-Position: refs/heads/master@{#333027}

Swiffy updates animations based on the current time (Date.now()), so we
shouldn't override that function to return dummy values.

BUG=493357

Review URL: https://codereview.chromium.org/1154243006

Cr-Commit-Position: refs/heads/master@{#333026}

Review URL: https://codereview.chromium.org/1161413003

Cr-Commit-Position: refs/heads/master@{#333025}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9766f7e..83034c6

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1164473005

Cr-Commit-Position: refs/heads/master@{#333024}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce5a5df..9766f7e

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1162263013

Cr-Commit-Position: refs/heads/master@{#333023}

An observer can now safely call addObserver: or removeObserver:
while being called from an observer method dispatch from
CRBProtocolObservers.

BUG=None

Review URL: https://codereview.chromium.org/1157863009

Cr-Commit-Position: refs/heads/master@{#333022}

Review URL: https://codereview.chromium.org/1159953009

Cr-Commit-Position: refs/heads/master@{#333021}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/89ddbc7..ce5a5df

TBR=yutak@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1150543006

Cr-Commit-Position: refs/heads/master@{#333020}

Cr-Commit-Position: refs/heads/master@{#333019}

Use adb shell am's comma-separated --esa argument.
(escape commas in the script and un-escape them in Java)

John was hitting a JSON parsing error/crash locally.
This should circumvent that error and reduce complexity.

BUG=NONE
TEST=Android Mojo and Mandoline still works as expected.
R=sky@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/1151363004

Cr-Commit-Position: refs/heads/master@{#333018}

In the Data Reduction Proxy event store, if the secure proxy check failed
due to an HTTP response status failure, or a content failure (i.e. the
check returned text that wasn't "OK"), the net-internals#bandwidth page
would indicate that the secure proxy check (incorrectly) succeeded.

Other logs on the page would show the failure of the secure proxy check.

This is a logging/display only bug (no functionality was affected).

BUG=496731

Review URL: https://codereview.chromium.org/1154623008

Cr-Commit-Position: refs/heads/master@{#333017}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e6ec15c..89ddbc7

TBR=yutak@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1160353003

Cr-Commit-Position: refs/heads/master@{#333016}

Currently, there are two issues for potential crashes.

1. There is a chance that Java InfoBars can access native counterparts
even after they are destroyed.

mNativeInfoBarPtr is never reset even after native InfoBar is destroyed.
We do not accept touch inputs after closing infobars, but there may be
corner cases where mNativeInfoBarPtr is accessed afterwards.

2. Infobars aren't setting "base" native pointers correctly.

InfoBar_jni.h has the following code:

InfoBarAndroid* native =
    reinterpret_cast<InfoBarAndroid*>(nativeInfoBarAndroid);

Here, nativeInfoBarAndroid refers to the subclass, so we implicitly upcast
the pointer using reinterpret_cast<>, which may result in pointing to
an incorrect pointer depending on the architecture.

In order to prevent any such occurrence in the future,
this also prevents InfoBar Java subclasses from accessing
the native base pointer and functions.

BUG=492777, 481758

Review URL: https://codereview.chromium.org/1150193004

Cr-Commit-Position: refs/heads/master@{#333015}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a84f569..89d5988

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1156753004

Cr-Commit-Position: refs/heads/master@{#333014}

This CL removes the custom drawn shadow for app list folders and uses
the app list item shadow to render a shadow instead.

This CL also slightly tweaks the shadow values to match mocks.

BUG=485393
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1154323002

Cr-Commit-Position: refs/heads/master@{#333013}

BUG=495563
TEST=Open chrome://crash to upload a crash report and confirm chrome://crashes contains a new crash report.

Review URL: https://codereview.chromium.org/1166743002

Cr-Commit-Position: refs/heads/master@{#333012}

BUG=490597
TEST=none

Review URL: https://codereview.chromium.org/1153063009

Cr-Commit-Position: refs/heads/master@{#333011}