GitLab

ScopedAsyncTaskScheduler is deprecated.

Bug: 708584
Change-Id: Id7fe750e4e3201ed8ccda267cf296ed83dffd96b
Reviewed-on: https://chromium-review.googlesource.com/592244Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490805}

Previously the pref service was connected to the temporary login screen
profile prefs. Now it connects to the user profile on login and after
user switch.

Rename RegisterPrefs() to RegisterProfilePrefs() in ash to emphasize
that these are profile-associated and not local state.

Add ShellObserver notification of PrefService change. The lifetime is
tricky because the old PrefService must continue to exist so shell
observers can unregister their pref observers. Also, there is a window
using user switch where the user pref service is null.

This is based on https://chromium-review.googlesource.com/c/580115
and is a prerequisite for moving some system tray code out of chrome
into ash.

Bug: 747019, 721961, 736169
Test: added to ash_unittests
Change-Id: I186e55c1d88e0e2052b9cd76a490e26804e4b6d3
Reviewed-on: https://chromium-review.googlesource.com/590356
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490804}

This clarifies a comment regarding multiple dispatch per post-review
comment.

Bug: None
Change-Id: I9d2985559883ee3e69730f8e62fc94c95a1bd7f1
Reviewed-on: https://chromium-review.googlesource.com/594869Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490803}

Bug: 750730
Change-Id: I9d56f12d97a271b9b11abd14a63d9a907914394d
Reviewed-on: https://chromium-review.googlesource.com/594967Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490802}

Bug: NONE
Change-Id: I461180fe11e3a05106aa396166cd9527dc79b5a8
Reviewed-on: https://chromium-review.googlesource.com/594712Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490801}

This is a reland of 517fd5f9
Original change's description:
> Remove hover on icons in launcher
> 
> Changes:
> Disable ImageShadowAnimator in fullscreen app list mode so that the icon
> will not jump when hovered.
> 
> BUG=748236
> 
> Change-Id: Iba8c0717f7cdb132a28c4c21eb9add81a652e93a
> Reviewed-on: https://chromium-review.googlesource.com/592335
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490526}

Bug: 748236
Change-Id: I2721590e0b42a03e87ca277a82b7929124704412
Reviewed-on: https://chromium-review.googlesource.com/593188Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490800}

Update code in media to use JavaRef when calling Java methods via JNI,
instead of passing bar jobject. Various function parameter types are
converted from jobject to JavaRef to enable calls to obj() higher up the
call chain to be removed.

BUG=506850

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3ea85d7934655549e1f04feaf885f249cb9019c4
Reviewed-on: https://chromium-review.googlesource.com/585627Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490799}

Change-Id: Ie066edbabf38902768411c2fca5259560569cb95
Reviewed-on: https://chromium-review.googlesource.com/592695Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490798}

BUG=NONE

Change-Id: I6976ea94e9fb6fef2a300d3c70209dc36e289e0a
Reviewed-on: https://chromium-review.googlesource.com/594887Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490797}

BUG=none

Change-Id: I50c20eac60163d3a552bbc69fb40a78629ddcf2d
Reviewed-on: https://chromium-review.googlesource.com/594567Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490796}

These are the last ones, and we can cleanup now!

BUG=734762

Change-Id: I77457c6b110d081bc9d8247efffe9b65cdeccd3d
Reviewed-on: https://chromium-review.googlesource.com/592406
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490795}

On audio-only devices there is no need to perform rasterization for
real. We just need a dummy SkSurface that simply ignores all draw calls.
Using the null surface saves 3.6M memory and draw calls are much faster.

Bug: 737726
Change-Id: Ic11ee7afc80dd71a6ae5d5d2ba5e4aae513fcb61
Reviewed-on: https://chromium-review.googlesource.com/594643Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490794}

By changing the test to use promises, assertion checks happen after giving the
scroll enough time to get processed.

TEST=fast/events/wheel/mouse-wheel-scroll-latching.html,
virtual/wheelscrolllatching/fast/events/wheel/mouse-wheel-scroll-latching.html

Bug: 735130
Change-Id: I1c13bf7eb4be88be942cea40e0bd3228ea2830d9
Reviewed-on: https://chromium-review.googlesource.com/591771
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490793}

Bug: 749251
Change-Id: I2286685ba8ae969070424d142c780851a74eeea5
Tbr: eostroukhov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/594647
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490792}

Change-Id: Ida32bb0de8bd78fae003abd39bce4ec327ad9317
Reviewed-on: https://chromium-review.googlesource.com/594549Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490791}

With this change, external textured rects are handled the way
that textured rects are handled. I have not, in this patch,
moved the shaders out of this file, but I did rearrange them
to keep related vertex/fragment shader pairs together.

This also allowed the ContentElement to handle its own
rendering, so that Fill type was eliminated.

Bug: None
Change-Id: I094c9658bb44aea614d9fab7823a1604e949869e
Reviewed-on: https://chromium-review.googlesource.com/582970
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490790}

Bug: 717207, 560475
Change-Id: I244fab42c9148ca3a001e0c025612249e9ce599e
Reviewed-on: https://chromium-review.googlesource.com/593773Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490789}

Previously we don't feed the logger with access token until the logger
fails to send a log due to denied permissions, which will pollute our
error rate statistics.

This CL makes the app set the logger's access token immediately after the
user logs in or switches account.

Bug: 750366
Change-Id: I6898efd73339b2207d954422bcf2410eb0efa4f5
Reviewed-on: https://chromium-review.googlesource.com/591510Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490788}

Bug: 750708
Change-Id: I283ee164229f46c15e0fd9db95aa1347383a6405
TBR: ivoc
Reviewed-on: https://chromium-review.googlesource.com/594429Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490787}

1. Update the app list background opacity based on the shelf's original opacity.
Shelf changes to fully transparent if app list is opened.
Relationship:
    Applist background opacity = (Opacity of app list) * t + (1 - t) * (opacity of shelf)
    t = gesture_drag_amount / (3.0 * shelfsize)

2. Update the opacity of all the items in the app list.
Includeing, searchbox view, suggested_apps_indicator, suggested_apps, all_apps_indicator,
            all apps in the first page, page switcher
Formula:
Opacity of item = (work_area_bottom - centroid of the item's screen bounds) / (2.0 * shelfsize)

Bug: 748620
Change-Id: Ia1fc25628423fcc1ffad666319e04292837aae2c
Reviewed-on: https://chromium-review.googlesource.com/585398Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490786}

Update code in cronet to use JavaRef when calling Java methods via JNI,
instead of passing bare jobject. Various function parameter types are
converted from jobject to JavaRef to enable calls to obj() higher up the
call chain to be removed.

BUG=506850

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Id58e5b96c08df22f81f1a205cff877523ff2dad0
Reviewed-on: https://chromium-review.googlesource.com/591617Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490785}

This is part of the effort to remove ChromeApplication. Now
nativeGetBrowserUserAgent() is moved to a new class
org.chromium.chrome.browser.content.ContentUtils.

Bug: 698015
Change-Id: I22d848f484d81bb13bc8ba065ff9bda2ed02d16d
Reviewed-on: https://chromium-review.googlesource.com/585630Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490784}

Bug: none
Change-Id: I9ef8991ab9861760edc55877e818b010c6cc78a0
Reviewed-on: https://chromium-review.googlesource.com/594356Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490783}

OWNERS files for these entries have been created @281fecb6
(The only change since then was to add a few [ Skip ] entries.)

DirectoryOwnersExtractor has been modified to read from OWNERS files and verified to work correctly.

Following steps were carried out in this batch removal:
$ sed -e '/external.*\[ Pass\ ]/d' -i W3CImportExpectations
$ sed -e '/^## Owners/d' -i W3CImportExpectations
Line "# external/wpt/media-capabilities" was manually removed as it is
treated equivalently as a [ Pass ] entry by TestCopier.

Now W3CImportExpectations should only contain [ Skip ] entries.

Bug: 713987
Change-Id: Ib5906aa652a3db64deb973a961b0dbf7cbfcc2ff
Reviewed-on: https://chromium-review.googlesource.com/592290
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490782}

Allows a DWriteFontProxy to have a thread-safe way to send IPCs even
when it's not on main thread.

Bug: 722393
Change-Id: I6f840898bce9340ed5c12dcb43ae74ea3bbe7f47
Reviewed-on: https://chromium-review.googlesource.com/587415
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490781}

Enforced in base QueryRegKeyValue function.

TBR=robertshield
BUG=714401
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2885243002
Cr-Commit-Position: refs/heads/master@{#490780}

Bug: 672263
Change-Id: I8d8e9c563175f26e8c6cee1aaaa4e9e3dcd2e144
Reviewed-on: https://chromium-review.googlesource.com/592410Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490779}

In non-single-process tests, there's a good chance that two unit tests
running in the same process need to set different client names.
Currently whichever comes second cannot set the client name correctly.

However, there is no ideal way to test both processes. Resetting the
client names in the test doesn't work because the histogram has static
client name which invalidates the name resetting. To fix, it requires
confusing work-around in the code therefore we prefer to test only one
process after all the logic is almost identical.

Bug: 749366
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iebd312e1138292754f4aa2aa1875b13365e5602f
Reviewed-on: https://chromium-review.googlesource.com/590172Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490778}

Bug: 699244
Change-Id: I4cc9d213d5a1ca96631d77388f286592b5bffd1e
Reviewed-on: https://chromium-review.googlesource.com/558495Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490777}

Reset login container opacity before voice interaction OOBE since the
container could be transparent after unlock animation.

BUG=b/64123072

Change-Id: I38b7d176d83f122bf680674f8ee7ebea5a0054fd
Reviewed-on: https://chromium-review.googlesource.com/591634Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490776}

ScopedAsyncTaskScheduler is deprecated.

Bug: 708584
Change-Id: If36e43e68fe63bee75f2b34f13f98acaa8571f1c
Reviewed-on: https://chromium-review.googlesource.com/591988Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490775}

This CL reverts a change that was made in
https://chromium-review.googlesource.com/c/519422.
Namely, the desired size when fetching a favicon image has to be set to
32px. Even though the image will not be resized in the c++, this provides
information to the c++ side about what image to fetch from the server.

Bug: 715477
Change-Id: Iadb89de97cdc7ab0e188b95bd8fbae63de271bb5
Reviewed-on: https://chromium-review.googlesource.com/593947Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Galia Peycheva <galinap@google.com>
Cr-Commit-Position: refs/heads/master@{#490774}

ScopedTaskScheduler is deprecated.

Bug: 708584
Change-Id: I011a4eab603068729a0c754e4e4dc6a33b23ec77
Reviewed-on: https://chromium-review.googlesource.com/586924Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490773}

Date.after() and .before() don't allow for equal times, which
can happen on fast emulators/devices.

Bug: 749148
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5e81e17435e5827855e44adbc7eb91052f17aa66
Reviewed-on: https://chromium-review.googlesource.com/592751Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490772}

This CL extracts two lengthy (8 and 57 lines) callbacks into a single method
and renames affected methods.

Bug: None
Change-Id: I712116269eef394c1582263d0a2d24e16fdedfe8
Reviewed-on: https://chromium-review.googlesource.com/591652Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490771}

R=rohitrao@chromium.org

Bug: 667892
Change-Id: Ia6cd649c678a65a1f16351864d6a88c9a8e4b9d2
Reviewed-on: https://chromium-review.googlesource.com/590080Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490770}

Bug: 747828
Change-Id: I1d531f2288017b64b6c43f43f855c02e6ad74732
Reviewed-on: https://chromium-review.googlesource.com/588790Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490769}

https://skia.googlesource.com/skia.git/+log/50b2084bd15e..1eace2db482c

$ git log 50b2084bd..1eace2db4 --date=short --no-merges --format='%ad %ae %s'
2017-07-31 caryclark fix capitalization

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Ia3b3b108dc51f8f383f1c894cf638bddfd8f3f2c
Reviewed-on: https://chromium-review.googlesource.com/593850Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490768}

Change-Id: Ie93c7c9010a5e946290aa0482d224bcc96913b73
Reviewed-on: https://chromium-review.googlesource.com/591967Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490767}

(this doesn't use the TaskScheduler API directly because that's the
default behavior on JsonPrefStore now when not provided an explicit
SequencedTaskRunner at construction :))

R=rohitrao@chromium.org

Bug: 667892
Change-Id: Ifa0549e4ddf65ad8606451a47724234981c35467
Reviewed-on: https://chromium-review.googlesource.com/590573Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490766}