- 31 Aug, 2018 40 commits
-
-
David Black authored
Per the spec, the first card element should have a top margin of 40dip. See bug for spec/screenshots. Bug: b:113611382 Change-Id: I323bc7283db600e1f1e319652715b572583a6fbe Reviewed-on: https://chromium-review.googlesource.com/1185878Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#587911}
-
Michael Giuffrida authored
Logs how much active time is spent in pre-installed apps or the browser window when the device is enrolled into Demo Mode by sampling the active window while the user has been recently active. The DemoModeApp enum covers browser windows, several preinstalled Chrome and ARC++ apps, and catch-all categories for unknown apps and non-app UI. These metrics require UMA opt-in and are only collected in demo sessions. Bug: 827380 Change-Id: Icbbb94186b2bff4767c0ee193aa27126eb0a00c2 Reviewed-on: https://chromium-review.googlesource.com/1189711 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#587910}
-
Becca Hughes authored
Add the audio context and media element playbacks fields to the Media Engagement WebUI. BUG=878460 Change-Id: I25a2bdc28a9b98355269e56072c6dc98a019456a Reviewed-on: https://chromium-review.googlesource.com/1195101 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587909}
-
Dan Sanders authored
This CL changes DecoderStream to maintain an instance of DecoderSelector continually. This enabled DecoderSelector to maintain DecryptingDemuxerStream state and the blacklist internally. An immediate consequence is that DecoderSelector can now always try the full list of potential decoders each time that selection is triggered. This fixes the GPU->GPU changeType() transition, and provides a foundation to build GPU fallforward on top of. Another consequence is that fallback can occur more than once for a stream. It is no longer possible to loop forever doing fallbacks, so this is a robustness improvement in addition to being a requirement for changeType(). Bug: 877673 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I76d1bed1c914e1ec58a6653d7200fbb67f70971a Reviewed-on: https://chromium-review.googlesource.com/1188978 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#587908}
-
Istiaque Ahmed authored
This is a reland of 15b15db4 https://chromium-review.googlesource.com/1187856 was in conflict with the CL. Fixed in patchset #5. Original change's description: > [Extensions] Remove an unused param from StartTestFromBackgroundPage. > > The param was always passed with nullptr value, so remove it entirely. > > Bug: None > Test: None, test cleanup. > Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 > Reviewed-on: https://chromium-review.googlesource.com/1196143 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587871} Bug: None Change-Id: Ie25c1f8d87e555ad813c3f044a10b1ce7fad3b00 Reviewed-on: https://chromium-review.googlesource.com/1198483Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587907}
-
Reid Kleckner authored
This passes the /time option to LLD, which prints out some statistics about how long various linking phases took. I plan to add more timers around the major LTO phases so we have more visibility into how ThinLTO performs on buildbots. Also remove two CFI bots that moved from chromium.fyi to chromium.clang. R=dpranke@chromium.org Bug: 877722 Change-Id: I63181af92503ac6877db3cec7b3296d3e229e5a0 Reviewed-on: https://chromium-review.googlesource.com/1197792Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#587906}
-
Wenzhao (Colin) Zang authored
This reverts commit b3b25596. Reason for revert: Re-enable in M70. Original change's description: > cros: Disable new wallpaper picker for M69 > > The plan is to ship all tablet features together in M70. This CL will > be merged to M69 and reverted in M70. > > Bug: 800945 > Change-Id: I8ca2adb4b8b0c1715d7229f48bb521d0dd3ed35b > Reviewed-on: https://chromium-review.googlesource.com/1198523 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587898} TBR=xiyuan@chromium.org,wzang@chromium.org Change-Id: Iaf353081adb041d9b5df6aee2642e6cfa8e092ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800945 Reviewed-on: https://chromium-review.googlesource.com/1198487Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#587905}
-
Tanja Gornak authored
ObjectId is the representation of the subscription topic from the outdated Tango protocol. It's not relevant to the new architecture, since subscription is represented by topic name (in case of sync topic name is for example "BOOKMARKS" or "PASSWORDS"). After this CL all code related to the FCMInvalidationService won't use the ObjectId. But in some places the term Id still used. This is the subject for follow up refactoring. Bug: 878446, 801985 Change-Id: Idcf5bb464fff8976b319bd4721bdca2e3be77751 Reviewed-on: https://chromium-review.googlesource.com/1194032 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#587904}
-
Mohsen Izadi authored
Before this CL, they were in content::GpuProcessHost. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9183ed0fc7c5baec2ea98fd3e68d8a8910fc41d4 Reviewed-on: https://chromium-review.googlesource.com/1195679 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#587903}
-
Clark DuVall authored
This reverts commit a475e1ab. Reason for revert: Test failing on Win debug and msan. Original change's description: > Fix crash in web request proxies connection error handler > > When WebRequestAPI is destroyed, it posts a task to the IO thread to > shutdown the proxies. This crash can happen when the WebRequestAPI is > destroyed, and a connection error happens on one of the proxies (which > accesses data destroyed by the profile) before the ProxySet can be fully > shutdown on the IO thread. This change adds an atomic flag to check to > make sure the WebRequestAPI has not been destroyed before running error > handlers. > > Bug: 878366 > Change-Id: I2f7b98c1d6df7c53a5917444ac996e9b5ef4e794 > Reviewed-on: https://chromium-review.googlesource.com/1196031 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587749} TBR=rockot@chromium.org,cduvall@chromium.org Change-Id: I5825fdb5449001062095bd56ed39eb8b76e055e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878366 Reviewed-on: https://chromium-review.googlesource.com/1198488Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587902}
-
calamity authored
This reverts commit 53107676. Reason for revert: Seems to flake. Examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5019 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71221 Original change's description: > Convert fast/scrolling layouttests to use gpu benchmarking. > > This cl converts all tests in fast/scrolling that are using event sender > other than the following two keyboard tests: > keyboard-scroll-before-layout.html > keyboard-scroll-page-scale.html > > Bug: 846424 > Change-Id: Id6c10046d591724c347bf931ae877e1cb8b7d3c2 > Reviewed-on: https://chromium-review.googlesource.com/1196826 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587687} TBR=bokan@chromium.org,sahel@chromium.org Change-Id: I4bf438ec94ee6732b7db30506c39d8a4672429ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Reviewed-on: https://chromium-review.googlesource.com/1198702Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#587901}
-
Stephen Martinis authored
Change-Id: I89fa7d5596688f676d60d6f58b82383ee60cefab Reviewed-on: https://chromium-review.googlesource.com/1197729 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Becca Hughes authored
Adds AudioContext player tracking to MediaEngagementContentsObserver with it's own page level timer. On MediaEngagementSession this CL seperates significant playback into media element playback and audio context playback. Since we may record a playback we need to disable committing on significant playback and just record on destroy or navigate instead. BUG=878460 Change-Id: Ic66152f8cb5b3a6338804c04de7dd0bf5c1cb154 Reviewed-on: https://chromium-review.googlesource.com/1194992 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The plan is to ship all tablet features together in M70. This CL will be merged to M69 and reverted in M70. Bug: 800945 Change-Id: I8ca2adb4b8b0c1715d7229f48bb521d0dd3ed35b Reviewed-on: https://chromium-review.googlesource.com/1198523Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#587898}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b6e7d49ad5f3..d4e7ca034cbb git log b6e7d49ad5f3..d4e7ca034cbb --date=short --no-merges --format='%ad %ae %s' 2018-08-30 tsepez@chromium.org Add unit test for AutoRestorer<> on smart pointer types. 2018-08-30 tsepez@chromium.org Use pdfium::span<> arg in A85 and RLE encoder methods 2018-08-30 tsepez@chromium.org Use span<> in CFX_FontMgr Created with: gclient setdep -r src/third_party/pdfium@d4e7ca034cbb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib094f35ed0b7da0c0dceaf8561451afc760cb663 Reviewed-on: https://chromium-review.googlesource.com/1198205Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587897}
-
rbpotter authored
Bug: 875449 Change-Id: Ic4c32e2d8c2385dafb778a517d5622d58e090bd7 Reviewed-on: https://chromium-review.googlesource.com/1197264Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#587896}
-
David Grogan authored
Change baselines to NG results. Legacy renders this test identically in quirks mode and standards mode. FF and NG change the rendering between the modes but match each other in both. I didn't look into why the test is supposed to change in quirks vs standards. NG and Firefox draw the empty P block below the cell in quirks mode. Bug: 869873 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ice54cce0fed3d8c260297ac0b8c9f5a8099086c4 Reviewed-on: https://chromium-review.googlesource.com/1196033 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#587895}
-
Kyle Horimoto authored
This CL updates TetherService and TetherHostFetcher to use the MultiDeviceSetupClient's GetFeatureState() function to determine whether the feature should be active or not. This fixes a few edge cases: (1) If the Instant Tethering user preference is enabled, but the Better Together suite is disabled, we should not start up the feature. (2) If the preference is enabled, but the host device does not support Instant Tethering, we should not start up the feature. This CL eliminates the MULTIDEVICE_HOST_UNVERIFIED metrics enum since an unverified host results in NO_AVAILABLE_HOSTS; it replaces that enum value with BETTER_TOGETHER_SUITE_DISABLED, which can occur in practice. Note that because the old metric value has not yet been pushed to users, it is okay to replace it with a new value instead of deprecating it. Bug: 875502, 824568 Change-Id: Ia85f0ba31871c94ed9eb0cb2ef3c4699bb0000dd Reviewed-on: https://chromium-review.googlesource.com/1196172Reviewed-by:Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#587894}
-
Carlos IL authored
This CL removes the checkbox for certificate reporting from SSL interstitials, and for SBER from safe browsing interstitials if unified consent is enabled. Bug: 861747 Change-Id: I751c31cd70e7ba2a1e6358586652b5ae0b0ae18e Reviewed-on: https://chromium-review.googlesource.com/1189058Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#587893}
-
calamity authored
This reverts commit b94164ad. Reason for revert: Suspected of causing ExtensionWebRequestApiTest.WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed failure in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71221 Original change's description: > NetworkService: Fix WebViewTest.ClearDataCache > > This patch does 3 things to fix the test: > 1. Register listeners before loading the actual guest page. See bug for > more background. > 2. Add |was_fetched_via_cache| to |ResourceResponseInfo|. > 3. Call |NetworkContext::ClearHttpCache()| in > |WebViewGuest::ClearData()| when Network Service was enabled. We > cannot use |BrowsingDataRemover| because it doesn't support > non-default |StoragePartition|. > > Bug: 878060 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I5f0ea8e62ee8f44944428cfb041f9d4e427bd67c > Reviewed-on: https://chromium-review.googlesource.com/1195596 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Chong Zhang <chongz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587753} TBR=rockot@chromium.org,tsepez@chromium.org,chongz@chromium.org,cduvall@chromium.org Change-Id: I0a4f300e25d7fd9160d9a8e9ac02c8c733654818 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878060 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1198642Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/44b2c0b1d349..1bf963b62929 git log 44b2c0b1d349..1bf963b62929 --date=short --no-merges --format='%ad %ae %s' 2018-08-30 tobine@google.com Clean up PlatformMethods attribute enum Created with: gclient setdep -r src/third_party/angle@1bf963b62929 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I90d90d3e561c78d54c390d471ae9d0e279f7cca8 Reviewed-on: https://chromium-review.googlesource.com/1198203Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587891}
-
Alexander Timin authored
Add support for disabling input heuristics (or only expensive task blocking) via Finch. R=skyostil@chromium.org,alexclarke@chromium.org BUG=874836 Change-Id: I48837a46b8381d8e805f69899ef57efbda08cf38 Reviewed-on: https://chromium-review.googlesource.com/1187150 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#587890}
-
Malay Keshav authored
This patch implements a URLDataSource that loads oobe video assets from disk based on the provided chrome URL. It also installs the same for the oobe web ui. Bug: 878594 Change-Id: I443144d4e5ab65d313c0e56d8b988a9cb05e6109 Component: Video source, oobe Reviewed-on: https://chromium-review.googlesource.com/1196145Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#587889}
-
Becca Hughes authored
Add a media element playbacks and an audio context playbacks field to the MediaEngagmentScore. The media element playbacks field should be pre-populated with the current media playbacks value (as all previous playbacks would be from media elements). BUG=878460 Change-Id: If34b468bddf1cefaf753e0acd220afa1f100331b Reviewed-on: https://chromium-review.googlesource.com/1194690 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Resolved a TODO that aims to move java test util class package path to content_public to match that of native ones. Only package path has changed; there should be no functional/behavioral change. Change-Id: I276198aeb5b952b2d18db19df6444c589df3aba6 Reviewed-on: https://chromium-review.googlesource.com/1183003 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#587887}
-
siyua authored
1) Added legal message (clickable) to the offer dialog. 2) Added a Close Button which will be shown when the user clicks save button and the migration process lasts for more than 5 secs. 3) Modified ChromeAutofillClient to enable passing legal message to the LocalCardMigrationDialogControllerImpl. 4) Adjusted format/style of the dialog contents according to the mock: go/autofill-paradise. 5) Added an experiment flag (disabled by default) to control whether we want to show migration feedback to the user. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic0ca348fc689486a21d53a76921ee5954cb08295 Reviewed-on: https://chromium-review.googlesource.com/1192688 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#587886}
-
S. Ganesh authored
TBR=thakis@chromium.org BUG=833687 Change-Id: I2e8fedc25facc470d9ece26f5699fb236d044784 Reviewed-on: https://chromium-review.googlesource.com/1171735 Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#587885}
-
Weilun Shi authored
Link icon will be enlarged when there is only one line of attribution. The size of the link icon will still correspond to the text size when there are two lines of attribution. Screencast: https://screencast.googleplex.com/cast/NTQwNTYzNTc2NDAyNzM5Mnw1ZjlmZGVjNC04Yg Bug: 878917 Change-Id: I351569a1c260b4e5d0524c44bebdcdc8f67a4522 Reviewed-on: https://chromium-review.googlesource.com/1197425Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#587884}
-
Raymond Toy authored
Just update the messages to say M71 for when the media element nodes will be removed from an OfflineAudioContext, as required by the WebAudio spec. We're still gathering some UMA stats on this. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913 Change-Id: Id6b5803533a96bca509d4b5b2b8c4dd2d8ecd7a3 Reviewed-on: https://chromium-review.googlesource.com/1194737Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587883}
-
Scott Chen authored
If a settings-subpage doesn't have a valid associated-control attribute value, searching would crash. This CL fixes a couple of those instances. Bug: 876280 Change-Id: I4be99c6d6e29e5019409f0fde056847e68d34d9e Reviewed-on: https://chromium-review.googlesource.com/1197907Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587882}
-
Han Leon authored
Removing an unused function: Response* Response::Create( ScriptState* script_state, const WebServiceWorkerResponse& web_response); BUG=879019 Change-Id: I23878fd116cfee6acf6442f854f75b825d08cba4 Reviewed-on: https://chromium-review.googlesource.com/1195732Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#587881}
-
Wez authored
In future the fidlc tool will require explicit 'using' declarations for all dependencies. Bug: 879388 Change-Id: Ic82e6c7338d31e045ab20f24044fb97fbc151bbf Reviewed-on: https://chromium-review.googlesource.com/1198012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587880}
-
Xiaohui Chen authored
It is possible that the callback from libassistant comes right after assistant_manager is stopped/reset. Let's guard this case. Bug: 879390 Test: locally build Change-Id: Iea2fe174a02627e6d61406a1319d172470028afd Reviewed-on: https://chromium-review.googlesource.com/1198105Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#587879}
-
Findit authored
This reverts commit 15b15db4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 587871 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1YjE1ZGI0NzQ3YzNlOTI2MzgwZTJiZDg4MmNjN2E0OGUzNjRmZTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.gpu/GPU%20Linux%20Builder/128717 Sample Failed Step: compile Original change's description: > [Extensions] Remove an unused param from StartTestFromBackgroundPage. > > The param was always passed with nullptr value, so remove it entirely. > > Bug: None > Test: None, test cleanup. > Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 > Reviewed-on: https://chromium-review.googlesource.com/1196143 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587871} Change-Id: Iced35e86429f566d79c2ab7807d34c69b6456a35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1198563 Cr-Commit-Position: refs/heads/master@{#587878}
-
Bailey Berro authored
The browser_tests for the Add New Services menu make the assumption that there are no native FSPs installed, so this change disables NativeSmb in those tests. Bug: chromium:757625 Change-Id: I0d4d5d20fd71b3d537b0ef58a109a37ca4fc0cf3 Reviewed-on: https://chromium-review.googlesource.com/1197222 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#587877}
-
Xiaohui Chen authored
Bug: 879401 Test: eve does not have assistant button Change-Id: Ie65d700eb6c052d2089bef6ec2a209bdd12dbc9b Reviewed-on: https://chromium-review.googlesource.com/1198282Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#587876}
-
Daniel Hung-yu Wu authored
Make camera metadata tags mojo interface so that it matches the HAL adapter mojo modified for portrait mode (Bokeh). BUG=b:79901482 TEST=CCA works on Soraka R=jcliang@chromium.com Change-Id: I5aaf263efa863f569477cf30a4a63b93f242ab30 Reviewed-on: https://chromium-review.googlesource.com/1195187Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
-
Ben Wells authored
This means if a PWA is installed on one machine and synced to another machine such that it isn't locally installed (i.e. it is synced to a non-Chrome OS machine), it won't be treated as an installed PWA. This affects features such as the navigation options available. Bug: 874841 Change-Id: I42667edbd7d9ac7dbe2a088d4b11bda422beee8b Reviewed-on: https://chromium-review.googlesource.com/1195382Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#587874}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eabc276ceacd..01bd09d56fbd git log eabc276ceacd..01bd09d56fbd --date=short --no-merges --format='%ad %ae %s' 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 nodir@google.com [bot_update] Fix initialization from buildbucket 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@01bd09d56fbd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161 TBR=agable@chromium.org Change-Id: I6abb911ab1aa454dcd6d86d4fd60990c9333caad Reviewed-on: https://chromium-review.googlesource.com/1198123Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587873}
-
Giovanni Ortuño Urquidi authored
UninstallApps adds uninstallation tasks to the queue of tasks and uninstalls the corresponding extension for the provided URL. Bug: 876174 Change-Id: Id79adb12a0999332aaec830acb48eadbf62b2abb Reviewed-on: https://chromium-review.googlesource.com/1196782 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
