- 01 Mar, 2019 40 commits
-
-
Robert Ogden authored
Adds a generic constructor to widget.TextBubble to accept a String so that formattable string resources can be used in TextBubbles. This CL is 2 of 4 to move the DataSaver "Chrome saved you XX data" from a snackbar to an IPH. Bug: 878337 Change-Id: I35b04641bcd680fa4eaa527f265b4c7f33f6ddd1 Reviewed-on: https://chromium-review.googlesource.com/c/1492472 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#636886}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/2d403737b88f..503cb8e63a06 $ git log 2d403737b..503cb8e63 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 marpan vp9-rtc: Set init noise level based on resoln 2019-02-28 marpan vp9-rtc: Reduce thresholds for skip golden 2019-02-26 jianj Set segment ID from ROI map if enabled. 2019-02-27 marpan vp9-rtc: Change init level of denoiser & noise level 2019-02-27 marpan vp9: Remove unused function in cyclic refresh 2019-02-27 marpan vp9-rtc: Add cyclic_refresh condition to segment reset 2019-02-27 marpan vp9-rtc: Modify skip golden mode check for 1 layer 2019-01-31 paulwilkins Change to direction of scan for GF only group boost. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I556f92b49302693bd32de47234c81bbe63fd6a97 Reviewed-on: https://chromium-review.googlesource.com/c/1496487 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#636885}
-
Sebastien Marchand authored
WMIRefresher is created during the creation of SystemMonitor on the UI thread, it is then used only in a MayBlock sequence. Change-Id: I7a14f59272a7ac6170c25e15518f31bfbc9f4870 Reviewed-on: https://chromium-review.googlesource.com/c/1493157 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636884}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a1924739029e..dd1e37e31d68 git log a1924739029e..dd1e37e31d68 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 bclayton@google.com SpirvShader: Begin unary and binary ops. Created with: gclient setdep -r src/third_party/swiftshader@dd1e37e31d68 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126870789,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I04991288a1fb4051323daa38cd6b1e0e38f69a0a Reviewed-on: https://chromium-review.googlesource.com/c/1496896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636883}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/d50a88f50782..7a61cf37d6a0 $ git log d50a88f50..7a61cf37d --date=short --no-merges --format='%ad %ae %s' 2019-02-23 vadimsh Update httplib2 0.9.2 -> 0.12.1. Created with: roll-dep src/tools/swarming_client Fix client side SSL issues some people have been observing. R=sergiyb@chromium.org Change-Id: I72e40ec935d68f5a443d5a970457a598251b30cb Reviewed-on: https://chromium-review.googlesource.com/c/1496080Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636882}
-
Lei Zhang authored
- Make RenderProcessBlockedStateChanged() private. - Modernize new and NULL usage. Change-Id: I91fd842c3fbfc7eff1a89142d09cfe3e55430993 Reviewed-on: https://chromium-review.googlesource.com/c/1496242Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636881}
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: Ibb9ec7c516dc70618481d89f4da6d224b9c3212c Reviewed-on: https://chromium-review.googlesource.com/c/1477852 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#636880}
-
Antonio Gomes authored
|StyleSheetContents::import_rules_| is of type HeapVector<Member<StyleRuleImport>>. Its members will always resolve |import_rules_[index]->IsFontFaceRule()| to false (once StyleRuleBase::IsImportRule() is the one that resolves to true. This CL removes the if-block that checks that altogether, allowing the removal of the remaining DEFINE_STYLE_RULE_TYPE_CASTS occurrence. Note: This was caught because trying to use To<StyleRuleFaceRule> failed to compile. ../../third_party/blink/renderer/platform/wtf/casting.h:102:10: error: non-const lvalue reference to type 'blink::StyleRuleFontFace' cannot bind to a value of unrelated type 'blink::StyleRuleImport' return static_cast<Derived&>(from); ^ ~~~~ R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I6bbf992b3654601a50fc68b18961de79899d5284 Reviewed-on: https://chromium-review.googlesource.com/c/1496056Reviewed-by:Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636879}
-
Yi Gu authored
Mark virtual/scroll_customization/fast/events/touch/touch-handler-iframe-plugin-assert.html as flaky This test sometimes produces result twice. i.e. --- PASS successfullyParsed is true TEST COMPLETE PASS successfullyParsed is true TEST COMPLETE --- TBR=nzolghadr@chromium.org NOTRY=true Bug: 937358 Change-Id: I90c2001dc5c262193a8279e15c969fa032469273 Reviewed-on: https://chromium-review.googlesource.com/c/1497116 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636878}
-
wutao authored
This patch matches the corner radius of assistant page and the search result page. Also, since we have a mask layer, remove the background's corner radius. Bug: 924624 Test: manual Change-Id: I640d1cd1d52495a9cd2ed405c16eaecc9cb9781c Reviewed-on: https://chromium-review.googlesource.com/c/1496297Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636877}
-
Fabrice de Gans-Riberi authored
Change-Id: I0e8b2684f768841f4e087d02752d3490b02ec31e Reviewed-on: https://chromium-review.googlesource.com/c/1496253Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#636876}
-
Gauthier Ambard authored
This CL fixes the select action with VoiceOver, allowing to close the popup menus using the "Close Menu" scrim. Bug: 936850 Change-Id: Ifd245eed2f4d302d8aa959aae3f441c2199f31ee Reviewed-on: https://chromium-review.googlesource.com/c/1496890Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#636875}
-
David Bienvenu authored
If a background occlusion calculation is in progress when the screen is locked, it will overwrite the setting of visible windows as occluded by the code receiving the screen lock notification. Bug: 532128, 813093 Change-Id: Ia256dd3668029220d00d31101942600527fe5f6e Reviewed-on: https://chromium-review.googlesource.com/c/1492038Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636874}
-
Hector Carmona authored
Screenshot in bug. Bug: 934497 Change-Id: Id1f1795439da5397206a56b68a422691f1b5e944 Reviewed-on: https://chromium-review.googlesource.com/c/1496498Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#636873}
-
Alex Leung authored
Bug: b:126783022 Test: CQ Presubmit and verified header files are correct. Change-Id: I0b7c6f97b6191a7c28fa20e470d3718e079925fb Reviewed-on: https://chromium-review.googlesource.com/c/1496437 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#636872}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If18e186ea901d715d352ce9b77fb8e5998cf7b2e Reviewed-on: https://chromium-review.googlesource.com/c/1496393Reviewed-by:
-
Yi Gu authored
TBR=bokan@chromium.org See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Ffast%2Fevents%2Fpointerevents%2Fpinch%2Fpointerevent_touch-action-pinch_zoom_touch.html%20 Bug: 893659 Change-Id: I520774abc21e15a2fb3e55b04c7195d36cfb3804 Reviewed-on: https://chromium-review.googlesource.com/c/1496484 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
khachatryan authored
CL https://crrev.com/635738 fixed this bug. Enabling test on Android for Chrome Stable Change-Id: Id2191f71e30051471277f174791582871ed11eaa Reviewed-on: https://chromium-review.googlesource.com/c/1495810 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636869}
-
Katie D authored
Bug: 905419 Change-Id: Id5e803304da0e864113186bd7c0c9b2d1b88777b Reviewed-on: https://chromium-review.googlesource.com/c/1496485Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#636868}
-
Andrey Lushnikov authored
DevTools protocol method |Page.addScriptToEvaluateOnNewDocument| accepts an optional "worldName" argument. When defined, a script will be evaluated in a new isolated world. These worlds are getting re-created on every page navigation. This patch lifts the limit for inspector-created isolated worlds from 100 to 2^29. R=pfeldman Change-Id: Iec387ea0adb79bad759446dd76007bfb3cec38e3 Reviewed-on: https://chromium-review.googlesource.com/c/1496759 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636867}
-
Yi Gu authored
TBR=kmilka@chromium.org Bug: 937041 Change-Id: Iede3e9f2aa032642f90c22f1c2c716990b966c13 Reviewed-on: https://chromium-review.googlesource.com/c/1497033Reviewed-by:
-
Moe Ahmadi authored
Adds a11y labels for the gear and dismiss buttons. Adds a11y traits for the language tabs in selected state. Adds a11y traits for the popup menu items in selected state. Adds appropriate a11y announcement when the infobar UI is shown. Bug: 910994 Change-Id: I340acb4f3786db8bab884c3e60bcbbf553867a6d Reviewed-on: https://chromium-review.googlesource.com/c/1495858 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#636865}
-
Maksim Ivanov authored
The extension should use the chrome.runtime.onConnectNative event in order to listen for the messages from the daemon when the daemon starts the communication itself. The application string passed to the event will be 'com.google.wilco_dtc'. The hardcoded whitelist for extensions that receive this event is currently empty - it will have to be updated once we figure out extension IDs that we'll use. BUG=chromium:907932,b:123926112 TEST=manual Change-Id: Ic5db3817ccc757bcf6bef4e4f800623d02e11660 Reviewed-on: https://chromium-review.googlesource.com/c/1464579Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#636864}
-
Elly Fong-Jones authored
Per email discussion :) Bug: None Change-Id: I92886849f0c29ac70b3743b777844a188914bc94 Reviewed-on: https://chromium-review.googlesource.com/c/1496918 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636863}
-
Siddhartha S authored
BUG=924842 Change-Id: Ic9437bd02e0196b82b2896960c8c2eb7f0cc289c Reviewed-on: https://chromium-review.googlesource.com/c/1496316Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#636862}
-
Yuwei Huang authored
This CL makes FtlClient use OAuthTokenGetter to retrieve access token and attach it to the gRPC request. It also has some other changes in the FTL playground: * Move FtlSignalingPlayground into a separate class to make it cleaner. * Make FtlSignalingPlayground prompt and read access code from the user and use it to start up an OAuthTokenGetter. Bug: 927962 Change-Id: I43d2f19b53b41e2fa3652e6c6e4c09eb54ae889e Reviewed-on: https://chromium-review.googlesource.com/c/1496317Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#636861}
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build, and future-proofs the code against libc++ changes related to https://cplusplus.github.io/LWG/lwg-defects.html#2408 That defect report states that std::iterator_traits should be SFINAE-friendly, and libstdc++ already complies with that, so when commit 2808b7ec ("cros: Improve damage for underlays") started using std::any_of() with a cc::ListContainer the underlying code that function assumes (per the standard) that the iterators it receives are at least input iterators. For that to be true, std::iterator_traits needs to have a valid specialization rather than the empty one (SFINAE), otherwise we end up with an error like this: In file included from ../../components/viz/service/display/overlay_processor.cc:5: In file included from ../../components/viz/service/display/overlay_processor.h:10: In file included from ../../base/containers/flat_map.h:12: In file included from ../../base/containers/flat_tree.h:8: In file included from /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/algorithm:62: /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algo.h:162:10: error: no matching function for call to '__iterator_category' std::__iterator_category(__first)); ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algo.h:3930:19: note: in instantiation of function template specialization 'std::__find_if<cc::ListContainer<viz::DrawQuad>::ConstIterator, __gnu_cxx::__ops::_Iter_pred<(lambda at ../../components/viz/service/display/overlay_processor.cc:258:49)> >' requested here return std::__find_if(__first, __last, ^ /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algo.h:526:40: note: in instantiation of function template specialization 'std::find_if<cc::ListContainer<viz::DrawQuad>::ConstIterator, (lambda at ../../components/viz/service/display/overlay_processor.cc:258:49)>' requested here { return __last == _GLIBCXX_STD_A::find_if(__first, __last, __pred); } ^ /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algo.h:544:20: note: in instantiation of function template specialization 'std::none_of<cc::ListContainer<viz::DrawQuad>::ConstIterator, (lambda at ../../components/viz/service/display/overlay_processor.cc:258:49)>' requested here { return !std::none_of(__first, __last, __pred); } ^ ../../components/viz/service/display/overlay_processor.cc:257:30: note: in instantiation of function template specialization 'std::any_of<cc::ListContainer<viz::DrawQuad>::ConstIterator, (lambda at ../../components/viz/service/display/overlay_processor.cc:258:49)>' requested here bool has_damage = std::any_of( ^ /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_iterator_base_types.h:205:5: note: candidate template ignored: substitution failure [with _Iter = cc::ListContainer<viz::DrawQuad>::ConstIterator]: no type named 'iterator_category' in 'std::iterator_traits<cc::ListContainer<viz::DrawQuad>::ConstIterator>' __iterator_category(const _Iter&) ^ Fix it by adding a few types confirming to STL's naming conventions so that std::iterator_traits works with all 4 iterator types cc::ListContainer defines. Bug: 819294 Change-Id: I1424e22b3793bec810d6d83be2490b4a402ed94d Reviewed-on: https://chromium-review.googlesource.com/c/1496991 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/329fac37dd27..8962ac298f14 Created with: gclient setdep -r src-internal@8962ac298f14 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I87059be2b55b6f4a86eec793419d173f1de2f378 Reviewed-on: https://chromium-review.googlesource.com/c/1496898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636859}
-
Saman Sami authored
Change-Id: I6c39c63ea36e6ebbdbbf2f459f5c826087142211 Reviewed-on: https://chromium-review.googlesource.com/c/1495364Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#636858}
-
Tao Bai authored
This reverts commit ff22e974. Reason for revert: broke the bot https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/35526 Original change's description: > [vr] Move Java and resources to //chrome/android/features/vr > > Bug: 870056 > Change-Id: I6e1dbf041d0b57a9457eb421cf7a4cc2a9cc7ebc > Reviewed-on: https://chromium-review.googlesource.com/c/1494721 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636818} TBR=yfriedman@chromium.org,mthiesse@chromium.org,wnwen@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I7f3154acac5604648bc96eef5db8f56342ecc1d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870056 Reviewed-on: https://chromium-review.googlesource.com/c/1496489Reviewed-by:
-
Yi Su authored
This CL enables dynamic type support for tile views on NTP. Tile views will have 4 groups of size depending on which font size is selected. The font size of tile views' caption will be capped to 2nd smallest accessibility font size. Bug: 893523 Change-Id: I11871071026a8eda52f66ebd5f826912462cf9f3 Reviewed-on: https://chromium-review.googlesource.com/c/1489208Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636856}
-
Patrick Monette authored
While it makes the code a bit less readable, writing the server-side configuration file will be way easier. Bug: 928846 Change-Id: I1e2965d335443fed643fe779adf3fcb6fd81d030 Reviewed-on: https://chromium-review.googlesource.com/c/1495860Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#636855}
-
Alice Boxhall authored
This is pre-work for https://crrev.com/c/1369489 Bug: 835455 Change-Id: I11dcc45745a0b5ddabaf160958d4d6ade22ea6fa Reviewed-on: https://chromium-review.googlesource.com/c/1493336 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Matt Menke authored
Previously, in the case of HTTP auth challenges received while establishing HTTP tunnels, ownership of the socket with the challenge was passed to the caller, which then had to handle the auth challenges before returning the socket to the original socket pool, after successfully dealing with the auth challenges. In the SSL tunnel over an HTTP proxy case, after successfully authenticating with the proxy, the socket had to be returned to the HTTP proxy pool, so that then an SSLConnectJob could be created in a higher layer pool to wrap the proxied HTTP connection. This CL changes behavior so that, while the consumer is still responsible for handling auth, it happens while the socket is still owned by a ConnectJob inside the socket pool. Once the first auth challenge is received, the ConnectJob is implicitly bound to a consumer, which is then responsible for handling all HTTP authentication for the ConnectJob. This approach will allow for a flat socket pool, which didn't work with the old behavior, because of SSL over HTTP proxy tunnel logic. It will also let HttpProxyClientSocketWrapper be merged into HttpProxyConnectJob once more, which will make things a bit more consistent, since the HttpProxyClientSocketWrapper is responsible for establishing a tunneled connection, which is normally the job of ConnectJobs. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Iafaae5bb6bf42df77fb4a9f4ea78ae812232dcf6 Reviewed-on: https://chromium-review.googlesource.com/c/1481900 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#636853}
-
Antonio Gomes authored
There is one ocurrence left, and a TODO added for follow up. in //third_party/blink/renderer/core/css/style_sheet_contents.cc. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I05bffd7814e816e06743a21651dba2666b8495b3 Reviewed-on: https://chromium-review.googlesource.com/c/1496337 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/255569187f27..1223e7fc0a3c git log 255569187f27..1223e7fc0a3c --date=short --no-merges --format='%ad %ae %s' 2019-03-01 jvanverth@google.com Add GrMtlPipelineStateCache. 2019-03-01 fmalita@chromium.org [canvaskit] Ignore image paths in Skottie asset keys 2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5546fb4fdd85..1581ff030b9c (2 commits) 2019-03-01 fmalita@chromium.org [canvaskit] Consolidate Skottie assets Created with: gclient setdep -r src/third_party/skia@1223e7fc0a3c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ic0f2304e92186dbead9ddcfe115ae59bfea274f7 Reviewed-on: https://chromium-review.googlesource.com/c/1496895Reviewed-by:
-
Nico Weber authored
This reverts commit f6fa5cac. Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/ios-device/116376 Original change's description: > Enable -Wextra-semi in release builds that don't set dcheck_always_on=true. > > Most of these are macros that expand to nothing when dchecks are off, but > to a declaration when dchecks are on. They are meant to be used to declare > member variables. > > Since clang-format gets very confused on class member declarations that > don't end in a semicolon and since we require clang-formatting, > we need some way to still permit a semicolon after these macros even > with dchecks off. To that end, add a dummy static_assert() at the end > of these macros. > > Alternatively, we could surround all uses of these macros with explicit > DCHECK_IS_ON() checks. > > Depends on https://skia-review.googlesource.com/c/skia/+/196421 > > TBR=dalecurtis > > Bug: 926235,936856 > Change-Id: I66ab08f383b2f27dc6a7617f67f33fa66ddfa00c > Reviewed-on: https://chromium-review.googlesource.com/c/1495041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636838} TBR=dalecurtis@chromium.org,gab@chromium.org,thakis@chromium.org Change-Id: Iba14b13129b16b569249e62afa4644209e1435c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 926235, 936856 Reviewed-on: https://chromium-review.googlesource.com/c/1496308Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636850}
-
Jacob Dufault authored
This reverts commit 62a0a01c. Reason for revert: Relanding Original change's description: > Revert "cros: Make FakeGaia in OobeBaseTest a mixin" > > This reverts commit c0c53eb2. > > Reason for revert: breaks compilation when is_chrome_branded=true > OobeBaseTest::kFakeUserEmail is referenced at: > https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/sync_consent_interactive_ui_test.cc?l=141&rcl=95ffa536956a89b861c39e6df1c8670638dd31a0 > > https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?l=2010&rcl=80199d3ea8218c1e8568bcc087c6d77f0ebaf94e > > Original change's description: > > cros: Make FakeGaia in OobeBaseTest a mixin > > > > We may want to just use FakeGaia directly instead of introducing a > > mixin, but that can be decided later. For now let's focus on simplifying > > all of the test bases. > > > > Bug: 912704 > > Change-Id: Id4a7ab8e0c23343b7e6e59c7b7d2aefc16891515 > > Reviewed-on: https://chromium-review.googlesource.com/c/1366895 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Sergey Poromov <poromov@chromium.org> > > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#635236} > > TBR=antrim@chromium.org,alemate@chromium.org,jdufault@chromium.org,poromov@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 912704 > Change-Id: I31882d938465fb8404c90b84379e34aff7354512 > Reviewed-on: https://chromium-review.googlesource.com/c/1490353 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635836} TBR=antrim@chromium.org,alemate@chromium.org,jdufault@chromium.org,poromov@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 912704 Change-Id: Iae75e9c32dcccb0281738128436907e9e29de7d9 Reviewed-on: https://chromium-review.googlesource.com/c/1495734Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#636849}
-
Fernando Serboncini authored
ImageBitmap can fail to be created, if it doesn't fit in memory. Bug: 936885 Change-Id: I694ed4fb964782f84cdec33d465a1e404aca6324 Reviewed-on: https://chromium-review.googlesource.com/c/1496921 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636848}
-
Lei Zhang authored
Do the same for ConstrainedDialogWebView. Fix lint errors along the way. Change-Id: I8ce13cb4fd8891c610a20c49dcec32b465327c1b Reviewed-on: https://chromium-review.googlesource.com/c/1496449 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
