- 24 Oct, 2019 40 commits
-
-
Naoki Fukino authored
I ran tools/resources/optmize-png-files.sh on: ui/file_manager/audio/assets/ ui/file_manager/file_manager/foreground/images ui/file_manager/gallery/images ui/file_manager/video_player/images The resource size (/opt/google/chrome/resources.pak) changes from 42641939 bytes to 42417396 bytes (219KB saved) The image quality should stay the same as the optimization process doesn't lose any information. Bug: 1017111 Test: Manually confirmed images look same on the device (not all the images, though) Change-Id: Id37286924fcd94440791e2dd31a883437eb7f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875861Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#708898}
-
Andrii Shyshkalov authored
Includes 2019-10-23 tandrii@google.com vpython: more logging when incomplete virtualenv dir can't be removed. R=bpastene Bug: 869227 Change-Id: I5c736089176473ef9ba8cbf1bc8b3791c7ada393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877650 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708897}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbf7cb0e..71f4ff16 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I07c4dd8664bd0f74a8f8e3fbc4670bcfa56a968c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877369Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708896}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iec3984d64b4c0421ff25b5759f5fa21bc4102efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877910Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708895}
-
Koji Ishii authored
This patch removes |NGLineInfo::LineEndFragment|, which was introduced to support hyphens and ellipsis with the single code. However, ellipsis was changed to use different code, and |LineEndFragment| ended up with non-optimal way to handle hyphens. Although hyphens appear at most once in a line, storing this to |NGLineInfo| makes harder to keep it in sync with the hyphenated item. This patch changes it to a field in |NGInlineItemResult|. Bug: 1015297 Change-Id: I0706cf54bebfa967661dc40123c6dfd5887ff59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868534 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708894}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1a8abc0a3e7..bd2007738e5a git log c1a8abc0a3e7..bd2007738e5a --date=short --no-merges --format='%ad %ae %s' 2019-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 510c0ca3..f656c810 (708742:708845) 2019-10-23 mbonadei@webrtc.org RTC_EXPORT webrtc::DesktopCapturerDifferWrapper. Created with: gclient setdep -r src/third_party/webrtc@bd2007738e5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I8b8b4d63b6113eb1c4810379d57fbe752c478afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708893}
-
Alex Cooper authored
In preparation for removing the code for WebVr, the remaining tests must also be removed, both browser tests and perf tests. Future work will remove the actual blink side code that allows WebVr to be accessed from a runtime feature flag. Bug: 960132 Change-Id: I6ba70e2798401a6c76d7eed338967e77d0f5fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867257 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708892}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::RendererHost. It uses AssociatedRemote and AssociatedReceiver instead of RendererHostAssociatedPtr and AssociatedBinding. Bug: 955171 Change-Id: If977953c0cecfa6462b01fc4f51612411fdca2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872579Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#708891}
-
Miyoung Shin authored
This CL cleans up TODOs of |associated| in fake_bluetooth_chooser.mojom and hid.mojom since JS generator for PendingAssociated is supported by crrev.com/c/1847331, and converts FakeBluetoothChooserClientAssociatedPtrInfo and HidManagerClientAssociatedPtrInfo to new Mojo types. Bug: 955171 Change-Id: I505d74b8888dd7e4153ddb65c159a5c2efef25e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872216Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Joel Hockey authored
Add new restarter observer functions: * OnStageStarted(mojom::InstallerState stage) * OnContainerMounted(bool success) These functions will be used by terminal during startup. OnStageStarted allows terminal to notify users as each stage starts without having to have intimate knowledge of each stage that will be run and the ordering. OnContainerMounted completes the set of callbacks. Bug: 1016680 Change-Id: I063390727db99aeb701b3e96d909cb85451bd328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876291 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708889}
-
Peter Kasting authored
Bug: 82078 Change-Id: I7cae2dbd48a7ca1abbb1ec4ac34a798a7f218a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867812 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708888}
-
Fergal Daly authored
I ran the listed tests with --repeat 100. Some of them are slow and didn't complete 100 with the 1200s swarming timeout. Tests that passed 100 times NavigationControllerBrowserTest.ReplacedNavigationEntryData_Back NavigationControllerBrowserTest.BackOnBrowserInitiatedErrorPageNavigation NavigationControllerBrowserTest.BrowserInitiatedLoadPostCommitErrorPageForSubframe NavigationControllerBrowserTest.PageStateAfterForwardInCompetingFrames TouchpadPinchBrowserTest.* RenderViewHostTest.IsFocusedElementEditable NavigationControllerBrowserTest.BackSameDocumentAfterBlockedSubframe TouchInputBrowserTest.* Their logs https://chromium-swarm.appspot.com/task?id=480f3577f603df10 https://chromium-swarm.appspot.com/task?id=480f35af96d38810 https://chromium-swarm.appspot.com/task?id=480f3529b3cb5b10 https://chromium-swarm.appspot.com/task?id=480f3560f9248710 https://chromium-swarm.appspot.com/task?id=480f3620d07eea10 https://chromium-swarm.appspot.com/task?id=480f35a40c170a10 https://chromium-swarm.appspot.com/task?id=480f35c19a626c10 https://chromium-swarm.appspot.com/task?id=480f35df2a874410 Tests that passed 100% but only ran ~30 times MSE_ExternalClearKey/EncryptedMediaTest.* IndexedDBBrowserTest* MSE_ClearKey/EncryptedMediaTest.* MHTMLGenerationTest/MHTMLGenerationTest.* Their logs Task: https://chromium-swarm.appspot.com/task?id=480f58227f406610 Task: https://chromium-swarm.appspot.com/task?id=480f351ac8bdb010 Task: https://chromium-swarm.appspot.com/task?id=480f580b0085c010 Task: https://chromium-swarm.appspot.com/task?id=480f5ec378dd1210 Bug: 1016230 Change-Id: Iad60171b7f8f3a54af4f76e4755e6568ac73514c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874070 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708887}
-
Ricky Liang authored
This CL enables the blink ImageCapture.grabFrame() implementatio to grab video frames backed by GpuMemoryBuffer. Bug: 982201 Test: https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html Change-Id: I9eada1924aaeffd447f55140cd0a166e88f9582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864759Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708886}
-
Eero Häkkinen authored
This changes NativeFileSystemDirectoryHandle.GetEntries to be asynchronous like the web-exposed API and the storage implementation. This should make directory iteration more efficient. Bug: 970059 Change-Id: I43bdd4950a70abc8d7cd8dcc890963655d49fdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867150Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708885}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1faae79f67ac..e8d14c45f873 Created with: gclient setdep -r src-internal@e8d14c45f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43b543a0063cca5e5b0ae69029e2be33f5c31c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708884}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1b164088d5..e83f334d45d6 git log fd1b164088d5..e83f334d45d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e83f334d45d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ie8405f88dfbcaba7e577b0251ec90219da747eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877405Reviewed-by:
-
Chris Lu authored
Creates a new BadgeType for the Save Credit Card Infobar. Adds support for the badge in BadgePopupMenuItem and BadgeButtonFactory. Bug: 1014959 Change-Id: I3052c0a17ea4e5f68db3a16ead997605b58aaacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872014 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708882}
-
Julie Jeongeun Kim authored
This CL converts ActivationDelegate from cellular_setup.mojom to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I95085ca9a9d9759bf71366be043adb7223a9a32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872093 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Yun Liu authored
Android instrumentation tests and gtests cannot be separated at mb so we pass '--coverage-dir' to both if any coverage turned on and tackle it at runner side for '--coverage-dir'. Also changed 'java_coverage' to 'use_java_coverage' to be consistent. Bug: 985574 Change-Id: Ia3d99f07292b49714196e3c296d3234420bee0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876492 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e8378a666b73..2b4bcf993ef5 git log e8378a666b73..2b4bcf993ef5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org wrapper: use importlib if available Created with: gclient setdep -r src/third_party/chromite@2b4bcf993ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I745380dfa4cfea386914b694747647fdbeb89b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877612Reviewed-by:
-
Chris Lu authored
This change implements presenting InfobarBannerViewController when InfobarTranslateCoordinator starts and the button action. Some constants from TranslateInfobarController are moved to a constants so that they can be shared. Screenshot of what it will look like when activated: https://drive.google.com/open?id=11W6HznODlJduMCZgNOSR1b8Gi_crfQl0 Bug: 1014959 Change-Id: I4e5e2859d20e3f04cd477f65e23889d2aa5b37e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872013 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
M77 has reached stable and there have been no major issues with the new names. Bug: 968369 Change-Id: I2de8132b9ac233a982c3e0d01bafd1c53e80d412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816251Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts WebContentsNSViewHost and WebContentsNSViewHost from web_contents_ns_view_bridge.mojom to new Mojo types using PendingAssociatedRemote, PendingAssociatedReceiver, AssociatedReceiver, and AssociatedRemote. Bug: 955171 Change-Id: Ib6770e5030ee68c9882f7f5f2d3654e6cda79d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872215Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
kdillon authored
Change-Id: I9236718df91559319cc1e52992713a1ee0112952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822877Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708875}
-
Mohamed Heikal authored
Change-Id: I349a83d51452b4c55480fe079a7e1c732dd10f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876970Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708874}
-
Fergal Daly authored
All of these passed in this run on linux debug shards/0:Task: https://chromium-swarm.appspot.com/task?id=480b070d14519110 shards/1:Task: https://chromium-swarm.appspot.com/task?id=480b07300c6b9710 shards/2:Task: https://chromium-swarm.appspot.com/task?id=480b0756649ce610 shards/3:Task: https://chromium-swarm.appspot.com/task?id=480b0788b3c15e10 shards/4:Task: https://chromium-swarm.appspot.com/task?id=480b07cc5f172610 shards/5:Task: https://chromium-swarm.appspot.com/task?id=480b07d051ded010 shards/6:Task: https://chromium-swarm.appspot.com/task?id=480b0808d3319210 shards/7:Task: https://chromium-swarm.appspot.com/task?id=480b08113378bb10 shards/8:Task: https://chromium-swarm.appspot.com/task?id=480b084685625110 shards/9:Task: https://chromium-swarm.appspot.com/task?id=480b088bbb9ab510 and on android debug android-shards/0:Task: https://chromium-swarm.appspot.com/task?id=480adbf31c911d10 android-shards/1:Task: https://chromium-swarm.appspot.com/task?id=480adbfb629e4110 android-shards/2:Task: https://chromium-swarm.appspot.com/task?id=480addfec56a7110 android-shards/3:Task: https://chromium-swarm.appspot.com/task?id=480adbfe38c2a210 android-shards/4:Task: https://chromium-swarm.appspot.com/task?id=480ade00c0c16c10 android-shards/5:Task: https://chromium-swarm.appspot.com/task?id=480adbf515c64f10 android-shards/6:Task: https://chromium-swarm.appspot.com/task?id=480adbfcd1f37b10 android-shards/7:Task: https://chromium-swarm.appspot.com/task?id=480ade0fee6ffb10 android-shards/8:Task: https://chromium-swarm.appspot.com/task?id=480adbfe8d557810 android-shards/9:Task: https://chromium-swarm.appspot.com/task?id=480ade012ccd8a10 Sadly, I haven't figured out a nice way to aggregate these into friendly test reports. Tests noted as being flaky will be handled in a different CL. Change-Id: I84df1dc4be6efa13b911c2ae3232e76abd35b925 Bug: 1016230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862137Reviewed-by:
-
Aaron Colwell authored
- Create a common function for generating the killed_process_origin_lock crash key value so we get consistent results no matter what causes this key to get logged. - Introduce can_access_data_failure_reason crash key to make it easier to determine the reason for access failures. Citadel enforcement was trying to use the killed_process_origin_lock key to convey this info but that is no longer possible now that values for that key are consistent across all code paths. Bug: 1015882 Change-Id: I892ee47ca50ac1739eeebdbfb91425342df742dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876745 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708872}
-
Jinsuk Kim authored
AssertionError-based tests are not guaranteed to work. This CL changes the assertion exception used in UserDataHost class to runtime exceptions to make it test-friendly. Items tested in the tests now throw IllegalStateException or IllegalArgumentException. Bug: 877918 Change-Id: I0f1d8c7d9b49a7b8c4020bdfaaf3e15479110b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1192484 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708871}
-
Christopher Cameron authored
We are already doing this in the GPU process as the histogram Gpu.Metal.TestShaderCompileSucceeded. That histogram indicates that we fail to compile the shader from the GPU process within 6 seconds 2% of the time. The new histogram Browser.Metal.TestShaderCompileTime histograms the shader compile time, up to 1 minute, whereupon it uses the max bucket (3 minutes). Also add a DumpWithoutCrashing on timeout. This will have to be removed after one promotion to dev (to not drown out real crashers), but will help gather more information about crashing machine profiles. Move the test shader code into the metal_util component so that it can be used by both locations (the previous implementation was in /viz/). Bug: 974219 Change-Id: Ieeac67d7dcbef53d7e3cc257eca6ba9fccf94286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872624 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9988f9da4047..bf69ed0d31f4 git log 9988f9da4047..bf69ed0d31f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 sadrul@chromium.org uma-metric: Specify the bins for peak gpu memory usage metric. 2019-10-23 crouleau@chromium.org [Telemetry] Abridging a story set must come before shard indexing Created with: gclient setdep -r src/third_party/catapult@bf69ed0d31f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:908462,chromium:987273,chromium:965158 Change-Id: Ibd00bf8827a0ccae00a0ddfe470e3cc5a2fe8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877608Reviewed-by:
-
Charlene Yan authored
Bug: 901183 Change-Id: Iadae6a197d4e2842b285d4ea7ce7e632a771bd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867179 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708868}
-
Rouslan Solomakhin authored
Before this patch, a compromised renderer could read-write the instrument metadata for any origin. This patch ties the payment manager to the origin of its context. After this patch, cross-origin payment manager access should not be possible. Bug: 1011600 Change-Id: I22142bdca98de9c9334c0f5e62f9f0268cda8f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865770Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708867}
-
Collin Baker authored
Thumbnail sizes will soon be dynamic. WebUITabStripContainerView will need to resize itself when they change, so it needs to know how the tab strip will be layed out. This CL adds layout calculation logic in C++-side code so both the tab strip and the WebUITabStripContainerView can use it. Bug: 1013646 Change-Id: If45238985e304ec42721a96518b7f1afc264f256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872784 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3b63d6f..bbf7cb0e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idcb42373582b82f1baa529432cc60fde453384fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877367Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbaef603dece..fd1b164088d5 git log fbaef603dece..fd1b164088d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 herb@google.com Use common path drawing code Created with: gclient setdep -r src/third_party/skia@fd1b164088d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I2a96b727c7fc33eca267b9137e0a666f4aa04ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877428Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88a99e4382c1..b2885bc4a40f git log 88a99e4382c1..b2885bc4a40f --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Enable UpdateBufferInUse test on AMD 2019-10-23 xinyi.he@arm.com Vulkan: Mipmap is unconditionally enabled in ANGLE Created with: gclient setdep -r src/third_party/angle@b2885bc4a40f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I3b36d0ffca4cd0b0f61614e5ad576cdff1a4a41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877607Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7bf2eba2b5d..1faae79f67ac Created with: gclient setdep -r src-internal@1faae79f67ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia8adbe6e840ebf93accd8e3007c25a6dc80a6948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877391Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia3a734a764a952f565c3785bddf2a381774a96f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877430Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts CarrierPortalHandler to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I5ac9e2b0c40a7e0020af8cd2265bb64ece4b9c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871878Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactory from //content to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: I106caf8803c9897d6a671042bbc94d3f90a8450a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863933Reviewed-by:
-
