- 06 Jun, 2020 16 commits
-
-
sczs authored
Bug: 1054024 Change-Id: Ib20d303f75d06f3bb0c78132c7031fc54ff0da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233617Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#775817}
-
Charlene Yan authored
Bug: 1018230 Change-Id: Iae567776524a5850171c91ded1afa4e11b58d77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232798Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775816}
-
Gabriel Charette authored
PreventMessagePumpHangs will be used for further tweaks in followup CLs. In this CL, the first tweak avoids looking at sent-messages from ProcessPumpReplacementMessage as MPForUI's kMsgHaveWork message can never have taken precedence over a sent message. Processing them in PreventMessagePumpHangs only adds two more checks to that queue and a potential for hangs deeper in the stack since the PeekMessage that found kMsgHaveWork will already process sent-messages (twice) : https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-peekmessagea#remarks Example stack of this happening in the wild: https://pastebin.com/EKVqg2SN Also add a trace event for ::PeekMessage from ProcessPumpReplacementMessage and bump the work id as the docs claim it can still "process internal events". R=fdoray@chromium.org Bug: 1074019, 1075960 Change-Id: I110d314f6682a97748c62be16e8b5f3551a48a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228579Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#775815}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd37d6813a23..9a30664a3fdd 2020-06-05 jalyn@microsoft.com Add missing platform attributes to shortcuts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11a95e34e20354fa5b36645ef842aa5e3b8357c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775814}
-
Nate Chapin authored
Bug: 1091577 Test: html/semantics/scripting-1/the-template-element/template-element/template-construction-in-inactive-document-crash.html Change-Id: I226aec64092784834be3197bf7a78c99e0120949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232746 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#775813}
-
Adrienne Walker authored
This is a preliminary fix for this patch to require tokens: https://chromium-review.googlesource.com/c/chromium/src/+/2225477 That patch will require origin trial tokens for any use of appcache. This fixes up browsertests to include the tokens so that they keep running when that ptach lands. Bug: 582750 Change-Id: Idf686b0c6423e9a4458e72b608dfdfad311f049c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229642 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#775812}
-
Ethan Jimenez authored
1. Creating virtual test suite to run all the `css-grid` web tests from `fast/css-grid-layout` and `external/wpt/css/css-grid` using the new LayoutNG implementation. Test suite is individually disabled in order to progressively re-enable tests fixed by new changes. Bug: 1045599 Change-Id: Ia28d40e8ab75c3668910e66330658f52ffcf2595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227306 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#775811}
-
Yann Dago authored
Browsers installed under "C:\Program Files (x86)" remain in that directory and will continue to be updated. They must be uninstalled first to be reinstalled under "C:\Program Files". Bug: 380177 Change-Id: I45b8898ddf39dd7a5fe7e6e0ce258da313ea880f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204420 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#775810}
-
Sam Sebree authored
This change uses the calendar_picker_refresh.css to set correct dark mode styling for date time local native controls. Bug: 929098 Change-Id: I6daa542ed1148c782815eb392d6f65d58c3d1366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209406Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775809}
-
Devlin Cronin authored
base::Version is interesting. It is treated as (up to) four dot- separated integers. However, because these are parsed individually, leading zeros in each component are ignored. This leads to some interesting (potentially unexpected) behavior: - v1.01 is equivalent to v1.1 - v1.01's string representation is "1.1" - v1.02 is greater than v1.1 Additionally, leading zeros are not allowed in the first component, though they are allowed in subsequent components. That is, v01.1 is invalid. Add unittests to cover these cases, and make them more explicit. Bug: None Change-Id: Ia8cc6ec988fdef7f6c2b41c93e7468781a458591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233495Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775808}
-
Gyuyoung Kim authored
This CL applies mojo::PendingRemote to all uses of mojom::MidisClientPtr. Bug: 955171 Change-Id: Iade30d5473c8d812812dce9e6a105d668cccb3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228746Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#775807}
-
Sammie Quon authored
Popups like the wifi dialog are excluded from overview, but weren't being passed to the scoped object that handles hidding excluded windows. Fixed: ash_unittests OverviewControllerTest.ExcludedWindowsHidden Bug: 1000596 Change-Id: If52f2e3be2d99f483fd59c8b479a6aa0c0cdcece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228261 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#775806}
-
Frank Liberato authored
Bug: 1077645 Change-Id: Iabcd01be3f3899a80ad861e6389077c54de2e0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232776 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#775805}
-
Peng Huang authored
For some system, vulkan API version is geater than 1.1, but driver for the GPU is less then 1.1. In this cass, calling vkGetPhysicalDeviceFeatures2() for that GPU will crash. Fix the crash by skip vkGetPhysicalDeviceFeatures2() for that GPU. Later, when we are creating VulkanDeviceQueue, we will skip that GPU. Bug: 1091196 Change-Id: Ic5572a9a29842b484850908689d0e5d2c4382afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233685Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775804}
-
John Chen authored
This reverts commit 7a07674d. Reason for revert: Causing build errors on perf waterfall (crbug.com/1091991) Original change's description: > Add resource_sizes targets for webview bundle & trichrome > > Bug: 1091256 > Change-Id: I244afe4d9735901937b39c0d0c554eddaf88eace > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230493 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775727} TBR=torne@chromium.org,agrieve@chromium.org,benmason@chromium.org Change-Id: Id9ac2e4f9ec7fc9eb0c2b3a6761ca2a822d8b242 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091256, 1091991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233860Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775803}
-
Sophey Dong authored
Bug: 1079467 Change-Id: Ied01eab041229533706b9bcf2a6164476b4d65bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219147 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#775802}
-
- 05 Jun, 2020 24 commits
-
-
Lijin Shen authored
As per offline discussion, add lazzzis@ to owner list of android ui color resources. Bug: NONE Change-Id: I077a18324b4be0ae5170c2b5a87b58e6cbeab4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233195Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#775801}
-
Andrew Xu authored
Currently the bounds animation of status area widget is disabled if the target bounds have the different size from the current bounds. Based on https://crrev.com/c/2158911, it aims to disable the animation when tray items are added/removed. However. we do have a scenario where the status area widget's bounds change meanwhile it does not involve the tray item's movement: when entering/exiting overview mode in tablet, the status area widget's height changes. In this CL, StatusAreaWidget::LayoutInputs has a new attribute to indicate whether animation is allowed. The animation is banned if the status area widget's length on the main axis (that is the width for horizontal shelf or the height for vertical shelf) changes. Bug: 1079347 Change-Id: I9190168b40af6e88bf774e1f98c7a0de0467be7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227099 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#775800}
-
Abhijeet Singh authored
Currently, an active impression is approximated by whenever the menu or the Quick Answer is dismissed without clicking on a menu-item. This indicates user could be actively looking for Quick-Answers instead of any other menu operation. This is currently buggy because DismissQuickAnswers() overcounts the metric even when a Quick-Answer was not shown to the user (because the User-Consent view was shown instead). This CL ensures that the metric is not overcounted by fixing that, and also ensures this change will not lead to under-counting by routing the view-close operations via DismissQuickAnswers() where logging happens. Bug: b:158265647 Test: Tested on Chrome OS VM. Change-Id: Ieed9356fbb64650b521c893a44e83caa49ea831e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233342Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#775799}
-
Daniel Rubery authored
We should not do malware deep scanning for files that the metadata check identifies as DANGEROUS_HOST Bug: 1085182 Change-Id: I7324ccb11a560b33d2be83f65cdc2f4ab71c55a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233340 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#775798}
-
Robbie McElrath authored
This CL just tests that the activity launches. Bug: 1049683 Change-Id: I22ac17028eb34d3effb3d69474971972c9959430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219347 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#775797}
-
Bo Liu authored
Bottom control positioning depends on knowing the surface size, but is not informed of surface size changes. This CL adds the bottom controls as a listener on ContentViewRenderView. Also query java for the controls offset. Bug: 1091717 Change-Id: I2c1ec6be7d1dd470e21590c66b09b4f99dbfe5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232753Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775796}
-
Jon Mann authored
Any networks that are added during OOBE should be considered to be owned by first user to log in for the purposes of sync. Bug: 966270 Change-Id: I04495ee36c93cd4ae652e1cf45cfaafaf31224fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231859Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#775795}
-
Stephen Roe authored
Bug: 1042511 Change-Id: If15c4d9afa07f9f0d7d467f32a49cd92986a5e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233006Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#775794}
-
Sorin Jianu authored
Without the change, the prefs changes made by the update client were never persisted, since the process terminated before such changes were lazily committed by the prefs service. With the change, the prefs are committed with each update complete notification for any app. They are also committed when the Stop() function is called. Since the ComServer is a leaky singleton, the implementation of Stop() acts like a finalizer, and resets the members of the ComServer instance. Bug: 1091532 Change-Id: I07dd0b3d989ad383a0a39e43ed6d47164c389d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233609Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775793}
-
Ionel Popescu authored
This CL updates the select behavior for Enter key to pre-M83 where: 1. on Mac, Enter key submits the form 2. on other platforms, Enter key opens the popup Bug: 1087503 Change-Id: Id3ca7171cc752e01db3c8c9bc23bbbb0a067d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231456 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#775792}
-
Joey Arhar authored
I added this test to fast/ without thinking about it, and it got flagged for being a new test not in wpt. The -crash.html should make wpt recognize it as a "crash test": https://web-platform-tests.org/writing-tests/crashtest.html Change-Id: Ia424f0f407dba48b0a7bf87331a6843fb3b13e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231867Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#775791}
-
Fergal Daly authored
- make some things constructor parameters previous were poked in after construction - move nav_entry_id_ so that all the entry-dependent initializers were together - drive-by fix 1 typo - move things around a little for initiator_routing_id_ - use make_unique instead of new in 1 spot I'm pretty sure this is a no-op although there may be ordering issues that I didn't spot. Change-Id: Ice1e0d53f2351795da109047d4d16fd1776d3db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230181 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775790}
-
Rainhard Findling authored
* When navigating to a Settings subpage from safety check, clear the search term so that content on the subpage is not hidden by it. Bug: 1085422 Change-Id: I8caf29cc417e7af69fa2981d444e580c0963bac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230483 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#775789}
-
Xing Liu authored
This CL passes download later data through DownloadDialogBridge. Bug: 1078454 Change-Id: Idd2cbbded85ce25e630bf37ad523254cfec9265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233361Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775788}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63973bb2e9cc540e0295a0a94482977ed91e0b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775787}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e32669d4cb17..ca8f75a8db60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085525 Tbr: yigu@google.com,tbansal@google.com Change-Id: Ifb54c8700ae9680d35e7f7f9c75cbe05dc2f0aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232796Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775786}
-
James Cook authored
This is the "V1" feature. It: - Creates a new "Sync your settings" section in Chrome OS settings - Moves app, wallpaper and Wi-Fi sync to OS settings - Provides a separate toggle for OS preferences, distinct from browser preferences - Makes the OS ModelTypes run in sync transport mode, controlled by a master pref for the OS sync feature - Updates the OOBE sync consent screen NOTE: The feature is rolling out via a client-side Finch trial, so the actual state will vary. See config in chrome/browser/chromeos/sync/split_settings_sync_field_trial.cc Bug: 1013466 Change-Id: Ie84b193cd7c298387245f1c32f868b04731fb0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#775785}
-
Erik Chen authored
Previously, the log was dumped to a file with the current timestamp. This proved unwieldy. Now we always log to the same file, and delete it if lacros is launching for the first time. Change-Id: I1a5d321abf14e62e1cc8464b0d3a36647f0cdd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227438 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775784}
-
Finnur Thorarinsson authored
UX designer (after review meeting) requested a few things changed with regards to how the overlay controls animate. - Animation timings and delays should be according to spec. Most importantly, controls should be brought into view fast and fade out of view somewhat slower with one exception: - Play button should animate away much faster than the other controls in cases where the user's focus is on the video playing. - Tapping on the video area should show the controls if hidden and hide them if showing (current implementation always brings overlay controls into view on tap, or extends their time on-screen if already showing). BUG: 895776, 656015 Change-Id: I88ec9078a6546c1eea3adf43d8cf7f027d921159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210232 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#775783}
-
Yi Gu authored
The test is flaky on Linux MSAN build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/6163 TBR=aaronhk@chromium.org NOTRY=TRUE Bug: 1091948 Change-Id: I8d5318ec259677167818323082259dde2f7f12a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233720Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775782}
-
Xianzhu Wang authored
The filter-with-PaintOffsetTranslation (crrev.com/c/2227621) broke http/tests/devtools/layers/layer-compositing-reasons.js because the element with reflection containing composited descendant now has a different transform node. BTW remove expectation entries for tests that are passing. Change-Id: I5d2e8af77d0d559c5e24f5983c380810d0c36d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232748Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775781}
-
danakj authored
The test seems to not be flaky any more with improvements made to the web test harness for site isolation. If wrong.. we can revert and investigate. Local run of 50 runs had 0 failures and TestExpectations claims it was very flaky. R=vmpstr@chromium.org Bug: 891427 Change-Id: I79ff5e5ed81745dfde6f34d584f4baa1ce0bcd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233498Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775780}
-
Richard Townsend authored
Removes a section of code which was creating a new Tokenizer. Later attempts to retrieve content from the BackgroundHTMLParser were possibly asserting based on this. Also improves scheduling check to make sure that the parser doesn't accidentally defer work when it shouldn't. Bug: 901056, 1087325, 1087032 Change-Id: I9b6de16748a713196bf26438eb4f1bfe001cb999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230491Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#775779}
-
danakj authored
The test is marked as failing only on mac, but also has mac-only expectations with FAIL lines in them. Recent failure on the mac bot have been of the test passing. R=vmpstr@chromium.org NOTRY=true Bug: 891427 Change-Id: I252e50e365bda896ddd1157c576faf8ac7fac581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232770 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775778}
-