- 04 Mar, 2015 40 commits
-
-
machenbach authored
Summary of changes available at: https://chromium.googlesource.com/chromium/deps/icu/+log/db16fd8..eda9e75 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/977043004 Cr-Commit-Position: refs/heads/master@{#319073}
-
Paweł Hajdan, Jr authored
BUG=460949 R=jochen@chromium.org Review URL: https://codereview.chromium.org/977593007 Cr-Commit-Position: refs/heads/master@{#319072}
-
sdefresne authored
Delegate to the embedder the decision to filter URLs to add to the history through the HistoryClient defaulting to registering all URLs (in the base class implementation but also when there is no HistoryClient during tests). BUG=390953 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/971423002 Cr-Commit-Position: refs/heads/master@{#319071}
-
blundell authored
This CL is a companion to https://codereview.chromium.org/945423002, and will allow a server app to serve apps that were uploaded to the Mojo bucket in GS from Chromium without having to know anything about these apps in particular. Review URL: https://codereview.chromium.org/956593003 Cr-Commit-Position: refs/heads/master@{#319070}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/20c53c8..96cd5bb TBR=samli@chromium.org Review URL: https://codereview.chromium.org/969913003 Cr-Commit-Position: refs/heads/master@{#319069}
-
tobiasjs authored
onFailure is only invoked when the render frame has been destroyed, but it is not really useful to distinguish onComplete from onFailure in that case. This also addresses the feedback that we received from API Council. This is a resubmit of CL 943633003 BUG=459539, 457184 Review URL: https://codereview.chromium.org/974483002 Cr-Commit-Position: refs/heads/master@{#319068}
-
hanxi authored
- Introduce WebUIInjectionHost class and plumb InjectionHost interface to replace Extension in script injection system in the render. - Store InjectionHost in ScriptInjection to avoid constructing InjectionHost objects everywhere. BUG=459234 Review URL: https://codereview.chromium.org/934763003 Cr-Commit-Position: refs/heads/master@{#319067}
-
vabr authored
This CL adds default values to config parameters for running the Python tests of password manager. It also corrects a typo (parrallel -> parallel). R=engedy@chromium.org BUG=463504 Review URL: https://codereview.chromium.org/977043003 Cr-Commit-Position: refs/heads/master@{#319066}
-
Paweł Hajdan, Jr authored
BUG=460949 R=primiano@chromium.org Review URL: https://codereview.chromium.org/964873005 Cr-Commit-Position: refs/heads/master@{#319065}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#319064}
-
pfeldman authored
BUG=463892 TBR=dgozman Review URL: https://codereview.chromium.org/979793002 Cr-Commit-Position: refs/heads/master@{#319063}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01e2ba6e..9ff21de5 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/982523002 Cr-Commit-Position: refs/heads/master@{#319062}
-
mnaganov authored
When a script modifies page source of a non-committed page, we need to notify clients, so they can update the URL bar to avoid confusion. New logic since the last attempt (https://codereview.chromium.org/924833003/): distinguish between a "vanilla" WebView state (basically, a newly created WebView, where no loading attempts have been made) and an "attempted to navigate" state. In the "vanilla" state, don't fire synthesized page loading events to avoid confusing clients. This is safe, as WebView is guaranteed to be on a blank page. Implementation note: we detect navigation attempts using didStartProvisionalLoadForFrame WebContentsObserver event on the Java side. As for popups AwWebContentsObserver gets re-attached from the original popup WebView to the one provided by the client, notifications issued inbetween can be missed on the Java side. To work around this, we assume that WebViews opened as popups can never be in "vanilla" state (as they are anyway opened as a result of navigation). BUG=458569,462213 TBR=davidben@chromium.org,tedchoc@chromium.org Review URL: https://codereview.chromium.org/970883002 Cr-Commit-Position: refs/heads/master@{#319061}
-
rijubrata.bhaumik authored
TEST= http://jsfiddle.net/73v8rmex/3/ (manual) BUG=336424 Review URL: https://codereview.chromium.org/754963006 Cr-Commit-Position: refs/heads/master@{#319060}
-
kcwu authored
Note this CL depends on s5p-mfc kernel driver fix https://chromium.googlesource.com/chromiumos/third_party/kernel/+/090b79f, which is available since 6840.0.0 Otherwise exynos chromeos will crash. BUG=chromium:449920 TEST=apprtc loopback with resolution 640x354 on peach pit; run run video_VideoSanity Review URL: https://codereview.chromium.org/972063002 Cr-Commit-Position: refs/heads/master@{#319059}
-
dzhioev authored
In case when GN output dir is inside src/, GN uses pathes relative to src/ directory that start with // (//out/Release/gen). But python interprets such pathes as relative to /. BUG=459230 Review URL: https://codereview.chromium.org/973873003 Cr-Commit-Position: refs/heads/master@{#319058}
-
yawano authored
Summary of changes available at: https://chromium.googlesource.com/chromiumos/platform/system_api/+log/01a9492..c5bdf10 BUG=413541 TEST=none Review URL: https://codereview.chromium.org/977593006 Cr-Commit-Position: refs/heads/master@{#319057}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/327fcc4..20c53c8 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/974913005 Cr-Commit-Position: refs/heads/master@{#319056}
-
treib authored
Followup to https://codereview.chromium.org/850283003. BUG=397951 Review URL: https://codereview.chromium.org/968183002 Cr-Commit-Position: refs/heads/master@{#319055}
-
shiva.jm authored
BUG= Review URL: https://codereview.chromium.org/974243002 Cr-Commit-Position: refs/heads/master@{#319054}
-
finnur authored
BUG=463854 NOTRY=true TBR=rkc Review URL: https://codereview.chromium.org/971613003 Cr-Commit-Position: refs/heads/master@{#319053}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b317635..327fcc4 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/976033002 Cr-Commit-Position: refs/heads/master@{#319052}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea02c333..01e2ba6e Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/966723005 Cr-Commit-Position: refs/heads/master@{#319051}
-
aberent authored
TBR=jamesr@chromium.org BUG=463852 Review URL: https://codereview.chromium.org/982513002 Cr-Commit-Position: refs/heads/master@{#319050}
-
carlosk authored
This CL adapts several test classes with changes due now that the IPCS for beforeUnload ack and renderer navigation requests are not one and the same anymore. BUG=440266 Review URL: https://codereview.chromium.org/953503002 Cr-Commit-Position: refs/heads/master@{#319049}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/467060f..b317635 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/982503002 Cr-Commit-Position: refs/heads/master@{#319048}
-
hirono authored
Previously the thumbnail metadata is obtained as a part of old metadata. The CL adds thumbnailMetadataItem to GalleryItem, and remove old metadata models from Gallery. BUG=410766 TEST=None Review URL: https://codereview.chromium.org/976713004 Cr-Commit-Position: refs/heads/master@{#319047}
-
finnur authored
Revert of Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #1 id:1 of https://codereview.chromium.org/981473003/) Reason for revert: Hmmm... My revert did not fix the test, so I'm undoing it. :/ Original issue's description: > Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/) > > Reason for revert: > Audio tests started failing consistently in the next build after this was checked in. See: > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762 > > Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem. > > Error: > [ RUN ] AudioRecorderTest.BasicRecordAndStop > ../../components/audio_modem/audio_recorder_unittest.cc:203: Failure > Value of: IsRecording() > Actual: false > Expected: true > ../../components/audio_modem/audio_recorder_unittest.cc:208: Failure > Value of: IsRecording() > Actual: false > Expected: true > ../../components/audio_modem/audio_recorder_unittest.cc:213: Failure > Value of: IsRecording() > Actual: false > Expected: true > [ FAILED ] AudioRecorderTest.BasicRecordAndStop (1292 ms) > > Original issue's description: > > Chromecast: Play audio streams not supported by CMA via default renderer > > > > For Chromecast we want to choose which media renderer to use based on > > the types of input content streams. We will use CMA media renderer for > > media types that are supported by our hardware (H264, AAC, etc) and > > will use the default media renderer for audio streams other than AAC > > or Vorbis. This will allow us support software decoding of FLAC and > > Opus via the default Chrome audio path. > > > > BUG=457959 > > > > Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276 > > Cr-Commit-Position: refs/heads/master@{#318941} > > TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=457959 > > Committed: https://crrev.com/ee687fd9c6c2bc41642cd8b65de87fe548a3cf75 > Cr-Commit-Position: refs/heads/master@{#319033} TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457959 Review URL: https://codereview.chromium.org/967933003 Cr-Commit-Position: refs/heads/master@{#319046}
-
benwells authored
These are flaky on various platforms for app windows; outerBounds is preferred. BUG=453707 Review URL: https://codereview.chromium.org/976563002 Cr-Commit-Position: refs/heads/master@{#319045}
-
xiang.long authored
1. Register client to quota manager after it is initialized. As the ServiceWorker cache storage is not affected during DB recovery we don't need to create a new ServiceWorkerCacheStorageManager. 2. Ongoing register jobs could be aborted by DB recovery. BUG=none Review URL: https://codereview.chromium.org/943333007 Cr-Commit-Position: refs/heads/master@{#319044}
-
hirono authored
Previously if MetadataProvider fails to fetch metaata, there is no way to check if the entry does not have a property or it fails to obtain the metadata. The CL adds error fields to MetadataItem, which are cached with corresponding property. BUG=410766 TEST=FileManagerJsTest.MetadataCacheItem Review URL: https://codereview.chromium.org/977873002 Cr-Commit-Position: refs/heads/master@{#319043}
-
jif authored
BUG=None. Review URL: https://codereview.chromium.org/961673004 Cr-Commit-Position: refs/heads/master@{#319042}
-
mtomasz authored
IsAborted() and Remove() were removed, and semantics of Abort() simplified. TEST=unit_tests: *FileSystemProvider* BUG=463344 Review URL: https://codereview.chromium.org/971303003 Cr-Commit-Position: refs/heads/master@{#319041}
-
arjanl authored
Whether the context menu appears on mouse up can depend on run-time settings (in the case of Opera). This reads the setting to WebPreferences, so that the browser has the possibility of communicating the appropriate setting to the renderer. If not explicitly set, it defaults, as before, to 'true' on Windows and 'false' on other platforms. BUG= Review URL: https://codereview.chromium.org/819293002 Cr-Commit-Position: refs/heads/master@{#319040}
-
hirono authored
BUG=410766 TEST=None Review URL: https://codereview.chromium.org/971173002 Cr-Commit-Position: refs/heads/master@{#319039}
-
kelvinp authored
The HostTableEntry is currently shared between the local host section and the host list. However, they have slightly different creation behavior. For one, the DOM is generated on the fly for the HostList whereas the local host section has its DOM hard coded in the ui_me2me.html. In addition, the existing HostTableEntry expects the host to be passed in during construction time. This is slightly awkward for the LocalHostSection as the host is null until the local host has started. After the refactoring, the HostTableEntry generates the DOM in its constructor. The host is passed in via the setHost() function that updates the DOM using querySelector and innerText. The refactor also combines updateStatus() and setHostName() into once single function updateUI() that refreshes the UI based on the underlying state (the host). This CL also separates the local host section in the hostlist into its own class. BUG=461539 Review URL: https://codereview.chromium.org/944183002 Cr-Commit-Position: refs/heads/master@{#319038}
-
finnur authored
Revert of Add new test: DownloadTest.TestMultipleDownloadsBubble (patchset #2 id:40001 of https://codereview.chromium.org/976823002/) Reason for revert: New test added is flaky. Sorry. :) https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21829 [ RUN ] DownloadTest.TestMultipleDownloadsBubble [3840:2828:0303/224822:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup HTTP server started on http://127.0.0.1:54250... sending server_data: {"host": "127.0.0.1", "port": 54250} (36 bytes) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\download\download_browsertest.cc(2974): error: Value of: mock_bubble_view->IsVisible() Actual: false Expected: true Original issue's description: > Add new test: DownloadTest.TestMultipleDownloadsBubble > > This ensures that both infobars and bubbles are tested by creating both > DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. > TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is > forced with a switch. > > BUG=438758 > > Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 > Cr-Commit-Position: refs/heads/master@{#318987} TBR=asanka@chromium.org,felt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=438758 Review URL: https://codereview.chromium.org/977863002 Cr-Commit-Position: refs/heads/master@{#319037}
-
mgiuca authored
The CHECK-fail was introduced in r315272 (64121b7f), which switched the app list to run with the "original profile" rather than the incognito profile. Partially reverted that CL so that the app list runs with the incognito profile, and fixed StartPageService to correctly use the incognito profile (rather than being null when the app list profile is incognito), which addresses the original issue (http://crbug.com/440484). Had to work around DCHECK on shutdown in StartPageService due to crbug.com/463419. Added a DCHECK to catch use of non-incognito profiles in guest mode early (without having to select a search result to trigger the crash). Added AppListControllerGuestModeBrowserTest to test opening the app list in guest mode. BUG=460437,440484 Review URL: https://codereview.chromium.org/976553003 Cr-Commit-Position: refs/heads/master@{#319036}
-
tmoniuszko authored
BUG= Committed: https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b Cr-Commit-Position: refs/heads/master@{#318859} Review URL: https://codereview.chromium.org/965713002 Cr-Commit-Position: refs/heads/master@{#319035}
-
finnur authored
Revert of Fix BluetoothAdapterProfileChromeOS lifecycle management (patchset #7 id:120001 of https://codereview.chromium.org/935383003/) Reason for revert: Leaks detected. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/7185 ================================================================= ==22324==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0x901bd6 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:7 #2 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #3 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #4 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #5 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #6 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #7 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #8 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #9 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #10 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #11 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #12 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #13 0x80ad38 in Run base/callback.h:396:12 #14 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #15 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #16 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #17 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Indirect leak of 93 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0x7f35c92df739 in __gnu_cxx::new_allocator<char>::allocate(unsigned long, void const*) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/ext/new_allocator.h:92 #2 0x7f35c92ded2c in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:609 #3 0x7f35c92def04 in std::string::_Rep::_M_clone(std::allocator<char> const&, unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:631 #4 0x7f35c92dbc48 in std::string::reserve(unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:512 #5 0x9021d7 in operator+<char, std::char_traits<char>, std::allocator<char> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.tcc:702:7 #6 0x9021d7 in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:47 #7 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11 #8 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #9 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #10 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #11 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #12 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #13 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #14 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #15 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #16 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #17 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #18 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #19 0x80ad38 in Run base/callback.h:396:12 #20 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #21 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #22 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #23 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0xd9c743 in chromeos::BluetoothProfileServiceProvider::Create(dbus::Bus*, dbus::ObjectPath const&, chromeos::BluetoothProfileServiceProvider::Delegate*) chromeos/dbus/bluetooth_profile_service_provider.cc:251:12 #2 0x90227f in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:51:7 #3 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11 #4 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #5 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #6 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #7 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #8 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #9 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #10 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #11 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #12 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #13 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #14 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #15 0x80ad38 in Run base/callback.h:396:12 #16 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #17 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #18 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #19 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Fix BluetoothAdapterProfileChromeOS lifecycle management > > Have BluetoothAdapterProfileChromeOS remove itself from adapters when it > is deleted via it's deconstructor, to avoid references being left behind > after deletion. > > BUG=457978 > > Committed: https://crrev.com/0cca591aaf6f6a0cbf46840faaead236dd8317a2 > Cr-Commit-Position: refs/heads/master@{#318925} TBR=keybuk@chromium.org,isherman@chromium.org,armansito@chromium.org,stgao@chromium.org,jamuraa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457978 Review URL: https://codereview.chromium.org/975323002 Cr-Commit-Position: refs/heads/master@{#319034}
-