- 30 Jul, 2017 5 commits
-
-
meade_UTC10 authored
This reverts commit 1d8d254c. Reason for revert: Broke ProcessMemoryMetricsEmitterTest.FetchDuringTrace ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics ProcessMemoryMetricsEmitterTest.FetchThreeTimes on chromium.win/Win7 Tests (dbg)(1) First broken run: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933 Original change's description: > Plumb URLs through memory_instrumentation UKMs. > > The URLs are obtained by creating a new interface CoordinationUnitIntrospector > on the resource_coordinator service. The implementation of this interface crawls > all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by > looking at associated FrameCoordinationUnits. > > The interface for memory_instrumentation is modified slightly to include pid in > ProcessMemoryDump to allow correlation between the memory dump and the URLs > obtained from resource_coordinator. In a hypothetical future world where > memory_instrumentation and resource_coordinator live in the same service, this > can be removed. > > Bug:730783 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 > Reviewed-on: https://chromium-review.googlesource.com/578482 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490668} TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org Change-Id: I07a942b89aa22dcddd924fdcaeda025b6484b4eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730783,750476 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/593267Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490682}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: If5f382894c71980166de8f73a82a763c03e7c31f Reviewed-on: https://chromium-review.googlesource.com/593210Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490681}
-
Florin Malita authored
BUG=630695 TBR= Change-Id: I98783ed2a818cdf744c9d1652094648e79d06417 Reviewed-on: https://chromium-review.googlesource.com/593149Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#490680}
-
weili authored
Add a return status code to avoid aborting the service upon any error. Mojo verifies the validity of returned handle, will exit it is not valid. Also add unit test for this service. BUG=chromium:455764 Review-Url: https://codereview.chromium.org/2919823004 Cr-Commit-Position: refs/heads/master@{#490679}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/28a586966d58..77c6866668ac $ git log 28a586966..77c686666 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Remove stale SkTwoPointConicalGradient assert 2017-07-29 fmalita Don't instantiate degenerate 2pt gradients Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ie246fb31808c2bc4dd00bc713457e4c16c6c6e98 Reviewed-on: https://chromium-review.googlesource.com/593189Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490678}
-
- 29 Jul, 2017 35 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/93fe0ccd240c..28a586966d58 $ git log 93fe0ccd2..28a586966 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Remove now-dead SK_SUPPORT_LEGACY_GRADIENT_MATRIX_MATH code Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I7295cb3046712f64273a5b07d6685f9bea97a955 Reviewed-on: https://chromium-review.googlesource.com/592533Reviewed-by:
-
Nico Weber authored
The major blockers for this were that gcc+libc++ (android) and clang+libstdc++4.8 (linux) didn't compile in this mode. We've since switched android from gcc to clang, and linux from libstdc++ to libc++, so this works fine everywhere now. Off-waterfall bots setting `enable_custom_libcxx` to false need to make sure that they use a libstdc++ newer than 4.8 (like the simplechrome chromeos bots), else they'll get build errors -- see the blocker bugs of the linked bug below. We'll use the same process for C++14 that we used for C++11, we'll list new features at http://chromium-cpp.appspot.com/, disallow everything at first, and then allow things over time. So don't use any C++14 stuff for now. This doesn't affect the Windows bots; cl.exe (and clang-cl.exe) have implicitly always allowed C++14. Bug: 554717 Change-Id: Ibf2a19168a35b5aad2449af9abdc44a56997aeef Reviewed-on: https://chromium-review.googlesource.com/583635Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490676}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5f9b59b52db2..93fe0ccd240c $ git log 5f9b59b52..93fe0ccd2 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 liyuqian Enable delta AA by default Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I15c28e1c4d86b9380d80cff8c8b406cd0410b6e2 Reviewed-on: https://chromium-review.googlesource.com/592703Reviewed-by:
-
Wei Li authored
PrintWebFrameHelp will be a better name since this class is associated with render frame, not web view anymore. This CL changes the class name. BUG=chromium:666548 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4843fa611509d5def25a838f555a9ab47f37203d Reviewed-on: https://chromium-review.googlesource.com/583583 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#490674}
-
Wenzhao Zang authored
As a follow-up of CL 572144, some redundant dependency needs to be removed. Please see the bug and the error log for more details. Bug: 750260 Change-Id: I00ef044160cd90aac8e39b23144eef21f29a7d31 Reviewed-on: https://chromium-review.googlesource.com/592328Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#490673}
-
Biao She authored
Remove usage of SequencedWorkerPool::GetNamedSequenceToken from WallpaperApi and WallpaperPrivateApi SequencedWorkerPool is being deprecated in favor of TaskScheduler. Bug: 667892 Change-Id: Id4b1bdfba4b5f004bea8985925f23d5211016280 Reviewed-on: https://chromium-review.googlesource.com/561657 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#490672}
-
wutao authored
Force use of render surface and cache it when there is no damage from contributing contents. This will allow us to create a caching mechanism that is simple to maintain and provides the benefits needed to make the Chrome OS UI fast. BUG=708513 TEST=manual && new damage_tracker_unittests && surface_aggregator_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2873593002 Cr-Commit-Position: refs/heads/master@{#490671}
-
Florin Malita authored
(SK_SUPPORT_LEGACY_GRADIENT_MATRIX_MATH) Change-Id: I99305d8dc64a7e4c90baaa6c3b64d907c0469284 Reviewed-on: https://chromium-review.googlesource.com/586633 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#490670}
-
Aaron Leventhal authored
We need to look for extra enums in automation.idl that are not reflected in ax_enums.idl. Bug: None Change-Id: I7cf93697f5c09fc48606b787f6ff8b3cb71081f2 Reviewed-on: https://chromium-review.googlesource.com/592054 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#490669}
-
Erik Chen authored
The URLs are obtained by creating a new interface CoordinationUnitIntrospector on the resource_coordinator service. The implementation of this interface crawls all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by looking at associated FrameCoordinationUnits. The interface for memory_instrumentation is modified slightly to include pid in ProcessMemoryDump to allow correlation between the memory dump and the URLs obtained from resource_coordinator. In a hypothetical future world where memory_instrumentation and resource_coordinator live in the same service, this can be removed. Bug:730783 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 Reviewed-on: https://chromium-review.googlesource.com/578482 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490668}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4e622d7..bf07eadc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I25619a59551ba72f9e3474ef32ab5d4a945b581a Reviewed-on: https://chromium-review.googlesource.com/592949Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490667}
-
ananta authored
To achieve this the following changes were done. 1. The URLLoaderRequestHandler which is implemented by the navigation request handlers like AppCache/ServiceWorker, etc now has the following method MaybeCreateLoaderForResponse(). AppCache returns fallback content for the response passed in if applicable. 2. The AppCacheRequestHandler class which implements the URLLoaderRequestHandler interface implements the above method. It uses the MaybeLoadFallbackForResponse() function to potentially return fallback content. The difference between fallback handling for subresources and the frame is a new job is created for the latter. The MaybeCreateJobForFallback() function has been updated with this check. 3. The URLLoaderRequestController class which handles top level navigations now provides functionality to invoke the registered handlers when it receives a response. This is only done if the request was sent to the default network loader. A boolean flag default_loader_used_ is used to track this. If this is set we invoke the registered handlers and pass in the bound URLLoaderClient and the request to the handlers which enables them to bind to the connection. 4. We don't use the throttling URL loader for this case. This is fine because the main URL would already have been checked by the throtting URL loader when it was sent to the network service. Added a function DisconnectClient() to the throttling URL loader which disconnects the client from the network service in case we are passing fallback content to the client. BUG=715632 Review-Url: https://codereview.chromium.org/2982363002 Cr-Commit-Position: refs/heads/master@{#490666}
-
Nico Weber authored
One just needs a rebaseline, the other looks like a renderer crash we need to look into. TBR=hans@chromium.org Bug: 750447,750447 Change-Id: Ifc03635c48d70eda70c8113bf2b875e6a8572619 Reviewed-on: https://chromium-review.googlesource.com/593127Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490665}
-
Uzair Jaleel authored
PepperFileSystemHost already inherits SupportsWeakPtr. Hence, instead of creating a WeakPtrFactory instance to access its weak pointer, we can directly use AsWeakPtr(). BUG=None Change-Id: I97e716d9ceb479e02ae7b80ea77fe1eaf7bf28b0 Reviewed-on: https://chromium-review.googlesource.com/590342Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#490664}
-
Mircea Trofin authored
This reverts commit 0278717e. Reason for revert: Fixed leak by moving ownership of promise (when streaming has started) on the V8 side. Blink is still responsible, and owns, promises in setup error cases (like invalid MIME). Original change's description: > Revert "[wasm] Response APIs: use promise-based module building API" > > This reverts commit 2f3d3147. > > Reason for revert: Suspected cause of failures on WebKit Linux Trusty Leak bot : > Unexpected Failures: > * http/tests/wasm_streaming/wasm_response_apis.html > * virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html > * virtual/mojo-loading/http/tests/wasm_streaming/wasm_response_apis.html > > First failure: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/7364 > > Original change's description: > > [wasm] Response APIs: use promise-based module building API > > > > The first implementation of the response-based APIs used > > sync compile as an implementation detail. As we're getting close > > to having a true streaming implementation, we're switching to > > a promise-based API, closer in shape and implementation to the > > final design. > > > > What differs from true streaming is that the implementation, just > > like before this change, still pre buffers data before starting > > compilation. The difference in this CL is that compilation is > > asynchronous, and is responsible for resolving/rejecting the promise. > > > > The case of network error is where we expect differences in the final > > implementation. Currently, no compilation is started, and the > > blink side rejects the promise. When we move to true streaming, > > we'll need to explicitly signal to the v8 side when the download is > > dropped, and probably let it (v8 side) reject the promise. > > > > Also added a regression test for v8:6619, which is implicitly fixed by > > the new design. > > > > > > Bug: chromium:747396 > > Bug: v8:6619 > > Change-Id: Ic47c948a7cd001e07926ee4d0ae70669bab680bb > > Reviewed-on: https://chromium-review.googlesource.com/580788 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#490111} > > TBR=bradnelson@chromium.org,haraken@chromium.org,mtrofin@chromium.org,ahaas@chromium.org > > Change-Id: I6a7fdb9b3d49d2fb26bc070f99ba6d4247f0f04f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:747396, v8:6619 > Reviewed-on: https://chromium-review.googlesource.com/590389 > Commit-Queue: meade_UTC10 <meade@chromium.org> > Reviewed-by: meade_UTC10 <meade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490175} TBR=bradnelson@chromium.org,haraken@chromium.org,mtrofin@chromium.org,ahaas@chromium.org,meade@chromium.org Change-Id: I45d883fabf294efdcab87e5eb18ea7879a054aa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:747396, v8:6619 Reviewed-on: https://chromium-review.googlesource.com/591053 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#490663}
-
Catherine Mullings authored
Currently, if there are multiple radio buttons in a context menu and an unchecked button is updated to checked, nothing happens. Instead what should happen is that the updated radio button should be checked, and all other radio buttons should be unchecked. This CL implements this fix. Bug: 129421 Change-Id: Ic2301a7191efef6a4a712ab400339e897cb6a5cb Reviewed-on: https://chromium-review.googlesource.com/576271 Commit-Queue: catmullings <catmullings@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#490662}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/31981ecdcb37..5f9b59b52db2 $ git log 31981ecdc..5f9b59b52 --date=short --no-merges --format='%ad %ae %s' 2017-07-27 mtklein use new Stage ABI for ARMv7 too Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I2b6d8ef4ccca1cb83291ddc237e51b09bd1355eb Reviewed-on: https://chromium-review.googlesource.com/592552Reviewed-by:
-
Rob Buis authored
Bug: 402536 Change-Id: I7d522b7aaef1654aa9931689b9b45397f43bcf8d Reviewed-on: https://chromium-review.googlesource.com/591867Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#490660}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 65b35725. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/393 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I9bfb5e85df5acba4fcd6f5e2340e05e607a9b188 Reviewed-on: https://chromium-review.googlesource.com/592912 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490659}
-
Miguel Casas-Sanchez authored
On ToT, RenderThreadImpl creates one "remote" mojom::VideoEncodeAcceleratorPtr on main render thread and gives it to GpuVideoAcceleratorFactoriesImpl [1]; this factory gives it to the first constructed MojoVideoEncodeAccelerator; this is good for the first time, but after that it'd be gone, the construction of subsequent MojoVideoEncodeAccelerators will fail and we'll be falling back to software and/or the old IPC mechanism. This CL changes that by adding a mojom VideoEncodeAcceleratorProvider interface, which is bound along the chain: RenderThreadImpl --> gpu.mojom --> GpuClient --> gpu_service.mojom --> GpuService GpuService finally bind the request to a new MojoVideoEncodeAcceleratorProvider (added in this CL as well). GpuVideoAcceleratorFactoriesImpl uses this bound Provider to create MojoVideoEncodeAccelerators every time. [1] https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?dr=CSs&sq=package:chromium&l=1463 Bug: 736517 Change-Id: I3c753f951f120e1d2ffefb50a526fac15de6e881 Reviewed-on: https://chromium-review.googlesource.com/590513 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#490658}
-
Morten Stenshorne authored
Otherwise DCHECKs will fail when attempting certain read operations on the legacy layout tree. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8f09461bf7404aab1ef9a369380542759bb05a53 Reviewed-on: https://chromium-review.googlesource.com/591567Reviewed-by:
-
Julien Brianceau authored
Get a unique implementation in base::test instead of having specific implementations in various places, as suggested by Scott Graham. Bug: none Change-Id: I1ac2186bd5ec0df38bb58189f42fafb7b75acfed Reviewed-on: https://chromium-review.googlesource.com/591428Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#490656}
-
Gabriel Charette authored
Leaving static MessageLoop::QuitWhenIdleClosure() behind as a mere redirect but flagging it in presubmits so its usage dwindles overtime. R=danakj@chromium.org Bug: 748715 Change-Id: I523c6e598f0de5c9d326ae2764cd6e2502be9cc4 Reviewed-on: https://chromium-review.googlesource.com/586889 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#490655}
-
Oystein Eftevaag authored
A few consequences of this: * To be able to easily tear down all the active CoordinationUnitImpls, the static CU map now owns the CoordinationUnitImpls as unique_ptrs, rather than just holding a raw pointer to them. * Because of the above, client code that creates CoordinationUnitImpls must now explicitly call Destruct() on these. This mainly impacts test code, so I've made a TestCoordinationUnitWrapper which RAII handles this. Bug: 749804 Change-Id: I251c17606c2b055a6a66409681c954cdd76b58d6 Reviewed-on: https://chromium-review.googlesource.com/590700 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#490654}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d30c218d..d4e622d7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I371c2977fd2f8829d2bcb19e1feb52725041bcc1 Reviewed-on: https://chromium-review.googlesource.com/592910Reviewed-by:
-
Kenneth Russell authored
The associated code has been removed for some time and its continued presence is confusing. BUG=237931 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4c2ed46f7e8882958b6e533633a60f9afe04ce36 Reviewed-on: https://chromium-review.googlesource.com/592713Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490652}
-
Fady Samuel authored
This is a mechanical CL that updates includes, namespaces and forward declarations accordingly. Bug: 722935 TBR: dalecurtis@chromium.org, reed@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0c3da1e0236100487f59b7b8c15f5a94452ac607 Reviewed-on: https://chromium-review.googlesource.com/591777 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490651}
-
Xiaocheng Hu authored
This is a quick fix to crbug.com/745501 that stops trying to extend selection when there is no selection. This may not fix the root cause as we are not sure why we reach there without a selection. This patch is made small to be merged to M61. Bug: 745501 Change-Id: Ib0ff45b71e8850ded6d292bf86859364cdaff299 Reviewed-on: https://chromium-review.googlesource.com/592056Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#490650}
-
Nico Weber authored
This is the only build configuration that still uses libstdc++4.8. Does not affect the simplechrome build (which is what we ship, and which uses a newer libstdc++). Bug: 554841 Change-Id: If8acb3c59445214ba78d6f076cd9698b52a37b59 Reviewed-on: https://chromium-review.googlesource.com/591775 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Robert Hogan authored
This is a reland of 49ca5347 Original change's description: > Don't truncate inline atomic elements before an ellipsis > > A follow-up to https://chromium-review.googlesource.com/c/539460/, we > need to remember the linebox we added the ellipsis to and only hide > atomic inline elements associated with lineboxes that occur after it. > > Bug: 745867 > Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338 > Reviewed-on: https://chromium-review.googlesource.com/579973 > Commit-Queue: Robert Hogan <robhogan@gmail.com> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490341} Bug: 745867 Change-Id: Iaae3f85525588d97a76946005138f8b85253a713 Reviewed-on: https://chromium-review.googlesource.com/592967 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
-
David Reveman authored
These elements need to be centered to align with profile picture preview. BUG=730031 TBR=stevenjb@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2aeb8b7b7aed8903278a9d8b6cd24d0c8224d566 Reviewed-on: https://chromium-review.googlesource.com/592911 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490647}
-
Nico Weber authored
This reverts commit 517fd5f9. Reason for revert: Speculative; looks like it broke app_list_unittests on cros bots: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/28588 https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/22655 Original change's description: > Remove hover on icons in launcher > > Changes: > Disable ImageShadowAnimator in fullscreen app list mode so that the icon > will not jump when hovered. > > BUG=748236 > > Change-Id: Iba8c0717f7cdb132a28c4c21eb9add81a652e93a > Reviewed-on: https://chromium-review.googlesource.com/592335 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490526} TBR=stevenjb@chromium.org,weidongg@chromium.org Change-Id: Ida566f754ff80b698c49a3c1ae6d82c0b098d983 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 748236 Reviewed-on: https://chromium-review.googlesource.com/593108Reviewed-by:
-
Nico Weber authored
This reverts commit d7a2d953. Reason for revert: Looks like this broke at least the CFI bot: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20CFI/491 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_CFI%2F491%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPushMessagingBackgroundModeEnabledBrowserTest.BackgroundModeEnabledWithCommandLine%2F0 ./../third_party/boringssl/src/ssl/internal.h:184:10: runtime error: control flow integrity check for type 'bssl::(anonymous namespace)::X25519KeyShare' failed during cast to unrelated type (vtable address 0xffffc815a9ffce5e) 0xffffc815a9ffce5e: note: invalid vtable <memory cannot be printed> #0 0x9aefdf8 in bssl::(anonymous namespace)::X25519KeyShare* bssl::New<bssl::(anonymous namespace)::X25519KeyShare>() third_party/boringssl/src/ssl/internal.h:184:10 #1 0x9aefcb5 in bssl::SSLKeyShare::Create(unsigned short) third_party/boringssl/src/ssl/ssl_key_share.cc:199:37 #2 0x9b0bdbd in bssl::ext_key_share_add_clienthello(bssl::SSL_HANDSHAKE*, cbb_st*) third_party/boringssl/src/ssl/t1_lib.cc:2172:19 #3 0x9b07dc4 in bssl::ssl_add_clienthello_tlsext(bssl::SSL_HANDSHAKE*, cbb_st*, unsigned long) third_party/boringssl/src/ssl/t1_lib.cc:2679:10 Original change's description: > Roll src/third_party/boringssl/src 0e4a448ab..2507d9e70 > > https://boringssl.googlesource.com/boringssl/+log/0e4a448ab8aa66a38593f68d19fa0a2e340833e4..2507d9e7090fcd461f33f3b89bcd56c9a7476a04 > > BUG=none > > Change-Id: I34232babbf1adfdb663142b1f6970ed490b16399 > Reviewed-on: https://chromium-review.googlesource.com/586645 > Reviewed-by: Adam Langley <agl@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490632} TBR=davidben@chromium.org,agl@chromium.org,svaldez@chromium.org Change-Id: I155a5550fa70429a33a85654845b9b87c3f11991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/593107Reviewed-by:
-
Christian Biesinger authored
This should now be sufficient to allow an initial version of Flexbox-in-LayoutNG! Change-Id: I0c9c5f330e90e85705cdbc3eb0cfb26b24d0fbf3 Reviewed-on: https://chromium-review.googlesource.com/592691 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Christopher Cameron authored
In some instances, rather than update the logic to use the base::Feature instead of the command line switch, simply delete the old logic (especially logic that checks for color correct rendering being enabled). R=holte,hubbe,jbauman TBR=avi (content/ stamp) Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7dbc0c6151e353e94600ff83d975909b96af9fb4 Reviewed-on: https://chromium-review.googlesource.com/589348 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490643}
-
