- 20 Nov, 2020 40 commits
-
-
Renjie Tang authored
Change-Id: I3097a6925a59f2cced10c43f389f6d1108fcde6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531055 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829521}
-
Dave Tapuska authored
A subtle change that occurs is that WebFrameWidgetBase always returns its own size, previously it stored a size but delegated Size() to the View method. Remove the Resize methods on the public WebView API for removal in the future. BUG=1097816 Change-Id: Ic165921efd8bc8f3afafd8b2f821a602300d0b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547965 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829520}
-
Ioana Pandele authored
Change-Id: I508cab7aab3f1a6fb6fd03daf535d0a0934c3e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549965Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#829519}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 1145565 Change-Id: Iaa127ff7d30adeba6ffc70c26a3c8432bec84d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548000 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#829518}
-
Wenyu Fu authored
When native is loaded fast for LWFRE then deciding skip ToS, we should hide ToS components before existing. This CL also add this mechianism for ToS fragment to keep consistency, though in practice this never happens. Bug: 1148589 Change-Id: I88c8ac2316c59e25701f8bcbdbf6f57ff59d361a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543193Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829517}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f8e0fa49d95..b472168267a0 2020-11-19 ehmaldonado@google.com [owners] Validate owners config in Depot Tools client. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4a54fb550a75e838c5cbe0e81f6180198e02f1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829516}
-
Michael Crouse authored
Bug: 1151125 Change-Id: Ib22f4984f78d60863705188456c04a7b7e935832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551934 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829515}
-
Siyu An authored
Approvals @ crbug.com/1081328 and crbug.com/1104413 Bug: 1082013 Change-Id: I10fd7fb5e7daae3c10a6fb6b10e294dd6b0bd051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527921Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#829514}
-
Stephen Roe authored
This reverts commit 022c5b0e. Retained fuchsia/http/OWNERS from the original CL as it is required for a chromium_presubmit security check. Reason for revert: This CL breaks out-of-tree WebEngine clients (http://fxbug.dev/64893). Original change's description: > [fuchsia] Migrate to fuchsia.net.interfaces/State > > Fixed: fuchsia:21155 > Change-Id: I85b388be33d4c9697ba866cf11a143493b2b3239 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380329 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828229} TBR=wez@chromium.org,agl@chromium.org,servolk@chromium.org,rsesek@chromium.org,marinaciocea@chromium.org,tamird@google.com,brunodalbo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I0c6bc348a06200713411c924e4a788b16b8566ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551536Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#829513}
-
Matt Menke authored
There's still a constructor that takes Origins that needs to be removed, once consumers are migrated. Bug: 1145294 Change-Id: Iba1836f47e99d2f0ff66a5f6b6bcb878e6b218f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538317Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829512}
-
Chris Blume authored
Previously, the raster query queue was part of the GpuRasterBufferProvider. Soon, we plan to access that queue from multiple locations. Not all of them are tied to the GpuRasterBufferProvider. This CL moves the raster query queue to its own class so it can be cleanly accessed from other locations. Change-Id: I8a37258d201bcf2c4caec71ea5bd3a80cd769989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354237 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#829511}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9496fe5bcec9..ed289e777cfa 2020-11-19 johnstiles@google.com Simplify _blend_set_color_saturation, removing an instruction. 2020-11-19 michaelludwig@google.com Simplify layer bounds syncing and no-device error handling in SkCanvas::internalSaveLayer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I780d50e85b32d08fb3b455a23a08b0ceb2af82bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551423Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 9cdc15b9. Reason for revert: RecordingServiceBrowserTest.RecordingInterruptedOnCaptureLocked crashes three builds in a row: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21388 Original change's description: > capture_mode: Hook to policy and locked fullscreen mode > > Capture Mode should be disabled when the `kDisableScreenshots` policy > is disabled. > It also should be disabled when a tab requests to be in a locked > fullscreen mode, and any on going recording should be interrupted. > > BUG=1150585 > TEST=Existing, and added a new test. > > Change-Id: Ia16a2b1f2ce3a7c9588909c266b09bd5b439af9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548880 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829390} TBR=jamescook@chromium.org,afakhry@chromium.org,isandrk@chromium.org,poromov@chromium.org,bmalcolm@chromium.org Change-Id: I6e959a20c2e708580b68f4a1228c6d4459056b90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551876Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829509}
-
Shannon Chen authored
A point scan menu will be opened after the point is selected by point scanning. The current actions include left click and right click. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: I50b3918a25936d97cac89d2b56568954b2bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538416Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Shannon Chen <shannc@google.com> Cr-Commit-Position: refs/heads/master@{#829508}
-
Tomasz Wiszkowski authored
This change enables the native AutocompleteResult object to create and retain a copy of its corresponding java counterpart. The change moves logic away from the AutocompleteController into the AutocompleteResult, simplifying the logic of both classes. Bug: 1138587 Change-Id: Ib5d7c7b9eb1c938af31371ef96eeffd8c3f9a51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548261Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#829507}
-
Bettina authored
The ResetShortcutsComponent will use the existing sandboxed shortcut parser to retrieve modified shortcuts and then overwrites the existing shortcuts with new ones. The component will be hooked up to the CCT in a future CL. The previous CL was previously reverted due to the target_path FilePath being equal but the actual string not equal causing tests to fail. The only difference between the reverted CL and the new CL is that the reset_shortcuts_component_unittest now compares the target_path with the expected path using PathEquals instead of string comparison of the FilePath value(). Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2545895 Bug: 1148930 Change-Id: I1a4223632e6ecae6ff8fd0660003f5e4b1d501e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545650Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#829506}
-
Paul Irish authored
Extension names were sorted with a basic str1 < str2, however this meant all lowercase names followed after uppercase. Sending them through base::i18n::ToLower() first provides the expected order. Change-Id: Ic64a6481bbd657037cf92e74ac603e3766ca228e Bug: 1136299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447035 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#829505}
-
Alexandre Courbot authored
Failing to dequeue an event is part of the normal flow, so make sure this is reported at the lowest log level. BUG=None TEST=Chromium builds Change-Id: I72cbe50fc82bcb4b0d005bee6c8e07498ea7f9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548590 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#829504}
-
wutao authored
1. Change the music note from unicode to icon. 2. Adjust the icon and text spacing. 3. Adjust the text weight. Bug: b/169595749 Test: manual Change-Id: I1150ddf86ad7d8f6e13b86935100dccfd4ad4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548362 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829503}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I31bb39be741763f399ac4ffe2faf823112eeeef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548274 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829502}
-
Alexandre Courbot authored
Errors are fatal, so there is no need to keep the queues and the poll thread running when one occurs. On the contrary, after errors poll() may return immediately and result in messages accumulating endlessly in the poller's client thread. BUG=None TEST=video.Seek.switch_vp9 passes on Trogdor. Change-Id: I7c1fd15d39ec3ada9fd4222fa261c2b77e87205e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548589 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605808617-b7b98d0b2e0adfd912eea875a170478679e39b07.profdata to chrome-linux-master-1605830203-b886e962da8895514d6a5d81640dc11fdcd7ef55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I722a4a59c3a59348a3f24c3fc0590b55cfa22d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551837Reviewed-by:
-
Avi Drissman authored
Don't attempt to show an infobar on a WebContents that cannot show one. This does mean that if a WebContents that cannot show an infobar tries to load EME that cannot load due to there being no Rosetta installation, it will fail without requesting the user install Rosetta. Bug: 1151015 Change-Id: I3c2f6638027e1586cf9fc0b0ea354b0d7a2b845a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551243 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#829499}
-
Yu-Hsuan Hsu authored
Query the default output buffer size from CRAS server to reduce the chance of underruns. BUG=b:173675463 Change-Id: Ifc1b59352596a2c4d16314f05159e0d9ee4d9cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548107Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829498}
-
Toni Barzic authored
Fixes the issue where shelf navigation buttons clip rect was only getting updated in tablet mode - given that the condition used to be IsHotseatEnabled(), I assume the intention was to only skip this if the hotseat feature was disabled, even though IsHotseatEnabled implementation implied tablet mode. BUG=1150101 Change-Id: I46161d85c5111679a04a80d241fa6dfeeca26cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551420 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829497}
-
Joon Ahn authored
CSS transitions utilize as much resources as possible to make things as smooth as possible by default (often 60+ fps). Instead, manage our own frames and set limits. With 30 FPS the CPU usage drops by 65%+ on a test device. We can play with the properties to get a tighter optimization, but will wait for layout/chart size changes. http://screen/46Lcaa3EPqhURku Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I25ff25696b466712be9e9615601bd67b230b7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548365 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#829496}
-
David Van Cleve authored
We've now fully rolled out the new default referrer policy of strict-origin-when-cross-origin; the corresponding enterprise policy was a temporary measure to allow accommodating the change, and the policy's description mentions that we'll remove it "in M88". Like most release targets, that was off a little, since this CL will make it in M89. Bug: 1150018 Change-Id: Iada9415e37412619ec76cf62b5a016eaec8e25af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545223 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829495}
-
Clark DuVall authored
This should make analysis easier for a binary experiment, since the Finch dashboard can be used. Bug: 1150162 Change-Id: Id90204398234938c441982d5c2bc5c6f7c63d575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545874 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829494}
-
Kuo Jen Wei authored
Introduce |ModeFactory| to encapsulate different mode capture object creation process. Bug: b/151047537 Test: tast run -verbose <DUT> "camera.CCA*" Change-Id: Ibb6884e950144996e14743958889dcf8b225b920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534270Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#829493}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605797682-23848ae8029e54d2d5879a1157d78fd58275e00a.profdata to chrome-win64-master-1605808617-3dd590b3717c834812eb8652d51332097d715185.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica6f1b0b1da883859d7d664fb3d0df2da118795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551833Reviewed-by:
-
Hitoshi Yoshida authored
We used obj->signal() to check the existence of the dictionary member "signal", but it is a wrong usage and crashes if we use the new IDL dictionary code generator. This CL fixes them to call obj->hasSignal() as expected. Bug: 839389 Change-Id: I8db7e974adf6f95cf3c4c0107fcabe679bde8ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#829491}
-
Sophie Chang authored
Bug: 1146151 Change-Id: I713082856f769e17f01955f721abd1c4b1375da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548707Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829490}
-
Anton Bikineev authored
PartitionBucket::get_bytes_per_span() is not required to be multiple of PartitionPageSize(). This adds an explicit check that |maybe_ptr| doesn't point outside of slot span usable area. Bug: 11297512 Change-Id: Idabd14555fb21c73f1ad43663c349fd1d5a187b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550822 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Zhaoyang Li authored
Since it's enabled on 3 FYI builders 6 days ago, the issue occured in 1 swarming task among more than 20000 tasks. Enable it on all iOS FYI builders to gather more data before enabling everywhere. (Excluding code coverage experiment builders and builders without tests) Bug: 1136998 Change-Id: Ie8f939526ac9c72b1c4fb65d4c018a6392b0a667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551288Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#829488}
-
Dan Harrington authored
Bug: 1151039 Change-Id: I6797bbb10f496f8733c7bfadd9c22cdb2a339cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551282Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#829487}
-
Evan Stade authored
Unlike the first attempt at this change (which was 657b47a9), this doesn't make any change to the notification delegate for non-casting notifications (i.e. MediaSession notifications). This also moves the context unwrapping logic that's needed for MediaRouter on WebLayer behind the MediaRouterClient interface, i.e. into //weblayer. This logic is harmless on Chrome but also unnecessary. It's moved because it needs to be accessible to the WL MediaNotificationController.Delegate. Test by casting to a web video to a device and then using the physical volume controls. The casting volume should change. If you instead start a media session, e.g. on [1], that should also work and not crash. [1] https://googlechrome.github.io/samples/media-session/audio.html Bug: 1057099 Change-Id: I7aec21d2ff2d5ebd1cf9cc0ce12cf06016b6f5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548368 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#829486}
-
Pranav Batra authored
BUG=none Change-Id: Ifad95cc941d236ef5ace356c80013c36dda37be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458326 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#829485}
-
Makoto Shimazu authored
TBR=pmeuleman@chromium.org No-Try: true Bug: 1071909 Change-Id: I17d927cc3414b49fef6a52b92a937311b8746f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551874Reviewed-by:
-
Ken Rockot authored
LocalStorageImpl and SessionStorageImpl are self-owned objects with lifetime loosely bound to their corresponding Mojo interface receivers. This means it's possible for them to outlive the service itself (i.e. the StorageServiceImpl instance) and continue scheduling work during the service process's shutdown. They also use shutdown-blocking TaskRunners for some of their tasks, which is problematic given the potentially too-long lifetime: if a non-shutdown-blocking task races with shutdown completion and then attempts to schedule a shutdown- blocking task, we have a bad time. This CL fixes the issue by changing LocalStorageImpl and SessionStorageImpl to have stronger ownership within PartitionImpl and initiating an explicit shutdown step when the partition is torn down. This step effectively inhibits the scheduling of any subsequent non-shutdown-blocking tasks for these objects, ensuring that any remaining work comes in the form of shutdown-blocking tasks scheduled prior to or during the explicit shutdown step, or from other shutdown-blocking tasks posted by those tasks. In other words, shutdown remains continuously blocked until these objects are done scheduling work. This achieves the same shutdown-blocking behavior without the risk of a race against shutdown completion. Fixed: 1135957 Change-Id: Ie2fcc25df7fafe390c736d2c56d139433c69bf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533934Reviewed-by:
-
Tal Pressman authored
Presumably, these were used in the past, before many of the related IPC messages were mojofied. Change-Id: I6eee49976f22a7a98c6bb93c184d161764d77721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547750 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
-
