- 29 Sep, 2017 40 commits
-
-
Zentaro Kavanagh authored
- Replace uses of MD5 implementation in base with boringssl. - Replace uses of internal MD4 implementation with boringssl. - Use DES directly from boringssl and remove mozilla DES code. - The existing DES code was partially using boringssl already. - The existing DES code was setting parity itself. Now uses boringssl's DES_set_odd_parity - Re-implemented the mapping of a 128 bit NTLM hash onto three DES keys in Create3DesKeysFromNtlmHash BUG=chromium:755368,chromium:22532 Change-Id: I9f363b66c32dc8f7529627887ac46023403637e4 Reviewed-on: https://chromium-review.googlesource.com/616801 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#505285}
-
Yuki Awano authored
- Fix GetBounds to return bounds which can be passed to AXNodeData.location. Bounds are returned in the following coordinates. - Bounds of root node are relative to its container, i.e. focused window. - Bounds of non-root node are relative to its tree's root. - Bounds are returned in non-dip value. Android window with ChromeVox. Confirm that focus rectangle is shown on right location. Bug: 764870 Test: enable --enable-chromevox-arc-support and navigate elements on Change-Id: I052c3da643cd3e017b6256372221a6947410da65 Reviewed-on: https://chromium-review.googlesource.com/671168 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505284}
-
Ryan Landay authored
Long-pressing on a webpage in Android calls SelectionController::SelectClosestWordFromHitTestResult(), which calls CreateVisibleSelectionWithGranularity() to attempt to select the closest word. In some cases, this creates an invalid range (which ends before it starts), which causes a crash. This is currently the #3 top renderer crash in Chrome 61 for Android. This CL adds a check for an invalid selection range to avoid a crash that we can merge into the M62 release. We should properly fix CreateVisibleSelectionWithGranularity() at a later point to not return invalid ranges. Bug: 735774 Change-Id: If035606403df9f3d13961e49dce80f0129b96318 Reviewed-on: https://chromium-review.googlesource.com/691060 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505283}
-
Dale Curtis authored
kUnreliableDuration now means we can't rely on OnDurationChange events, which is fine since we generally use this with bad media. This also removes the run limit since the fuzzer seems to run fine locally now > 500000. BUG=758631 TEST=local long run Change-Id: I4b585776c64c1860c72ae89fc8ab5c020f266bdb Reviewed-on: https://chromium-review.googlesource.com/688002Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505282}
-
Xianzhu Wang authored
In the following few cases we intentionally allow under-invalidations in cached subsequences: - offscreen image animation - media buffered range We intentionally don't update each time the contents change to improve performance or avoid complex implementation of real time change notification. Now allow cache skipping in cached subsequences. Enable under-invalidation checking for tests that would have reported under-invalidation with the checking enabled. This also helps clusterfuzz not to trigger under-invaldiation checking failures when it creates a test for the above cases. Bug: 769729 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe Reviewed-on: https://chromium-review.googlesource.com/690851 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505281}
-
Lei Zhang authored
No longer needed since Mac builds are targeting 10.9. Change-Id: I2ff87eda6ba3f9af5c2ae3d9cdd034791542b7cf Reviewed-on: https://chromium-review.googlesource.com/686295Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#505280}
-
Pramod B S authored
Change-Id: I6c688cd5019fd0a425093b44c62981c0bb6bc8d2 Reviewed-on: https://chromium-review.googlesource.com/683934 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505279}
-
Alice Boxhall authored
Bug: 470311 Change-Id: Iccf06495bcbeb87748990cf8a66e5c6be0b47d0f Reviewed-on: https://chromium-review.googlesource.com/674508Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#505278}
-
Alice Boxhall authored
Bug: 560525 Change-Id: I36e4144ea8a66e430dd7c3b0b9010b900dd7398d Reviewed-on: https://chromium-review.googlesource.com/641694Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#505277}
-
Adenilson Cavalcanti authored
In inflate_fast() the output pointer always has plenty of room to write. This means that so long as the target is capable, wide un-aligned loads and stores can be used to transfer several bytes at once. When the reference distance is too short simply unroll the data a little to increase the distance. Patch by Simon Hosie. PNG decoding performance gains should be around 30-33%. This also includes the fix reported in madler/zlib#245. Bug: 697280 Change-Id: I90a9866cc56aa766df5de472cd10c007f4b560d8 Reviewed-on: https://chromium-review.googlesource.com/689961Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505276}
-
Hajime Hoshi authored
This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is recorded when a Document object survives 5, 10, 20 or 50 garbage collections after detached. If a document outlives such long time, the document might be leaked. The UKM would be very useful to know where such leaky documents exist and to fix them. Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing Bug: 757374 Change-Id: Idc05b03f625db11ab54c5203d18344b1ca72b4eb Reviewed-on: https://chromium-review.googlesource.com/647050 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505275}
-
Xianzhu Wang authored
We seem to have some under-invalidation of effect paint properties. This CL avoids the bug for SPv1. We will fix the bug in SPv175/SPv2. Bug: 769769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iade52f8b1748318edacf959c872552278a116321 Reviewed-on: https://chromium-review.googlesource.com/690616Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505274}
-
smut authored
Bug: 769870 Change-Id: Icbd3f71ee151fd4a6f17df2de0fbf5bef3f42d9b Reviewed-on: https://chromium-review.googlesource.com/691518Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#505273}
-
Max Moroz authored
There are some build issues with fuzz targets for blink. Also, we've decided to postpone the switch towards component build because of potential issues with sancov-based generation of code coverage stats and reports. TBR=dpranke@chromium.org, ochang@chromium.org Bug: 768918, 701825 Change-Id: Iea97a0db39796e142a420821f05726137addba78 Reviewed-on: https://chromium-review.googlesource.com/691212 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505272}
-
Yuichiro Hanada authored
TBR=reveman@chromium.org Bug: 768805 Test: Tests pass. Change-Id: I95e40b2d43c6ee0d670924214712a1960d6e7f38 Reviewed-on: https://chromium-review.googlesource.com/691534Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#505271}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I53dfcf0bbc2d01fd99770f6e30a80d589791add5 Reviewed-on: https://chromium-review.googlesource.com/691320Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505270}
-
dpapad authored
Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3efa3993d9ff75cce73eb48d583adb0ea5db543 Reviewed-on: https://chromium-review.googlesource.com/686041 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505269}
-
Lei Zhang authored
Change-Id: I2ad9adf9a3ca63a83a4a2f0991fabeac5f3cc182 Reviewed-on: https://chromium-review.googlesource.com/686274Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#505268}
-
dpapad authored
Bug: 768599 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8104ae1a081564d66425cd0f6bdec9229f4f6c26 Reviewed-on: https://chromium-review.googlesource.com/682455Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505267}
-
Evan Stade authored
- Remove unused function NotifierSource::GetNotifierType - Rename NotifierSource to NotifierController - Add docs Bug: 755413 Change-Id: Ib214b452548c348661569fe4496a06e67004809e Reviewed-on: https://chromium-review.googlesource.com/682108Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#505266}
-
chrome://interventions-internalsThanh Le authored
Bug: 764413 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37d9046c98e3c94030a87484249f6de20687eda1 Reviewed-on: https://chromium-review.googlesource.com/679743 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505265}
-
Daniele Castagna authored
The refactoring introduced in crrev.com/c/653037 introduced a new main file for simple client that included client_base.h. The memory layout of ClientBase depends on the define OZONE_PLATFORM_GBM. On ozone gbm platform, when building wayland_simple_client, the define would be present while building simple.cc but no when building simple_main.cc. This meant that the allocated layout for Simple would be different than the memory layout expected by the ctor, and it caused surprising bugs. This CL renames the define OZONE_PLATFORM_GBM to USE_GBM and moves it to a public_configs of client_support. In this way any target depending on client_support will build with that define. Additionally, this CL adds explicit minigbm dependencies where needed. Bug: Test: wayland_simple_client stopped behaving in unexpected ways. Change-Id: I17327b47b4ac3cac889d0452467c453ecc1ec165 Reviewed-on: https://chromium-review.googlesource.com/690804 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505264}
-
Alexis Hetu authored
A few tests already flaky on Windows have had failures on Linux also, so marking them as flaky. TBR=kbr@chromium.org Bug: 248938,763810 Change-Id: Iefe8eb79e494544b51b9bb177005736ba78ec2ca Reviewed-on: https://chromium-review.googlesource.com/691183Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505263}
-
Majid Valipour authored
Old test was too specific to Blink implementation and assumed a resolution is a multiple of 5 microseconds. The new test takes multiple samples and uses a GCD estimator for min resolution. See relevant discussion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1381492#c10 Bug: Change-Id: Id67f76511ec55c6e94c4dcfab07b95777b10425d Reviewed-on: https://chromium-review.googlesource.com/677981Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#505262}
-
Matt Falkenhagen authored
This is a step toward removing the process tracking code, which we shouldn't need to do in the PlzNavigate case. In PlzNavigate mode, we can rely on SiteInstance to track renderer process. I also somewhat suspect the IPC_FAILED errors are coming from using a dead process, which can happen when we don't rely on SiteInstance. See: https://bugs.chromium.org/p/chromium/issues/detail?id=732729#c23 Bug: 732729, 765526 Change-Id: I56d54f3c0b7200bf3e38693436619dd56c2811c2 Reviewed-on: https://chromium-review.googlesource.com/668354Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#505261}
-
Stephen Martinis authored
This reverts commit aa3c707d. Reason for revert: Didn't do anything Original change's description: > Fix run_multiple_telemetry_benchmarks_as_googletest.py compile targets > > https://build.chromium.org/p/chromium.perf.fyi/builders/One%20Buildbot%20Step%20Test%20Builder > is failing because the isolate target isn't being built on Linux Builder. > > Bug: 758630 > Change-Id: I793fed5a265b21762ba0a0cb6a669a3ba79f7ef6 > Reviewed-on: https://chromium-review.googlesource.com/683462 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504500} TBR=nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758630 Change-Id: Iab205ccbc2b1ce5042746bea28a2d2dcebb4faa3 Reviewed-on: https://chromium-review.googlesource.com/690637Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#505260}
-
Devlin Cronin authored
Add and use an extension_install.proto file. This will allow us to gather more detailed metrics on the types of extensions that users have installed, and determine the answers to more structured queries than could be determined by UMA histograms alone. Add the extension_install.proto and an ExtensionInstallMetricsProvider to gather these metrics, and hook these up to the metrics service. Add unittests for the provider. Bug: 673875 Change-Id: Ic0bdded27cafe3de75f2edeec2e7d927e0e2ecb6 Reviewed-on: https://chromium-review.googlesource.com/621672 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505259}
-
Benjamin Pastene authored
I removed it in https://chromium-review.googlesource.com/c/chromium/src/+/595248. Bug: 769899 Change-Id: I84eb38e697ee4f66329c6098b5431c1907b53d4e Reviewed-on: https://chromium-review.googlesource.com/691277Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#505258}
-
Scott Chen authored
This CL is the first pass for error-console such that it no longer looks completely broken, as well as fixing keyboard navigation. There will be follow-up CLs to bring it closer to the design spec as well as adding the missing dev-tool buttons. Bug: 768580 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I15d85e0ebe946b11a9a7aaf9f471ba22fe705a97 Reviewed-on: https://chromium-review.googlesource.com/685988 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505257}
-
Xiangjun Zhang authored
Add UMA metrics for media remoting sessions with duration less than 15 seconds to: 1) record the duration in finer scale; 2) record the stop trigger for those short sessions. Bug: 768581 Change-Id: I0fdefaf4284fbff36ac8ba063df7aca6e334df1b Reviewed-on: https://chromium-review.googlesource.com/683234Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505256}
-
Shakti Sahu authored
1 - Fixed download page screenshot to point to download arrow. 2 - Dismiss bubbles on hardware menu press 3 - Fixed accessibility text for download home IPH Bug: 768304, 768585, 765596 Change-Id: I11d1fe64cee9ba99a9fbe3603a58b72097ac8c49 Reviewed-on: https://chromium-review.googlesource.com/688059 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#505255}
-
Christopher Grant authored
This app draws the VR UI in a window on Linux, using fake browser state. This lets us debug UI appearance and implementation without building and loading the full Android APK. BUG=769325 Change-Id: I1a0efd7376d5103ed98641587f559ba8a5f65450 Reviewed-on: https://chromium-review.googlesource.com/682754 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505254}
-
Robert Kaplow authored
Bug: 767192 Change-Id: Ibea39c5a94c36d8c7c67672ee7fc380f50fa7acb Reviewed-on: https://chromium-review.googlesource.com/676193Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#505253}
-
Scott Violet authored
Additionally all services that are launched run using the utility process. BUG=763529 TEST=none Change-Id: I82ca2cef75335de7a85c7c7d3cb7362530a9ad56 Reviewed-on: https://chromium-review.googlesource.com/685979 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505252}
-
Stephen Martinis authored
Also creates cleaner way to add additional compile targets to builders. NOTRY=true # win chromium rel ng seems flaky Bug: 758630 Change-Id: I03f2b599d8f953f21d3a6d0e57d8db90d8d13999 Reviewed-on: https://chromium-review.googlesource.com/691065 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#505251}
-
Yuichiro Hanada authored
ChromeOS has switched over to ozone. Bug: 750642 Test: Build passes. Change-Id: Iffaf5f2b6d18fc05a6fa29fa22c7d16f2132497d Reviewed-on: https://chromium-review.googlesource.com/689874Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#505250}
-
Pavel Feldman authored
Change-Id: I8013c0c149548069e91df8e3b47228f3b2f0646b Reviewed-on: https://chromium-review.googlesource.com/691099Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505249}
-
Charles Harrison authored
This patch logs the time a particular WebContents spends in the foreground, after a navigation which: - Is started in the background - Commits to a cross-origin site - Has no user gesture - Is not the first navigation in the WebContents This metric will serve as a basis for determining how much user benefit comes from the (imo) harmful practice of navigating a site without user action or direct consent. In the near future, this metric will be broken up to also include breakouts for if the WebContents opened a popup before performing this kind of navigation. Bug: 661629 Change-Id: Ib6b59792b193bd447fd59939e06ed94d25c1be6b Reviewed-on: https://chromium-review.googlesource.com/685559Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#505248}
-
Jialiu Lin authored
If user see modal warning, ignore it, then restart browser, change password card should still be showing on chrome://settings page. Bug: 765807 Change-Id: Iaeedcc4e68f865b0fc263e0b4f7cc460df43302f Reviewed-on: https://chromium-review.googlesource.com/683461Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#505247}
-
Trent Apted authored
Adds initial support to views::Link as well, by allowing it to pass TextContext to its parent views::Label constructor. The entire StyledLabel has a single TextContext. A default TextStyle can be optionally overridden on a RangeStyleInfo. Audited the StyledLabel consumers: One consumer (EchoDialogView) uses underlined text outside of a Link. The dialog is under review (http://crbug.com/768663), so don't add a style for it. The PageInfoBubble was the only consumer that wanted an underline on its links. Remove underlines from all links in the page info bubble for consistency with the rest of Chrome's UI. All the (slow) FontList::Derive(..) calls disappear from StyledLabel. Most fonts just come from the ResourceBundle cache now, unless they need a custom_font (which is currently just EchoDialogView). Bug: 691891 Change-Id: I6cca4480d366d2578ac01da4d604a414415ffbc4 Reviewed-on: https://chromium-review.googlesource.com/649930 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#505246}
-