- 01 Feb, 2020 32 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4073a3e9ecf..555e26ba9311 git log d4073a3e9ecf..555e26ba9311 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 primiano@google.com Merge "Client Library: temporarily re-link full library in Android" Created with: gclient setdep -r src/third_party/perfetto@555e26ba9311 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1011764b507e5463f3a6619c189a8251d474e8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033947Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737556}
-
Esmael El-Moslimany authored
Bug: 1047811 Change-Id: I0fd7bbc18752122ba1bc415fc41f98298a92da7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033911 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737555}
-
Eric Orth authored
Route a DnsSession* back through HostResolverManager on config updates, and then reuse the cache invalidation mechanism to also update the per-context cached data in ResolveContext, particularly the current session. As part of reusing the cache invalidation mechanism, HostCache ownership moved from ContextHostResolver to ResolveContext. Seems reasonable because it is per-context data. HostResolverManager still accesses the cache separately from ResolveContext, but we could have it just use it out of the passed ResolveContext in the future. Bunch of related code churn in HostResolverManagerTests, but it's all pretty trivial. Bug: 1022059 Change-Id: I69f55895b1dc8d03c783002fda4e7ff031fde807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004953 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737554}
-
Chong Gu authored
Remove retry attempt limit, instead keep retrying to connect to device for a minute. Fuchsia bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=45090 Change-Id: I0c424fa4d63ffa457c50487261ad37ab97092d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033909 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737553}
-
Jinsuk Kim authored
We evaluate gesture navigation enabled status every time Chrome app is resumed in order to deal with the system gesture navigation mode change while the app was in background. When testing, the parent view (CompositorViewHolder) is always in attached state when the activity is resumed, but it can happen that it is in detached state as reported in the bug. This caused an exception, since WindowInsets will be null in that state. This CL skips the check if the state is queried while the view is detached from its window. The only scenario that could potentially be affected is when user switched the system gesture navigation on the settings and resume the app later. But experiment shows that this re-creates ChromeActivity and attaches the views before resuming, and the mode change rarely happens in the field. So the change is not likely to be risky. Bug: 1045942 Change-Id: I7ac11796737b1f355786c65f309182b107c39f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029547Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42a51f6af195..906bfde9b6e2 git log 42a51f6af195..906bfde9b6e2 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sokcevic@google.com Use logger where unit test has coverage Created with: gclient setdep -r src/third_party/depot_tools@906bfde9b6e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2a73a1c83c82a484c40f9a285677d27676abaec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033946Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4513cdde4912..1b80c357926b git log 4513cdde4912..1b80c357926b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1b80c357926b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I94d792c0fd5deae0b56c80f6269162ee6770964d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033945Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4dc1eb42a4de..1736c47b74c1 git log 4dc1eb42a4de..1736c47b74c1 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tobine@google.com Vulkan: Remove transient cmd buffer workaround 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8317b28e672a..bd4b3a888fca (27 commits) Created with: gclient setdep -r src/third_party/angle@1736c47b74c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I286636257d1be25a3c69bf26365d4680577cfd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033944Reviewed-by:
-
Shimi Zhang authored
We want to have a more general SchemeHostPortMatcher to allow a callsite doesn't need to rely on ProxyBypassRules' specific logics. The user should either use SchemeHostPortMatcher or create their own rules based on SchemeHostPortMatcherRule. Bug: 1030092 Change-Id: I095deb103cb4c3cbecc6e3c454423c805f1977c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030051 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7b8eb884cfd6..a451858403a2 git log 7b8eb884cfd6..a451858403a2 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 thestig@chromium.org Remove some CPDF_ImageLoader::Start() parameters. 2020-01-31 tsepez@chromium.org Remove CFFL_FormFiller::WndtoPWL() and FFLtoWnd() 2020-01-31 dhoss@chromium.org Add test case for dysfunctional FPDFTextObj_SetTextRenderMode() Created with: gclient setdep -r src/third_party/pdfium@a451858403a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifae40f85d36abadc7d886f7125a0ffb2132efc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033602Reviewed-by:
-
Peter Kasting authored
This is called a few places now and will add a few more in future CLs. Bug: none Change-Id: I83f17f4b981781a649c00aa2cf23f63994093d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026414 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#737546}
-
Avery Musbach authored
Test: manual Change-Id: I06df2ec89e48c9bd620ee1698a2dd4549e6ca45a Fixed: 1046517, 1047758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032235 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#737545}
-
Tibor Goldschwendt authored
Bug: 1042534 Change-Id: I7fd3603d7ee547ef2f70aec3576572f4e7f23f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028303 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737544}
-
Alexander Hendrich authored
This reverts commit 139c1efd. Reason for revert: https://crbug.com/1047721 Original change's description: > Run policy-presubmit when presubmit is changed > > When policy templates are changed, syntax_check_policy_template_json.py is run as part of the presubmit checks. It should also be run when changes to the file itself were made. > > Bug: 1045930 > Change-Id: Ic8870bd748d80d87b99b93889640cf2ebbbf0b27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022794 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Anina Koehler <aninak@google.com> > Cr-Commit-Position: refs/heads/master@{#737240} TBR=hendrich@chromium.org,aninak@google.com Change-Id: I9b1e9c6fc799516a5a7944706032ad5fc9cffd6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045930, 1047721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031110Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#737543}
-
Nick Diego Yamane authored
WindowEventFilterLinux currently calculates event's screen location (in pixels) using window bounds' origin + event's root_location(), while the correct would be to use Event::location() instead. It currently works because (for some reason) MouseEvent ctor that takes an XEvent as input, which is used atm in Aura/X11 to instantiate such events, sets root_location to the same value as location [1]. This is causing issues in window drag handling after migrating PlatformEvent to ui::Event (CL under review at crrev.com/c/2022280). Such change involves switching to x11_event_translation.{h,cc} to build ui::Events out of XEvents, which was originally based on X11 event source impl used in ozone/x11 (formerly used only for "CrOS on Linux") [2] which correctly sets MouseEvent's root_location [3] using ui::EventSystemLocationFromXEvent function, which is required, for example, to be able to retrieve event's screen point in X11WholeScreeMoveLoop [4]. [1] https://source.chromium.org/chromium/chromium/src/+/master:ui/events/event.cc;l=417-418;drc=948073da23 [2] https://source.chromium.org/chromium/chromium/src/+/d436c8e6a1:ui/events/platform/x11/x11_event_source_default.cc;l=91-94 [3] https://source.chromium.org/chromium/chromium/src/+/master:ui/events/x/x11_event_translation.cc;l=53-56;drc=bb682b7a02 [4] https://crrev.com/c/2022280/15/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#64 Bug: 965991 Change-Id: I2ad3fbde354ff66885253ccaca0e74391d4a11db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032307Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#737542}
-
Natalie Chouinard authored
The ImageView id in modern_list_item_view was changed from "icon_view" to "start_icon" (https://crrev.com/c/2024495) causing an NPE when the "Download file" dialog's dropdown is clicked. Bug: 1047883 Change-Id: I656562af3af4ada9e602c176c5d10abc035c9b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033929 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737541}
-
Dale Curtis authored
This is the same as the original patch, but restores the logic in WMPI::CurrentTime() which clamps to duration upon ended. PS#1 is the original change and all subsequent patch sets are the fixed. Even though we have an explicit ended signal, a lot of content doesn't have an accurate duration -- with some formats (e.g., VBR MP3, OGG) it can't be known without a complete play-through from beginning to end. The HTML5 spec says that upon ended, current time must equal duration. Due to the aforementioned issue, if we rely exclusively on current time, we can be a few milliseconds off of the duration. [ORIGINAL DESCRIPTION BELOW] We've long used now > dur as an implicit signal, but with poorly muxed media this can be unreliable. Since EndedPlayback() is used for a few important signals, we should ensure it's always right. As such, switch to using the explicit signal known by the WebMediaPlayer. This has been the source of a lot of flakiness over the years and we've been thinking about doing this since 2014. The only tricky part is in handling seeks to the end of file correctly; our pipeline previously required that play be called before we would trigger a real pipeline ended event. Instead we relied on HTMLME just declaring the playback ended at now >= dur. Now we will "render" end of stream even if playback hasn't started if we have nothing to play. TBR=rtoy,jrummell,mlamouri,guidou Bug: 409280, 1035472 Test: Updated unittests, all existing tests pass. Change-Id: I46dab0049ab8145c8d647a3d8c5365a45ba84c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033643Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b0c794156ba..36d6ae8fe7eb Created with: gclient setdep -r src-internal@36d6ae8fe7eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022108 Tbr: jbudorick@google.com Change-Id: Ic1c0b2ee515963304bddcf513191f1ad85c111c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033601Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 440da23e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1609fa65bef8cce4e600c21611af0adce18b1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033483Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737538}
-
Changwan Ryu authored
Currently, Chrome uses application context when it creates ContentView because it needs to reparent the view across different activities. Since it is not using activity context, and it seems quite challenging to refactor the codebase to do so, we are landing this as a short term workaround. The workaround consists of the following: 1) Pass WindowAndroid into IMMWI, and try to get activity context, only for Chrome. 2) Call setLocalFocus(true, true) only for showing keyboard. (jinsukkim@'s idea) 3) Wait for input connection to be established (yukawa@'s idea) The rest are just plumbing work. Manually tested the following on physical device and emulator: 1) activate IMEs between omnibox and content 2) activate and deactivate IMEs by touching inside and outside input box 3) move ChromePublic between displays and activate IMEs Also, manually tested that this works on WebView. Bug: 1021403 Change-Id: Ia952f76e2fb1afef073825435ab4569bcded6762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994393 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#737537}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2a397db501d..1ab87e04c957 git log c2a397db501d..1ab87e04c957 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 chrche@microsoft.com Fixed localization presubmit command line too long error Created with: gclient setdep -r src/third_party/devtools-frontend/src@1ab87e04c957 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib748032d28af476f9b71b991625b9314e8febbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033600Reviewed-by:
-
Ovidio de Jesús Ruiz-Henríquez authored
This reverts commit 0744e76c. Reason for revert: Suspect CL in causing compile errors on ios-device-xcode-clang and ios-simulator-xcode-clang builders. https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/121716 https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-xcode-clang/98510 Original change's description: > [base] Use dummy class to avoid superfluous initialization in Optional > > The initialization of "char empty_" union-member in Optional is > redundant and causes the compiler to generate extra code to ensure > zero-initialization. Using an empty Dummy class for the union member is > more optimal, since it guarantees that no code for its initialization is > generated. > > Explicitly touching this char member in the constructor also causes a > problem for conservative GC. Compiler is free to split shared and not > shared parts of the union in separate memory locations on stack (or keep > them in different registers). If a conservative GC is triggered at this > moment, stack scanning may not find the correct object (this is exactly > what happened in the bug 1044331). > > This can be tested in a minimized example: https://godbolt.org/z/t5q5ry. > > Bug: 1046776 > > Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737494} TBR=gab@chromium.org,fdoray@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I6a1f3a20d2c19716f51a45a4a1bb0bcafb7a558a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033439Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737535}
-
Jesse Schettler authored
Add SmartBatteryInfo to store Smart Battery information. Update DeviceStatusCollector to correctly include this info in the DeviceStatusReportRequest. Bug: 1026848 Change-Id: I00951bc8c4ef7e2acdd5f5371108e3d10993f76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028261Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#737534}
-
Luum Habtemariam authored
Per bcwhite@'s instructions on crrev.com/c/2015832, this CL removes the unnecessary enum and now matches the "BooleanMigrated" in histograms.xml. Bug: chromium:730242 Test: sync tests pass Change-Id: I1fad2ef07cf428160fc3e284a94439568728211d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025869Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#737533}
-
Joe Mason authored
It calls MigrateShortcutsInPathInternal several time and each call may or may not load DLL's, so the whole thing needs to be in the foreground in case it needs the loader lock. R=gab Bug: 1047442 Change-Id: Id962af6556e312bf638066e33268fe4902e0110f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032005Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#737532}
-
Chris Lu authored
This creates an EG2 test suite for Translate for the new Messages UI. Many tests are either direct copies or similar to those found in TranslateTestCase. Some of them were also not moved over, because they do not apply to the new Messages design. Bug: 1014959 Change-Id: I3e8c5865686f23f500a31902dbfd60fe225bda6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027127 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737531}
-
Kenneth Russell authored
This reverts commit 46b1cc8c. Reason for revert: was not the cause of the flaky crashes. See anglebug,com/2273 . Original change's description: > Revert "Remove three flaky suppressions on Mac NVIDIA WebGL" > > This reverts commit 2a085af2. > > Reason for revert: 5 GPU FYI bots started failing after this (extremely mysteriously, because this shouldn't affect them this way) > https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20Intel/98243 > https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/19387 > https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20AMD/96734 > https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/20055 > https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20GPU%20ASAN%20Release/14113 > > Original change's description: > > Remove three flaky suppressions on Mac NVIDIA WebGL > > > > These tests are no longer flaky > > conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2) > > conformance2/textures/canvas/tex-3d-rg16f-rg-float.html > > > > Bug: 923080 > > Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260 > > Auto-Submit: Austin Eng <enga@chromium.org> > > Commit-Queue: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#737052} > > TBR=kbr@chromium.org,enga@chromium.org > > Change-Id: I92cc1297bd71bc82b8e22662e58affe53b40ad6c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 923080 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033626 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737412} TBR=ccameron@chromium.org,kbr@chromium.org,enga@chromium.org Change-Id: Ib9d24c670f4f4d91f78e7b3696d571d4dcab1201 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033914Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737530}
-
Yao Xiao authored
Why: We’d like to learn where and how often they are used. How: In LocalFrameView::RunIntersectionObserverSteps, fire a hit test event in the center of the main frame with a 1 second interval. We check the style of the returned element and its container elements, to see whether it is immobile to scrolling and if it can overlay with other contents in the page. Bug: 1032681 Change-Id: I18acd22a7972a1e4ca361a7c466aa20705844dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993140 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#737529}
-
Brian Sheedy authored
Switches the heuristic that GPU Gold tests use to determine if they're running on a workstation or not. Previously, it checked for the presence of a git repository, but is now checking for the presence of the SWARMING_SERVER environment variable. This is the heuristic that will be used in other test types as they get switched to use Gold. Also removes the RunInChromiumSrc context manager that was being used to run the git commands, as it's simpler to just pass cwd to subprocess. Change-Id: If1b2fdf2ebda355319359d80017b25e24bb07d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033637Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#737528}
-
Xiaohui Chen authored
Using test TaskEnviroment's built-in mock timer and task runner. Bug: None Test: run unit tests Change-Id: I47ee9f3366298fa07cbfe56a06674a5f6932db49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033817Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737527}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22ab8b24f234..d4073a3e9ecf git log 22ab8b24f234..d4073a3e9ecf --date=short --first-parent --format='%ad %ae %s' 2020-01-31 primiano@google.com Suppess ServiceWorker errors Created with: gclient setdep -r src/third_party/perfetto@d4073a3e9ecf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:147015767,chromium:148675312 Tbr: perfetto-bugs@google.com Change-Id: Ie68ac01b311f33aa1a47a6665341c0d8a36b4aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033596Reviewed-by:
-
Tom Anderson authored
This is needed to fix the "Build From Tarball" bot: https://ci.chromium.org/p/infra/builders/cron/Build%20From%20Tarball R=thakis Bug: 1047860 Change-Id: Id41ebee75dc760580b1d2334dffcbb5fc2004f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033904 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737525}
-
- 31 Jan, 2020 8 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d67872733ec..42a51f6af195 git log 4d67872733ec..42a51f6af195 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tvanderlippe@chromium.org Enable Javascript formatting by default Created with: gclient setdep -r src/third_party/depot_tools@42a51f6af195 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9864f318ce68bd029319b8c274e2251c95350d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033593Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c0c0522e8076..4513cdde4912 git log c0c0522e8076..4513cdde4912 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 herb@google.com Rename flush -> issueDrawMaybeInlineUpload 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4513cdde4912 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I775eeea35657092c86849e996af3d8608f0dc781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033597Reviewed-by:
-
Becca Hughes authored
If we erase all of the history we should reset the entire Media History database. We do this by deleting the database and creating a new one. BUG=1024352 Change-Id: I14589cdee5ed8b807d0463f1efb5ccfb6d7e7d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990218 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737522}
-
Chong Gu authored
Add cc_unittests to the fuchsia_gtests test suite. Create an exception so that it doesn't run on Fuchsia CI bot. Bug: 1041160 Change-Id: Ie8dedb172085fad735155ac657a4e38f493e1e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025992Reviewed-by:
-
Marijn Kruisselbrink authored
This will be used in a follow-up CL to support storing native file system handles in IndexedDB. Also slightly simplify how BlobStorageContext is plumbed through the IDB code, addressing some of the follow-ups from https://chromium-review.googlesource.com/c/chromium/src/+/1994009 Bug: 955193 Tbr: avi@chromium.org Change-Id: I00038ad4a058c492ba9c53038a6effbed89ec639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026507 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#737520}
-
Mark Schillaci authored
This CL removes the "time" role description for <time> elements on Android. Anything with ax::mojom::Role::kTime will no longer have a role description explicitly set. Unit test expectations are updated as well. Bug: 1043377 Change-Id: I05c184244b84783b9ed4afc615e1e534a346a67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032059 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737519}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I3729a407bef47e5ca4212ee3fe748b89c8d16a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031526Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737518}
-
Marijn Kruisselbrink authored
This adds a new (internal) mojo interface that will be used by IndexedDB code (in the Storage Service process) to talk to Native File System code (in the browser process) to serialize and deserialize handles. Bug: 955193 Tbr: pwnall@chromium.org Change-Id: I01aad3db0787483caff11f94904eda00829c6033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025950 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
