GitLab

This CL enables composited scrollers on Mac to jump when clicked on the
scrollbar. On Mac, the "jump to the spot that's clicked" setting can be
dynamically set via System Preferences. When enabled, the expectation
is that regular clicks on the scrollbar should make the scroller "jump"
to the clicked location rather than animated scrolling. Additionally,
when this is enabled and the user does an Option + click on the
scrollbar, the scroller should *not* jump to that spot (i.e it should
be treated as a regular track click). When this setting is disabled on
the Mac, Option + click should make the scroller jump and a regular
click should animate the scroll offset. On all other platforms, the
"jump on click" option is available (via Shift + click) but is not
configurable.

Bug: 1080590
Change-Id: Ibf5bf2c12184189b136f8b96acc20585406c168c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244972
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778551}

Bug: 1069567
Change-Id: Ice3948b8848007eb11dcbaed13c0db7cb4171089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244122
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778550}

This change along with flipping FLAGS_quic_reloadable_flag_quic_enable_zero_rtt_for_tls will enable Chrome IETF QUIC 0-RTT support.

Manually verified with https://quic.rocks:4433/

Change-Id: I6e69ab5a006b520238ad43b97e3af33497e2bbe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246986Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778549}

If crypto::HMAC::Sign is passed too large of a buffer, it silently
fails to initialize the entire buffer. If crypto::HMAC::VerifyTruncated
is passed too large of one, it silently ignores the remainder of the
digest. Fix both of these.

Change-Id: Id57d5fc61ad85c9c63aef8f497c20fffd4409e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246989Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778548}

Change gfx::ColorSpace::ToSkYUVColorSpace() to return
kJPEG_SkYUVColorSpace for full-range BT.601 YUV only, rather than all
full-range YUV color spaces.

Change-Id: Idc407f87baf110ac1fbdabdc6a6a6a535b48c1c3
Bug: 1095161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244046
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778547}

This CL adds session_history.md to explain how NavigationController
tracks the back/forward history in each tab.

BUG=1015882

Change-Id: I48d7143b513b049ea100ab7efe7d8cc8c41b2cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225373
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778546}

This CL includes subframe navigations along with same-doc navigations
when we make sure to hide the path when a navigation finishes. This
also fixes some logic so that we do *not* hide the path on these
navigations if the path hasn't already been hidden (i.e. if the user
hasn't interacted with the page yet).

There are new unit tests for both subframe and same-doc navigations.

Bug: 1093870
Change-Id: Ibc382041e79931a6cd5dce9e0d3fd61edd7ff5cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243594
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778545}

Changed test files for 2 sites
tirerack - add an escape step
pac_sun - update proper cc exp date & change expectations to FAILURE

test files diff:
pac_sun.test
27c27
<       "value": "05/27"
---
>       "value": "05/20"
197c197
<       "expectedValue": "05/27",
---
>       "expectedValue": "05/20",
201c201
<       "expectedAutofillType": "CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR",
---
>       "expectedAutofillType": "CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR",
tirerack.test
175,178d174
<       "type": "PressEscape",
<       "action_index": 22
<     },
<     {



Bug: 1094470,1090042
Change-Id: Ib4d6348ebe32e68eb277ecb5ae404dd23a80c492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246921
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778544}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477847f85b70..3e3864d7cbd1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC flackr@google.com,sergeyu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1087037
Tbr: flackr@google.com,sergeyu@google.com
Change-Id: I77853ded090fea8746f81fe7d5190c5cd169b819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246751Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778543}

This fixes a regression after [1] where windows could not be joined
via tab dragging.  The issue is that
X11EventSource::dispatching_event_ got reset to the old event, not to
nullptr, so when nested message loops end, |dispatching_event_| is an
old event from when the tab drag started.

[1] https://chromium.googlesource.com/chromium/src.git/+/5c0232fa34a0a236b895de81034a042e906b8a0d

R=sky

Bug: 1066670
Change-Id: Ic03f0f418591ec7e7ce3dbdb4e7067ca0b19b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246850
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778542}

This improves the backward compatibility of the on-demand legacy
server. It feeds install progress to the update client in Chrome
and handles the installer errors.

There is a patch which can be used to fix some eager DCHECKS in
the update client in Chrome to facilitate debugging end to end.

Don't patch the production update client in Chrome.

Bug: 1067348

Change-Id: I9ea2e732c9a2ebc3102a2696179ca186aa2fd72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233858Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778541}

https://skia.googlesource.com/skia.git/+log/82d619699dd3..6b2caf7dfc87

2020-06-15 bsalomon@google.com GrAlphaThresholdFragmentProcessor uses child processor for mask.
2020-06-15 johnstiles@google.com Update EllipticalRRectEffect to support an input FP.
2020-06-15 johnstiles@google.com Improve error reporting in ProcessorCloneTest.
2020-06-15 elliotevans@google.com Added CanvasKit.MakeImageFromCanvasImageSource which is useful as an alternative to 
2020-06-15 fmalita@chromium.org Fix infinite loop in SkParsePath::FromSVGString
2020-06-15 brianosman@google.com Moved SampleMatrix computation out of SectionAndParameterHelper
2020-06-15 johnstiles@google.com Update ConstColor FP to support an input FP.
2020-06-15 egdaniel@google.com Fix tracking of d3d cpu descriptor heaps.
2020-06-15 herb@google.com GrTextContext::Options -> GrSDFTOptions
2020-06-15 johnstiles@google.com Fix pointer ownership issue with SkSL static switches.
2020-06-15 bsalomon@google.com Disable MorphologyFilterRadiusWithMirrorCTM_Gpu on AndroidOne
2020-06-15 johnstiles@google.com Add cloneAndRegisterAllChildProcessors.
2020-06-15 dmazzoni@chromium.org Add separate PDF tag attribute interfaces for names and strings
2020-06-15 johnstiles@google.com Add helper method to clone and register a child FP.
2020-06-15 djsollen@google.com Revert "Allow building with Wuffs v0.3, not just v0.2"
2020-06-15 nigeltao@google.com Allow building with Wuffs v0.3, not just v0.2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777
Tbr: djsollen@google.com
Change-Id: If5c89785645af74a759c99e4ca90d8ff903466c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246857Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778540}

This is meant to improve stability by checking the translate frame
response does apply to the current pending operation.

Bug: 1093320
Change-Id: I6abb5b721f3ec8467cb317e6b14901f377c89fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246862
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778539}

This CL only adds a function parameter through the pipeline. No logic
change in DownloadItemImpl.

For InProgressDownloadManager, since it's only used in resumption, we
reuse the persisted DownloadSchedule struct from DownloadItem.

For devtool and weblayer download manager, a base::nullopt is passed
through that we don't support download later feature in these cases.

Bug: 1078454
Change-Id: Ia9503e980e3ab25946d0899fd0ef1048c6328b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242202Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778538}

Fuzzy diff can help deflake some pixel tests. This cl also
changes the dialog pixel tests to use fuzzy diff.

Bug: 1087164
Change-Id: I808045876d4e147137a7461a75628f0fabd5127a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219393
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778537}

Bug: 1078460
Change-Id: I4a78617ef3ccfe2fa9bad06f8eb6bedcefaf2391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245677Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#778536}

When test passes, there is no guarantee that the test itself will clean
up all created child processes, so to make the test launcher leak proof,
issues a group kill. This only applies to clang profiling build because
those lingering processes usually indicate prod issues, so we don't
want them to be masked in regular build.

Bug: 1073832
Change-Id: I92ce55d9e5122e4aae18d4c4df46a378fe57159c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241641Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778535}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/323c2565a364..bde6ff28cf3d

2020-06-15 soxia@microsoft.com [DevTools][Telemetry] Frontend change for dual screen histogram

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5c4dd88bd95620d3a83e0211c4d4b4aef5160976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246754Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778534}

In the [1] review, three comments were missed - this CL addresses those
comments. One test is deleted, as it is no longer needed once WCv0 is
removed. One is a rename. And one is updated to replace ::content
with ::slotted().

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2243692

Bug: 937746
Change-Id: I2160ba32632b7ba1cd900158ad7b222a4e1bd941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246786
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778533}

The widget for QuickAnswersView is parented to the owner of the
MenuController of an active menu to allow keyboard accessibility
starting chromium/2222119. The bounds the widget is set to will need to
be converted from screen coordinates to that of its parent for it to
keep being positioned correctly within the screen. This CL does the
required coordinate conversion.

Bug: b:158883518
Test: Tested on Chrome OS VM and Atlas test device.
Change-Id: I52f34069df5ddb0fedff2fb5be9161bd10c31454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245172Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#778532}

Bug: 1005891
Change-Id: I8648cb582a6009653d3fd717ee8f3af8a1617dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246837Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778531}

Converts test filters in chrome/android/webapk, chrome/browser, and
chrome/test.

Bug: 1005891
Change-Id: I0d14e2243cacbae5338cce3d73ec4eb610f7d135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245685Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778530}

dev_finder and device-finder are both available in the SDK.

device-finder is preferred. dev_finder is deprecated and will be removed
from the SDK very soon.

Bug: fxbug.dev/54129
Change-Id: I73dbbe4115fff7d2f69c7a415219c47f4fa78d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246876
Commit-Queue: Andrew Davies <awdavies@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#778529}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I194e3a501b2f54d01301541aa1cb7621bafc23d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246872Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778528}

Reland crrev.com/c/2224990, including a fix for failing builders and
a fix with tablet screenshot related.

It seems the problem was Minimize animation also recreates layers so
when we do destroy the window, calling stop animation on the current
window layer would not stop the layer we originally observed. This
patch also caches the correct layer and stops the animation if the
window is recreated.

Test: none
Bug: 1088169, 1088039
Change-Id: I502e83ac22470c892b2c4a06f8feb86af1fff59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242742
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778527}

No need to add XXXToString helper function in each file.

Bug: None
Change-Id: Ie717defac4f4444aeab207de472ae190f935ac1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220359
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778526}

In some unittests, the ThreadPool is not created and tasks can't be
posted.

Typically, unittests should instantiate a TaskEnvironment to allows
posting tasks to the pool. The GPU tests are wrapped and doesn't provide
an easy place to instantiate that environment.

As an example, this is how the angle platform methods 'gles2_conform_test':

        angle::InitializePlatform [0x00007FF924B66670+112] (C:\src\chromium\src\ui\gl\angle_platform_impl.cc:150)
        gl::GLSurfaceEGL::InitializeDisplay [0x00007FF924B79497+4943] (C:\src\chromium\src\ui\gl\gl_surface_egl.cc:1206)
        gl::GLSurfaceEGL::InitializeOneOff [0x00007FF924B78110+64] (C:\src\chromium\src\ui\gl\gl_surface_egl.cc:856)
        gl::init::InitializeGLOneOffPlatform [0x00007FF9540E764A+102] (C:\src\chromium\src\ui\gl\init\gl_initializer_win.cc:195)
        gl::init::InitializeGLOneOffPlatformImplementation [0x00007FF9540E607E+60] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:178)
        gl::init::`anonymous namespace'::InitializeGLOneOffPlatformHelper [0x00007FF9540E5CE7+276] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:107)
        gl::init::InitializeGLNoExtensionsOneOff [0x00007FF9540E5E4B+104] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:134)
        egl::ThreadState::Get [0x00007FF6C17C68D7+623] (C:\src\chromium\src\gpu\gles2_conform_support\egl\thread_state.cc:82)
        eglGetDisplay [0x00007FF6C17C6036+21] (C:\src\chromium\src\gpu\gles2_conform_support\egl\egl.cc:23)
        GTFInitEGL [0x00007FF6C17A731D+218] (C:\src\chromium\src\third_party\gles2_conform\GTF_ES\glsl\GTF\Source\GTFInitEGL.c:310)
        GTFMain [0x00007FF6C17A9E1C+2073] (C:\src\chromium\src\third_party\gles2_conform\GTF_ES\glsl\GTF\Source\GTFMain.c:406)
        main [0x00007FF6C17C78BE+422] (C:\src\chromium\src\gpu\gles2_conform_support\native\main.cc:56)
        __scrt_common_main_seh [0x00007FF6C17E01E4+268] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
        BaseThreadInitThunk [0x00007FF962404034+20]
        RtlUserThreadStart [0x00007FF964443691+33]

R=sunnyps@chromium.org

Bug: 1091259
Change-Id: I037a4bdcaf525c6c8b3bce7dd6e76252c231a792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246869Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778525}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/774f09ba9004..e364dd820b29

2020-06-15 nodir@chromium.org Roll rdb binary

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ib481f629f2560954b09ef15e2833e077601639c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246752Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778524}

The main goal of this CL is to add a regression test for
https://crbug.com/1093748. To do that, it adds an
OmniboxViewViews::SetPathColor() method that is overridden by
TestingOmniboxView to check that the path is not set to transparent
when it shouldn't be. The same method is used to test that the path is
set to transparent when the path-hiding field trials are enabled.

This approach waas complicated by the fact that the unit tests don't
actually call the real EmphasizeURLComponents(), which is where the
bug was located. TestingOmniboxView had an EmphasizeURLComponents()
override that did a subset of what the real version does. The real
EmphasizeURLComponents() was not immediately usable from unit tests
because it had an early-return when there was a null
location_bar_view_, which is the case in tests. However, I couldn't
find any reason why a non-null location_bar_view_ was needed, so I
simply removed that check and made the unit tests use the real
EmphasizeURLComponents().

The last wrinkle in this plan is that using the real
EmphasizeURLComponents() caused OmniboxViewViewsTest.OnBlur to start
failing. AFAICT this is due to either a real bug related to how RTL
URLs are scrolled in focus mode, or an incorrect assertion. I
commented out the assertion for now and filed
https://bugs.chromium.org/p/chromium/issues/detail?id=1094386.

Bug: 1092651,1093748
Change-Id: I8b4690251d5d82fc28f4141bb37087ca730726fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243491
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778523}

One variant of base::IsAligned() takes a void*, but that does not work
for const float*. Change the parameter type to const void*, add a unit
test for it, and convert some code in media/ that can use IsAligned().

Change-Id: Iae7f8d5057dc947ebb85839a0b10e33f21ac207a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246838Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Brian Geffon <bgeffon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778522}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ebf55a0711b8..00965b9fa9a8

2020-06-15 dj2@everburning.com Remove unused variable. (#2273)
2020-06-15 rharrison@google.com Remove unused function, BaseTypeName (#2272)
2020-06-15 cepheus@frii.com HLSL: Remove support for having GLSL versions of HLSL intrinsics.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com
Change-Id: Iea7977262c60e3a570477ab55242e84690685870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246749Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778521}

chrome://signin-reauth is displayed within a native dialog. The content
should occupy all available space in the dialog.

It used to be done by setting body.height css property to the expected
height of the dialog. This logic has a flaw because the actual size
might be different from the expected one.

This CL defines the body.height parameter as 100% of viewport height,
which we actually want.

Bug: 1045515
Change-Id: I4b1200cb44882a5d9b22869a947a7bfeb6e554a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246171Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778520}

These navigation start offset maps have unbounded growth in the
number of frames on the page. This CL adds notifications for
render frame deletion to the PLMUpdateDisaptcher and LCPHandler to
prevent any potential memory leaks.

Change-Id: I06689fdd00c284f4fd9986384e2d7ff7614d9415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238493
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778519}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I67006b7fcb07d3328c0f0a5a33b594ca70ff60c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246753Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#778518}

This CL refactors update required screen browsertest to use
test::UIPath as constants for better readability.

Bug: 1048607
Change-Id: Ia8f6c201409abb2074492982dbbe7484b00548d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245700Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#778517}

This reverts commit 28bafce9.

Reason for revert: Flake due to the tests timing out.

Original change's description:
> Reland "Reland "Group tests of Trusted Types for WebUI""
> 
> This change groups tests of Trusted Types for WebUI into 10 WebUI pages
> per test to minimize the size of the file. This change also fixes a bug
> where `CallJavascriptFunction` might be called before allowing JS.
> See: crrev.com/c/2242372
> 
> Bug: 41905
> Change-Id: I5f28e056ca3bcb3f39678e2b6009e66316848322
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242656
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#777969}

TBR=dpapad@chromium.org,Jun.Kokatsu@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 41905
Change-Id: Ica2a1b8b76e2cb2d6690514e336b6e5e42183f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246984Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778516}

Add the boolean parameter premultiply_alpha to
ConvertVideoFrameToRGBPixels((), default to true.

This will be used by blink::AVIFImageDecoder.

Change-Id: I2a9f2ab55c0dbfa4a9e44bd749cdee187088f33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243866Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#778515}

Refactors the Skia Gold-related code in //content/test/gpu/gpu_tests
to be the same as //build/android/pylib. All the code that interacts
with Gold is encapsulated in its own class, and users simply run one
method and check its output to perform an image comparison.

Also adds a bunch of unittests (also taken from //build/android/pylib)
since the split makes the code unittest-able.

Drive-by fixes a related TODO in //build/android since the same TODO
was fixed in the GPU code in this CL.

Bug: 1093994
Change-Id: Id2fe1506796695f258069334149550cfaea49f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243718Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778514}

Currently, creation requests that specify public-key algorithms that an
authenticator doesn't support can still be routed to that authenticator.
When that happens, it fails immediately and we ignore it, so it never
blinks.

Instead, don't route such requests to the authenticators in the first
place and replace them with dummy touches.

BUG=1094066

Change-Id: Ie89c387887339f4dfc970a9f2205c6c354d141f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214100
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#778513}

Prevents the need for an extra OWNERS review for search tag screenshots.

Change-Id: I5959ee4b10555025ad71f18c9dcb501604496104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246821
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#778512}