- 08 Jun, 2020 40 commits
-
-
Maggie Chen authored
Bug: 1092512 Change-Id: Ie6afbe0d8e9e264ab7e42089b853121126ff17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236059Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776184}
-
Min Qin authored
see cl/314848673 Change-Id: I883f7ebb436bae3b5d3020b0e79dbac4abc63b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232999Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776183}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/47e79f83dec0..6370cd416c74 2020-06-08 lalitm@google.com Merge "test: run functional benchmarks under sanitizer." 2020-06-08 ilkos@google.com Merge "Add ion_buffer_create/destroy events" 2020-06-08 fmayer@google.com Merge "Drive-by^2: fix potential unaligned read." 2020-06-08 fmayer@google.com Merge "Only show "Download profile" for native." 2020-06-08 fmayer@google.com Merge "drive-by: Make RemoveWhitespace call-by-value." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6df08125a206bb435834fbdba9ae5e17d823a72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776182}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e1a57b83a52..e9a0cb87f7a3 2020-06-08 yang.gu@intel.com Fix assertion when running tests without suffix on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic610ad012276d47ed99353ccead5440bc10fe050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235920Reviewed-by:
-
Hongbo Song authored
This UKM is for the duration of event handlers processing the input event UKM Privacy Review:https://docs.google.com/document/d/1FV_oiGauBxxLiGqpAfNFYaDCg-0z8Tc2oaYMqqMBdEU/edit?usp=sharing Change-Id: I1396809c982cc49dd9b74d669dc71859b3a7eb9f Bug: 1086233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225879Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#776180}
-
Xing Liu authored
This CL exposes the download later feature flag to Java. TBR=dtrainor@chromium.org Bug: 1078454 Change-Id: Ib500e472c78383ce663a43f77792b6da6c248f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236215Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776179}
-
Charlie Hu authored
|DocumentPolicy::IsFeatureEnabled| is a dead function that should be removed when |mojom::DocumentPolicyFeature| is used in document policy to replace usage of |mojom::FeaturePolicyFeature|. Change-Id: I9a844b771607adec03ede78b03fcb78cbee979ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235984Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#776178}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ia88aabece93431cb8fb08dd958a0434d81084e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236056Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#776177}
-
Bettina authored
Many untested lines of client side detection related code are log statements. Removing them as they make the code messier. Also removed unneeded methods that only does DCHECKs and made them inline instead. Removed unneeded methods in tests. There will be follow up CLs to address untested methods. Bug: 1069793 Change-Id: I910e01dd89db27351474a9d5bc589f3f67437d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233712 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776176}
-
Matt Menke authored
They were previously aborted instead, which both confused users and required an extra round trip to figure out that bug reports in this case are actually related to H2. Bug: 941651 Change-Id: I5a84f5fa117c5fe50e0b399e3ad9f24b4f2ea1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232758Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776175}
-
Frank Liberato authored
At least, set it correctly for some value of "correct". Bug: 1091466 Change-Id: Ib5f242fcc923333d647e5209233b718acf902197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232777Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#776174}
-
Eric Orth authored
Bug: 1088715 Change-Id: I8e55f1350126632b83ae6e57148d97881f66c455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231661 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776173}
-
Doug Arnett authored
Bug: 1089210 Change-Id: I883e8fae43262a428a2f8488d962358dc03728a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236238Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#776172}
-
Joel Hockey authored
When all fonts have been exhausted and we must render tofu / notdef, we use the first candidate font rather than the system or last resort font. This helps in the case where a user has specified a monospace font such as for the terminal system app. We want to use the uniform width tofu, rather than the system or last resort font. Renamed is_last_resort to is_last_font in HarfBuzzShaper to reduce confusion since the final font used may not be the system last resort font. Some tests required updating since they are now rendering .notdef from the preferred font rather than the last resort font. I have added SansNotoTibetan-Regular.ttf font which is required in test external/wpt/css/css-text/word-break/word-break-break-all-005.html. Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.10-blink-rel;luci.chromium.try:mac10.11-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:mac10.14-blink-rel;luci.chromium.try:mac10.15-blink-rel;luci.chromium.try:win7-blink-rel;luci.chromium.try:win10-blink-rel Bug: 1090566 Change-Id: Ifca2800e6296adac3e40e3dae16008959b669337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227711Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a85d58e50e33..355e6449e7fd 2020-06-08 brucedawson@chromium.org Python 3 support for get_toolchain_if_necessary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I494a8a6c360d0bb443d3a81e62db694619555dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236239Reviewed-by:
-
Steven Bennetts authored
This reverts commit 6095d2a2. Reason for revert: This breaks official builds: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/7704 Original change's description: > Add release notes query parameters to logs. > > Bug: 1091050 > > Change-Id: Ie7f4320f2234f223851dfcaae71a14babbe88efd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230776 > Reviewed-by: Yulun Wu <yulunwu@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776138} TBR=ellyjones@chromium.org,yulunwu@chromium.org Change-Id: I426e4f3e6f9848cb3505bb8a796f6cf5208fefef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236222Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776169}
-
Christopher Cameron authored
The file shared_image_backing_factory_gl_texture.cc has grown to the point where its in-file class definitions are inhibiting readability. Split class definitions out into a separate header file, shared_image_backing_factory_gl_texture_internal.h. This is an entirely mechanical-code-movement change, and should have no effect on any behavior. Bug: 1092155 Change-Id: Iff9e2b7c28223ce246d6bf58f2573219beb91f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234549Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#776168}
-
Jeffrey Cohen authored
This also adds the screenshot to the view. https://hsv.googleplex.com/5993630915362816 Test classes for the view and mediator are also added. Bug: 1034733 Change-Id: Iaadf3e32d87c31bf453c049b416fa2cd7bf6445f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211050 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776167}
-
Andrew Grieve authored
Cronet is the only project that requires a lower minSdkVersion. To continue supporting building of their targets, this change enabled proguard on all of their apks in order to have all files desugared at the proper minApiVersion. This change should speed up compiles somewhat, as it removes the need to generate main-dex-lists for legacy multidex purposes. Bug: 1091919 Change-Id: Ifd8089bbf4965b55a13dea11464ccda979fd5028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233581Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776166}
-
Tom Anderson authored
BUG=1055026,1090915 R=dpranke CC=goanuj Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776165}
-
Denis Kuznetsov authored
This CL adds 'inline-suffix' slot that allows to have suffix element within undelined space of cr-input. It also renames existing 'prefix' slot to 'inline-prefix' for consistency. Bug: 856310 Change-Id: If371576fd69006a1c20d9ab5406ea6d2becdd88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198994Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776164}
-
Joshua Pawlicki authored
Bug: 1088779 Change-Id: I01b5ec432f7aa17955375f637a387c779c45fc06 Fixed: 1088779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236013 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Kartik Hegde authored
Add a routine to test whether a DNS resolution can be completed successfully. BUG=chromium:956783 TEST=unit_tests --gtest_filter=DnsResolutionRoutineTest.* Change-Id: I70f15771569e03068e10e8213c55f7656e4a49f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159897 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Because the options in a combo box are not in the automation tree, we will handle combo boxes by simulating arrow keys. This behavior will be changed when the underlying data is available. AX-Relnotes: n/a. Bug: 996401 Change-Id: Ice9003de483a4d9cdb7edd32f97f8024ec8b477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231660 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#776161}
-
Alison Maher authored
As a result of http://crrev.com/c/2079192, the PreferredColorScheme is stored and accessed through WebSettings instead of WebThemeEngine. With this change, SVGImage no longer can retrieve the correct PreferredColorScheme needed to respond to the prefers-color-scheme media query as it had before. To fix this, pass the PreferredColorScheme from Settings to SVGImage via SVGImage::DataChange(). Bug: 1090464,1090660 Change-Id: I0aacd08930fad21f55c9dfa8dd1b8f747912237d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230909 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776160}
-
James Cook authored
This reverts commit e8e3c1af. Reason for revert: This was a mistake. We aren't ready to launch everywhere (see comment about field trial below). There's a JSON file we can likely use to get the test waterfalls to exercise the feature. I'm following up with the Finch team to make sure the file can be used for first-run client-side trials, but for now I'm going to revert this. Original change's description: > chromeos: Enable feature SplitSettingsSync by default > > This is the "V1" feature. It: > - Creates a new "Sync your settings" section in Chrome OS settings > - Moves app, wallpaper and Wi-Fi sync to OS settings > - Provides a separate toggle for OS preferences, distinct from browser > preferences > - Makes the OS ModelTypes run in sync transport mode, controlled by a > master pref for the OS sync feature > - Updates the OOBE sync consent screen > > NOTE: The feature is rolling out via a client-side Finch trial, so the > actual state will vary. See config in > chrome/browser/chromeos/sync/split_settings_sync_field_trial.cc > > Bug: 1013466 > Change-Id: Ie84b193cd7c298387245f1c32f868b04731fb0e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775785} TBR=jamescook@chromium.org,xiyuan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013466 Change-Id: Ib3e22c79ce90f8bbfdb6ba2acd4d5e311681eb4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236216 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#776159}
-
Eugene But authored
This CL records the following user actions: - MobilePullGestureReload (existing action recorded on Android) - MobilePullGestureCloseTab (new action; iOS-only) - MobilePullGestureNewTab (new action; iOS-only) Bug: 1083433 Change-Id: I0bc7c3b0b70adec65e89708ad125d90c7534c13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229615Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Whenever we create a RenderViewHost, update it's Blink properties and enable the scrollbar. The scrollbar is disabled by default on Chromecast since Cast Apps are not supposed to be scrollable. Webviews don't have such limitations so enable scrollbars for Webviews only. BUG=b/158124105 TEST=Manually on device with a scrollable page. Change-Id: I0e7c8971760977568afa2a6a3eede6b28a8dd6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231589Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#776157}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00a96f2c994c..fee069880d16 2020-06-08 johnstiles@google.com Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file." 2020-06-08 johnstiles@google.com Define sample(null) as returning the inputColor unchanged. 2020-06-08 fmalita@chromium.org Reland "[skrive] Initial parser plumbing" 2020-06-08 bungeman@google.com Use "und" in place of HB_LANGUAGE_INVALID. 2020-06-08 herb@google.com simplify GrTextContext 2020-06-08 fmalita@chromium.org Revert "[skrive] Initial parser plumbing" 2020-06-08 johnstiles@google.com Update GrAARectEffect to use a child FP. 2020-06-08 reed@google.com inline Cluster::run() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I5907047496a3d6c68b7e75e4853c0629707f283c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236172Reviewed-by:
-
Fredrik Söderqvist authored
Previously this would be happening via the call to RemoveClient(), which ended up calling RemoveClientFromCache() on the LayoutObject associated with the <filter>. Bug: 1091568 Change-Id: I473321962dd5855e228403ad6bcba96ea6f825ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235078Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#776155}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/675551d57710..cab169a237ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059002 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ic8ae4d3c71275d45a42342d055cc0a3d974c1e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776154}
-
Akihiro Ota authored
This change does the following: 1. Adds an interactive tutorial polymer component 2. Adds a lesson polymer component 3. Adds html files used to define the test areas for interactive lessons. 4. Ports over some content from the existing tutorial into the new one. 5. Connects the interactive tutorial to the ChromeVox panel. 6. Wait to send commands to the panel until the panel has loaded. Connecting the tutorial to the panel was increasing the panel load time, which was causing us to fail panel-related tests. 7. Compiles ChromeVox using ES_NEXT rule to support async panel command behavior; errors were fired when trying to compile using ES6. Bug: 1075752 AX-Relnotes: N/A Change-Id: I7589a1d81185cba93242a1e419da4bd466351f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194345 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776153}
-
Brian Sheedy authored
This reverts commit 7e159a10. Reason for revert: No longer necessary. Original change's description: > Disable GPU Watchdog on CrOS tests > > Temporarily disables the GPU watchdog on GPU Telemetry tests on CrOS. > It is suspected that the watchdog is causing general test flakiness > on CrOS, so it is being disabled for ~1 day to see if there's any > noticeable impact on flakiness. > > Bug: 1090071 > Change-Id: I13936e94798bcd71e024bf761246ed330ec5444c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229436 > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774932} TBR=kbr@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090071 Change-Id: I155137da44a3e479d474a1fd87b53f1e9bedc195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236017Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776152}
-
Harald Alvestrand authored
and rebase changed tests. This reverts commit 328f27b7. Reason for revert: Change has now landed Original change's description: > Disable tests for landing a WebRTC name change > > Bug: webrtc:8787 > Change-Id: I5a166726bf236e088426734456f2d503e3c6875e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232554 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775594} TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8787 Change-Id: Ic074a1b1231f90363bf6af7a581c8044bef947c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235041Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776151}
-
Tao Bai authored
- Add the callback invoked after the observers. - Flush the pending change in pref. This will let WebView consistently see the persisted metrics after restart. Bug: 1076549 Change-Id: I9ab7a228bfd0431ead9545c37a07905c1a41ec8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226067 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776150}
-
Joe DeBlasio authored
This CL bumps the histograms for Safety Tips until after M87. Safety Tips is currently targeting M86, so that is hopefully the last bump we'll need to do. Fixed: 1089806, 1089471, 1089805, 1089477, 1089475, 1089473, 1089474, 1089472, 1089470, 1089469, 1089468, 1089467 Change-Id: I036f674d5a4ecc532b6aca0058ee672fbc3cd02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236042 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#776149}
-
Gang Wu authored
Because strict mode violation issue fixed, we can enable the test now. Bug: 1076643 Change-Id: I2a4283aef68767fedc850fa2a538ccf2eaaa5042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233921Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776148}
-
Jian Li authored
Bug: 1044139 Change-Id: Ic482b9590c14bfac490666d65a198e5f7c537a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231539Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776147}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4fa4342740a8..1557a1c16778 2020-06-08 jacktfranklin@chromium.org Components dev server 2020-06-08 changhaohan@chromium.org Remove behavior of merging Computed pane in the Elements Tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I736c7cee49d699f5617473f8a33574465c4d3298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235957Reviewed-by:
-
Sujie Zhu authored
When nickname management is disabled, nothing changes. When nickname management is enabled, given that expired & invalid nickname error message spaces are both reserved, we config larger margins among the inputs so that the inputs&text&buttons are evenly distributed in the dialog: 1. Margins between inputs are set to 26px in total by setting the cr-input-error-display to block. 2. Margin between saved-to-this-device and nickname input is 26px. Achieve by using the nickname input's error message spaces. 3. Margin between saved-to-this-device and button is the same 26px in total. Override Button's padding-top to 0, and set the label's margin-bottom to 26px We also update the character count's font-size and padding-inline-start (8px) to move the character count closer to the input field. Bug: 1082013 Change-Id: I5fb16eaeb0c9feb3b323ecc26a60c7e06d175d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229724 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#776145}
-
