GitLab

Remove SpecialPopupRow.

BUG=686220

Review-Url: https://codereview.chromium.org/2780743002
Cr-Commit-Position: refs/heads/master@{#460527}

We accidentally didn't handle the case where the iterator was evicted
and invalid. This is now much more explicit and tested.

R=pwnall,cmumford
BUG=705837

Review-Url: https://codereview.chromium.org/2786463002
Cr-Commit-Position: refs/heads/master@{#460526}

EventFilters are currently built by the LayoutManager and all gestures
are routed through it to the active layout. This indirection is
unnecessary since only the StackLayout requires gesture handling. This
also ends up exposing public APIs on the Layouts making it difficult to
follow the path for events from different sources (CompositorView vs
the Toolbar).

This change pushes EventFilters deeper into the Layout implementations,
so the Layouts directly consume touch events and generate gestures if
necessary. Layout still has an API for swipe gestures coming from the
toolbar.

BUG=

Review-Url: https://codereview.chromium.org/2774443002
Cr-Original-Commit-Position: refs/heads/master@{#459980}
Committed: https://chromium.googlesource.com/chromium/src/+/ef25f0df9d626028752de7d945d89abe15d39dfb
Review-Url: https://codereview.chromium.org/2774443002
Cr-Commit-Position: refs/heads/master@{#460525}

BUG=689479

Review-Url: https://codereview.chromium.org/2784673004
Cr-Commit-Position: refs/heads/master@{#460524}

Review-Url: https://codereview.chromium.org/2778943002
Cr-Commit-Position: refs/heads/master@{#460523}

BUG=367113

Review-Url: https://codereview.chromium.org/2648683003
Cr-Commit-Position: refs/heads/master@{#460522}

Revert of Disable SPInvalidation by default (patchset #2 id:20001 of https://codereview.chromium.org/2772833003/ )

Reason for revert:
Enable SPInvalidation on M59.

Original issue's description:
> Disable SPInvalidation by default
>
> We decided to delay launch until M59.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2752673002
> Cr-Commit-Position: refs/heads/master@{#456857}
> TBR=nasko@chromium.org (content_features.cc changes SlimmingPaintInvalidation disabled by default)
>
> Review-Url: https://codereview.chromium.org/2772833003
> Cr-Commit-Position: refs/heads/master@{#459201}
> Committed: https://chromium.googlesource.com/chromium/src/+/a038d334a0e1baae632e583dbc023f3383e8bf6f

TBR=chrishtr@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2782943003
Cr-Commit-Position: refs/heads/master@{#460521}

Previously, if an extension requesting automation has more than one page it opens in its extension process (e.g. background.html and panel.html, in ChromeVox), we instantiated two AutomationInternalCustomBindings (one for each page).

This fix makes it so we only ever make "active" the instance that is associated with the extension's background page.

Note that as a result, any calls to chrome.automation from non-background page contexts will result in an no-op (e.g. getDesktop will not trigger the callback).

In the case that the extension has no background page, we revert to the previous behavior of having one instance per page.

TEST=open the ChromeVox Panel, and close it again. Press caps lock. Verify we only process one event and only output one alert.
BUG=691165
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2782753002
Cr-Commit-Position: refs/heads/master@{#460520}

Revert of [scheduler] Split suspendable tq from unthrottled tq. (patchset #4 id:60001 of https://codereview.chromium.org/2754673002/ )

Reason for revert:
Causing failures in perf tests. Reverting to confirm it is the culprit.

crbug.com/706108
crbug.com/706104

Original issue's description:
> [scheduler] Add suspendable task queue.
>
> Add suspendable task queue to avoid running (and cancelling) callbacks
> when execution context is suspended.
>
> R=skyostil@chromium.org,alexclarke@chromium.org,haraken@chromium.org
> CC=nhiroki@chromium.org,tzik@chromium.org
> BUG=700792
>
> Review-Url: https://codereview.chromium.org/2754673002
> Cr-Commit-Position: refs/heads/master@{#459787}
> Committed: https://chromium.googlesource.com/chromium/src/+/12e16766adec5bb1e5cdd73d3cd8f5016b59ce18

TBR=alexclarke@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700792

Review-Url: https://codereview.chromium.org/2780233002
Cr-Commit-Position: refs/heads/master@{#460519}

Review-Url: https://codereview.chromium.org/2770083004
Cr-Commit-Position: refs/heads/master@{#460518}

Ensure the floor calculation is taken into account when running the
layout test. The calculation matches what is happening when e.timeStamp
is being returned.

BUG=706494

Review-Url: https://codereview.chromium.org/2784913002
Cr-Commit-Position: refs/heads/master@{#460517}

When latching is disabled, instead of setting a timer with zero timeout
to send the scrollEnd event, we send the event right away.
This change has happened to prevent unittests from unintentionally
simulating the latching behavior when it's disabled.

BUG=706175

Review-Url: https://codereview.chromium.org/2782733002
Cr-Commit-Position: refs/heads/master@{#460516}

BUG=internal b/36563551

Review-Url: https://codereview.chromium.org/2786493004
Cr-Commit-Position: refs/heads/master@{#460515}

It seems that there are some abusive extensions that act as if they were
other extensions with fake names. Instead of recording only the extensions
names in feedback reports, we should also record the ID and the version.

BUG=699266
TEST=manually

Review-Url: https://codereview.chromium.org/2772403004
Cr-Commit-Position: refs/heads/master@{#460514}

This patch adds the placeholder for NGColumnLayoutAlgorithm class
and refactors NG(Inline|Block|Column)LayoutAlgorithm classes
moving some common logic to NGLayoutAlgorithm base class.

BUG=635619

Review-Url: https://codereview.chromium.org/2782603003
Cr-Commit-Position: refs/heads/master@{#460513}

This patch enables persistence2.0 experiment by default, which results
in the following changes:
- automapping will be enabled by default for all workspace users
  (automapping design doc: https://goo.gl/lqYrql)
- a new UI for workspaces will be enabled by default for all workspace
  users

BUG=277885
R=dgozman

Review-Url: https://codereview.chromium.org/2744553003
Cr-Commit-Position: refs/heads/master@{#460512}

As per crrev.com/2283253002#msg37 this patch updates one of the
conditional branches BrowserNonClientFrameView::DoesIntersectRect to
return true if a large hit-test rectangle overlaps both the tabstrip and
the client area.

Review-Url: https://codereview.chromium.org/2775083002
Cr-Commit-Position: refs/heads/master@{#460511}

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
TBR=bauerb, skuhne, thestig

Review-Url: https://codereview.chromium.org/2499023004
Cr-Commit-Position: refs/heads/master@{#460510}

A major part of android's ChildProcessLauncher is implemented in Java
so having an easy access to the launcher thread is important.

Refactor JavaHandlerThread in base so that that java part can be created
first, and then connected with native peer after consutrction. This is
needed because the launcher thread can be used before native library is
loaded.

Add LauncherThread in content which is a simple wrapper around
JavaHandlerThread. Then for android, override the launcher thread
message loop. Note this means the launcher thread will no longer be
joined on shutdown, but this is not a problem in practice since android
never does clean shutdowns.

Convert two cases of random background threads in ChildProcessLauncher
to use LauncherThread. There are more in the future.

BUG=701442

Review-Url: https://codereview.chromium.org/2774363003
Cr-Commit-Position: refs/heads/master@{#460509}

This CL adds a timer to WebApkIconHasher. Consequently, classes that
invoke WebApkIconHasher::DownloadAndComputeMurmur2Hash no longer need
to maintain a timer dedicated to WebApkIconHasher.

This CL also simplifies the error checking and handling logic.
WebApkIconHasher now checks for URL validity itself, and would return
an empty hash string for any errors encountered.

BUG=649771

Review-Url: https://codereview.chromium.org/2771793003
Cr-Commit-Position: refs/heads/master@{#460508}

even for zero byte files.

URLRequestExtensionJob depends on this behavior, so add a zero-byte
test to url_request_file_job_unittest. Also update other relevant tests
in that file to check for DoneReading.

This is merely a test addition/modification for crbug.com/703892

BUG=703892
Test=None, internal change only.

Review-Url: https://codereview.chromium.org/2776873002
Cr-Commit-Position: refs/heads/master@{#460507}

Added a concrete example in comments on how to call Chrome OS Component API.

BUG=690521
TEST=None

Review-Url: https://codereview.chromium.org/2762393002
Cr-Commit-Position: refs/heads/master@{#460506}

When the default browser is not set, the 'Open in browser' option in the
context menu for CCT does not work for image and video link.

This is because for image and video, the linkUrl of the
ContextMenuParams is null. It is a same problem as the bug here:
https://bugs.chromium.org/p/chromium/issues/detail?id=696417.

And to fix it, follow this CL:
https://codereview.chromium.org/2739723004/ that checks the type of link
first then passes different urls for different types of link.

BUG=706209

Review-Url: https://codereview.chromium.org/2779113006
Cr-Commit-Position: refs/heads/master@{#460505}

compositor_frame_sink_id won't exist once we switch to mojo, so it
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink
on the view when its value changes. When
DidCreateNewRendererCompositorFrameSink is called, the views ensure
that they never return resources of the old RendererCompositorFrameSink
by recreating CompositorFrameSinkSupport.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2780713004
Cr-Commit-Position: refs/heads/master@{#460504}

If user opens recent/history menu and at the same moment syncronization
is updating session from other devices then user will can see
non-relevant a list of opened tabs from the other devices.

It's easy to reproduce.
1. Open a browser with enabled syncronization.
2. Open chrome://sync-internals page.
3. Open recent/history menu and wait for updating session on
   chrome://sync-internals page.
4. Open new tab on other synced device.
5. When chrome://sync-internals shows that session was updated the
   opened menu will show previous state of list list of opened tabs
   from the other devices.

R=pkasting@chromium.org, pavely@chromium.org

Review-Url: https://codereview.chromium.org/2768633003
Cr-Commit-Position: refs/heads/master@{#460503}

This way it shrinks if the text is bigger than expected, or expands if
more space is provided.

BUG=none
TEST=none
R=bsep@chromium.org

Review-Url: https://codereview.chromium.org/2782743003
Cr-Commit-Position: refs/heads/master@{#460502}

When a result of |string.c_str()| expression is passed to a function that takes
a StringPiece, it will measure the length of the string using strlen() function.
This is useless operation because we know the length already.

No behaviour changes.

BUG=679479

Review-Url: https://codereview.chromium.org/2779893005
Cr-Commit-Position: refs/heads/master@{#460501}

BUG=693525

Review-Url: https://codereview.chromium.org/2774293002
Cr-Commit-Position: refs/heads/master@{#460500}

BUG=676164
TBR=estade

Review-Url: https://codereview.chromium.org/2779523005
Cr-Commit-Position: refs/heads/master@{#460499}

Previously, params that were queried via their associated features
would not get correctly picked by perfbots using the field trial
testing config.

This was caused by the generated command-line not using the
--enable-features=FeatureName<TrialName syntax. This syntax is
needed in order to estable the link between a feature and its
associated trial, so that when a field-trial param is looked up
by feature, it's able to find it from the associated trial.

Adds quotations to these params since "<" characters would
otherwise get interpreted by some shells.

PERF SHERIFFS: This CL may cause perf bots to move - if so, it
means that one of the entries in the field trial testing config
that uses both params and features is causing the change but was
previously not being correctly tested. If so, we will need to
narrow down which one.

BUG=706414

Review-Url: https://codereview.chromium.org/2778313003
Cr-Commit-Position: refs/heads/master@{#460498}

BUG=646928

Review-Url: https://codereview.chromium.org/2785533002
Cr-Commit-Position: refs/heads/master@{#460497}

The BindingSet for mojom.GpuService is bound on the IO thread. So make
sure it gets destroyed on the IO thread too.

BUG=706357

Review-Url: https://codereview.chromium.org/2779903005
Cr-Commit-Position: refs/heads/master@{#460496}

BUG=697333

Review-Url: https://codereview.chromium.org/2782193002
Cr-Commit-Position: refs/heads/master@{#460495}

BUG=695613

Review-Url: https://codereview.chromium.org/2784633002
Cr-Commit-Position: refs/heads/master@{#460494}

This CL makes the paper icon button focus ripples (disc) consistent.
Before this CL, the menu icon and clear search icon had a different
focus color than the search icon, for example. Alan wants them to all
have a white focus highlight.
This is a step toward fixing the bug (not a complete fix).

BUG=693383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2778463003
Cr-Commit-Position: refs/heads/master@{#460493}

This CL fixes some desktop integration issues on Ubuntu 17.04, where
XDG_CURRENT_DESKTOP has changed from 'Unity' to 'Unity:Unity7' (or
'Unity:Unity8' if you're of the Mir persuasion).

BUG=706317
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2780863003
Cr-Commit-Position: refs/heads/master@{#460492}

There is a current refcounting known issue where a blob can be sent to
another process but while that IPC is scheduled the source process
dies. The blob will be non-existent. We want to gracefully handle this
error in IndexedDB instead of crashing.

(also fixes missing include in the connection class)

BUG=677780

Review-Url: https://codereview.chromium.org/2779433002
Cr-Commit-Position: refs/heads/master@{#460491}

Revert of Make VR screen tap tests more stable (patchset #6 id:100001 of https://codereview.chromium.org/2768583002/ )

Reason for revert:
Breaking compile on several bots including Android x64 builder:
  symbol:   class OnDispatchTouchEventCallback
  location: class WebVrTest
../../chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java:269: error: cannot find symbol
        ((VrShellImpl) VrShellDelegate.getVrShellForTesting()

Original issue's description:
> Make VR screen tap tests more stable
>
> The single tap sent during the VR screen tap tests wasn't always
> getting registered since device response can be a bit slow during
> the VR transition. For the Cardboard case, wait on Javascript to say
> it received another click event. For the Daydream case, wait on VrShell
> saying its parent has consumed the event before checking.
> BUG=
>
> Review-Url: https://codereview.chromium.org/2768583002
> Cr-Commit-Position: refs/heads/master@{#460452}
> Committed: https://chromium.googlesource.com/chromium/src/+/3e2ce51e88f19f0cc5196284f580583ddd4dbd9a

TBR=dtrainor@chromium.org,tedchoc@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2782963002
Cr-Commit-Position: refs/heads/master@{#460490}

This requires changing its signature. This is a preliminary stage to making it
private.

BUG=633030

Review-Url: https://codereview.chromium.org/2698673003
Cr-Commit-Position: refs/heads/master@{#460489}

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.nearest_neighbor indicates the desired
filtering effect on the rendered quad, the resource.filter actually
indicates the filtering algorithm on the resource inherently. To remove
this error msg whilst maintaining the correctness of filtering algorithm
applied on accelerated 2d canvas, we need to specify the resource filter to
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599

Review-Url: https://codereview.chromium.org/2758863003
Cr-Commit-Position: refs/heads/master@{#460488}