- 07 Aug, 2018 40 commits
-
-
Makoto Shimazu authored
Previously ChromeDoNotTrackTest only tested updates in RendererPreference instead of issuing actual network request. This CL is to change the test to send a request to check if the header is sent with respecting to the preference. Bug: 853085 Change-Id: I62d7eb88b3fea14db68baf5a23d1c44b4e8ab8db Reviewed-on: https://chromium-review.googlesource.com/1164862Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581173}
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray should keep the position of the notification list from the bottom of the notification. Notifications should be pushed up when UST is expanded, and the notification right under the expand button should be the same one. TEST=manual BUG=856060 Change-Id: I0393dadca02a2e1d633a5a7e3fa165b7c4e3ba82 Reviewed-on: https://chromium-review.googlesource.com/1164807 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581172}
-
Adam Rice authored
Update TransformStream to standard version https://github.com/whatwg/streams/commit/51227372cc84846bdcf68312724c4cac6a4b9e58 Remove failing test expectations. Changes: The order of access of strategy parameters has been changed to match the standard. This mostly only affects the tests that are looking for it. Algorithms are cleared out once they will no longer be called, enabling garbage collection. Bug: 866388 Change-Id: I26a062acee86112d72aeae439f461b4a1713babd Reviewed-on: https://chromium-review.googlesource.com/1146533Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581171}
-
Luciano Pacheco authored
Metadata backend raise an error if we pass a non-Entry object. This fixes an error when clicking on "Drive > Shared with me". Bug: 867974 Change-Id: I741c310c86b1481823dc9fa5bd84575050c428d3 Reviewed-on: https://chromium-review.googlesource.com/1164802 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581170}
-
Momoko Sumida authored
Currently, empty CSSStyleSheets can only be constructed using a constructor method. This CL adds Document.createEmptyCSSStyleSheet so that it can be tied to document in the future. Tying it to document restricts the use of a CSSStyleSheet in different documents, which means CSSStyleSheets can only be used in the documents where they are constructed. This will reduce security risk. Note: The constructed CSSStyleSheet is not currently tied to the Document yet Constructor method will be deleted in another CL createEmptyCSSStyleSheet(CSSStyleSheetInit) produces an empty CSSStyleSheet, while createCSSStyleSheet(text, CSSStyleSheetInit) creates a CSSStyleSheet with text Link to related comments in discussion: https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786 https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056 Bug: 807560 Change-Id: I94ea6f795deaf0dee67fba5c2705c8749ac72da8 Reviewed-on: https://chromium-review.googlesource.com/1160422 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#581169}
-
Greg Kraynov authored
SequenceManagerPerfTest now runs in both environments. Bug: 828835 Change-Id: Ib06dc1bbabd4fe972c428605247f6bf86b2c9825 Reviewed-on: https://chromium-review.googlesource.com/1163883Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581168}
-
Elad Alon authored
Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: 1. If the policy was disabled before, and becomes enabled, subsequent calls to StartRemoteLogging() will succeed (barring unrelated issues), even for peer connections created while the policy was disabled. 2. If the policy was enabled before, and becomes disabled: a. Peer connections associated with the profile reject calls to StartRemoteLogging(). b. Active logs (associated with the profile) are stopped, and those log files deleted. c. Pending log files (associated with the profile) are deleted. d. If a log file associated with the relevant profile is currently being uploaded, the upload will be cancelled, and the file deleted. Bug: 775415 Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f Reviewed-on: https://chromium-review.googlesource.com/1162168Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#581167}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: Ieb39e079c26a508f11fe582b7419bf47b1be696a Reviewed-on: https://chromium-review.googlesource.com/1164804Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581166}
-
Giovanni Ortuño Urquidi authored
Some clients like Default Apps and Policy Apps install apps without a Browser window. Some steps can be skipped for these clients, like sending the install event to the page, but other are needed for example creating shortcuts. Changes BookmarkAppHelper to not return early if there is no Browser window but still skip some unnecessary steps. Bug: 844278 Change-Id: I24003ff51d47937dc349aafca67912224db1eab2 Reviewed-on: https://chromium-review.googlesource.com/1164160Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#581165}
-
Rakina Zata Amni authored
TBR=kenrb@chromium.org Bug: 871648 Change-Id: Iff588adef9a640e699bb8d50009d83d2a1987f58 Reviewed-on: https://chromium-review.googlesource.com/1164803Reviewed-by:
-
yoshiki iguchi authored
This CL introduces the feature to defer events from notifications until the device unlocks, add adds the UI to encourage user to unlock the clicked notification to perform their events. The main concept of this CL is introducing LockScreenManager to message center code, which intercepts the event handlers in MessageCenter and defers the event if necessary. And Ash has the implementation of LockScreenManager named AshMessageCenterLockScreenManager, which handles message center events depending on the status of the lock screen. PRD: go/notification-on-lock-screen Bug: b/79951342 Test: added tests pass Change-Id: I3be8897598eda490590217837a7169d7505877e7 Reviewed-on: https://chromium-review.googlesource.com/1161715 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581163}
-
Koji Ishii authored
This patch marks outline-related failures in FlagExpectations for LayoutNG. TBR=atotic@chromium.org NOTRY=true Bug: 835484 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib5bba0976d0bae63d838c4b02f3f6be33ede8e30 Reviewed-on: https://chromium-review.googlesource.com/1164819 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581162}
-
Nicholas Verne authored
Crostini linux containers are going to use a new Cicerone based API for setup. This will allow us to surface more install progress for users. A future CL will wire this in to CrostiniManager and CrostiniRestarter. Bug: 860094 Change-Id: Iea91285af1bd42e5bb8ecfd5f62f66091b7e6eae Reviewed-on: https://chromium-review.googlesource.com/1163350 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581161}
-
Yutaka Hirano authored
No-Try: True Bug: 871578 Change-Id: I90e8d63d4d0424cfa189db3ba726022c7b30c6eb Reviewed-on: https://chromium-review.googlesource.com/1164809Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#581160}
-
Rakina Zata Amni authored
TBR=msw@chromium.org Bug: 871652 Change-Id: Ic5ecabf54b1915a3c29cdf65d4bcc4e400300840 Reviewed-on: https://chromium-review.googlesource.com/1164805Reviewed-by:
-
David 'Digit' Turner authored
NOTE: This is a reland of the following CL which was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1131190 The revert was due to a problem with an internal clank/DEPS runhooks step that calls jinja_template.py (see BUG entry below for details). The new CL was checking inputs by defaults, which would raise an error during gclient sync. To ease review, the first CL on gerrit is the original one, unmodified, and the second fixes the issue. ---- end of NOTE ------ ProTip: start by looking at the action_with_pydefps() definition in internal_rules.gni to review changes in this CL. This CL tries to make "gn analyze" smarter by ensuring that it knows about Python module dependencies, for any python script under //build. At the moment, these dependencies are computed by build_utils.WriteDepFile() automatically (unless the add_pydeps=False argument is passed). This adds all imported module paths to the generated .d file written by the script. Unfortunately, because this .d file is generated by the actions, the corresponding Python sources are not part of the target's inputs, known by GN at parse time, and thus do not appear in "gn analyze" properly. This CL tries to solve the problem by adding a new template named "action_with_pydeps", which acts as "action", but also expects a foo.pydeps file for every foo.py invoked through the 'script' scope variable. This '.pydeps' file is read directly at GN parse time and added to the action's target inputs. These .pydeps contain the path of each imported module, one per line, and are generated with build/print_python_deps.py Benchmarking shows no significant difference in the time taken to perform a "gn gen out/Release" on a full Chrome for Android checkout. This also needs a PRESUBMIT.py step that ensures that all .pydeps files are up-to-date with regards to their corresponding .py source files (this can be done with 'gen_pydeps.py --check .../foo.py') + Remove some --depfile options on a few Python scripts that don't need it anymore (e.g. when their inputs and outputs are now fully known by GN at parse time). + Remove uses of compute_inputs_for_analyze in rules.gni and internal_rules.gni (as well as exec_script() calls to print_python_deps.py). Note that the variable itself is still needed for grit inputs, see tools/grit/grit_rule.gni for details). BUG=870845,843562 R=agrieve@chromium.org, estevenson@chromium.org Change-Id: Id1f606a0c9df9e4e8971fd885ac0394103ca7b03 Reviewed-on: https://chromium-review.googlesource.com/1163512Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#581158}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If74a5b3fa28406bacfe489cff08e9bd636bef897 Reviewed-on: https://chromium-review.googlesource.com/1164842 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581157}
-
Rune Lillesveen authored
This reverts commit c9cbab07. Reason for revert: Caused flakiness https://crbug.com/871601 Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If5d71d67ad54ed590408c7ef1af0c71431c788d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164822Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581156}
-
Anand K. Mistry authored
BUG=None Change-Id: Ib8f43276637b7ad679a7429f3ad88db5878f29c0 Reviewed-on: https://chromium-review.googlesource.com/1163347 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581155}
-
Eric Willigers authored
Ability to Prevent scrolling in HTMLElement.focus() shipped in M64 https://chromium-review.googlesource.com/731225 https://www.chromestatus.com/feature/5745122025144320 BUG=734166 Change-Id: Ia2f8ebe29c553069e4893f7b474bd21b4b1f29a2 Reviewed-on: https://chromium-review.googlesource.com/1163056Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581154}
-
Renee Wright authored
The name should be the only member of the app item that can change as a result of the app being updated (i.e. changes to the .desktop file), so that is the only thing we need to update on the app item. This fixes the problem of app items moving or changing folder when the app is updated. I have tried this on hardware and it works as intended. Bug: 861524 Change-Id: I20e413991609f861b0b371856e8fc96e4905978c Reviewed-on: https://chromium-review.googlesource.com/1160067Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#581153}
-
Koji Ishii authored
Following bot results are included. dummy 0 lines were removed and 3 lines were deflaked by consecutive results since 8628. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib15a811e8240f0570947168b8bf115d874c875da Reviewed-on: https://chromium-review.googlesource.com/1163053 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
Clean up. Should not change any behavior. After this CL, the TaskHandle retains the ScriptPromiseResolver by its Persistent. Thus, the KeepAliveWhilePending in ResolveOrReject script forbidden path is removed. Bug: None Change-Id: I72bd9998d621b9d375faa9b1eb90d6ecf3dec2e6 Reviewed-on: https://chromium-review.googlesource.com/1164157Reviewed-by:
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I587e9cb4b321b08e07f86003537116a0b3b55543 Reviewed-on: https://chromium-review.googlesource.com/1164738Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581150}
-
Koji Ishii authored
This patch changes NGInlineItemsBuilder to remove trailing spaces at the end of blocks. It used to do so, but stopped in https://crrev.com/c/1022191 because doing so reduces opportunities to re-use NGInlineItem and increases shaping when contents are added. However, for fonts that has kerning before a space character, this change increased re-shaping every block end. Given line breaking is more often ran than adding contents dynamically, this turned out to be not a good trade off. We could re-shape only end-part in RestoreTrailingCollapsibleSpace to achieve the originally intended optimizations. This speeds up blink_perf tests on Windows by ~10%. This patch also fixes a few cases where space collapsing is incorrect when items are re-used. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id6e0c262db29b4d39ddd4eb1f55b18da2c7e5880 Reviewed-on: https://chromium-review.googlesource.com/1163240 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#581149}
-
Rune Lillesveen authored
This reverts commit d00fd143. Reason for revert: Caused test flakiness https://crbug.com/871652 Original change's description: > window-service: ignore requests to focus null > > Here's my comment as to why this is ignored: > > // The client is asking to remove focus from a window. This is typically a > // side effect of the window becoming, or about to become, an unfocusable > // Window (for example, the Window is hiding). Windows becoming unfocusable is > // handled locally. Assume the request is for such a scenario and return > // false to ignore the change. > // > // To process null requests conflicts with top-level activation changes. For > // example, the typical sequence when a window is hidden is to first remove > // focus, and then hide the window. FocusController keys off window hiding to > // move activation. If this code where to set focus to null, FocusController > // would not see the window hiding (because the active window was set to null) > // and not automatically activate the next window. > // > // Another possibility for this code is to handle null as a signal to move > // focus to the active window (if there is one). I'm going with the simpler > // approach for now. > > BUG=867654 > TEST=covered by tests > > Change-Id: Iee8efd8895284acca4603ff22bde19adf16d8a7f > Reviewed-on: https://chromium-review.googlesource.com/1164409 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581113} TBR=sky@chromium.org,msw@chromium.org Change-Id: I7710ea88b1dcb53d5ad299ff1295ecec31ce3f87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867654 Reviewed-on: https://chromium-review.googlesource.com/1164782Reviewed-by:
-
Jia authored
This cl contains the following changes * Real implementation of smart dim model (SmartDimModelImpl). * Checking in the generated tf native inference code. * Checking in the example preprocessor config. * Additional UMA metrics to log. Bug: 862461 Change-Id: Ib37a9562b23590be7555e34e3227049751f6d07e Reviewed-on: https://chromium-review.googlesource.com/1154618 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#581147}
-
Christopher Cameron authored
Add an empty BridgedNativeWidgetHost interface and a largely-empty BridgedNativeWidgetHostImpl implementation. These will be the browser process part of BridgedNativeWidget. Update NativeWidgetMac to have a BridgedNativeWidgetHost instead of a BridgedNativeWidget, but still allow calls through the old interface. The next steps will be a long process of shuffling members and methods to these interfaces. Bug: 859152 Change-Id: Id8be908302a32e52dc0ae1bf54fe19a285adccef Reviewed-on: https://chromium-review.googlesource.com/1162875Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#581146}
-
Hayato Ito authored
The most of changes are mechanical ones. The interesting part is, for example, that the current EventDispatcher::dispatchEvent, takes a pointer to Event (Event*), while it is doing DCHECK at the beginning, as follows: > DCHECK(event_.Get()); Given that, we can use a reference there safely; the mechanical changes in this CL should be safe. Since there are a lot of callers of event dispatcher (and other functions), I gave up doing every necessary changes in one CL, so that the size of CL wouldn't become huge. For this reason, I couldn't remove EventTarget::DispatchEvent(Event*), for example, yet in this CL, which is now just calling a function which takes a reference, after doing DCHECK(). Once we can replace every usages of callers in follow-up CLs, a function which takes a pointer will be removed. These efforts should be tracked in bug 871637. BUG=871637 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3f20e9a40dd3f950c87282101e968e893b1e8c2c Reviewed-on: https://chromium-review.googlesource.com/1163591 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#581145}
-
tzik authored
STACK_ALLOCATED macro leaves `private:` section on clang build after https://crrev.com/c/1160424, and doesn't change the access specifier on non-clang build, that seems to confuse non-clang build. This CL unifies the difference to fix the non-clang build. Change-Id: I0fdd1236670a5dd64892c19fa642dd4d681e4008 Reviewed-on: https://chromium-review.googlesource.com/1164156Reviewed-by:
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I80b9e122132fd914da335e8d5133c4ffef831ac4 Reviewed-on: https://chromium-review.googlesource.com/1164729Reviewed-by:
-
Kouhei Ueno authored
Bug: 868592 Change-Id: Ida5a487e26634b5f424e82a0323acfab939ffe84 Reviewed-on: https://chromium-review.googlesource.com/1164149Reviewed-by:
-
Steve Anton authored
Bug: 787254 Change-Id: I081690b1e46a73705f86217f38a899706127feea Reviewed-on: https://chromium-review.googlesource.com/1161614Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#581141}
-
Weidong Guo authored
1. Fix test error ArcAppModelBuilderTest.IconLoadNonSupportedScales which is caused by icon file path not found. 64px icon is supported by CL http://go/cgcl/1154136. Test fails because the icon size with 2.0 scale factor, namely 128px, cannot be found, so add those icons. 2. Enable feature flag by default. Bug: 871444 Change-Id: I9f54f71cfb8cf2fbd73dcb2f9b7da514a231ad0f Reviewed-on: https://chromium-review.googlesource.com/1164243 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch simplifies the tests that confirms text selection upon drag selects differently on mac. I will move the test to selection/mouse. Bug: 811502, 866120 Change-Id: Id9bb292236b709b65a98be1eff3fc778da02264b Reviewed-on: https://chromium-review.googlesource.com/1163348 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581139}
-
Peter Collingbourne authored
The intent of crrev.com/579533 was to use the same symbol_level on sanitizer bots as we did before crrev.com/579330 landed by using the default symbol level on all sanitizer bots. That was thought to be 1 on every platform (which would match the previous behaviour), but it turns out that on Mac/Win, the default symbol_level on sanitizer bots is 2, not 1, so the effect of crrev.com/579330 was to increase the symbol level on those bots and crrev.com/579533 had no effect. This change implements the intent of crrev.com/579533 by setting the symbol level back to 1. Bug: 869361 Change-Id: I33e572b215b389fb7d0201f5e6d11415530d86b3 Reviewed-on: https://chromium-review.googlesource.com/1164532 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581138}
-
Mikel Astiz authored
These should allow tests in upcoming patches to mimic the experimentally supported scenario where sync the feature is disabled, but the sync machinery (the engine acting as a transport mechanism) is active as soon as the user is signed in, in a special mode (subset of datatypes, with ephemeral storage). As first user, we introduce a test for USER_CONSENTS. Bug: 856179,866814,814307 Change-Id: Ie3b6c2da470dde691862a379977b4e01c4f2ead2 Reviewed-on: https://chromium-review.googlesource.com/1160852 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#581137}
-
Yuta Kitamura authored
Currently, the main thread WebThread is owned by the embedder. We'd like to shift the ownership to Platform, so that we can stop exposing WebThread to embedders. As a first step, this patch introduces a new initialization method Platform::CreateMainThreadAndInitialize(), which is parallel to Platform::Initialize(). It is targeted to tests or other use cases which only require a simple execution environment of Blink. Currently, each embedder implements its own WebThread, but I'd like to unify those and remove them from non-Blink code eventually. The new CreateMainThreadAndInitialize() lets Platform own the main thread WebThread object, unlike Initialize(). Currently, Platform needs to handle two different cases: main thread owned or not owned, but this is only temporary, and they will eventually converge to the "owned" case. As a test bed, v8_context_snapshot_generator is migrated to the new initialization method. Bug: 826203 Change-Id: I14436509f420a5d73f2ce64722f41da5756fa45b Reviewed-on: https://chromium-review.googlesource.com/1163560 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
We aim to forbid V8 execution from the default task runner of the main thread. As one of the steps, this CL removes EmptyFrameScheduler that offers the default task runner instead of a per-frame task runner. By removing this, some assumptions are changed: Before this CL, a Page might not have a PageScheduler. After this CL, a Page always have a PageScheduler. This CL also moves |CSSAnimationsTest::platform_| and other similar variables to their ancenstor |PageTestBase::platform_| in order to assure that a scheduler owned by a platform is destroyed after a local frame is destroyed. This was necessary to pass the tests. Bug: 870606 Change-Id: I39bf80aea5d4ac01da125b47224620605fea16de Reviewed-on: https://chromium-review.googlesource.com/1162083 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Ned Nguyen authored
Bug:828472, 868162, 828466 Change-Id: Id68fa398fff62455e220946394bf7b53d285cc7a NOTRY=true # site_per_process_webkit_layout_tests flake Change-Id: Id68fa398fff62455e220946394bf7b53d285cc7a Reviewed-on: https://chromium-review.googlesource.com/1164535 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
