- 03 Jan, 2019 40 commits
-
-
Leonard Grey authored
Bug: 918553 Change-Id: I03c20eedeede033bcfb912672ab29f02e8090c14 Reviewed-on: https://chromium-review.googlesource.com/c/1393532Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619641}
-
Lowell Manners authored
None of the iOS tests need a TestUrlLoaderFactory, so we should not create one by default. Once FakeGaiaCookieManagerService is eliminated, tests will need to own the TestUrlLoaderFactory themselves, so it's better not to have a TestUrlLoaderFactory be created except when it will actually be used. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I420748e43f468858c33bd3d6c8b32f182e50a88f Reviewed-on: https://chromium-review.googlesource.com/c/1382497 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#619640}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b924e20a..5efb17b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I646ea4b6820cad608d94f64dbb15f7d6267eb19a Reviewed-on: https://chromium-review.googlesource.com/c/1394380Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619639}
-
Ian Kilpatrick authored
This adds a new test expectation file for the width-avoid-floats.html test. We believe that if/when fill-available does get specified, it should avoid floats similar to 'auto'. Bug: 635619 Change-Id: I1c112952ea70176c55106d9bd396034cbf5ca531 Reviewed-on: https://chromium-review.googlesource.com/c/1393667Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#619638}
-
Gabriel Charette authored
R=etiennep@chromium.org TBR=fdoray@chromium.org Bug: 915207 Change-Id: I3283dee3dad0d6f64cc70bb9bb49cebdac49616a Reviewed-on: https://chromium-review.googlesource.com/c/1394589Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#619637}
-
Nico Weber authored
See https://github.com/erikdoe/ocmock/issues/369 TBR=rnk Bug: none Change-Id: Ice9aca9e524d54eecb4bb41615f36c9926de1e2e Reviewed-on: https://chromium-review.googlesource.com/c/1394430Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619636}
-
Kevin Ellis authored
This patch improves test coverage for the interpolation of transform lists. Specifically, the new tests cover: * mismatched list lengths with a partial prefix match * mix of exact and primitive (e.g. scaleX & scaleY --> scale) matches These new tests fail in Chrome without the patch (https://chromium-review.googlesource.com/c/chromium/src/+/1372025) to implement the algorithm outlined in transforms spec (https://drafts.csswg.org/css-transforms-1/#interpolation-of-transforms), but pass when tested in Firefox version 64.0. Bug: 918643 Change-Id: I65bfe5b3c13c2fb33b3d2b926dc153135b140a63 Reviewed-on: https://chromium-review.googlesource.com/c/1393460Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#619635}
-
Egor Pasko authored
This reverts commit 09f15bdb. Reason for revert: http://crbug.com/918796 Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=wnwen@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ieb34a24da7c001e78d832f7300855c7c7c749add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988, 913554 Reviewed-on: https://chromium-review.googlesource.com/c/1394528Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619634}
-
Eric Noyau authored
Bug: None Change-Id: Iea5db9ccf1b792b45d4d0bf542f3900111802ccb Reviewed-on: https://chromium-review.googlesource.com/c/1394526Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#619633}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdde2926df92..8966b55644c2 git log fdde2926df92..8966b55644c2 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com Reland "undefine SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE" Created with: gclient setdep -r src/third_party/skia@8966b55644c2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I61cd4ef210740e401c1d34069f4dea5e7dccd00d Reviewed-on: https://chromium-review.googlesource.com/c/1394447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619632}
-
Henrik Boström authored
The tests started failing in an earlier WPT import, see https://crbug.com/832501. TBR=hta@chromium.org Bug: 832501 Change-Id: If53c927e03dabb60158c61befc5a29d1c45bba1f Reviewed-on: https://chromium-review.googlesource.com/c/1394307Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619631}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4abc078d238b..d0a1f2d4e2ab Created with: gclient setdep -r src-internal@d0a1f2d4e2ab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d3a8449745e4047f95143a19ab85eac8aa29bdf Reviewed-on: https://chromium-review.googlesource.com/c/1394199Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619630}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39e8ad8f..b924e20a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4af2c35a9ed69cdec2f5a6f055b29be450fb04dc Reviewed-on: https://chromium-review.googlesource.com/c/1394379Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619629}
-
Xida Chen authored
This CL does the plubming for the PaintWorkletLayerPainter. It follows the same implementation as the existing LayerTreeMutator which is designed for animation worklet. Change-Id: I173a61173e025d257f1782c5270e41ca24538e9e Reviewed-on: https://chromium-review.googlesource.com/c/1350332 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619628}
-
Colin Blundell authored
This CL inverts the dependency between SigninManager and SigninErrorController: rather than the former depending on the latter, the latter now depends on the former. The concrete motivation is that SigninManager forms part of the core implementation of the Identity Service, whereas SigninErrorController is fundamentally a client-side class: it coalesces authentication errors from various underlying sources in order to conveniently present global information to the UI. The inversion of the dependency is conceptually straightforward. Currently, SigninManager updates SigninErrorController's primary account ID when its own primary account is set/cleared. This CL changes SigninErrorController to explicitly check SigninManager's primary account ID and to observe SigninManager for changes to the primary account. Note that this change means that if the primary account were to be set/cleared on ChromeOS in an ongoing session, SigninErrorController would not be notified (since the SigninManager observer callbacks are not invoked on ChromeOS). However, in production on ChromeOS the primary account is set when SigninManagerBase is created and is never cleared. As of this CL, SigninManagerBase will be created before SigninErrorController (since the latter now depends on the former). This CL was unfortunately difficult to subdivide: the changes to make SigninErrorController depend on SigninManager and the changes to have SigninErrorController *use* SigninManager need to be made atomically in order to avoid the two objects depending on each other, which is an antipattern for KeyedServices. The meaningful changes are the ones to signin_error_controller.* and signin_manager_base.*. To test this change, I verified the following: - Start Chrome - Sign in to the browser - Sign out on the web (e.g., in gmail) - Observe that the "sync paused" error shows up in the avatator button on the top right of the chrome - Restart Chrome - Observe that the "sync paused" error is still present - Sign in to the browser again - Observe that the "sync paused" error goes away I also verified that the above behavior is dependent on SigninErrorController being correct by changing SigninErrorController::Update() to return immediately and verifying that the avatar button never changes through the above set of steps. Followup CLs will move signin_error_controller.* out of the signin_internals GN target and will port SigninErrorController to talk to IdentityManager. TBR=droger@chromium.org Bug: 917836 Change-Id: I7e4a66bcffa4c1d3a8f296dabbf6a7c38602b5fa Reviewed-on: https://chromium-review.googlesource.com/c/1390012 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#619627}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4cfddf92. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2a9c667753b136145712e4f4944a514cdf3a4b29 Reviewed-on: https://chromium-review.googlesource.com/c/1394378Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619626}
-
Mark Cogan authored
The ViewControllerSwapping method -showTabSwitcher: had a completion parameter that was no longer being used. Change-Id: Ife1b0609191868d9a3505d8ea0657c54c8ed25dc Reviewed-on: https://chromium-review.googlesource.com/c/1392341 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619625}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6523d678d86c8ece5b33483e5a93fe96868790da Reviewed-on: https://chromium-review.googlesource.com/c/1394446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28aa65d24293..4abc078d238b Created with: gclient setdep -r src-internal@4abc078d238b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4c079efe300be08b97a6208402fbb1ae9373a902 Reviewed-on: https://chromium-review.googlesource.com/c/1394198Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619623}
-
Khushal Sagar authored
The ClientPaintCache assumes that once an entry has been added to its state tracking, it is guarenteed to be transferred to the service side cache and is removed only when explicitly purged. This assumption is not true in the case where serializing an op fails due to insufficient memory. In this scenario, the memory is remapped and the op is re-serialized but any changes made to the ClientPaintCache state, supposed to be a mirror of the service side state, are not actually made to the service side state. This cause the Client and Service PaintCaches to get in an inconsistent state and we fail to raster the tile due to deserialization failures. Avoid this by tracking the serialized cache entries in a pending list that is committed only when the data is guarenteed to be transferred to the service, and discarded otherwise. R=enne@chromium.org, ericrk@chromium.org Bug: 912282 Change-Id: I96d4108acb4903ce0ff48b54718c65b61805e103 Reviewed-on: https://chromium-review.googlesource.com/c/1393138 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#619622}
-
Finnur Thorarinsson authored
The UX design calls for showing only one number/email on-screen, and have the rest show only in details view (a view that will appear in an upcoming CL). Bug: 860467 Change-Id: Ifaccdbd89b0fc5041cef7c05e288469032f5e78b Reviewed-on: https://chromium-review.googlesource.com/c/1393368Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#619621}
-
A Olsen authored
- Changes OwnerSettingsServiceChromeOsFactory so that its stubbed behavior can be used without setting a switch - Changes CrosSettings so that it can be stubbed during a test without worrying about it being reinitialized later - Add a new class ScopedTestingCrosSettings that makes use of this new functionality, is much simpler than ScopedCrosSettingsTestHelper. - Changes one test - users_private_apitest.cc - that previously used switches, so that it no longer uses switches, as a proof-of-concept. For more details, see the bug. Bug: 909635 Change-Id: I57b053038592512fb7cfb7c09061d5d03475e979 Reviewed-on: https://chromium-review.googlesource.com/c/1392186 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/512058c06578..28aa65d24293 Created with: gclient setdep -r src-internal@28aa65d24293 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I562aad60a5eaca06c056e3b0c1b85a90eb2fe6fa Reviewed-on: https://chromium-review.googlesource.com/c/1394196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619619}
-
Rune Lillesveen authored
In the dynamic profile, /deep/ have been translated into descendant combinators for a while. Removing selectors from webui which should have no effect. Bug: 794083 Change-Id: Ic30ad81bd8ae14adf4f36b4fdc718b355dd96fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1392952Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#619618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aae6ae39a356..fdde2926df92 git log aae6ae39a356..fdde2926df92 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 904bb9185767..4627b3705d59 (1 commits) Created with: gclient setdep -r src/third_party/skia@fdde2926df92 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I79b0340bd6cd4b9d6f2be288660c3331002740d2 Reviewed-on: https://chromium-review.googlesource.com/c/1394197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619617}
-
Morten Stenshorne authored
Place them together with their friends. :) And use appropriate bug numbers. TBR=eae@chromium.org Bug: 829028, 875235, 918663 Change-Id: Ib8c5164747dc433e145984c869ce1fd19557686d Reviewed-on: https://chromium-review.googlesource.com/c/1394305Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619616}
-
Jérôme Lebel authored
|_unifiedConsentCoordinator| should be removed once the sign-in is done and the user consent is recorded. This is to avoid to receive notifications related to the UIScrollView in UnifiedConsentViewController, like: -[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:] Bug: 918557 Change-Id: I9d57dbf4d9f37f636fa44105f268d7089e192abf Reviewed-on: https://chromium-review.googlesource.com/c/1393372Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619615}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/013602ac..39e8ad8f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3703e140485fa6cddbeaaf14943557b2a550485 Reviewed-on: https://chromium-review.googlesource.com/c/1394375Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619614}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cff4a724. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1c14ef3c2c82ab5426a48dded689b007d54db29c Reviewed-on: https://chromium-review.googlesource.com/c/1394373Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619613}
-
Sergio Villar Senin authored
A new function has to be added to identity_test_utils in order to set the maximum number of authentication token fetch retries to 0, i.e., to disable retries. Bug: 912171 Change-Id: I7f39f8b0aec5c180a92a2b26cb3e6a73f58645b1 Reviewed-on: https://chromium-review.googlesource.com/c/1386791 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#619612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d238bb67a52a..2b9d702c09f1 git log d238bb67a52a..2b9d702c09f1 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 yunchao.he@intel.com Fix a bug for depth test on Vulkan backend Created with: gclient setdep -r src/third_party/dawn@2b9d702c09f1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I39f7f4705c05de016c25f467dfab2cbffeab51f6 Reviewed-on: https://chromium-review.googlesource.com/c/1394194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619611}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7b477b1120e..4f718c120c1e git log b7b477b1120e..4f718c120c1e --date=short --no-merges --format='%ad %ae %s' 2019-01-03 primiano@google.com Merge "Extract base::UnixSocketRaw" Created with: gclient setdep -r src/third_party/perfetto@4f718c120c1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I49d0496f3b002553b0b9c5d639c097f3d166054f Reviewed-on: https://chromium-review.googlesource.com/c/1394195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619610}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I43853fea01bd25d4c8be1c92ec029911e306ea8d Reviewed-on: https://chromium-review.googlesource.com/c/1394445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619609}
-
Dominik Röttsches authored
DWriteFontProxy is no longer implemented as a message filter but is a regular Mojo service now. Rename files from *_message_filter_* to *_impl_*. Change-Id: I8e5202993c45168636a2e09287f69da397ac5092 Reviewed-on: https://chromium-review.googlesource.com/c/1392345 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619608}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995eb7e708cf..512058c06578 Created with: gclient setdep -r src-internal@512058c06578 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie31ed8527bbd110b365001cbff55455904e6c6ed Reviewed-on: https://chromium-review.googlesource.com/c/1394444Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619607}
-
Eric Seckler authored
perfetto_unittests and content_unittests seem to be passing. Other test suites (content_browsertests / services_unittests) aren't currently supported on Fuchsia so can't yet verify that everything works in practice. Depends on aosp/853409 and aosp/859117. Bug: 916074 Change-Id: I6d7c034fdf9e3086e08b6a1338e78f75a1c86afd Reviewed-on: https://chromium-review.googlesource.com/c/1382134Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#619606}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0fe2ff41..013602ac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6d4eb78a69583fbfc6777c7f86d99a4e47263d6 Reviewed-on: https://chromium-review.googlesource.com/c/1394368Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619605}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96345a23dfa9..aae6ae39a356 git log 96345a23dfa9..aae6ae39a356 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@aae6ae39a356 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I9331ddf10087b5410949b21a8a81b3d48c5b8864 Reviewed-on: https://chromium-review.googlesource.com/c/1394443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619604}
-
Mohsen Izadi authored
This used to represent three different modes: disabled, simple ui, parallax ui. Now that the parallax mode is removed, we can use a simple bool. BUG=890390 Change-Id: Ic96fb6fa82c0fa2f9071e39ef5b0b10af5587e75 Reviewed-on: https://chromium-review.googlesource.com/c/1275205Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619603}
-
Tomasz Moniuszko authored
Bug: 918516 Change-Id: Id97aac57ef7e4bc64e312712068d8500f1d2f4e2 Reviewed-on: https://chromium-review.googlesource.com/c/1386432 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#619602}
-