GitLab

A fix for the bidi leak was committed as blink r164996 thus the
suppressions are no longer needed.

R=thakis@chromium.org
BUG=333572

Review URL: https://codereview.chromium.org/138453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
NOTRY=true
R=sky@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/138363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245169 0039d316-1c4b-4281-b951-d872f2087c98

The capitalization on two of the histograms were wrong, and
it was missing a TimeOnline value.

R=isherman@chromium.org
BUG=209709
TEST=Start chrome, and browse to chrome://histograms to make sure
these enums now exist after starting a VPN connection.

Review URL: https://codereview.chromium.org/138343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245168 0039d316-1c4b-4281-b951-d872f2087c98

Adding a LaunchApp command to Chromedriver using the Chrome management API in the background extension, this will give developers an improved way to launch apps over having to navigate to the chrome://apps page and click on the app tile.

BUG=

Review URL: https://codereview.chromium.org/114403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334278

Review URL: https://codereview.chromium.org/138413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245166 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=erg@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/138343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245165 0039d316-1c4b-4281-b951-d872f2087c98

Previously no API is provided to report drive sync errors to JavaScript side.
This CL adds the API and colllecs erros by using OperationObserver.

BUG=260510

Review URL: https://codereview.chromium.org/137903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334461
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/138273006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245163 0039d316-1c4b-4281-b951-d872f2087c98

Create HpackEncodingContext, HpackHeaderTable, and HpackEntry classes,
which are based on the draft
http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-04 .

Implement some basic tests.

This implementation is based on
https://github.com/akalin-chromium/httpbis-header-compression and
https://codereview.chromium.org/22074002/ (which was based on an
earlier draft).

This lands server change 55803359 by akalin.

R=akalin@chromium.org

Review URL: https://codereview.chromium.org/138243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245162 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/332504

R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245010

Review URL: https://codereview.chromium.org/138223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
R=ananta@chromium.org,finnur@chromium.org

Review URL: https://codereview.chromium.org/138213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334878

TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/138143013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245159 0039d316-1c4b-4281-b951-d872f2087c98

Set the debug app for user build devices programatically.
This allows running some telemetry benchmarks without any intervention.

BUG=334007
TEST=tools/perf/run_benchmark -vvvv --browser=android-chrome --show-stdout octane

Review URL: https://codereview.chromium.org/138093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245158 0039d316-1c4b-4281-b951-d872f2087c98

Instead of initiating sync startup during initialization of the
SettingsBackend, only do so when an actual change takes place,
which was the original intent of https://codereview.chromium.org/15404005

BUG=80194

Review URL: https://codereview.chromium.org/138073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245157 0039d316-1c4b-4281-b951-d872f2087c98

Ensure there's always a HandleClientSizeChanged call that happens when the bounds change (even if that doesn't cause the actual bounds of the HWND to change), as otherwise the view size will be stale.

BUG=330123

Review URL: https://codereview.chromium.org/138073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245156 0039d316-1c4b-4281-b951-d872f2087c98

There is no more ShouldShowMergeSessionPage, so the comment speaking about it is no longer needed.

NOTRY=true
BUG=243364

Review URL: https://codereview.chromium.org/138063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245155 0039d316-1c4b-4281-b951-d872f2087c98

leveldb::Slice holds a pointer to the string passed to it, so the string must
outlive the slice itself.

BUG=284553

Review URL: https://codereview.chromium.org/138053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
NOTRY=true
R=msw@chromium.org

Review URL: https://codereview.chromium.org/138053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245153 0039d316-1c4b-4281-b951-d872f2087c98

In TouchEditable interface, almost all points are expected to be in
local coordinates of the editable view, except GetBounds() which wrongly
expects points in the parent view coordinates. Up to r244436, this was
not a problem since editable views completely covered their parents and
have the same coordinates with them. Fixing this situation to prevent
similar problems in the future.

BUG=334009

Review URL: https://codereview.chromium.org/138023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245152 0039d316-1c4b-4281-b951-d872f2087c98

BUG= None
TEST= None

Review URL: https://codereview.chromium.org/137993016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330851

Review URL: https://codereview.chromium.org/128683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/137993011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
NOTRY=true
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/137993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245148 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 17dad9d5.

Although simple in principle, the Python C extension approach does not fit the
diversity of our infrastructure.

We will need a better method to address the speed requirements for
ColorHistogram.

BUG=333606,323813,334097,333361,334523
TBR=tonyg,maruel

Review URL: https://codereview.chromium.org/138143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245145 0039d316-1c4b-4281-b951-d872f2087c98

This relands digit@'s CL that completely reworks the traffic forwarding logic
and that should guarantee in particular that select() never blocks without a
good reason (i.e. that we are not leaking Forwarder instances due to the fact
that their internal thread would be blocked on select()).

The initial problem with r235213 was only the use of PipeNotifier which added
two file descriptors for each Forwarder instance (in addition to the two
sockets the Forwarder instance operates on). We were exceeding the file
descriptor limit (1024) on the intl_ko_th_vi Telemetry page set which is not
surprising since Chrome easily keeps 256 sockets around in its socket pool.
Therefore this change simply removes the PipeNotifier since we were not (yet)
using it anyway.

The initial problem was reproduced and the fix was tested as well with:
tools/perf/run_measurement -v --browser=android-chromium-testshell \
    --show-stdout page_cycler tools/perf/page_sets/intl_ko_th_vi.json

Note that a next step would be to have all the Forwarder instances operate on a
common thread owned by DeviceListener so that we don't end up with 256 threads.

BUG=332403

Review URL: https://codereview.chromium.org/137923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245144 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/137913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178409
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/139723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245142 0039d316-1c4b-4281-b951-d872f2087c98

The one interesting bit is this makes mojo use the aura theme rather
than the android theme.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/139623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245141 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245140 0039d316-1c4b-4281-b951-d872f2087c98

libwebm will be used by chromoting client to generate WebM stream for
MediaSource API.

BUG=321825

Review URL: https://codereview.chromium.org/134643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245139 0039d316-1c4b-4281-b951-d872f2087c98

On Android, viewing the data reduction settings screen would
trigger configuring the proxy, even if the user did not change
the data reduction proxy enabled pref. This CL limits
reconfigurations to actual pref changes, which reduces the work
Chrome needs to do.

BUG=181049

Review URL: https://codereview.chromium.org/124793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245138 0039d316-1c4b-4281-b951-d872f2087c98

This adds a very basic surface class with tests under cc/surfaces
to establish gyp and DEPS rules. While this system is under early
development it shouldn't be used by anything outside of unit tests.

BUG=334090

Review URL: https://codereview.chromium.org/131893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245137 0039d316-1c4b-4281-b951-d872f2087c98

icu.isolate file added in https://codereview.chromium.org/99073008/
is used where icudt.dll is directly listed for
'isolate_dependency_tracked'.

icu.isolate includes either icudtl.dat or icudt.dll depending on
'OS' and 'icu_use_data_file_flag'.

Besides, 'icu_use_data_file_flag' is added to build/isolate.gypi as a
config-variable.

Once the above icu-side CL is checked in, this CL will also includes
icu DEPS roll.

This is a prerequisite for the following CLs to use icudtl.dat :

Windows : https://codereview.chromium.org/99473012
Linux : https://codereview.chromium.org/102413007
Mac : https://codereview.chromium.org/109013004

BUG=72633
TEST=All tests utilizing isolate pass on bots.

Review URL: https://codereview.chromium.org/124143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245136 0039d316-1c4b-4281-b951-d872f2087c98

    
This change splits ChromiumEnv into two classes: ChromiumEnv/ChromiumEnvPosix.
ChromiumEnvWin32 was also added which uses the Win32 API - except for logging.

The default is to create POSIX environments for all platforms for non-IDB
LevelDB users. For IDB we create a Windows environment on Windows, else a
POSIX environment like before.

BUG=222623

Review URL: https://codereview.chromium.org/113373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245135 0039d316-1c4b-4281-b951-d872f2087c98

The policy protobufs were duplicated at chrome/browser/policy/proto
so that the protofiles ebuild of ChromeOS could still fetch them.
That ebuild has been fixed in a separate CL at:

  https://chromium-review.googlesource.com/#/c/182300/

BUG=327345

Review URL: https://codereview.chromium.org/137903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245133 0039d316-1c4b-4281-b951-d872f2087c98

Currently there's a symbol retrieval in place every time someone asks for
a NSString* inside the AVFoundation library. Change this so that the
AVFoundationInternal retrieves them on construction and caches them. This
CL should not change the behaviour of the avfoundation_glue.

BUG=323536, 288562

Review URL: https://codereview.chromium.org/137903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245132 0039d316-1c4b-4281-b951-d872f2087c98

Move the bulk of the files in content/browser/aura to
content/browser/compositor, since they're not aura-specific.

Build all of those files in the Mac build, and add ui/compositor
to the dependencies of the Mac build. These files will soon only
be excluded from the Android build.

BUG=314190

Review URL: https://codereview.chromium.org/137893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245131 0039d316-1c4b-4281-b951-d872f2087c98

Android requires us to call restart input when input node changes.
Previously we relied on onHandleGesture which is not the right way
to do it.

BUG=242715

Review URL: https://codereview.chromium.org/56643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245128 0039d316-1c4b-4281-b951-d872f2087c98

This is a regression introduced by 97028206 (bug 299224).

BUG= 
TEST=Go to youtube.com or dailymotion.com. Start playing Flash video. Middle-click one of suggested link to videos to open new tab in background. Activate the tab you've just opened. Expected: Flash video should be playing in active tab. Current: Flash video is not playing until you scroll the page.

Review URL: https://codereview.chromium.org/137883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245127 0039d316-1c4b-4281-b951-d872f2087c98