GitLab

If the main thread is unblocked and we access this function on the impl thread,
we're in a racy situation. This should be an error.

BUG=235188

Review URL: https://chromiumcodereview.appspot.com/14179022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202942 0039d316-1c4b-4281-b951-d872f2087c98

Pulls the call to open a new user's first window out of the ProfileManager and
into the UI layer that called for the creation of the new user. This improves
code layering (ProfileManager shouldn't have to know about the host desktop type)
and allows us to communicate errors during user creation (also
partially added here, although most errors aren't yet captured).

BUG=153864, 243379
TEST=existing unit tests

Review URL: https://chromiumcodereview.appspot.com/15734006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202939 0039d316-1c4b-4281-b951-d872f2087c98

When a user of the spelling service right-clicks on a misspelled word and 
selects 'Add to dictionary', the SpellingMenuObserver notifies spelling service
feedback sender. This feedback will be used to improve spellcheck suggestions 
from spelling service.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15736012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238418

Review URL: https://chromiumcodereview.appspot.com/14646034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202937 0039d316-1c4b-4281-b951-d872f2087c98

+remove separators in creation dialogs.

TBR=derat@chromium.org, nkostylev@chromium.org, oshima@chromium.org

NOTRY=true
Because of changes in binaries.
BUG=229762

Review URL: https://codereview.chromium.org/16103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202934 0039d316-1c4b-4281-b951-d872f2087c98

Like the previous Blink roll of 151349:151373, this breaks WebViewInteractiveTest.PopupPositioningMoved on the Mac.


TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15797008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202933 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/16082003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202931 0039d316-1c4b-4281-b951-d872f2087c98

TBR=lambroslambrou@chromium.org
BUG=244562

Review URL: https://codereview.chromium.org/15827007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202930 0039d316-1c4b-4281-b951-d872f2087c98

MacOS and Linux are currently not supported. This will come in a later CL.

BUG=242540

Review URL: https://chromiumcodereview.appspot.com/15738013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202929 0039d316-1c4b-4281-b951-d872f2087c98

This change causes us to not process any headers unless they are correctly
terminated with a \r\n\r\n sequence.

BUG=244260

Review URL: https://chromiumcodereview.appspot.com/15688012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202927 0039d316-1c4b-4281-b951-d872f2087c98

Before, if a custom auth extension is given through the --auth-ext-path flag,
the manifest is loaded from the browser resource rather than the overriden
path. We want to load the manifest from the given path instead. 
Also change ComponentLoader::AddOrReplace to return an empty string on failure
for consistency with other ComponentLoader functions.

BUG=239212
TEST=on cros device with custom telemetry auth extension

Review URL: https://chromiumcodereview.appspot.com/15937003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202926 0039d316-1c4b-4281-b951-d872f2087c98

A dangerous download can be accepted by the user or rejected. If
rejected, the downloaded file used to be deleted. This change adds
DownloadItem::AcquireFileAndDeleteDownload() which allows the caller to
acquire the dangerous file.

The intended consumer of this feature is SafeBrowsing where the caller
may want to acquire a dangerous file that's being discarded for the
purpose of further analysis.

Also change the logic during shutdown to no longer delete dangerous
downloads, but to cancel them.

TBR=rdsmith
BUG=244604

Review URL: https://chromiumcodereview.appspot.com/14947007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16026006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202920 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151394&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/15881007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202919 0039d316-1c4b-4281-b951-d872f2087c98

* Parent classes in alphabetical order.
* Overrides as private as possible, and in same order as parent classes.  We
  also keep the .cc file order matching the .h file.
* Remove AlwaysDrawText() entirely as it was never called.  This also means we
  can remove |force_draw_text_|.
* Inline SetImage(), SetTooltipText(), StartLabelAnimation(), PauseAnimation(),
  and UnpauseAnimation() into their lone callers.  Inline AnimationOnClick()
  into OnClick() since the two were always called together.
* Remove the scoped_ptr<> on |slide_animator_| and initialize it in the
  constructor, instead of the first time we want to animate.
* Eliminate |font_color_| since it was never used.  (We will eventually use the
  color the parent supplies us, so the constructor arg sticks around.)
* Separate out three other members that will be going away in the future.  Put
  the other ones into some sort of hopefully-logical order.
* DISALLOW_IMPLICIT_CONSTRUCTORS -> DISALLOW_COPY_AND_ASSIGN.

The changes in the .cc file are basically just deleting and reordering code,
plus "->" to "." conversions for |slide_animator_|.  I avoided doing any other
cleanup/rewriting, to keep this change "basically mechanical".

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/15732018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202917 0039d316-1c4b-4281-b951-d872f2087c98

* Eliminte the distinction between "item to item padding" and "item to edge
  padding" because the two values are always equal.
* Don't bother supporting "height 0 = use preferred height" in
  location_bar_layout.*, since only one caller uses it at this point and it's
  easier to understand the code by just making it explicit.
* Switch to using a views::Painter for the popup mode background as well,
  instead of explicitly drawing the images.  This will make it easy to switch
  both modes to ninebox painting in the future.
* Try to reorder code in order to declare variables as close to their use as
  possible, and in the order that they're accessed.
* Visible change: Instead of assuming the edit always has 1 px. of "internal
  space", calculate the correct conditions for which that's true.  This results
  in the OmniboxViewViews text moving right by 1 px. in the LTR case.

BUG=231005,239902
TEST=With "views textfield" on, address bar text moves 1 px. right
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16025004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202916 0039d316-1c4b-4281-b951-d872f2087c98

This should solve the flakiness we've been seeing.

BUG=236102

Review URL: https://chromiumcodereview.appspot.com/15688006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:271
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/16155004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202914 0039d316-1c4b-4281-b951-d872f2087c98

CryptoModulePasswordDialogView uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c107 
Trigger with debug code in Patch Set 1. 

BUG=166075
TEST=Crtypo module password dialog does not have an extra border. 
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/15859013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202912 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r191582.

R=danno@chromium.org
BUG=225325

Review URL: https://chromiumcodereview.appspot.com/15951011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202911 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r201447. SetOpacity() was hooked up backwards; I got confused
while reading the GTK+ code. However, if the "255 -" is simply removed, menus
stop showing. It looks like the menu system is still calling SetOpacity(0).

BUG=none
TBR=sidharthms@google.com,sky@chromium.org

Review URL: https://codereview.chromium.org/16189008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202910 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202908 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yfriedman@chromium.org
BUG=239595

Review URL: https://codereview.chromium.org/16176003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202907 0039d316-1c4b-4281-b951-d872f2087c98

iOS should pull the new Blink headers used by all the other platforms
now that the mirror repo exists.

The old WebKit header pull will be removed once nothing references
headers in those locations any more.

BUG=242829
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/15931004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243957
TEST=BrowserTest.NoStopDuringTransferUntilCommit

Review URL: https://chromiumcodereview.appspot.com/15742019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202904 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202903 0039d316-1c4b-4281-b951-d872f2087c98

Picks up support for Blink header-only repo for iOS.

BUG=242829
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/15651005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202901 0039d316-1c4b-4281-b951-d872f2087c98

They should be inclusive, not exclusive.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/16093009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202900 0039d316-1c4b-4281-b951-d872f2087c98

Drive-by Clang warning fix.

BUG=82385

Review URL: https://chromiumcodereview.appspot.com/15952003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202899 0039d316-1c4b-4281-b951-d872f2087c98

Also sort setting the policies by key.

BUG=233135
R=joaodasilva@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16072008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202898 0039d316-1c4b-4281-b951-d872f2087c98

Sample output:

Traceback (most recent call last):
  File "./tools/run-bisect-perf-regression.py", line 39, in LoadConfigFile
    local_vars)
  File "/usr/local/google/home/simonhatch/chromium/src/tools/run-bisect-perf-regression.cfg", line 64
    'truncate_percent':'',
                      ^
SyntaxError: invalid syntax

Error: Could not load config file. Double check your changes to run-bisect-perf-regression.cfg for syntax errors.


BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16007011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202897 0039d316-1c4b-4281-b951-d872f2087c98

Run as "python tools\win\split_link\graph_dependencies.py output.html"

Outputs a standalone html file so it can go on simple bot storage (coming
at some point).

R=jamesr@chromium.org
BUG=237249

Review URL: https://codereview.chromium.org/16196002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202896 0039d316-1c4b-4281-b951-d872f2087c98

* Changed the output directory option to '-s' and '--skp-outdir' because this was broken, running run_multipage_benchmarks with skpicture_printer resulted in the following error: 
optparse.OptionConflictError: option -o/--outdir: conflicting option string(s): -o 

* Added additional browser options due on recent changes in Skia/Chromium code base.

Review URL: https://chromiumcodereview.appspot.com/15665003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202895 0039d316-1c4b-4281-b951-d872f2087c98

This contains the binary drawables related to the following
CL, which implements the color picker for Chromium for Android:
https://codereview.chromium.org/14170009

Patch by Paul Navin <paulnavin@google.com>

TBR=yfriedman
BUG=135771

Review URL: https://codereview.chromium.org/15773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202894 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138226

Review URL: https://chromiumcodereview.appspot.com/15690007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202891 0039d316-1c4b-4281-b951-d872f2087c98

 - fixed the suppression for libevent to contain the correct filename (issue 23244)
 - removed the race:base::Thread::ThreadMain suppression, which was too broad (issue 115540)
 - suppressed a race in skia::BeginPlatformPaint (issue 244368)
 - suppressed a race in unixTempFileDir (issue 244385)

BUG=23244,115540,244368,244385
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/15771007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202890 0039d316-1c4b-4281-b951-d872f2087c98