- 26 Oct, 2018 40 commits
-
-
Dave Tapuska authored
Now that the change has been merged to the HTML spec we can remove the suffix. Fixes web-platform-tests/wpt/issues/13736 BUG=846858 Change-Id: Ic12b90c44126f801827bba7057a53fe640fa2859 Reviewed-on: https://chromium-review.googlesource.com/c/1301841Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#603108}
-
Becca Hughes authored
This test can be enabled again. BUG=841933 Change-Id: I8729daf0584da308f089502f0730ae398befb022 Reviewed-on: https://chromium-review.googlesource.com/c/1299550Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603107}
-
Sylvain Defresne authored
All clients of BCKSF uses the new API taking a base::Callback<> instead of the deprecated API that was using a raw function pointer. Remove the now obsolete deprecated API. Bug: 809610 Change-Id: I18359b2f91a1a6d9445affcf4720eed528d74af3 Reviewed-on: https://chromium-review.googlesource.com/c/1297354Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#603106}
-
W. James MacLean authored
These DCHECKs can be triggered during user touchscreen pinch, and are blocking work in https://chromium-review.googlesource.com/c/chromium/src/+/1286437/. Temporarily disable them until we can handle GesturePinch events properly. Bug: 897216 Change-Id: I2a37c468133340a95ec2b3f580a966dd71451482 Reviewed-on: https://chromium-review.googlesource.com/c/1301567 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603105}
-
Jordan Demeulenaere authored
Screenshot: https://screenshot.googleplex.com/kgCWVfNQx5e.png Issue: b/118246783 Bug: 806868 Change-Id: I20f38afdbcdeb66c14b747aaa7b92f03ebf460a6 Reviewed-on: https://chromium-review.googlesource.com/c/1299159Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#603104}
-
Scott Graham authored
Bug: 808287 Change-Id: I98e37d5baba3fd8784bbcaf8dcdafdf7f83518d1 Reviewed-on: https://chromium-review.googlesource.com/c/1296838Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603103}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cce05b09..262cfc4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie37e4419fd2dd9b157a4db6b1d4c08720db1c9c5 Reviewed-on: https://chromium-review.googlesource.com/c/1301564Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603102}
-
Dave Tapuska authored
Use wtf_size_t where appropriate. BUG=879657 Change-Id: I26f766e7f6f29c6beaf0d396d665f1eba1235d83 Reviewed-on: https://chromium-review.googlesource.com/c/1298246 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603101}
-
Tibor Goldschwendt authored
This is a reland of 0275d360 with a fix for x86 builders, which have VR disabled. Original change's description: > [vr] On-demand install VR dynamic feature module > > With this CL we initate the module install once the user enters VR on a > WebXR/VR page. In more detail this CL > > - Introduces native VrModuleDelegate used to request VR module from > native, > > - Refactors GvrDevice to request the VR module as part of its > initialization flow, > > - Adds native side of the VrModuleProvider for Java-native > communication. > > Bug: 862689 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602922} TBR=tedchoc@chromium.org,billorr@chromium.org Bug: 862689 Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1301568Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603100}
-
Peter Kasting authored
This also removes the MaterialDesignController mode enum and converts to a bool. This also adds a test that tablet mode changes won't affect the MD controller when it's forced to non-touch mode. Bug: none Change-Id: I185dbeec48189865e19b4432c1556b6a7d5692dd Reviewed-on: https://chromium-review.googlesource.com/c/1298498 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603099}
-
Ian Clelland authored
Bug: 899222 Change-Id: I4b87bc05b9333f74bd7c2286f8e2a913732ac6ce Tbr: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1301565Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#603098}
-
Peter Kasting authored
De-parameterizes one test that doesn't care about the MD mode. Removes a death test that won't consistently pass now and will soon be completely meaningless. (This was the source of the previous landing failure.) Bug: none Change-Id: I30fd5ed1ff06a14d757dbccdf8ac1d51cc0ac19e Reviewed-on: https://chromium-review.googlesource.com/c/1300109Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603097}
-
Harley Li authored
If a cached resource is from an opaque response, it will by design takes up more cache storage space than its real size. The indication inside the data grid of Application > Cache Storage shows the response type so users won't be baffled about unexpectedly huge cache storage usage. Resolved the merge conflict in CL1256018. Bug: 847462 Change-Id: I885dd62cc3528d29fd4abd789e4727aca028ba59 Reviewed-on: https://chromium-review.googlesource.com/c/1259299Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603096}
-
Roger Tawa authored
Bug: 898303 Change-Id: Icbc202b2924ebca3bd633073175f216b47a858d0 Reviewed-on: https://chromium-review.googlesource.com/c/1297449 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603095}
-
Pavel Shmakov authored
When an app hosting TWA is uninstalled or has it's data cleared, we show a notification that prompts the user to clear the data of corresponding websites. This CL implements the actual clearing. It should be performed in the same way as in the preferences for single websites, so I extract and reuse a method from SingleWebsitePreferences. Bug: 888949 Change-Id: I020ac697c16c08ad03b88a4ecd0c099ab5655275 Reviewed-on: https://chromium-review.googlesource.com/c/1290936 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#603094}
-
Mostyn Bramley-Moore authored
std::isnan seems to be used a lot more in the tree and other cmath functions are used in base_rendering_context_2d.cc, so let's use std::isnan here too. This has a side benefit of working on some older toolchains that don't like to mix math.h and cmath. While we're at it, include the required header files for other standard library types. Change-Id: I61c9333c984dd1332f1f18ce21550474a193275c Reviewed-on: https://chromium-review.googlesource.com/c/1301440Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#603093}
-
Xi Han authored
This CL instantiates the ServiceManagerContext before creating the BrowserMainRunner. It splits the startup path into two, with/without starting the full browser. The changes are implemented behind a flag "allow-start-service-manager-only". Bug: 846846,729596 Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568 Reviewed-on: https://chromium-review.googlesource.com/c/1113802 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#603092}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f git log 603c5da17491..e2fd74b48f6f --date=short --no-merges --format='%ad %ae %s' 2018-10-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e2fd74b48f6f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I81513ad4b54319c199819eb08a01adf504aa1bcf Reviewed-on: https://chromium-review.googlesource.com/c/1301537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603091}
-
Vladislav Kaznacheev authored
Bug: 876125 Test: manual Change-Id: I4e68cb980e829c4070d2735dd6dc4e1b6649d539 Reviewed-on: https://chromium-review.googlesource.com/c/1300217Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#603090}
-
Yi Gu authored
This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I7fd64fcfb4a135d13e02574602111299d672139f Reviewed-on: https://chromium-review.googlesource.com/c/1301563Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603089}
-
Nico Weber authored
This function is now used to zip the remoting installer on mac. That zip contains a .sh script that the build server extracts and tries to run, so make sure it remains executable after unpacking. Bug: 875279,870611 Change-Id: Ia515a997f9d67943daa8e09907b52ec070650de2 Reviewed-on: https://chromium-review.googlesource.com/c/1301793 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603088}
-
Jeremy Roman authored
This removes deprecated uses of V8CallBoolean, and takes advantage of the fact that some of these complicated objects can be more concisely constructed from script. Bug: 670615 Change-Id: Ie4a3cc6404559240a7cb0ea07736e7db0648f4d8 Reviewed-on: https://chromium-review.googlesource.com/c/1299339 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603087}
-
Roger Tawa authored
Bug: 899077 Change-Id: I5247aee260df04a450b485b6b55d25c2ae1fc2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1300107 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f75bf6c00916..bb4f1a567bdc Created with: gclient setdep -r src-internal@bb4f1a567bdc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8c5493e3815fa709d7a527b8b29bc1f547a16c4a Reviewed-on: https://chromium-review.googlesource.com/c/1301538Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603085}
-
David 'Digit' Turner authored
The trace_event_argument.h header was renamed to traced_value.h in a previous CL, this one updates all includes in //ui/ to use the new header. BUG=898787 R=sadrul@chromium.org,sky@chromium.org,thakis@chromium.org Change-Id: I8943695f5764134d2191235ee72a2575b1676607 Reviewed-on: https://chromium-review.googlesource.com/c/1301465Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#603084}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a5d543ce21cd..2769cd540c1e git log a5d543ce21cd..2769cd540c1e --date=short --no-merges --format='%ad %ae %s' 2018-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f54583b6..a539a245 (602763:603045) 2018-10-26 kthelgason@webrtc.org Allocate CMBlockBuffers using a memory pool. 2018-10-26 terelius@webrtc.org Reland "Encode RTC event logs in new format." Created with: gclient setdep -r src/third_party/webrtc@2769cd540c1e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3442c5036f6ba61b9675eb64f2643927597ac32b Reviewed-on: https://chromium-review.googlesource.com/c/1301536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603083}
-
Alex Clarke authored
They didn't reveal any leads, and are somewhat expensive. Bug: 798554, 897751 Change-Id: Id22b59ccd43b823902c48a4b5f324ccea07e9649 Reviewed-on: https://chromium-review.googlesource.com/c/1301463Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603082}
-
Friedrich Horschig authored
With this CL, there will be a KeyboardVisibilityDelegate specific to the ChromeActivity. This allows to consider keyboard extensions whenever the delegate is called. That means, if an accessory sheet is open, for every component listening or querying the keyboard, it will appear as if the sheet was a native keyboard. This defeats a lot of bugs in which components treat the accessory different from the keyboard (see linked bugs below). Bug: 894747, 895779, 881784, 898468, 897579 Change-Id: I52c234092b78f449f343c2166f9b3b1e52772a66 Reviewed-on: https://chromium-review.googlesource.com/c/1286426 Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#603081}
-
Alexander Timin authored
Address a common pattern of usage by replacing MessageLoopCurrent comparison with explicit method call. R=gab@chromium.org TBR=gab@chromium.org CC=alexclarke@chromium.org BUG=891670 Change-Id: I0f6a7f2c65c9f39dd26abf592dc59efc14b07f57 Reviewed-on: https://chromium-review.googlesource.com/c/1296499 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#603080}
-
Jeremy Roman authored
It doesn't add any functionality over v8::Date::New. Change-Id: Iec74a51f344309b382ed9170e4de0ed672326454 Reviewed-on: https://chromium-review.googlesource.com/c/1299836Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603079}
-
Stepan Khapugin authored
Changes the shortcuts background color to clear. Change-Id: I72d6ca59600fa29e191cf85144526aa573f828e9 Reviewed-on: https://chromium-review.googlesource.com/c/1296252 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#603078}
-
Alex Clarke authored
This patch adds ScheduleWork / ScheduleDelayedWork deduplication which improves the perf test results. Unlike ThreadControllerImpl this deduplication logic is main thread only because I'm assuming the overhead of the locks isn't worth it. Bug: 897751 Change-Id: I879ad904e41c820180712702c66c4afd66cb3fae Reviewed-on: https://chromium-review.googlesource.com/c/1301462 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603077}
-
Alexander Timin authored
Do not use MessageLoopForIO as it is used to post tasks anyway. R=gab@chromium.org TBR=gab@chromium.org BUG=891670 Change-Id: Ib255c6a5a5dd55c2654eaa284d43d7f78f06b244 Reviewed-on: https://chromium-review.googlesource.com/c/1299239 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603076}
-
David 'Digit' Turner authored
The header was renamed in a previous CL, this one updates all users under third_party/blink. BUG=898787 R=skyostil@chromium.org, vollick@chromium.org Change-Id: I7af7fb328588132e5047e6c60ccec028fe516dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1301436Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#603075}
-
Owen Min authored
Bug: 898673 Change-Id: Ic61ce99371e3b466f4123691e2544e30afb65f0b Reviewed-on: https://chromium-review.googlesource.com/c/1298303 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603074}
-
chaopeng authored
Based on Windows folks reply, this scroll lagging issue is because the message hit test to wrong window (Intermediate D3D Window) and need to forward to the correct window (Chrome Legacy Window), but Chrome Legacy Window is holding the input queue lock so Intermediate D3D Window can not forward the message. This fix adding 3 window extended styles to Intermediate D3D Window: WS_EX_LAYERED | WS_EX_TRANSPARENT | WS_EX_NOREDIRECTIONBITMAP The first two should make the window transparent for input, and the third avoids allocating a bitmap that would otherwise be allocated with WS_EX_LAYERED. WM_PAINT, WM_ERASEBKGD and ClearInvalidContents() also removed because they unnecessary for transparent layered window. Bug: 871257 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic708b4d2a5a37f8e2e98e425c1be8b28de41d001 Reviewed-on: https://chromium-review.googlesource.com/c/1299342 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603073}
-
Daniel Bratell authored
Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603072}
-
Jochen Eisinger authored
This mirrors the calls on OAuth2TokenService::Observer::On{Start,End}BatchChanges. Bug: 897113 Change-Id: I6a436baf28f4bf629da8a9b037cd5ab04c644fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1296249 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603071}
-
Tim Volodine authored
Implement the WebViewClient.onReceivedLoginRequest callback for Android WebView in the Network Service enabled case. This patch makes sure the header is properly parsed and the callback executed. Also updates the test filter with the tests fixed by this patch. Tests fixed: -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnGoogleCom -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginOnNonGoogle -org.chromium.android_webview.test.AwContentsClientAutoLoginTest.testAutoLoginWithNullAccount BUG=893562,841556 Change-Id: I91bfb1e3d9ffb8783cc0952e0498f2e428976a7e Reviewed-on: https://chromium-review.googlesource.com/c/1292052 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603070}
-
David Bienvenu authored
Use static initializer for condition_ member var instead of win api call. Bug: 891924 Change-Id: I61860a13f286389cf955a74d8e4b3e5c3d30bbb9 Reviewed-on: https://chromium-review.googlesource.com/c/1299916Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603069}
-