GitLab

Bug: 836908
Change-Id: Idb2422e16651df75fe2dac30d0d4bc65410e67aa
Reviewed-on: https://chromium-review.googlesource.com/1031560Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554475}

It's possible that when setting the opacity of the black scrim, the opacity is
a very small negative value. Set it to zero in this case.

Bug: 835900
Change-Id: Ia3b082e86cb5cca25987023a9a6f46625865b335
Reviewed-on: https://chromium-review.googlesource.com/1024243Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554474}

There are two main bug fixes:
1) make sure the poll time gets properly sent through the cycle snapshot so that
   it can be persisted.
2) On startup, if the poll interval expired in the past, schedule a poll soon.
   Without that, it's highly unlikely we ever do polls on platforms like Android
   where apps can get killed anytime. Plus, as notifications are less reliable
   there, polls are actually more relevant.

The feature to potentially poll on start-up is guarded behind a feature flag,
which allows rolling back to the current behavior.

Bug: 832019
Change-Id: If625704eace7a89a48d057c27d61abb8b10d1bb1
Reviewed-on: https://chromium-review.googlesource.com/1030177Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554473}

As per crbug.com/788024 Comment 1 (see mocks):
- Fix error box style
- Dialog width = 448
- Input box width = 200, left aligned
- Additionally: add SPACE between "Invalid PIN" & "Attempts left"

Harmonious nature of the pin-requestin' dialog.

Bug: 788024
Test: Get yourself into some kinda pin-needin' situation and confirm the
Change-Id: Ie573c8a79fdb2001a3c2b66adc4b80a4b09dd723
Reviewed-on: https://chromium-review.googlesource.com/1013412
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554472}

This reverts commit ce130512.

Reason for revert: broke compilation: https://ci.chromium.org/buildbot/chromium/Win/66613

Original change's description:
> Add ruleset_converter tool to subresource_filter
> 
> This CL also
> - Aggregates all subresource_filter tools into a single target
> - changes subresource_filter tools to use the same (but equiv)
>   condition as some other tools
> - Adds that target to "all"
> 
> Bug: 833419
> Change-Id: I732ac0860f90e036281bdf899f8b5e6e92f3f3e5
> Reviewed-on: https://chromium-review.googlesource.com/1031211
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554455}

TBR=sky@chromium.org,jkarlin@chromium.org,csharrison@chromium.org

Change-Id: I03e004c156e40d695c866ba07a00c480eedcd225
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833419
Reviewed-on: https://chromium-review.googlesource.com/1033399Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554471}

Bug: 736457
Change-Id: I818c4d048145ae77bfd5c0244cde67886c30f8be
Reviewed-on: https://chromium-review.googlesource.com/1031786Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554470}

Monochrome.apk_Dex
        +2 entries fields
        +5 entries methods
        +1 entries types
        +1 entries strings
Monochrome.apk_Breakdown (+1,897 bytes)
      +145 bytes Zip Overhead
      +251 bytes Non-compiled Android resources size
       +17 bytes Package metadata size
       -20 bytes Java code size
    +1,504 bytes Compiled Android resources size
Monochrome.apk_Specifics
    +2,289 bytes normalized apk size
        +1 zip entries file count
      +392 bytes main dex size

Change-Id: Ia465e1ee3a2b9c411feb4265ab18ef05d3674d7f
Reviewed-on: https://chromium-review.googlesource.com/1033453Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554469}

This change adds a global toggle for the WebUSB "guard" permission to
the site settings preferences on Android. Toggling this setting to
"block" will disregard existing USB device permissions and prevent any
site from requesting access to a USB device by displaying the device
chooser dialog.

To simplify the addition of this global toggle UsbChooserPreferences
has been merged into SingleCategoryPreferences and the entire USB
device permission framework has been refactored to manage the same kind
of opaque "objects" as is done in the desktop UI and underlying
storage infrastructure.

Screenshots of this new UI are included in the design doc:
https://goo.gl/uMPMZZ

Bug: 771703
Change-Id: I6ab766ddd1e00e8663d3b6658d872ef8ad8e95ea
Reviewed-on: https://chromium-review.googlesource.com/1006157Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554468}

Following https://chromium-review.googlesource.com/c/chromium/src/+/1020288

TBR=nick@chromium.org (trivial rename in comment in
content/public/test/frame_load_waiter.h)

Bug: 825327
Change-Id: I5ef7bc522a74fd9c783183ce2baca87ea3fc3291
Reviewed-on: https://chromium-review.googlesource.com/1020804Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554467}

Since there's only one device attached to this bot, set a 3 hour long expiration
time.

Bug: 837727
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia0f112f1620e6dd61c121c06a84f7e00062be2ba
Reviewed-on: https://chromium-review.googlesource.com/1033434Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554466}

This abstraction is an implementation detail of PinBackend. Further, the
existing API needs to be async, since determining if cryptohome is supported
requires a DBUS call to cryptohome. An alterative design is maintaining a
per-board list if cryptohome is supported, but that imposes a significantly
greater maintance burden.

Bug: 826773
Change-Id: Ib0ef30b4303302b9a8f3f2bf3deabd100d888e56
Reviewed-on: https://chromium-review.googlesource.com/999125
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554465}

https://pdfium.googlesource.com/pdfium.git/+log/575f238334d1..3241bb3e98c0

$ git log 575f23833..3241bb3e9 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 thestig Fix style for many jbig2 methods.
2018-04-27 thestig Add CJBig2_Image::IsValidImageSize() helper method.
2018-04-27 thestig Sanitize another image size in CJBig2_Context::parseHalftoneRegion().
2018-04-27 rharrison Updated libtiff 4.0.8->4.0.9
2018-04-27 thestig Sanitize the SBNUMINSTANCES value in the JBIG2 decoder.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:836872,chromium:837192


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I836d14f6bf7661851deff78a72360d0031648d18
Reviewed-on: https://chromium-review.googlesource.com/1033337
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554464}

This CL adds an instance of MultiDeviceNotificationPresenter to
ash::Shell; additionally, when the user logs in,
MultiDeviceNotificationPresenter now initiates a connection to the
MultiDeviceSetup service and starts observing it.

Bug: 824568
Change-Id: Ie0c77b3ae4ba4e52ccab3b8034e8473ed71e1a67
Reviewed-on: https://chromium-review.googlesource.com/1022470
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554463}

In preparation for a big refactoring of our logic that computes character and object bounds.

Important changes:
1. Wrote additional tests for scrollable editables and strengthened test for scrollable containers.
2. Tests that the height is the same across lines.

More cosmetic changes:
3. Replaced all-caps constants with newer style guide constants that start with "k".
4. Used raw litteral strings (a C++ 11) feature that allows the use of quotes in HTML code without escaping or the need to remember to use single quotes.
5. Split SetUp methods into more helper functions.
6. Introduced SetUp method for creating scrollable input field and added a test for it.
7. Stopped using net::EscapeQueryParamString because it was not appropriate for escaping HTML code.
R=aleventhal@chromium.org, dmazzoni@chromium.org

Change-Id: I7d9387323ae35a353dc62096c151355897f925eb
Reviewed-on: https://chromium-review.googlesource.com/1030842
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554462}

This patch changes DocumentThreadableLoader not to handle
CORS-preflight, but to delegate it to CORSURLLoader.

Originally preflight errors and usual CORS errors shared a common
error code set, and append extra error strings for preflight
errors, based on the context that DocumentThreadableLoader knows.
After this change, we define different error code for each case
so that DocumentThreadableLoader can create right error strings
without error contexts that only CORSURLLoader knows.

CORSURLLoader is also modified to set the HTTP Origin header
when it is needed, and now use PreflightController to perform
required preflight checks.

PreflightController is modified to use WrappedLegacyURLLoaderFactory.
This is unfortunate, but to make it work with legacy URLLoaderFactory
that relies on ResourceDispatcherHost that needs the legacy request_id.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibf82243ecf14be84bb11122f733c4cb9030d41b8
Bug: 803766
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/997914
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554461}

- Add MockLibraryCdm, a mock implementation of library CDM interface so
  that we can have more control in the test cases.
- Refactor CdmAdapter so that CreateCdmFunc is passed in constructor
- Refactor CdmAdapterTest so that it can take different CreateCdmFuncs
 * CdmAdapterTestWithClearKeyCdm uses Clear Key CDM and uses the
   CreateCdmFunc provided by CdmModule.
 * CdmAdapterTestWithMockCdm uses CreateMockCdmInstance to use
   MockLibraryCdm for testing.
- Add tests for ChallengePlatform, CreateFileIO and RequestStorageId
  using CdmAdapterTestWithMockCdm.

Bug: 836046
Test: Test class refactoring; added more tests.
Change-Id: If79922b26b57793f8e75f86e583109b0495fda58
Reviewed-on: https://chromium-review.googlesource.com/1027003
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554460}

This is necessary because these flags need to be accessed from within
//ash and //chromeos, which do not have access to chrome_features.h
since it resides in //chrome.

Bug: 824568, 752273
Change-Id: I2d20f244bc88758825dd37edf5b9956336017563
Reviewed-on: https://chromium-review.googlesource.com/1029228
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554459}

The visitor passed for tracing should not be const as tracing actually
modifies visitor-internal state.

The tracing methods themselves and their parameters should remain const.

The CL changes
  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
to
  virtual void TraceWrappers(ScriptWrappableVisitor*) const;

Bug: v8:7570
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib0132069baac8609a347ebb9c48aa6eda490ffa7
Reviewed-on: https://chromium-review.googlesource.com/1032558
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554458}

TBR=danakj@chromium.org

Bug: 837515
Change-Id: I315d5b9b2add8fd2c06a1c032bf20e4f3c950f85
Reviewed-on: https://chromium-review.googlesource.com/1032872Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554457}

1. Change constant variable naming style, e.g. VP9 -> Vp9. According to
the style guide [1]: "when abbreviations appear in such (Camel Case)
names, prefer to capitalize the abbreviations as single words (i.e.
StartRpc(), not StartRPC())".
2. Update TestMp4EncryptionPlayback() to take a |media_type|, in
preparation for adding other MP4 tests, e.g. FLAC.
3. Some misc changes.

[1] https://google.github.io/styleguide/cppguide.html#Variable_Names

Bug: 327115
Test: No functionality change.
Change-Id: Iab1243ad05f85d2aa845838cd1ab30606245cbf3
Reviewed-on: https://chromium-review.googlesource.com/1031557Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554456}

This CL also
- Aggregates all subresource_filter tools into a single target
- changes subresource_filter tools to use the same (but equiv)
  condition as some other tools
- Adds that target to "all"

Bug: 833419
Change-Id: I732ac0860f90e036281bdf899f8b5e6e92f3f3e5
Reviewed-on: https://chromium-review.googlesource.com/1031211Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554455}

https://boringssl.googlesource.com/boringssl/+log/9f0e7cb314ae64234b928fd379381ae9760a9a5f..cece32610b89549386b42b2032dd5d8a423af6c8

BUG=none

Change-Id: I3e35ab9410002fd62c6b7d75ef1cf7edbda41b44
Reviewed-on: https://chromium-review.googlesource.com/1028870Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554454}

Flip flags.

https://chromium-review.googlesource.com/c/chromium/src/+/1028457

Use Google QUIC padding frame methods for both Google QUIC and IETF QUIC

Removes a separate IETF Padding methods. The Google QUIC methods can be used for both QUICs.

N/A no operational impact, no code added and removed code was not wired in.

This work being done to develop support for IETF-format QUIC.

Merge internal change: 193920140

https://chromium-review.googlesource.com/c/1027805/

Default enable QUIC ack decimation.  Protected by FLAGS_quic_reloadable_flags_quic_default_enable_ack_decimation.

Merge internal change: 193716416

https://chromium-review.googlesource.com/c/1027908/

Remove the IETF Quic BLOCKED frame, fold into Google QUIC BLOCKED

N/A -- code is not live.

This work done in support of extending QUIC to use IETF QUIC.

Merge internal change: 193706746

https://chromium-review.googlesource.com/c/1028179/

In QUIC, enable fast path in QuicStreamSendBuffer::FreeMemSlice. Protected by FLAGS_quic_reloadable_flag_quic_fast_free_mem_slice.

Merge internal change: 193700647

https://chromium-review.googlesource.com/c/1027802/

Rename objects for IETF Quic MAX_STREAM_ID and STREAM_ID_BLOCKED frames

Objects were QuicIetf<mumble>, renamed to just <mumble>. This entails
renaming files and changing object class names. No logic/etc changes.
In addition, the Process... and Append... methods in QuicFramer were
renamed from ProcessIetf.../AppendIetf... to Process.../Append...

This code is not live, is done in support of developing IETF compatible
QUIC.

N/A All modified code is unreachable in prod.

Merge internal change: 193684938

https://chromium-review.googlesource.com/c/1027898/

Add IETF NEW_CONNECTION_ID frame to quic/core/frames and associated changes.

This in support of continuing effort to develop a QUIC version that
is complient with IETF-QUIC.

N/A, changes in this CL are not live. Code is unreachable

Merge internal change: 193664616

https://chromium-review.googlesource.com/c/1027896/

Add IETF APPLICATION_CLOSE frame to quic/core/frames

This adds appropriate files to the directory, extends
quic/core/frames/quic_frame.[cc|h] to support addition
of this frame, and so on.

This is in support of the developing IETF QUIC.

N/A No impact, none of this code is live.

Merge internal change: 193659905

https://chromium-review.googlesource.com/c/1026424/

In QUIC, detect lost packets from last largest lost packet. Protected by FLAGS_quic_reloadable_flag_quic_incremental_loss_detection.

Merge internal change: 193547935

https://chromium-review.googlesource.com/c/1026487/

(n/a) Deprecate FLAGS_quic_reloadable_flag_quic_fix_write_out_of_order_queued_packet_crash.

Merge internal change: 193534820

https://chromium-review.googlesource.com/c/1026486/

Use CurrentSupportedVersions() instead of AllSupportedVersions() in Quartc.

n/a (Quartc change)

Merge internal change: 193442805

https://chromium-review.googlesource.com/c/1026484/

In QUIC, protect respecting IETF header with FLAGS_quic_reloadable_flag_quic_respect_ietf_header.

Merge internal change: 193417278

https://chromium-review.googlesource.com/c/1026483/

Allow effective peer migration to start even if an active migration is ongoing. Protected by new flag FLAGS_quic_reloadable_flag_quic_enable_server_proxy2.

Merge internal change: 193388751

https://chromium-review.googlesource.com/c/1026482/

Change uint128 to QuicUint128

Merge internal change: 193384460

https://chromium-review.googlesource.com/c/1026481/

Let quic_client default talk current supported version instead of all versions.

n/a (tools only change)

Merge internal change: 193349968

https://chromium-review.googlesource.com/c/1026478/

In QUIC, allow pacing in multi-packet bursts. Protected by existing FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender.

The burst size is controlled by FLAGS_quic_lumpy_pacing_size and FLAGS_quic_lumpy_pacing_cwnd_fraction.

Merge internal change: 193255305

https://chromium-review.googlesource.com/c/1026416/

Deprecate FLAGS_quic_reloadable_flag_delay_quic_server_handshaker_construction and --gfe2_reloadable_flag_quic_store_version_before_signalling

Merge internal change: 193242173

https://chromium-review.googlesource.com/c/1026414/

Tag certificate chains as const.

n/a (if it compiles, it's a no-op)

Merge internal change: 193238365

https://chromium-review.googlesource.com/c/1026473/

Add a QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_unified_send_alarm.

n/a (Add FLAG_COUNT)

Merge internal change: 193210262

https://chromium-review.googlesource.com/c/1026413/

(n/a) Allow QuicPacketWriterWrapper to take a non-owning underlying writer. Not protected.

Merge internal change: 193203968

https://chromium-review.googlesource.com/c/1026472/

Allow QuicDispatcher(and subclasses) to save and restore arbitrary packet processing context. Only used in unit test, not protected.

Merge internal change: 193069438

https://chromium-review.googlesource.com/c/1026412/


R=rch@chromium.org

Change-Id: I3780420de6f9174a934cbcf2c6486716b6fb10e1
Reviewed-on: https://chromium-review.googlesource.com/1028459Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554453}

Instead of duplicating this bit off the compositor ContextProvider,
query it directy on the ContextProvider that will be held differently
as a result of its value.

R=piman@chromium.org, pdr

Bug: 826886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia9a4f7ca4d9cbf10121f7d729d4068a6f9b93e90
Reviewed-on: https://chromium-review.googlesource.com/1026839
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554452}

BUG=826700

Change-Id: I7cd5a32bb227d5ad07f8d0941aff922e10793790
Reviewed-on: https://chromium-review.googlesource.com/1025315Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554451}

This CL is a refactor and has no intended behavior change.

This CL updates AddWebContents to use explicit ownership semantics. This CL
fixes some of the subclasses to have proper ownership semantics, and leaves
behind some TODOs for other subclasses.

Bug: 832879, 674318
Change-Id: I6294e591e9166dfb0c029eb78648c17216075dab
TBR: skyostil@chromium.org, carlosk@chromium.org, torne@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1028631Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554450}

This CL adds a command line switch based on base::Feature to allow the
user to turn on the experimental WebRTC AEC feature for providing
increased transparency to stationary render noise.

Bug: chromium:836925
Change-Id: I941b3a26b5b4c657df37ceba69af6b548182713d
Reviewed-on: https://chromium-review.googlesource.com/1027817Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554449}

* Delete runner V1 scripts.
* Relocate runner V2 scripts to runner V1 location, and remove
  "runner_v2" directory.
* Delete unused GN attributes and transitional GN groups().
* Remove override flags from Fuchsia FYI buildbots.


Bug: 805057
Change-Id: I62e8fbfa200ebf31bd0a766bc276477ddca0b673
Reviewed-on: https://chromium-review.googlesource.com/1031564Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554448}

This change removes all Play Services Nearby-based scanning from
chromium.

BUG=826540

Change-Id: Id7b8a31724ac81709e056617bf003d7d43d5991c
Reviewed-on: https://chromium-review.googlesource.com/1028512Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554447}

Reflected synthetic fields:

Reflected synthetic fields are synthetic fields for which
if one changes the visibility of the corresponding hidden
select field in the source code, and select an option on
that, as a user would do, the change would be reflected
on the synthetic field.

Solution:

we can fill a reflected multiple field, by making an exception for
select fields. Previously, this exception was made for non-focusable
ones, meaning that a non-focusable select field would get autofilled,
even though it wasn’t visible. We need to broaden this exception to
include the fields with ‘role=presentation’. This will fix the problem.

Fixes:

chapters.indigo.com
www.newbalance.com


See: go/synthetic-fields for more on this issue.

Bug: 836949
Change-Id: Iefad5de1432e5c2a8a64c0ec9bf79a6db9f557b1
Reviewed-on: https://chromium-review.googlesource.com/1028721
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554446}

Bug: 821574
Change-Id: Ibdc60dd4731c141ab59b3faba7fd2c0c3835d1cb
Reviewed-on: https://chromium-review.googlesource.com/1031712
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554445}

Bug: 824594,824593,809571,790121,789564,731400
Change-Id: I7b1964b4c2c80f5b1b13329098a161e372f58202
Reviewed-on: https://chromium-review.googlesource.com/1032885
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554444}

https://webrtc.googlesource.com/src.git/+log/95141d91d8ab..169c7fd521da

$ git log 95141d91d..169c7fd52 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:837563


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iaa07e0d7ffe3f545cd5d2200e45ad5e3de4b3f43
Reviewed-on: https://chromium-review.googlesource.com/1033178
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554443}

https://chromium.googlesource.com/catapult.git/+log/82069c8b6ea2..6761f26bd9da

$ git log 82069c8b6..6761f26bd --date=short --no-merges --format='%ad %ae %s'
2018-04-26 szager Don't default to NoopArtifactResults
2018-04-27 perezju [devil] Add version_codes.OREO

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:831199


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I67d58104c1c892da7a171cc7ae67455a8899b4bc
Reviewed-on: https://chromium-review.googlesource.com/1033180
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554442}

Currently, all DOM constructors are treated as side-effect-free. This
CL introduces `[Affects=Everything]` to blacklist constructors.

While Worker/SharedWorker constructors produce effects:
- `new Worker` can asynchronously loads script
  (violates "fetch resources", "schedule execution")
- `new SharedWorker`, by spec, may "queue a task" or
  "in parallel, run a worker" and update the global scope's worker
  set (violates "schedule execution", "cache objects")

Bug: 829571
Change-Id: I931efb6212e2ac77be81d3dd721d6dba96a85097
Reviewed-on: https://chromium-review.googlesource.com/1027088Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554441}

Was no longer being used. As well, rename StartUploadProcess to
MaybeStartVoteUploadProcess.

Tbr: vabr@chromium.org
Bug: None
Test: existing
Change-Id: I7594bd79daa5f7878806de528c3e62ec0b70909b
Reviewed-on: https://chromium-review.googlesource.com/1032752
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554440}

Extracted from https://chromium-review.googlesource.com/1015743
Required in order to move Blink's scheduler/base to //base.

Bug: 783309
Change-Id: Iff610ed6da964fb6c93de070ac81916bec5dceba
Reviewed-on: https://chromium-review.googlesource.com/1032781Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554439}

Background:
The dcheck in AppListView::SetIsIgnoringScrollEvents fails when user
scroll up and down quickly. (The pagination transition starts again
before ends).

Changes:
Do not make decision based on |is_ignoring_scroll_events_| which is set
by state change animation or pagination transition. Instead, check the
animator and pagination model directly to decide whether to ignore
scroll events.

BUG=836088

Change-Id: Ic7aef13e53d299af3165082d7dfa2f89974e20c0
Reviewed-on: https://chromium-review.googlesource.com/1031207
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554438}

Bug: 831782
Change-Id: I7558d68a41f30120b6c573b9752612215e35b115
Reviewed-on: https://chromium-review.googlesource.com/1031293Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554437}

When a remote frame is navigated to about:blank#foo in --site-per-process mode
it is routed to the browser process through a RenderFrameProxyHost. It then
considers the navigation to be cross-site due to check for explicit
"about:blank" URL in DetermineSiteInstanceForURL. This causes a
cross-process navigation and Blink considers the about:blank#foo URL to be
same-document with the initial empty document. In turn, it sends a same
document commit to the browser process, which considers it a mismatch and
terminates the renderer.

This CL fixes DetermineSiteInstanceForURL to use GURL::IsAboutBlank, which
should cover various types of about:blank URLs. It also ensures that Blink
does not consider the first navigation in a provisional LocalFrame to be
eligible for same-document commit.

Bug: 833005
Change-Id: Ia7d849effbc52efb242b65ca822512bd44b016ff
Reviewed-on: https://chromium-review.googlesource.com/1031374Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554436}