- 23 Mar, 2018 40 commits
-
-
Chris Harrelson authored
PLC::CollectFragments includes fragmentation offset if called in GeometryMapper mode. However, when hit testing under transform, we apply fragmentation and transform, then hit test each fragment without any fragmentation or transform offset. Therefore, in this post-fragment/transform mode, don't apply fragmentation offset again. The callsites in PaintLayerPainter for the equivalent situation during paint already correctly pass an empty LayoutPoint offset for layer bounds. Bug: 823255 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3135e51b72c5fd02a9d67b3dcbdc51e39ef3cde2 Reviewed-on: https://chromium-review.googlesource.com/978675Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545606}
-
Kevin Marshall authored
A previous CL regressed this behavior, leading to the generated runner being generated with absolute paths in the buildbot's filesystem. Change-Id: I16aaca1556c9f8eccc81d3cdd841b4a3c71de3f2 Reviewed-on: https://chromium-review.googlesource.com/978639Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545605}
-
Abhishek Arya authored
Use base::StringPiece in cases where caller expects input in std: :string is null terminated whereas base::StringPiece is not. base: :StringPiece as it helps to catch for overflow cases. Change-Id: I0c70d1f8c40fc5f0e826ced5073f563bc74d1d80 Reviewed-on: https://chromium-review.googlesource.com/978036 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545604}
-
Fredrik Hubinette authored
VP8 has no color space information apart from full range / limited range. However, because of a comment in the VP8 spec that says that vp8 content is "like bt601", ffmpeg sets the matrix to SMPTE470BG. When we assign the color space to the video frame we default the other parameters to BT709, leading to a color space like: { primaries=BT709, transfer=BT709, matrix=SMPTE470BG, range=Limited } This mix of color spaces is is clearly wrong. This fix works around the ffmpeg behavior and leaves the color space completely unset when this happens. Unset color spaces defaults to BT709 later on, which is probably what we weant. Full-range content gets a JPEG color space. Bug: 754986 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I04694e949d211b134312ade01555fa1954a82bad Reviewed-on: https://chromium-review.googlesource.com/912436 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545603}
-
Erik Chen authored
This is required to correctly perform accounting of shared memory on macOS. Bug: 823915 Change-Id: I75a3bc4951e38bc24cc8c2b7867cfdd952fb860d Reviewed-on: https://chromium-review.googlesource.com/974443Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545602}
-
David Jacobo authored
This one-liner is to make this UI looks like the spec, also the other bubbles on the omnibox doesn't have a visible arrow. Bug: None. Test: Build, also on an ARC device enabled poked around with pinterest. Change-Id: Iad9913d68d86b9a276f793b5a34962644c836344 Reviewed-on: https://chromium-review.googlesource.com/978671Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545601}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:825349 Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3 Reviewed-on: https://chromium-review.googlesource.com/978844Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545600}
-
Jonathan Metzman authored
TBR=inferno@chromium.org Change-Id: I0aa9a1a30dba80b064b0fcb59598d69def1f8071 Reviewed-on: https://chromium-review.googlesource.com/978866 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545599}
-
Zhiheng Vincent Li authored
1. Intead of hard code the initial visibility priority, add a parameter to allow web app to set its initial value of visibility priority. 2. Report visibility change to cast apps through intents and JNI interfaces. This is a follow up change of https://chromium-review.googlesource.com/c/chromium/src/+/940809 Design doc: go/cast-to-android Test: cast_shell_junit_tests browsertests Bug: b/65100261 b/72227153 b/72436346 b/72237087 b/72912957 b/72436104 b/72712171 Change-Id: I6189b55beca64e3529a0f43fbef9790dbd3f0c2e Reviewed-on: https://chromium-review.googlesource.com/977057 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545598}
-
Ken MacKay authored
Add a hack (since priority inheritance doesn't work with PostTask) to avoid priority inversion on the mixer thread, to reduce underruns. Add logging for per-stream underrun. Add some special-case buffering for communications streams to avoid issues with voice calling. Bug: internal b/74603750 Change-Id: I82be8f03558cccac6bf04967ef48a31828f29cda Reviewed-on: https://chromium-review.googlesource.com/977037 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545597}
-
Matt Wolenetz authored
Conditionally disables these 2 tests on windows dbg builds. BUG=825038,823003 TBR=tsepez@chromium.org,thestig@chromium.org NO-TRY=True Change-Id: I31b9365a71c29c794af7c1c424d3f6eeed9ea708 Reviewed-on: https://chromium-review.googlesource.com/978940Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545596}
-
Candice Sy authored
Undoing the reordering from https://chromium-review.googlesource.com/969925 because this change created bugs related to starting/stopping the foreground service. Correct usage of notifyDownloadPaused() with isAutoResumable true and of notifyDownloadInterrupted() is to mark downloads as pending if they are not already paused. Bug: 812576,825113,825163 Change-Id: I6c33e035ec501c418c93acff916b7852f2b66cbd Reviewed-on: https://chromium-review.googlesource.com/978612Reviewed-by:
Joy Ming <jming@chromium.org> Commit-Queue: Candice Sy <cmsy@google.com> Cr-Commit-Position: refs/heads/master@{#545595}
-
Amirhossein Simjour authored
This reverts commit a8b44439. This will fix the problem with keyboard not staying after tap. I reopen 820898. Bug: 825175 Change-Id: I41ca2828fe6f81ac8c6569ebe99f97616506bcb5 Reviewed-on: https://chromium-review.googlesource.com/978035Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545594}
-
Lei Zhang authored
Change-Id: I388cf30b67d43939bfca0f8827d5fe3339ed123d Reviewed-on: https://chromium-review.googlesource.com/978480Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545593}
-
Ian Vollick authored
This updates the system indicators to match the spec. When hovered, a tooltip appears with details. Bug: 824187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5c44bb0e448febe4c253d6ce91a0b43aad50535 Reviewed-on: https://chromium-review.googlesource.com/978614Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545592}
-
David Benjamin authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I39b362f41eeb9f8d8951bf3f73900bbb39d36df1 Reviewed-on: https://chromium-review.googlesource.com/977005Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#545591}
-
Ryan Landay authored
The logic in StackLayoutBase#setTabLists() has a bug that's causing it to not reduce the number of stacks properly when the number of TabLists is reduced. This does not affect the StackLayout used in production since it always uses a fixed number of stacks, and I apparently didn't notice this when testing the prototype I was working on at the time. Bug: 648314 Change-Id: I93374f398b376ad2f39a09211d928abb407af0b6 Reviewed-on: https://chromium-review.googlesource.com/972199Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#545590}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf5bef7e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14369 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: Ia839d9516782a9a2e07cc647f229d571f927f9df Reviewed-on: https://chromium-review.googlesource.com/978037 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#545589}
-
Robert Ma authored
html.idl changed in upstream https://github.com/w3c/web-platform-tests/pull/10110 and imported in https://crrev.com/c/978021 Bug: 825191 Change-Id: Ie1a04e730aabd50c615f1dab079f92eeaa22565a Reviewed-on: https://chromium-review.googlesource.com/978508 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545588}
-
Michael Giuffrida authored
ShellExtensionsClient::IsScriptableURL() can be called a lot, so it would be better if it didn't log NOTIMPLEMENTED(). We can consider it to be "implemented". Bug: None Change-Id: I4dd42c526d2aa75f3d7146527f1d6dfa7beb20fa Reviewed-on: https://chromium-review.googlesource.com/967602Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545587}
-
Xiaoqian Dai authored
ScreenOrientationController is deleted earlier than SplitViewController in Shell during shutdown, so it's possible to have a nullptr dereference crash. Bug: 817520 Change-Id: I0e4ea1730c34dc7d767edffee80e5f09a88bb7af Reviewed-on: https://chromium-review.googlesource.com/976370Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545586}
-
Kurt Horimoto authored
Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I610f604d1f20695d028571166e443c12cd11cc20 Reviewed-on: https://chromium-review.googlesource.com/952766 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545585}
-
Nasko Oskov authored
When a content script is injected into a document, it can make requests to origins in its manifest. With recent changes to allow Chrome to block cross-site documents, the initiator of content scripts requests was changed to reflect the extension origin. This change meant that SameSite cookies were not attached to those requests. This CL introduces a check for content scripts making subresource requests and tags those requests to allow attaching SameSite cookies. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/896690 Bug: 796480 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8316f259f8b04c4fad406c398ba5207abef8a00e Reviewed-on: https://chromium-review.googlesource.com/974882 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545584}
-
Vaclav Brozek authored
The _CheckUmaHistogramChanges checks whether newly added UMA_HISTOGRAM_* calls only use defined histogram names. This CL removes two ways to introduce false positives: * Unrelated macro names which contain UMA_HISTOGRAM as a continuous substring * More than one string literal on the line with the histogram name. While those cases are rare, there seems no downside to fixing them. Bug: 821981 Change-Id: Ie1a803f562883f567d577e742ed2ed87fd0dfe66 Reviewed-on: https://chromium-review.googlesource.com/978245 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545583}
-
Paul Irish authored
Change-Id: I8fa0b6e606f828df9677deefbcbf7254359fe5c6 Reviewed-on: https://chromium-review.googlesource.com/974178 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#545582}
-
Mike Dougherty authored
Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I871fe76d7e2d8ce96ce5e70475e503216f711326 Reviewed-on: https://chromium-review.googlesource.com/975996 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545581}
-
Xiaoqian Dai authored
Define SPLITVIEW_ANIMATION_RESTORE_OVERVIEW_WINDOW. And also animate the overview window from its position in overview grid to its snapped postion. Bug: 822486 Change-Id: I64a48b33012c428a5529dfea58f048f30c043e73 Reviewed-on: https://chromium-review.googlesource.com/972562Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545580}
-
Matt Wolenetz authored
Conditionally disables this test on dbg win. BUG=825304,823003 TBR=dpapad@chromium.org NO-TRY=True Change-Id: Ic6950d3d6a2e1fd52a6d30f1f6a549045619ee2f Reviewed-on: https://chromium-review.googlesource.com/978863Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545579}
-
erikchen authored
There are no longer any cross-platform consumers of this code. There are two ChromeOS consumers of the latter, which have been extracted into a function only defined on ChromeOS. Bug: 819289 Change-Id: Iaa0c12c94619ba54be44e23eb45abc5337da4621 Reviewed-on: https://chromium-review.googlesource.com/973943 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#545578}
-
Jao-ke Chin-Lee authored
win_chromium_dbg_ng has had 176 tests running over 3 hours in the 1000 builds between 4670 and 3669. Currently, these show up as infra failures rather than test failures. Increase the hard timeout to 4 hours, as no build in the above sample exceeded 4 hours. BUG=731384 Change-Id: Iff6dba2ffb43920aa991cfef7fdc4bb6e5773eb4 Reviewed-on: https://chromium-review.googlesource.com/978673 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545577}
-
Weidong Guo authored
Changes: Treat browser back as esc key to navigate back in app list. BUG=819668 Change-Id: Iccccfe8b424570643c851a73d191e86f66271ced Reviewed-on: https://chromium-review.googlesource.com/978546Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545576}
-
Nate Fischer authored
No change to logic. This adds WebViewClientBoundaryInterface, which will be implemented by WebViewClientCompat on the support library side. These methods will be invoked from the support_library side in later CLs, as we implement each callback. Bug: 781764 Test: N/A Change-Id: I2ba052ff02076cec1c9d4e360aed322a63b511ef Reviewed-on: https://chromium-review.googlesource.com/974898Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545575}
-
Matt Wolenetz authored
It's flaky on Win7 Tests (dbg)(1). This change disables it in debug Windows builds. BUG=825341,823003 TBR=pkasting@chromium.org NO-TRY=True Change-Id: Ibb04812ca20081ec55cbc1bdbef01464ddb062f3 Reviewed-on: https://chromium-review.googlesource.com/978835Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545574}
-
yucliu authored
Pipeline checks policy before getting the clear audio data back. This also allows pipeline to call proper API for decryption. The patch adds a new enum OutputType for DecryptContextImpl. Pipeline checks the OutputType before decryption. The OEM CDM library still enforces license policy before doing the actual decryption. BUG=internal b/64914604 TEST=cast_cdm_widevine_test, encrypted content Change-Id: I95188b6b025978e0e2e508704216e40c9734db94 Reviewed-on: https://chromium-review.googlesource.com/977039Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545573}
-
Allen Bauer authored
Bug: 822000 Change-Id: I950ec472da2b5b8f8b52c54b9d14adc0098b3804 Reviewed-on: https://chromium-review.googlesource.com/969092Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#545572}
-
Xianzhu Wang authored
For <svg style="will-change: left"></svg>, previously we created a transform node just to store the direct compositing reason CompositingReason::kWillChangeCompositingHint, which broke the assumption that only objects having a PaintLayer can be composited. Bug: 825090 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6eddb3b025ea82c08b38dc4ae0c0efc1048f6854 Reviewed-on: https://chromium-review.googlesource.com/978504Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545571}
-
Min Qin authored
This CL moves DownloadWorker from content/browser/download to components/download. DownloadWorker is used by ParallelDownloadJob for creating parallel download requests. To remove the dependencies on content/, following changes are made: 1. Introduces URLDownloadHandlerFactory class, this class allows content/ to inject its own URLDownloadHandler implementation (UrlDownloader) when network service is disabled. 2. DownloadManager will always pass a SharedURLLoaderFactory to ResourceDownloader. ResourceDownloader will later return it back to DownloadManager, and DownloadManager will then pass it to the ParallelDownloadJob through DownloadItemImpl. Bug: 803135 Change-Id: I96dfb75daa438049df0dc9fd0fbe74abd5ff1d7a Reviewed-on: https://chromium-review.googlesource.com/974120 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#545570}
-
Siddhartha authored
The bitmap resources held by LayerTitleCache for tabs are never cleared by tab strip model. Release resources held for a tab if the tab is marked invisible in tab strip layout. BUG=701976 Change-Id: I3539d5aa546d5f002cb2b1a670de5dea52336722 Reviewed-on: https://chromium-review.googlesource.com/977324Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#545569}
-
Findit authored
This reverts commit cdd8661f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 545521 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NkZDg2NjFmM2YzNWQ3MDc1MDIwZWFkMDQ5MmNkODNlMThmNzk1ZTkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/48976 Sample Failed Step: base_unittests Original change's description: > base: Introduce the new Shared Memory API > > Design doc (public): https://goo.gl/HmBYy6 > > This patch proposes the new API for the Shared Memory based on two > concepts, a shared memory region and a shared memory mapping. The > region controls the platform-specific handle and mediates sharing and > access control. The mapping is just a reference to the memory bytes > which knows how to unmap itself. Ownership is per-instance: neither a > region nor a mapping may be copied, and resources are freed when then > instance dies. This is accomplished through move-only semantics. > > The goal of the new API is to provide a correct cross-platform > implementation that makes the sharing mode explicit via the C++ type > system. > > Thus, this CL introduces two classes for shared memory mappings: > - WritableSharedMemoryMapping owns and provides an access to writable > shared memory > - ReadOnlySharedMemoryMapping for read-only shared memory > > and three classes representing shared memory regions: > - UnsafeSharedMemoryRegion allows to create > WritableSharedMemoryMapping instances and cannot be used for making > read-only mappings > - ReadOnlySharedMemoryRegion, on the contrary, can produce only > ReadOnlySharedMemoryMapping instances and it also creates one writable > mapping in the caller process address space > - WritableSharedMemoryRegion allows to create writable > mappings and can be eventually converted to ReadOnlySharedMemoryRegion. > The important limitation in comparison with UnsafeSharedMemoryRegion > is that the WritableSharedMemoryRegion cannot be duplicated so in > order to pass the writable region to another process, the ownership of > the region must be moved/transferred to this process. > > Bug: 795291 > Change-Id: I7d1d0a24932145cc0f449b01ceb8cafef9b7e407 > Reviewed-on: https://chromium-review.googlesource.com/893458 > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545521} Change-Id: I9c5657e80b8a262a42311d4d2a0239dc242ab8f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795291 Reviewed-on: https://chromium-review.googlesource.com/978563 Cr-Commit-Position: refs/heads/master@{#545568}
-
Oksana Zhuravlova authored
This change moves thread_priority.mojom from //mojo/common to //mojo/public/mojom/base. Corresponding typemap and struct traits files were also moved. Unit test for ThreadPriority was added to mojo_unittests. Bug: 799482,806965 Change-Id: I47c23a6b5eea8fffd8a6aa9c18f9e8e12045e8e7 Reviewed-on: https://chromium-review.googlesource.com/976621 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545567}
-