GitLab

BUG=327641
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/340723005

git-svn-id: svn://svn.chromium.org/blink/trunk@176423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245436

Review URL: https://codereview.chromium.org/347513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/339493005

git-svn-id: svn://svn.chromium.org/blink/trunk@176421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Media query evaluator assumes that device size cannot change, which is
wrong in emulation mode.

BUG=327641,386142

Review URL: https://codereview.chromium.org/308003007

git-svn-id: svn://svn.chromium.org/blink/trunk@176420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/340813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384556
R=yurys

Review URL: https://codereview.chromium.org/347463006

git-svn-id: svn://svn.chromium.org/blink/trunk@176418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/344583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed m_stop and length comparison as they carry different units i.e. if there are two char text then m_stop will be 1 and length 2. As do not compare, needWordSpace does not set correct value.  

Also by default condition for needSpacing has been changed to true because if first character is space it was getting omitted. 

BUG=344873
R=leviw, eae
TEST=Word spacing in RTL with different segments handling.

Review URL: https://codereview.chromium.org/343443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaController::trace() needs to have the declaration of ExecutionContext
available, so as to determine what NeedsAdjustAndMark<> resolves to for
its (weak) ExecutionContext member.

R=haraken@chromium.org,zerny@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/344443008

git-svn-id: svn://svn.chromium.org/blink/trunk@176415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes TimelineDetailsView to be a TabbedPane and lets us add
additional tabs for record types where we can show more details (e.g.
layer tree view or paint profiler). The old details remain in "default"
first tab. Also, for selected range stats, we now show range begin-end
as a part of details view, not in the header.

BUG=

Review URL: https://codereview.chromium.org/325313006

git-svn-id: svn://svn.chromium.org/blink/trunk@176414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This switches trace events emitted from PlatformInstrumentation to use
trace event category consistent with the trace-based timeline.
Drive-by: fix category filter in TraceEventDispatcher.

BUG=361045

Review URL: https://codereview.chromium.org/337143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
NOTRY=true
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/343563003

git-svn-id: svn://svn.chromium.org/blink/trunk@176412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're trying to make v8::TryCatch nestable.
In preparation for that, this CL adds ReThrow for nested trycatches.

BUG=362388

Review URL: https://codereview.chromium.org/313033002

git-svn-id: svn://svn.chromium.org/blink/trunk@176411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates owner document of Range objects when orphan Node object moved
to another document in new member function |Range::updateOwnerDocumentIfNeeded|.

Note: when we move non-null parent Node object to another document, it is done
by removeChild and appendChild and Range objects to reset to start of document.

The root cause of issue 350362 is boundary points of Range objects isn't
adjusted when owner document of Range and boundary points are different.

Because |Range::nodeChildrenChanged|, which adjusts boundary points for
|Node.appendChild|, is called for Range objects in another document which
isn't owner of Range.

This patch also updates "move-detached-child-in-range.html" to have right
value.

BUG=350362
TEST=LayoutTests/fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
TEST=LayoutTests/fast/dom/move-detached-child-in-range.html

Review URL: https://codereview.chromium.org/332173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/341483004

git-svn-id: svn://svn.chromium.org/blink/trunk@176409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/338993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Remove more Backslash-as-JPY hacks (some encodings interpret backslash as yen
sign).

The code was added in https://bugs.webkit.org/show_bug.cgi?id=49714 (r73566).

The test used to be
editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.html

The feature was removed by https://codereview.chromium.org/27030014 (r159589),
but the removal was incomplete. This CL removes the leftover code and test
expectation files (the corresponding tests were removed by r159589).

2) Remove isJapaneseEncoding from TextEncodingRegistry.cpp; it was dead
code. There used to be bool TextEncoding::isJapanese() (see r16245) which was
used by WebCore/loader/Decoder.cpp... but TextEncoding::isJapanese no longer
exists, and isJapaneseEncoding appears not to be used any more.

BUG=
R=abarth@chromium.org, jshin@chromium.org

Review URL: https://codereview.chromium.org/335803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaQueryLists were re-evaluated for every styleResolverChanged(). The
evaluation of MediaQueryLists can only change when some media type or
features change. That is signalled through mediaQueryAffectingValueChanged().
Set m_evaluateMediaQueriesOnStyleRecalc there instead.

Since the media queries don't change this is not noticable through layout
or unit testing.

R=esprehn@chromium.org
BUG=382894

Review URL: https://codereview.chromium.org/322043008

git-svn-id: svn://svn.chromium.org/blink/trunk@176406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelineUIUtils now has two descendants:
- TracingTimelineUIUtils for tracing based timeline records
- TimelineUIUtilsImpl for timeline records based on Timeline agent events
This patch moves some of UI-specific getters from TimelineModel.Record into TimelineUIUtils instance methods. In the end we should have all ui logic that depends on particular backend details to be encapsulated in TimelineUIUtils instance.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/344443007

git-svn-id: svn://svn.chromium.org/blink/trunk@176405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, eustas, yurys

Review URL: https://codereview.chromium.org/344443003

git-svn-id: svn://svn.chromium.org/blink/trunk@176404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
The initializer should stay alive until the initialization succeeds (i.e. the
associated Promise is resolved), the initialization fails
(i.e. rejected), or the associated ExecutionContext is stopped.
This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
If KeepAliveWhilePending is specified, the created resolver stays alive while
one of the above conditions meets.
Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.

This CL rewrites WebMIDI and WebCrypto async operations with it.

BUG=361041

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381

Review URL: https://codereview.chromium.org/311733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash was presumably caused by breakpointId handle being null because of exception in debugger. Generally debugger calls shouldn't throw but since some parts of it are implemented in JS there may be a stack overflow which would result in an exception and empty result handle.

BUG=381567

Review URL: https://codereview.chromium.org/341713008

git-svn-id: svn://svn.chromium.org/blink/trunk@176402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the WebSocket class handles suspend / resume, we can remove the suspend /
resume code from ThreadableWebSocketChannelClientWrapper.

BUG=384238
R=tyoshino

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176303

Review URL: https://codereview.chromium.org/333223002

git-svn-id: svn://svn.chromium.org/blink/trunk@176401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/337283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor refactoring which moves the case of calculation
of cross-size of flex line for single line flex-container from
RenderFlexibleBox::repositionLogicalHeightDependentFlexItems
to RenderFlexibleBox::alignFlexLines which is more appropriate
and saves us from doing unnecessary work.  The old code was doing 
align-content for a single line, then reposition 
everything when aligning children.

Review URL: https://codereview.chromium.org/340513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Static attributes are now supported by the base IDL parser, so these
overrides are no longer needed.

Followup to:
IDL parser: add StaticAttribute production
https://codereview.chromium.org/333853002/

...and prep for:
IDL parser: align with current Web IDL specification
https://codereview.chromium.org/329853005/

Review URL: https://codereview.chromium.org/336733002

git-svn-id: svn://svn.chromium.org/blink/trunk@176398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- rename generatePopupContent.* to generateDetailsContent where appropriate;
- change generateDetailsContentForFrame to use TimelineDetailsContentHelper,
    thus removing redundant header;
- (drive-by) fix frame start time in case frames are built from trace events.

Review URL: https://codereview.chromium.org/341483005

git-svn-id: svn://svn.chromium.org/blink/trunk@176397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyPropertyAll expands all shorthand property to longhand properties,
and apply each longhand property according to all's value (e.g. if
all's value is initial, initial).

Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand.html

Review URL: https://codereview.chromium.org/339163002

git-svn-id: svn://svn.chromium.org/blink/trunk@176396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scrollbars does not paint as verticalScrollbarWidth() returns 0 in paint in case of overlay-scrollbars.
We should use actual scrollbar width while placing and painting the scrollbar.

BUG=385463

Review URL: https://codereview.chromium.org/337323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Last user was removed with
http://src.chromium.org/viewvc/blink?view=revision&revision=171958

Review URL: https://codereview.chromium.org/341503002

git-svn-id: svn://svn.chromium.org/blink/trunk@176394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Disallow new/delete operations for HitTestResult.
  HitTestResult was used
  -- with new/delete operators
  -- as part objects of ContextMenuController and MouseEventWithHitTestResult.
  -- as stack allocated objects

  We'd like to avoid to make such classes in Oilpan.
  So, this CL disallows new/delete, and WebHitTestResult owns another
  class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
  introduce new function to WebViewImpl for WebSubstringUtil.mm.


BUG=357163

Review URL: https://codereview.chromium.org/326393003

git-svn-id: svn://svn.chromium.org/blink/trunk@176393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The CG for constructors and named constructors had its own simplified
mechanism for generating the actual call to the C++ constructor, rather
than using v8_methods.cpp_value(). Except for constructors with
optional arguments without default values, which used cpp_value() via
v8_methods.generate_argument() to generate the "short-cut" call used
when the function is called without the optional arguments.

With this patch, v8_methods.cpp_value() is used for all calls. This
will make it easier to adjust the handling of arguments later on in the
more complex cases.

Some IDL files that declare named constructors are modified by adding
ConstructorCallWith=Document, which was previously implied for named
constructors.

BUG=258153

Review URL: https://codereview.chromium.org/340443004

git-svn-id: svn://svn.chromium.org/blink/trunk@176390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jww
BUG=372920,245025

Review URL: https://codereview.chromium.org/344503003

git-svn-id: svn://svn.chromium.org/blink/trunk@176389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation to improve WebCore::XPath::EvaluationContext.
This CL should have no behavior changes.

BUG=

Review URL: https://codereview.chromium.org/344553002

git-svn-id: svn://svn.chromium.org/blink/trunk@176388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enables custom background color to be specified for IME composition.
Its Chrome counterpart is: https://codereview.chromium.org/313053007 .  Details:

- Adding backgroundColor to the following:
    WebCore::CompositionUnderline
    blink::WebCompositionUnderline
  for backward compabitility, we keep an old constructor, which will be deleted
  in another refactoring CL. Updated some tests to use the new constructor.
- Refactored (now) repetative code to loop over WebCompositionUnderline  that
  intersect with a range by adding class CompositionUnderlineVisitor.
- Perhaps WebCompositionUnderline should be renamed to WebCompositionSpan,
  but this refactoring task can be done in a separate CL.

We will need to split this CL when we commit.

BUG=135900

Review URL: https://codereview.chromium.org/313233002

git-svn-id: svn://svn.chromium.org/blink/trunk@176387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/334393003

git-svn-id: svn://svn.chromium.org/blink/trunk@176386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To confirm sanity.

BUG=

Review URL: https://codereview.chromium.org/338283003

git-svn-id: svn://svn.chromium.org/blink/trunk@176385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2 real violations were masked by skipping check-webkit-style in this CL:
Manually commit changes that cause false-alarm on check-webkit-style.
https://codereview.chromium.org/330323005/

This fixes them.

BUG=381876
R=haraken

Review URL: https://codereview.chromium.org/347473002

git-svn-id: svn://svn.chromium.org/blink/trunk@176384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (https://codereview.chromium.org/311733004/)

Reason for revert:
This CL breaks the build.

Original issue's description:
> Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.
> 
> Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
> The initializer should stay alive until the initialization succeeds (i.e. the
> associated Promise is resolved), the initialization fails
> (i.e. rejected), or the associated ExecutionContext is stopped.
> This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
> If KeepAliveWhilePending is specified, the created resolver stays alive while
> one of the above conditions meets.
> Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.
> 
> This CL rewrites WebMIDI and WebCrypto async operations with it.
> 
> BUG=361041
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381
TBR=yhirano, haraken, eroman, toyoshim@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/339443004

git-svn-id: svn://svn.chromium.org/blink/trunk@176383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test is based on sorvell@'s test case reported
at http://jsbin.com/ganocegu/4/edit for crbug.com/355674.

As the result of moving style in shadow's scope from
its host to its root, this issue has been fixed since
r176304.  This is the test case to catch any regression
about shadow's sibling matching.

BUG=355674
TEST=this layout test passes.

Review URL: https://codereview.chromium.org/330193006

git-svn-id: svn://svn.chromium.org/blink/trunk@176382 bbb929c8-8fbe-4397-9dbb-9b2b20218538