- 19 Oct, 2018 40 commits
-
-
chrome://creditsPeter K. Lee authored
Bug: 884663 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0075911b60df18873c8c64db17d3455d567e9ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1236661Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#601171}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0e68bb36327c..67ebe3f7aebe git log 0e68bb36327c..67ebe3f7aebe --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Add custom target to wrap around custom commands. (#1986) 2018-10-19 greg@lunarg.com Fix ADCE to treat OpUnreachable correctly during liveness analysis (#1984) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@67ebe3f7aebe The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2efc4ff24e4f8f11ee84cca38316fd534c2e3466 Reviewed-on: https://chromium-review.googlesource.com/c/1291156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601170}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4c3ebaca5a9..4bcf107ea529 git log a4c3ebaca5a9..4bcf107ea529 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 titovartem@chromium.org Add units for Ampers, Volts, Hertz, bytes per second Created with: gclient setdep -r src/third_party/catapult@4bcf107ea529 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I219847965f9753d4ad032a9d41ea23baf483fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/1291157Reviewed-by:
-
Xida Chen authored
No behavior change. Bug: None Change-Id: Ifc1874c520d7d6f03f674f5fb228cdeec3bc9b7d Reviewed-on: https://chromium-review.googlesource.com/c/1291214Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601168}
-
W. James MacLean authored
Revise float comparison tolerance since it seems SyntheticTouchscreenPinchGesture is fairly imprecise sometimes in the final page scale factor. TBR=kenrb@chromium.org Bug: 897062 Change-Id: Ibd6470eb190f90deeff709f333c058d4c4367a1e Reviewed-on: https://chromium-review.googlesource.com/c/1291353Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#601167}
-
Takuto Ikuta authored
Currently we require Xcode 10.0+ https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ios/build_instructions.md#System-requirements So no need to have xcode version check. Cq-Include-Trybots: luci.chromium.try:ios-device-xcode-clang;luci.chromium.try:ios-simulator-xcode-clang;luci.chromium.try:ios12-sdk-simulator Change-Id: Ia5f3dfc45979dda917666bbfaa804f1308f74dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1290572 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601166}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/759a2673ff90..4b8db890c4ee Created with: gclient setdep -r src-internal@4b8db890c4ee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I37d6871cae3e501a305e8d899ce3ed0af0fbdccc Reviewed-on: https://chromium-review.googlesource.com/c/1291152Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601165}
-
Alex Clarke authored
Currently it only tests SingleThreadTaskRunners Change-Id: I73997d105d74b31a1b52b85fd076b81ff99e7958 Reviewed-on: https://chromium-review.googlesource.com/c/1290985 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601164}
-
Liquan(Max) Gu authored
The original implementation does not report an update to performance timing when the number of nodes is reduced to 0. This CL is to correct this behavior. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff578e793965ae89f0e865f175335bb9a318fb9c Reviewed-on: https://chromium-review.googlesource.com/c/1289702Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601163}
-
Jialiu Lin authored
Also made some adjustment to child_account_service_unittest and user_policy_signin_service_unittest to better simulate the sign-in state to avoid hitting a DCHECK in IdentityManager. Bug: 890882 Change-Id: Id76e2cd962904352bf0bdf86ff1fb5d6714573ae Reviewed-on: https://chromium-review.googlesource.com/c/1258162Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601162}
-
David Bokan authored
chrishtr@ pointed out in https://crrev.com/c/1038648 that the paint order selection used when multiple elements on a page meet all the criteria of an implicit root scroller isn't correct. On reflection, it's not immediately clear to me that this is at all useful so, rather than adding complexity, this CL removes the ordering and just avoids making any decision at all in this case. We can revisit if the need comes up in real usage. Bug: 844534 Change-Id: I4e05da981eace4062f3898a3a7fe1d4cffdec658 Reviewed-on: https://chromium-review.googlesource.com/c/1288905Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601161}
-
Emircan Uysaler authored
This CL moves frame checks from WebMediaPlayerMS to WebMediaPlayerMSCompositor so that they happen after |current_frame_| is updated via SetCurrentFrame(). Bug: 894317 Change-Id: I93ea3160cee18fb012d3fd6c7c32fb5fe935868f Reviewed-on: https://chromium-review.googlesource.com/c/1289751Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601160}
-
Eduard Satdarov authored
Enabled LocalSyncTest.ShouldStart only on Window. Added command line for local sync backend dir in order to avoid problem with swarming tests. R: mastiz@chromium.org, treib@chromium.org Change-Id: Ia0ef5622bc8cc003e1f2b7f61eabbdae6ccff137 Reviewed-on: https://chromium-review.googlesource.com/c/1290981Reviewed-by:
-
Morten Stenshorne authored
These tests change the width of the container back and forth. In one of the tests all children have fixed inline-size. In the other test they have inline-size auto. Change-Id: I4324d06b5f6df39f613937cedc85bf947bc4df9d Reviewed-on: https://chromium-review.googlesource.com/c/1290976Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601158}
-
Ryan Harrison authored
This CL changes the ICU collator being used for text searching in the PDF viewer from the default to the 'search' one. This is the same collator used in Blink, and it folds together similar looking characters in a locale specific way, so that things like accented and unaccented vowles will match or not match dependent on the expectations of the user locale. Additionally, when searching single and double quotation characters are being simplified to the ASCII forms of them to make matching between defferent types of quotes work better. Quotation marks are a known limitation of the search collator and this workaround is based off a similar solution that exists in Blink to improve matching. BUG=chromium:142627 Change-Id: I399ea1f0bacb58434b468866127a91ccb6213e99 Reviewed-on: https://chromium-review.googlesource.com/c/1281178 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601157}
-
Aldo Culquicondor authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I44fc041457ce218766c05239acf5d7d46005b0a6 Reviewed-on: https://chromium-review.googlesource.com/c/1291349Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601156}
-
Colin Blundell authored
Will shortly be needed by an //ios/chrome port of IdentityTestEnvironmentProfileAdaptor. Bug: 895772 Change-Id: Icb7478cfc51d6bd7f6061eeab5d1ced66fe1e1a7 Reviewed-on: https://chromium-review.googlesource.com/c/1290954Reviewed-by:
-
Geoff Lang authored
BUG=892288 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0619a87cc2babbc2e3f9e33135bb883a51d2d9c1 Reviewed-on: https://chromium-review.googlesource.com/c/1262429 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601154}
-
Thomas Tangl authored
The profile card title in the user menu is fixed for non-syncing users that are offline. Bug: 897078 Change-Id: I041cf8296d0ab8b77f0bd8b082cf8f03e418828f Reviewed-on: https://chromium-review.googlesource.com/c/1290913 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601153}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a5d83bcb62f..429fb7c2bca7 git log 7a5d83bcb62f..429fb7c2bca7 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 fmayer@google.com profiling: Use total size in heap dumps. Created with: gclient setdep -r src/third_party/perfetto@429fb7c2bca7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0ec1c260dfdae9362d80c543f50334a9aafc210f Reviewed-on: https://chromium-review.googlesource.com/c/1291154Reviewed-by:
-
John Abd-El-Malek authored
Similar to the Set-Cookie case in r600570, Cookie headers can't be read/written by webRequest handlers when the network service is enabled. Instead of sending the GAPS cookie from C++ to JS which then sets it in the webRequest callback, have the C++ code directly write it to the temporary storage partition for login using CookieManager interface. Bug: 887061 Change-Id: I50acfb324e830f42d6a0d53ed32aa63e48aaab3a Reviewed-on: https://chromium-review.googlesource.com/c/1289960 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601151}
-
Yi Su authored
Find the OSDD(Open Search Description Document) <link> in web pages and return it's URL. This is one of methods that recognize a web page as a search engine. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2c6d31bf48a9de4aedfe884147e55150c0ee23b9 Reviewed-on: https://chromium-review.googlesource.com/c/1290934 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bccae517ace..cf5c51bcd364 git log 1bccae517ace..cf5c51bcd364 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 reed@google.com remove unused flags -- no clients define these 2018-10-19 ethannicholas@google.com error when draw ops do not go through addDrawOp 2018-10-19 mtklein@google.com cut out another batch of old xfermodes Created with: gclient setdep -r src/third_party/skia@cf5c51bcd364 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I3eb68b170e44270a1c30bdceea29676a99977e2c Reviewed-on: https://chromium-review.googlesource.com/c/1291155Reviewed-by:
-
Nasko Oskov authored
The current window.open() implementation on the browser side is using OpenURL to navigate when the opener is suppressed (e.g. 'noopener') and URL is specified. This results in the navigation being sent up to the embedder and come back to content. Since the default parameters being constructed should not cause the embedder to make any changes to the navigation, it should be safe to skip the extra code and directly navigate the new window. This CL adds LoadURLParams storage to WebContentsImpl and implements all navigations of window.open() that are started browser process side to use NavigationController::LoadURLWithParams. It effectively short-circuits the unnecessary trip to the embedder. Bug: 882053 Change-Id: I09120397f3a6e7856e76ba0448d0bdff807f7628 Reviewed-on: https://chromium-review.googlesource.com/c/1286194 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601148}
-
Nicolas Ouellet-payeur authored
- Don't build traffic_annotation_auditor on MacOS. - Remove "mac" from the "os_list" everywhere in annotations.xml. - Add a warning and fail on buildbots when an unsupported platform is added in annotations.xml. Bug: 878760 Change-Id: I7329e8ca2940880cdc4aa357acd42b2976d9a80e Reviewed-on: https://chromium-review.googlesource.com/c/1287097Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#601147}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components/policy. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=pmarko@chromium.org Bug: 890902 Change-Id: I07dd9ef1d1e8e0cadbd622010b0f2a2b184e2b89 Reviewed-on: https://chromium-review.googlesource.com/c/1257848 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601146}
-
Mario Sanchez Prada authored
This will be used to migrate AuthService to the IdentityManager, so that we can migrate away from OAuth2TokenService::StartRequestWithContext() but still be able to pass a custom URLLoaderfactory to AuthRequest. Bug: 809440 Change-Id: I349ff1fb9fea29c89fe4abb520cb652560fb65af Reviewed-on: https://chromium-review.googlesource.com/c/1288536Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#601145}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a0b50a9a0590..a4c3ebaca5a9 git log a0b50a9a0590..a4c3ebaca5a9 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 cbruni@chromium.org [wpr] Reuse _CleanUpTempLogFilePath log output in StopServer Created with: gclient setdep -r src/third_party/catapult@a4c3ebaca5a9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878390 TBR=sullivan@chromium.org Change-Id: I55f60f57e3f42780fbdcca871f976b5fb75c8895 Reviewed-on: https://chromium-review.googlesource.com/c/1291153Reviewed-by:
-
Leszek Swirski authored
This is a reland of 7bd91635 No changes from the original, revert reason is fixed with https://chromium-review.googlesource.com/c/1283037 Original change's description: > [blink] Control ScriptStreamer with ScriptResource > > Move the ScriptStreamer control logic from ClassicPendingScript to > ScriptResource. In the future, this will allow us to start streaming > a ScriptResource before the ClassicPendingScript is available, e.g on > preload. > > The ClassicPendingScript now only sends one "finished" callback, from > ScriptResource. This callback is either when the streaming completes, > or when there is no streaming and the ClassicPendingScript has told > the ScriptResource that it doesn't intend to start streaming. In the > long run, we want all scripts to go through the streaming interface, > and we want ScriptResource to control when streaming starts, so the > "no more streaming" call will disappear -- however it is necessary to > maintain the current behaviour, and be able to control it with a > runtime flag. > > Bug: chromium:865098 > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599148} TBR=kouhei@chromium.org,kinuko@chromium.org Bug: chromium:865098 Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c Reviewed-on: https://chromium-review.googlesource.com/c/1286450 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#601143}
-
Vasilii Sukhanov authored
The CL moves the implementation from Android-specific code to the cross-platform component. This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1195483 https://chromium-review.googlesource.com/c/chromium/src/+/1202204 Bug: 879486, 835234 Change-Id: I03dfe07c19f215bc914c9d564011e68010a1c11a Reviewed-on: https://chromium-review.googlesource.com/c/1283133 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601142}
-
Joshua Bell authored
Bug: 824533,750452 Change-Id: I103d6b6a3bd106a6a38de03f9ff14d2766c7b269 Reviewed-on: https://chromium-review.googlesource.com/c/1288890Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#601141}
-
Jakob Gruber authored
These tests were badly outdated and had been marked as failing for three years. Issues were: regexp-caching: - RegExp properties were iterated with a for-in loop, but relevant properties are non-enumerable. Fixed by using Object.getOwnPropertyNames instead. - isReadOnly detection was broken, attempting to write a property and then comparing against the result with '=='. Removed just this part since it doesn't add any value. - We attempted to test 'multiline' coercion, but this property hasn't existed for ages. string-replace-2: - The test relied on old unspecced semantics of interactions between RegExp.p.replace and properties on the RegExp object. Updated to the current behavior. - A bunch of other previously failing tests now pass. Bug: chromium:569139 Change-Id: Ia56da800fc44dd3b750d72fd8fe87a19c7f59e2f Reviewed-on: https://chromium-review.googlesource.com/c/1290153Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601140}
-
Daniel Bratell authored
allocator/allocator_shim.h and base/base_paths_posix.h were in base's |sources| list twice each in some configuration. This removes the duplicates since that confused some tools. Change-Id: I0dfbf796a73ce28fd66352afe0651e61058506eb Reviewed-on: https://chromium-review.googlesource.com/c/1290910Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601139}
-
Michael van Ouwerkerk authored
Change-Id: Ifa4323adbfdf92c148caa2c052397ce0ca49e8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1283253Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601138}
-
Jérôme Lebel authored
Adding a fix that should have been committed with crrev.com/1286659 When the OK button layout is updated, the container layout should be updated too. Bug: 897105 Change-Id: I80a22e755d3255b4ce2c5f637280a3ac7576f1a5 Reviewed-on: https://chromium-review.googlesource.com/c/1290978Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601137}
-
Tom McKee authored
Memory.TabFootprint events give a high-level sample of how much memory is used to render a given URL. To keep these events easy to reason about and analyze, some memory isn't accounted for. Namely, when processes host parts of other tabs, we don't record their contributions. We do, however, make sure that an individual record has all the information nescessary to classify it as a full or partial record. Change-Id: If7a19031502e357be9567ebed760de234f2974ac Reviewed-on: https://chromium-review.googlesource.com/c/1191817Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#601136}
-
Hongchan Choi authored
Previously the storage for automatic pull nodes (handlers actually) were using a raw pointer, so when the BaseAudioContext goes away there\ is no object keeping these node alive. This CL adds ref-counting to the storage so the handler can be alive even after BaseAudioContext is swept away. Without this fix, the crash happens in few minutes. Bug: 891187 Test: The repro case does not crash after 2 hours on the local ASAN. Change-Id: I33a1f74c5803f53e1ace2990af3dd0728720d258 Reviewed-on: https://chromium-review.googlesource.com/c/1286823Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd316406e106..1bccae517ace git log cd316406e106..1bccae517ace --date=short --no-merges --format='%ad %ae %s' 2018-10-19 mtklein@google.com Revert "Use OpenGL sampler objects when available." 2018-10-19 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-10-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c4765aa78267..bc6f52f36d5f (8 commits) 2018-10-19 csmartdalton@google.com ccpr: Unregister path listeners when their cache entries are evicted 2018-10-19 bsalomon@google.com Use OpenGL sampler objects when available. Created with: gclient setdep -r src/third_party/skia@1bccae517ace The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ic944199786bf2bfcd3edbca0400204c5b36dc73b Reviewed-on: https://chromium-review.googlesource.com/c/1291150Reviewed-by:
-
Daniel Bratell authored
Some isolate step errors in trybots mentioned these non-existing headers so hoping the trybots will be happier, this patch removes and changes the names to point to existing files. Bug: 881589 Change-Id: I6c7728110a9ce162293c57606824140cdacd8d38 Reviewed-on: https://chromium-review.googlesource.com/c/1286660Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601133}
-
Sergio Villar Senin authored
It was using SigninManager API to get account info and also to check whether there was a the primary (authenticated) account available. Migrated to IdentityManager API so it could eventually use the identity service. Bug: 890773 Change-Id: Ic6ed0bfbadbfdead2541571d4ede9c91c24f0077 Reviewed-on: https://chromium-review.googlesource.com/c/1286652Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
