GitLab

Bug: None
Change-Id: I47934cdb696aca8e697f7c461495fb67edf4a894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508784
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638699}

Before https://crrev.com/c/1363676, a logic bug ensured that
all Chrome OS devices would exit the gpu process on context loss.

It turns out that this workaround was necessary for AMD chromebooks to pass
the dEQP-EGL.functional.robustness.reset_context.shaders.infinite_loop.*
tests.

BUG=b:123606754
TEST=pass dEQP-EGL on grunt

Change-Id: I34f2d601cc0643cdae568955830e56ac3164f851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504304
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Auto-Submit: Drew Davenport <ddavenport@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638698}

Bug: None
Change-Id: Ia33fbcb45db07ff825df129abcd8a5e23c1eda08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509234
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638697}

Bug: 839986
Change-Id: Ib7d6a38a6b62d467b299d5f06b840d308fcb6ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508787
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638696}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff41430adb0..cb039b04e175


Created with:
  gclient setdep -r src-internal@cb039b04e175

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org

Change-Id: I1721de6ed48dace03583dd2d7d9850091a62259e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508992Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638695}

In CryptAuthKeyCreatorImpl, elements of a flat_map were being erased
while the flat_map was still being iterated through. This caused a
container overflow ASAN error in http://crrev.com/c/1504121.

Verified locally that this CL fixes the ASAN error seen in
http://crrev.com/c/1504121, using the same gn args as the
linux_chromium_chromeos_asan_rel_ng builder.

Bug: 899080
Change-Id: I6f25d795545548ed108e95e2e1ec70f6de20941b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507314Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638694}

Presentation is not yet hooked up for android webview. Currently it is
leaking a little bit of memory for every new compositor frame submitted.
Just clear that map for now.

Bug: 939381
Change-Id: I992835d4b2e68ea97ae8baaf435e29298ec2dc9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508892
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638693}

CreateRenderer(HostedRendererType) was left in after Create*Renderer was
added, in order to prevent breaking the internal ChromeCast build.

This CL cleans up the leftovers and should be submitted after Chromecast
interal code switches to CreateCastRenderer()

Bug: 936528
Change-Id: I29ee8104099485ed32a22aec9ccd6cff5cd63771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493082Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638692}

Allow updating the patterns that the redirector matches to mixer
streams without removing and re-adding the redirector.

Bug: internal b/123626919
Test: cast_audio_backend_unittests
Change-Id: I4f79d9d1c1c95ba213bc1396d9d708fd8bb037bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506670Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638691}

Clear touch screen devices after each test so that touch screen
configuration doesn't interfere with the next test's setup.
Specifically, having a touch screen device causes the virtual
keyboard to be enabled before Shell is done initializing.

Bug: 939177
Change-Id: I8e24cc9ab2f425cdc8d9a3b4d11b0a4e1fd6d9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507250Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638690}

https://chromium.googlesource.com/catapult.git/+log/ccc29087522a..699655f07b93


git log ccc29087522a..699655f07b93 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 benjhayden@chromium.org Fix spa tests.


Created with:
  gclient setdep -r src/third_party/catapult@699655f07b93

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918193
TBR=sullivan@chromium.org

Change-Id: I9e9fb60c0c27e63225659cb611a6c13a972d4239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508912Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638689}

This is a follow up of https://crrev.com/c/1496217

TBR=jbroman@chromium.org

BUG=891908

Change-Id: Ib3a86b00c39ee0c0cc7081fbd87038d3a03c8cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509192Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638688}

Clean up code that has become obsolete due to decomission of
ChromeDriver waterfall.

Change-Id: Ifbdb43872111ec3e575ec6e4aa1b28b76b663756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509095
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638687}

This makes sure that we only allow up to 30 scheduled notifications and
handles the case when we update an existing notification with a
scheduled one.

Bug: 891339
Change-Id: Ifb884367d71f9156abf303d8330364f671e3afb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505503
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638686}

This reverts commit 281e80c3.

Reason for revert:
New test fails in official builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/104341
https://ci.chromium.org/p/chrome/builders/ci/ToTWin64/3351

Original change's description:
> Add tests that lookalike interstitial decisions are shared with incognito.
> 
> This CL adds tests to verify that a decision to bypass the lookalike
> interstitial made in the main profile does not affect incognito and vice
> versa.
> 
> Bug: 927924
> Change-Id: I238e2e263db42c1434b9190de007aa775129417e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458
> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638329}

TBR=meacer@chromium.org,jdeblasio@chromium.org

Change-Id: I68dbe18b841f4022ae0b533402d1f7fe1fa377b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 927924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509333Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638685}

This re-lands this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1503614

Which was reverted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1504597

There's one additional change, which is to ensure that windows
runtime_libs are available as data_deps. This omission was causing
failures on win_chromium_dbg_ng.

Bug: 938020
Change-Id: Id0196d86097f938d046c7936e619d1c7cf8174c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506124Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638684}

Previously we accumulated NEL policies forever until they were wiped out
by a browser restart. This CL introduces a maximum policy limit, beyond
which eviction of expired and/or least recently used policies is
triggered. A last_used field is added to the policies in order to find
the stalest policy to evict.

Bug: 930301
Change-Id: Ifebfc64c19a4228e8830f62c52e83bc06790cba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474530
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638683}

Making a new branch and CL to resolve issues with git and try jobs.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1498614

The utils for making various LabelFormatters sometimes favor std::set over
std::vector so that poorly formed forms, e.g. forms with duplicate fields, do
not interfere with processing later on. Sets allow us to safely assume that
there is just one of a particular ServerFieldType or FieldTypeGroup.

It is worth noting that ContactFormLabelFormatters store their FieldTypeGroups
while AddressFormLabelFormatters do not. This is because address forms are
guaranteed to have ADDRESS_HOME and NAME; however, contact forms could have
NAME and PHONE_HOME, EMAIL, or both PHONE_HOME and EMAIL. It is useful for a
ContactFormLabelFormatter to know which subset of FieldTypeGroups correspond
to its fields.

Change-Id: I6164081759848b263c3d9dd5cfcda190388a3d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506116
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638682}

I can review changes for anything scroll snap related. 🧐

Change-Id: Ia6c794e6bc6b91588cfe7fb8c133c253e2a04c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497388Reviewed-by: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638681}

Bug: 939100
Change-Id: Ia8b7bd430ece375a14569d86482b38c9ad461fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506877Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638680}

Dispatcher is expected to receive messaging IPCs for main thread and not
worker threads.
Add the check to Dispatcher::OnDeliverMesage, similar to what existed
for other messages, e.g. Dispatcher::OnDispatchOnDisconnect.

Bug: None
Test: No visible changes expected.
Change-Id: I0c11b302b9d9610b1f8792ebf2a385e0aec9fb77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508601Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638679}

The render process id param became obolete and unused at some point,
remove it.

Bug: None
Test: No expected change, internal cleanup only.
Change-Id: I422242473c0118692e010909c8380971f01812cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508600Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638678}

BUG=939406
TBR=robertma@chromium.org

Change-Id: I49024a8fad4b64cce2bf31d963b1ba1d80b32670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508581Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638677}

Renames in_set_bounds_from_server to is_server_setting_bounds, which is
hopefully a bit easier to understand.

BUG=none
TEST=none

Change-Id: Ic972be85123dc234fa98baee4d2d602bbcc84a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507324
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638676}

This adds additional resource access to the V2 GPU sandbox to address
crashes.

Bug: 915934
Change-Id: Icf346f03e32523549e5cb9c0806dce1a51794da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506390
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638675}

https://swiftshader.googlesource.com/SwiftShader.git/+log/45faa0849352..ec255730a818


git log 45faa0849352..ec255730a818 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 bclayton@google.com Reactor: Add address-of operator on reference types.


Created with:
  gclient setdep -r src/third_party/swiftshader@ec255730a818

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/126330097
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I1304317d6ebd954f85b3fccede912dffe6539326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508833Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638674}

Bug: 930922
Change-Id: I86eaed2c769f16ac21bcb7d4ee1f96dd01243f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506876Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Bruno Santos <brunoad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638673}

Bug: 938256
Change-Id: I622f1ab4c489fbedb3a72fabbb1e61705d5ae255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507121
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638672}

Since the override summary is used in some cases even when a form was
not edited, i.e. kMarkHttpAsParameterDangerous, a different name would
be more descriptive.

Also add checks in the browser test that this summary is present.

Change-Id: I294c68b0e57d2a87b501960185b7c91b2a3e0ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507319Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638671}

Bug: 924739
Change-Id: I40f649645349d7671b76bd9f480ff4207b89c430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487709
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638670}

Fixes JavaScript run in iframes during VR instrumentation tests not
being run on the UI thread, which was hitting a recently added DCHECK.

TBR=billorr@chromium.org

Bug: 939410
Change-Id: I5d3eba0e8075306cff0182c7d10c4c81204afc10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508582Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638669}

This change will remove UMA logging and related logic for expired origin
count metrics that live in QuotaManager.

Change-Id: I117d93b23a140e6e59aac0fe3f2adef3cd078f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506562Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638668}

Android currently doesn't report crash stack when renderer hangs.
This CL will ask the renderer process to dump the stack to crash report page, without crashing it.
Maybe i can do this for OOP network process alone for the crbug, but I think in general, we should
have the stack for non-responding renderers.

BUG=934317

Change-Id: I5d039c3c6d026e4b608a4f39da4b71933b19c566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498415Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638667}

Makes VrBrowserNavigationTest#testNavigationButtons cover more of the
manual test requirements. Specifically, ensures that the buttons are
properly greyed out when they're disabled and that clicking on the back
button can't cause the browser to go to a different tab.

Bug: 887510
Change-Id: Ie4a09c2286d58f6a7a9d0539995bc226132213a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497471Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638666}

This reverts commit 33fbc186.

Reason for revert: Suspected in a bunch of proto crashes here:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11240

Original change's description:
> Create golden file loader for the time limit consistency tests.
> 
> Bug: 935711
> Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: G. Silva <gfaus@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638569}

TBR=pkasting@chromium.org,michaelpg@chromium.org,hgrandinetti@chromium.org,gfaus@chromium.org

Change-Id: If5471f6687bac6a7fcbaa62f6e67bf4abb93b5ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 935711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508583Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638665}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffb1ffb82284..db5c5ade84ad


git log ffb1ffb82284..db5c5ade84ad --date=short --no-merges --format='%ad %ae %s'
2019-03-07 ehmaldonado@chromium.org gclient: Fetch refs/{branch-heads,tags}/* if needed.


Created with:
  gclient setdep -r src/third_party/depot_tools@db5c5ade84ad

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:938160
TBR=agable@chromium.org

Change-Id: Icbdd5562aeb5408f3e67d0f9bcc0a221b4b12131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508835Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638664}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I7eb7a82223577ece936bed46e2c515377ff05a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509233Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638663}

In an effort to reduce or even ban variable shadowing, this renames
some variables. I'm interested in prohibiting shadowing because
I think it might prevent potential jumbo problems.

The exact warnings this prevents is:

third_party/blink/renderer/core/fileapi/file_reader_loader.cc:358:16: error: declaration shadows a local variable [-Werror,-Wshadow]
    MojoResult result = consumer_handle_->BeginReadData(
               ^
third_party/blink/renderer/core/fileapi/file_reader_loader.cc:346:54: note: previous declaration is here
void FileReaderLoader::OnDataPipeReadable(MojoResult result) {
                                                     ^

third_party/blink/renderer/core/aom/accessible_node.cc:288:16: error: declaration shadows a local variable [-Werror,-Wshadow]
      Element* element = accessible_node->element();
               ^
third_party/blink/renderer/core/aom/accessible_node.cc:278:43: note: previous declaration is here
bool AccessibleNode::GetProperty(Element* element,
                                          ^

third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:43:16: error: declaration shadows a local variable [-Werror,-Wshadow]
    for (Node& node : FlatTreeTraversal::AncestorsOf(node)) {
               ^
third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:40:14: note: previous declaration is here
  for (Node& node : range.Nodes()) {
             ^

third_party/blink/renderer/core/loader/frame_loader.cc:892:10: error: declaration shadows a local variable [-Werror,-Wshadow]
    auto request = mojo::MakeRequest(&navigation_initiator);
         ^
third_party/blink/renderer/core/loader/frame_loader.cc:798:20: note: previous declaration is here
  FrameLoadRequest request(passed_request);
                   ^

third_party/blink/renderer/core/script/modulator.cc:52:20: error: declaration shadows a local variable [-Werror,-Wshadow]
  } else if (auto* scope = DynamicTo<WorkerGlobalScope>(execution_context)) {
                   ^
third_party/blink/renderer/core/script/modulator.cc:45:20: note: previous declaration is here
  } else if (auto* scope = DynamicTo<WorkletGlobalScope>(execution_context)) {
                   ^

Bug: 923510
Change-Id: I82659c403eb15b4f676d24b97414bfbbced9d701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508517
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#638662}

Bug: 939251
Change-Id: Ifbb8384ce97adaf68a32264aa575883886114e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508573
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638661}

The monochrome_public_apk__merge_manifests produced the expectations
file and takes a fraction of the time to build.

Also added a note about making sure your branch is updated.

Change-Id: I3abea3a082ec348c79e92c60c43515829e5dc320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509014
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638660}