GitLab

BUG=231125
TEST=git cl try

Review URL: https://codereview.chromium.org/318873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275410 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/314113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275409 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275408 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175595:175622&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/317323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275407 0039d316-1c4b-4281-b951-d872f2087c98

Blink generated file move requires a clobber to avoid using stale
generated files.

This should have been included in the Blink roll, but we
didn't realize this was needed, so we failed to advise the
gardener (sorry!):
Blink roll 175512:175568
https://codereview.chromium.org/317183002/

See discussion at:
https://code.google.com/p/chromium/issues/detail?id=381111#c4

BUG=381111
TBR=dcheng
TBR=peter

Review URL: https://codereview.chromium.org/316343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381302
TEST=ChunkDemuxerTest.Remove_StartAtDuration

Review URL: https://codereview.chromium.org/312403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275405 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates MetricsService's call to
PluginMetricsProvider::RecordPluginChanges (replaced by a new API on
MetricsProvider). It additionally adds a
MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer
call that API rather than calling MetricsService directly. This change will
enable easily moving MetricsService::LogPluginLoadingError() to
ChromeMetricsServiceClient once the latter is the class that keeps a weak
pointer to the plugin metrics provider.

BUG=375776

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403

Review URL: https://codereview.chromium.org/308433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275404 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275402 0039d316-1c4b-4281-b951-d872f2087c98

There are a lot of steps in processing resources and preparing them for
packaging. It will be easier if these are all done by the same script.

BUG=375431,359249

Review URL: https://codereview.chromium.org/321453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275401 0039d316-1c4b-4281-b951-d872f2087c98

Uprevved system_api to the latest commit for Bluetooth additional
GATT constants.

BUG=362799

Review URL: https://codereview.chromium.org/316283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275400 0039d316-1c4b-4281-b951-d872f2087c98

Generally speaking top synchronous suggestion remains as a top
asynchronous suggestion as well. Get a quick preview of the top
suggestion by requesting just the synchronous one.

Review URL: https://codereview.chromium.org/319813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275399 0039d316-1c4b-4281-b951-d872f2087c98

  out.
  There are some special cases that will cause button still can
  receive mouse down event when mouse is out of the button area.
  One is right click out of the button and a contextual menu
  comes out. If double click now, BrowserActionButton can still
  receive the event. Therefore we don't handle it in this case.

  BUG=377676
  R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/318913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369451

Review URL: https://codereview.chromium.org/311053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275396 0039d316-1c4b-4281-b951-d872f2087c98

This code path was broken sometime within a year, and we don't think
it's worth to support this more.

BUG=366154

Review URL: https://codereview.chromium.org/317083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275395 0039d316-1c4b-4281-b951-d872f2087c98

- BluetoothSocketWin::StartService -> BluetoothSocketWin::Listen;
- Update BluetoothSocketWin::Connect to use a new semantics;
- Impelment BluetoothDeviceWin::ConnectToService and
  BluetoothAdapterWin::CreateRfcommService using the above two;
- Remove no longer needed BluetoothProfileWin;

BUG=372494

Review URL: https://codereview.chromium.org/320463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=oshima@chromium.org
TBR=reed@google.com
TEST=athena_shell

Review URL: https://codereview.chromium.org/316323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275393 0039d316-1c4b-4281-b951-d872f2087c98

As per discussion in the associated bug, this DCHECK may not make sense
on CrOS.

BUG=chrome-os-partner:29388
TEST=Run Debug Chrome, DCHECK not hit

Review URL: https://codereview.chromium.org/315073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=shess@chromium.org

Review URL: https://codereview.chromium.org/313073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275391 0039d316-1c4b-4281-b951-d872f2087c98

The unit test was unfortunately written in a way that didn't catch it.

BUG=376793
R=pasko@chromium.org

Review URL: https://codereview.chromium.org/319053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275390 0039d316-1c4b-4281-b951-d872f2087c98

Apply Eric Rescorla's patch from upstream NSS:
https://bugzilla.mozilla.org/show_bug.cgi?id=1009227

R=agl@chromium.org,ekr@rtfm.com
BUG=369855

Review URL: https://codereview.chromium.org/319573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275389 0039d316-1c4b-4281-b951-d872f2087c98

The managed bookmarks are a new node at the root that are configured via
policy and can't be modified directly by the user. This change makes the
Bookmark Manager aware of those nodes by disabling the mutating options
when working with nodes from the managed tree.

BUG=49598
R=arv@chromium.org

Review URL: https://codereview.chromium.org/308003013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275388 0039d316-1c4b-4281-b951-d872f2087c98

This optional property indicates the reason why this BookmarkTreeNode can't
be modified by the user nor the extension. For now the only value defined is
"managed", indicating that this bookmark was configured by the system
administrator.

If the property is not present then the bookmark is modifiable (default).

BUG=49598
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/320473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275387 0039d316-1c4b-4281-b951-d872f2087c98

This is part I of the effort to support third party authentication for android.

The TokenFetcherProxy is generalized version of the existing PepperTokenFetcher.  It is used by the ThirdPartyClientAuthenticator to fetch auth tokens from both the webapp and the android client.  

BUG=329109

Review URL: https://codereview.chromium.org/311983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275386 0039d316-1c4b-4281-b951-d872f2087c98

The mutating APIs now fail with a new error if they're used to modify
managed bookmarks.

BUG=49598
R=kalman@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/308273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275385 0039d316-1c4b-4281-b951-d872f2087c98

(and suppress layout failures, pending rebaseline)

BUG=380686
TBR=humper@google.com

Review URL: https://codereview.chromium.org/314233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275384 0039d316-1c4b-4281-b951-d872f2087c98

When deleting a WebContents, keep SessionStorageNamespaces used in the tab alive until we receive an acknowledgment from the renderer that the renderer side constructs have been cleaned up. Otherwise we can receive messages from still executing content referring to sessions that were prematurely deleted.

BUG=371304

Review URL: https://codereview.chromium.org/305103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275383 0039d316-1c4b-4281-b951-d872f2087c98

This change wires the ManagedBookmarksTracker to the ChromeBookmarkClient.
The tracker keeps the new managed_node in sync with the ManagedBookmarks
policy, and the ChromeBookmarkClient publishes that node as an extra node
for the BookmarkModel.

Also cleaned up some duplicated constants used by the managed bookmarks code.

BUG=49598

Review URL: https://codereview.chromium.org/319543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275382 0039d316-1c4b-4281-b951-d872f2087c98

We will be saving bookmark salient images even if enhanced bookmark
feature is not turned on. This is to have some images available when we
turn on the feature. For just in case, add a field trial to disable
saving images.

BUG=368034

Review URL: https://codereview.chromium.org/314253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275381 0039d316-1c4b-4281-b951-d872f2087c98

Currently EventLocationFromNative on mac only properly handles events in
windows with no native window border because it flips coordinate systems
using the entire NSWindow frame.

This change flips coordinates in the window's contentRect instead.

BUG=366021
TEST=Added: events_unittests EventsMacTest.NativeTitlebarEventLocation

Review URL: https://codereview.chromium.org/316053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275380 0039d316-1c4b-4281-b951-d872f2087c98

Currently, Chrome Shell leaks the suggestion popup window when terminating.
We need to handle it as the clank does.

android.view.WindowLeaked: Activity org.chromium.chrome.shell.ChromeShellActivity has leaked window android.widget.PopupWindow$PopupViewContainer that was originally added here
    at android.view.ViewRootImpl.<init>(ViewRootImpl.java:348)
    at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
    at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
    at android.widget.PopupWindow.invokePopup(PopupWindow.java:1019)
    at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:925)
    at android.widget.ListPopupWindow.show(ListPopupWindow.java:625)
    at org.chromium.chrome.shell.omnibox.SuggestionPopup.onSuggestionsReceived(SuggestionPopup.java:126)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.onSuggestionsReceived(AutocompleteController.java:175)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.nativeStart(Native Method)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.start(AutocompleteController.java:79)
    at org.chromium.chrome.shell.omnibox.SuggestionPopup$4.run(SuggestionPopup.java:148)
    at android.os.Handler.handleCallback(Handler.java:733)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:136)
    at android.app.ActivityThread.main(ActivityThread.java:5017)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:515)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
    at dalvik.system.NativeStart.main(Native Method)

BUG=380224

Review URL: https://codereview.chromium.org/319553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275379 0039d316-1c4b-4281-b951-d872f2087c98

The way we map axes does not look quite correct to me. We rely on the ordering
in which InputDevice enumerates the motion ranges. There are several problems
with that. First, I don't find any evidence in the documentation that there is
a defined ordering. This means that InputDevice.getMotionRanges() does not
guarantee to enumerate the axes in the same order on different devices or
in different api versions. Second, this leads to using magic constants.
Third, ideally one should be able to add the code for a new device or at least
check if it is correct by looking at the Android specific documentation of the
device. But those documentations refer to api constants like
MotionEvent.AXIS_FOO instead of the index of the motion range.
This CL cleans it up by storing the axes values associatively indexed by api
constants, just like we do for buttons. Finally, it adds the device specific
code for the Samsung and the PS3 gamepads.

TEST=http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html
BUG=330094

Review URL: https://codereview.chromium.org/307413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275378 0039d316-1c4b-4281-b951-d872f2087c98

R=dtu@chromium.org

Review URL: https://codereview.chromium.org/317273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275377 0039d316-1c4b-4281-b951-d872f2087c98

Also, restricted the access to ComponentUpdateService::GetComponentDetails
so only the friends of the ComponentUpdateService class can call it.


BUG=381199

Review URL: https://codereview.chromium.org/313373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275376 0039d316-1c4b-4281-b951-d872f2087c98

The --enable-filemanager-mtp is now on by default.
It can still be disabled by --enable-filemanager-mtp=false, or
choosing "disabled" in about:flags.

BUG=266939

Review URL: https://codereview.chromium.org/314033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275375 0039d316-1c4b-4281-b951-d872f2087c98

I'm tired of copy/pasting the wrong style :)

http://www.chromium.org/developers/coding-style#TOC-File-headers

BUG=

Review URL: https://codereview.chromium.org/319813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275374 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/306083005/.
That was reverted because it implicitly added a dependency on
content from athena_shell.

This is identical to the original CL but still safe because
the dependency issue has been fixed already.

BUG=370204
TBR=oshima@chromium.org, benwells@chromium.org, reed@google.com
TEST=manually

Review URL: https://codereview.chromium.org/317163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275373 0039d316-1c4b-4281-b951-d872f2087c98

_NET_ACTIVE_WINDOW events with a CurrentTime timestamp are ignored by Unity.

BUG=365450, 355667
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/317783012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/318983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275369 0039d316-1c4b-4281-b951-d872f2087c98

r1927 android: Handle inputs with spaces inside make functions.
r1926 Fix msvs-ninja OutputDirectory path.
r1925 msvs: Revert r1920 and add a test for excluded idl
r1924 Use relative path/dir msbuild variables to map $(InputDir) and
      $(InputPath)
r1923 Fix for some rules not being run if their trigger is also an
      action dependency
r1922 ninja win: filter 64 bit idl processing, and confirm in test

BUG=

Review URL: https://codereview.chromium.org/313243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275368 0039d316-1c4b-4281-b951-d872f2087c98