- 31 Jul, 2019 40 commits
-
-
Yi Su authored
Some public functions WebFramesManagerImpl are only used for unittests. These functions should be converted to private to improve encapsulation and unittests of WebFramesManagerImpl. Bug: 956516,956511 Change-Id: I9d5b85f9014ffe7cf60a77331cb308a27fb6b1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718408 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#682633}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I4e1d03b3d4a753c5d273a3607cecf1a84d12da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700835Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682632}
-
Hajime Hoshi authored
There was no consistent rule what type should be used for isolated world IDs. Let's use int32_t for consistency. This is a following-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1703052 Change-Id: Ida971bc36a1c63cd63e7e77b8d49a9bc9efe39e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708690Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682631}
-
arthursonzogni authored
Test filters were configured to do the exact opposite of what was intended. They were configured to run ONLY the failing test. Adding a '-' before each lines to get the correct behavior. Bug: 511340 Change-Id: Ib3998f2556ae72fe0608965863ac6d470121541f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726057 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682630}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f0162f6..0c98484b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ida335af519e6e003d012a8fb97a6212e00b08615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/67d90245bad4..5aab967f546e git log 67d90245bad4..5aab967f546e --date=short --no-merges --format='%ad %ae %s' 2019-07-31 yyanagisawa@chromium.org Choose the Goma client based on where it runs. Created with: gclient setdep -r src/third_party/chromite@5aab967f546e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I009dbae460cc288c40325f9026af4362356673a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682628}
-
Anders Hartvoll Ruud authored
Instead of passing around scoped_refptr<NonInterpolableValue>&, pass around a virtual UnderlyingValue& which represents the underlying value. This should allow the internal APIs to cooperate better long term, since UnderlyingValue can have multiple implementations depending on what's required by the circumstance. If ::Composite now wants to modify the NonInterpolableValue, it must replace the entire value; it can no longer mutate the incoming scoped_refptr. This property will make it possible to store a scoped_refptr<const NonInterpolableValue> in InterpolationValue. A consequence of this is that ListInterpolationFunctions can no longer modify the underlying NonInterpolableList in-place. Hence NonInterpolableList::AutoBuilder is added to implement copy-on-write-like behavior for those lists. (Note that this in-place mutation of the underlying NonInterpolableList is the main reason why we can't just store a scoped_refptr<const NonInterpolableValue> in InterpolationValue in the first place ...) Bug: 981024 Change-Id: Iadc105beea9ea0006ce638011dd7b3168149449f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722967 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682627}
-
Antonio Gomes authored
This is phase 3.2.2 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ G=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I73798ce8683125b515fc02dceb53f2ccf38e46ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724559 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Kamila Śledź authored
SAML public account user type was merged into regular public account user type, which allows SAML public session pods to be shown on the login screen the same way as regular public session pods. Bug: 876287 Change-Id: Ib1e969b9b66efa5ae166aaec58fb94d2bb8c1a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710323 Commit-Queue: Kamila Śledź <kamilasledz@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682625}
-
Carlos Caballero authored
This is a reland of d2d3af26 Also we now call base::PostTaskAndroid::SignalNativeSchedulerShutdown() which on the Java side has the following comment "This is here to make C++ tests work" Probably a good idea to call it :) Also we no longer call ResetForTesting() but Shutdown instead. As this what happens in prod. Original change's description: > Fix flakly content_browsertests > > Looks like BrowserTaskExecutor is being deleted while the IO thread is > still running and thus capable of posting tasks. Also browser tests are > like prod, we shouldn't manually shut down pools and schedulers. > > Bug: 963702 > Change-Id: I1cb953acc4b495631fe269af9e06b94fbe5f2a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628748 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667097} Bug: 963702 Change-Id: I88f2b8d418eeb1a9a44f8f17bd5c1147993e8e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651725Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682624}
-
Kinuko Yasuda authored
Bug: 934009 Change-Id: I338f7e288d1767bfe221f947bdf76e34b4250ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723400 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#682623}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2568b37b25f5..0b1b7f03bc17 git log 2568b37b25f5..0b1b7f03bc17 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 dberris@chromium.org Pinpoint: Update stats to account cancelled jobs Created with: gclient setdep -r src/third_party/catapult@0b1b7f03bc17 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:977488 Change-Id: Id89e1f29f3442486439888e66492ecabc16be131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728254Reviewed-by:
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=msisov@igalia.com Change-Id: Ifd0a66916d58f2357552fd469542650ef94a57b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715361 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682621}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3667080a. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icfd7a92021761ef3afe14e261db4d9f0701acf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728209Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682620}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a13c7744f154..6808e2d1faac git log a13c7744f154..6808e2d1faac --date=short --no-merges --format='%ad %ae %s' 2019-07-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cbabea734cbd..1ebe6014389e (9 commits) Created with: gclient setdep -r src/third_party/skia@6808e2d1faac The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Id1cca862b7d7b72381ddc05856fe8bfad721cff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728252Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e967dfdfc37..e529ecb5bb99 git log 8e967dfdfc37..e529ecb5bb99 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bb33f8cf..1443fbac (682476:682581) Created with: gclient setdep -r src/third_party/webrtc@e529ecb5bb99 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I74ae8b3c9e550e26060d0b168c43141b0cff9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728253Reviewed-by:
-
Ramin Halavati authored
Omnibox.Search.OffTheRecord histogram metric is added that counts the number of searches from Omnibox on desktop, sliced based on being in regular mode or incognito/guest modes. Bug: 966747 Change-Id: Ifce9992a9bf4d5c4fa84d8668a24e0e024a8230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712673 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682617}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d08611b7a8dc..351ea23830db git log d08611b7a8dc..351ea23830db --date=short --no-merges --format='%ad %ae %s' 2019-07-31 shaobo.yan@intel.com Dynamic Buffer Offset : D3D Backend Created with: gclient setdep -r src/third_party/dawn@351ea23830db The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0a72bf73d004a724c069f3f5de11d5e2e34f4204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728250Reviewed-by:
-
Lei Zhang authored
https://pdfium.googlesource.com/pdfium.git/+log/7264bc930f9b..a9d33bd8b6ba Adjust caller to FPDFAnnot_GetFormFieldFlags() in PDFiumEngine to stop passing a useless parameter. Created with: roll-dep src/third_party/pdfium TBR=tsepez@chromium.org Change-Id: I4f360ccacffe51007fa93e59f913410352ddc53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728192Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa48b9720588..63b0b8018380 Created with: gclient setdep -r src-internal@63b0b8018380 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5bc2f3506e7f587dd55db72be1ac0af114aca7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682614}
-
Nigel Tao authored
This doesn't change how the code-under-test behaves. It simply adds more (programatically checked) information about what the test expects to happen. Change-Id: Icac601d5a98baf1a2646df78699e357ab23bd002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720229 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682613}
-
Eric Willigers authored
WebAppBrowserController::IsUrlInAppScope is now implemented. All of the web app badging tests are now run with and without BMO enabled. Bug: 966290 Change-Id: I28c2c0dd7bc50a96939e9008693964f0aa8c85e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728170Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682612}
-
Takashi Toyoshima authored
This patch implements SafeBundledExchangesParser and BundledExchangesReader. SafeBundledExchangesParser manages remote BundledExchangesParser interface to communicate with data_decoder service in a reliable way. BundledExchangesReader uses this trusted parser implementation and provides functionalities to read BundledExchanges resource in the browser process. In this patch, BundledExchangesFactory uses the reader interface to obtain the initial redirect URL. Bug: 966753 Change-Id: I0a03237141bea9639a0cbeac4ae085a87fac6c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712792Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62077a99..3f0162f6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1109260a718f9a1b090bc4a9abae9b6db0af9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726996Reviewed-by:
-
Yutaka Hirano authored
- "cross-origin-embedder-policy" set's the policy for frame. - dedicated worker's policy is set to the ancestor frame's policy. - nested frames with a conflicting policy is blocked. SharedWorker / ServiceWorker are not yet supported. All the implementation is behind the flag, and tested manually with work in progress WPTs[1]. 1: https://github.com/web-platform-tests/wpt/pull/17606 Bug: 887967 Change-Id: I70ed24841afde1b3c72dad40288744bb92a6f5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715378 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Manu Cornet authored
Bug: 973443 Change-Id: I06660e09b046ccd0e654fb868916044e9a27291b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666945 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#682608}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc3e90f1cb95841e9ff5ddc0c2bc3d9824896dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727990Reviewed-by:
-
Vadim Bendebury authored
A new enum is being added to the Cr50 codebase (see https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1723097) let's make sure it is displayed properly by UMA. BUG=b:135772657 TEST=none Change-Id: I7b8e9c6a8ecfd0ddc3392cdc762e4cf1fe0aca1b Signed-off-by:
Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725550Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#682606}
-
Austin Tankiang authored
In the current code, if |entry| is not null and |volumeInfo| is null, the code will throw an exception. Bug: 989364 Change-Id: Iae24eeabadd0d99f83fab8feb8cfbf3870723edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727829Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#682605}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLAreaElement> and DynamicTo<HTMLAreaElement> as new downcast helper. 2. Use IsA<HTMLAreaElement>(element) in place of IsHTMLAreaElement(element) Bug: 891908 Change-Id: I519218d8b82066eb21edd362c2c230ab31b3ae91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725541Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6980c4e0aef8..a13c7744f154 git log 6980c4e0aef8..a13c7744f154 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e6092f3bc901..324bdfed0692 (6 commits) Created with: gclient setdep -r src/third_party/skia@a13c7744f154 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Ieab2de11abf058c0e95097a823e949d36da17365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727588Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I57bb051a81907515ccfcc8d9e938a343203fc9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725538Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#682602}
-
Joel Hockey authored
Since files_xf_elements.html doesn't contain any reference to chrome://resources or other part which would need to be rewritten, there is no need to modify it for UI tests. Change-Id: I1b3fa6cb97d436b865eebf8939ac795a8bd966a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725133 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#682601}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLAudioElement> and DynamicTo<HTMLAudioElement> as new downcast helper. 2. Use IsA<HTMLAudioElement>(element) in place of IsHTMLAudioElement(element) Bug: 891908 Change-Id: I787075e911bdbd7371b1827a017f5dcdc1abf0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726430Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46e8be7b481d..aa48b9720588 Created with: gclient setdep -r src-internal@aa48b9720588 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I000318a6c0ab44d6dfe425b7dc0213326b485393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727757Reviewed-by:
-
Bartek Nowierski authored
They are old and superseded by Memory.Renderer.* & Memory.Experimental.Renderer2.* Bug: 916761 Change-Id: Ie99a6e37d5f7fe016f71cc713562c468efaf2bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722536Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682598}
-
Takashi Sakamoto authored
This reverts commit 6720f8ec. Reason for revert: suspect causing content_browsertests failure on Windows bots: E.g. https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39015 deterministic failures AXPlatformNodeTextRangeProviderWinBrowserTest.OutOfProcessIFrameTraversal AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitFormat AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitParagraph AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord AXPlatformNodeTextRangeProviderWinBrowserTest.IFrameTraversal AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitFormatAllFormats AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitParagraphCollapseTrailingLineBreakingObjects AXPlatformNodeTextRangeProviderWinBrowserTest.ExpandToEnclosingFormat AXPlatformNodeTextRangeProviderWinBrowserTest.GetBoundingRectangles https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906448482404732176/+/steps/content_browsertests_on_Windows-10-15063/0/logs/Deterministic_failure:_AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord__status_FAILURE_/0 [ RUN ] AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord ... ../../content/browser/accessibility/ax_platform_node_textrangeprovider_win_browsertest.cc(360): error: Expected: (nullptr) != (text_range), actual: (nullptr) vs 8-byte object <00-00 00-00 00-00 00-00> Original change's description: > Add trailing whitespace and punctuation to UIA Move(TextUnit_Word) > > 1. Changing the behavior of `ITextRangeProvider` methods `Move` and > `ExpandToEnclosingUnit` with `TextUnit_Word`. > > Previously we relied on both, word start and end offsets, computed > from Blink, but such approach didn't matched every AT's expectations. > > Updated logic makes use of start offsets only, this forces movement > by word to include whitespace and punctuation characters before the > next word start; the only special case being the last word, whose end > offset will be located after the last character on the document. > > 2. Removing `AXPosition`'s methods `AsLeafTextPositionBeforeCharacter` > and `AsLeafTextPositionAfterCharacter` in favor of refactoring > `AsPositionBeforeCharacter` and `AsPositionAfterCharacter`. > > This is a follow-up optimization since the former methods called > their `AsLeafTextPosition` equivalents, but reverted the result if > the position was not adjusted to another anchor. > > 3. Adding a new browser test to cover some AT's expectations. > > Rebaselining `AXPlatformNodeTextRangeProviderWin` unit and browser > tests to account for the new word movement behavior. > > Bug: 928948 > Change-Id: Iab689fde2a2ea973e86f7cdb10c1c22cf1af1704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718064 > Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682564} TBR=nektar@chromium.org,kschmi@microsoft.com,ethavar@microsoft.com Change-Id: I855ecf6dbb5769c591d35bd6134164e5aeec37b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728130Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#682597}
-
Shuo-Peng Liao authored
For some platform specific format, e.g. V4L2_PIX_FMT_MT21C, it does not have corresponding VideoPixelFormat mapping. As the format is only used between video decoder accelerator (VDA) and image processor, we shall add an optional field, fourcc, in PortConfig so that VDA can tell image processor which input format it should be used. BUG=985683, b:132589320 TEST=Run VDA_unittest and media_unittest on elm Change-Id: I1362a6805b64bab03db254010e7b62b0cc4fd68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724269 Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#682596}
-
Eric Willigers authored
The file handling tests are now run with both WebAppBrowserController and HostedAppBrowserController. Bug: 966290 Change-Id: I3ec4abf6883dfb132a294c3707439607e3cb6233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727849 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
E.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/40811 Unexpected Failures: * fast/borders/border-radius-mask-canvas-all.html * fast/borders/border-radius-mask-canvas-border.html * fast/borders/border-radius-mask-canvas-padding.html * fast/borders/border-radius-mask-canvas-with-mask.html * fast/borders/border-radius-mask-canvas-with-shadow.html * fast/borders/border-radius-mask-canvas.html * fast/borders/border-radius-mask-video-ratio.html * fast/borders/border-radius-mask-video-shadow.html * fast/borders/border-radius-mask-video.html Bug: 979422 Change-Id: I77650a186cf4dcb029b58b0d839aab07ee40688a TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727096Reviewed-by:
-
