- 03 Oct, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b30d11319bac..b437351d880f $ git log b30d11319..b437351d8 --date=short --no-merges --format='%ad %ae %s' 2017-10-02 mtklein add _skx stages 2017-10-02 brianosman Revert^6 "Make threaded proxy generation MDB-friendly, and defer instantiation" 2017-10-02 enne Fix SkRRect validation for negative types Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I86775b2a57fdabedb95053ea5a7aadc7eb4cf30a Reviewed-on: https://chromium-review.googlesource.com/696128Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505906}
-
Nico Weber authored
In gn files, only both were checked, so combine them to a single use_pangocairo flag. Also run ack -l skia::NativeDrawing printing/ | \ xargs sed -i 's/skia::NativeDrawing/printing::NativeDrawing/g' since NativeDrawingContext got moved from skia/ to printing/ a while ago. No intended behavior change. Bug: none Change-Id: Iba0a205b0026164bf434b7ad0ed246eff1f2c6f8 Reviewed-on: https://chromium-review.googlesource.com/693159Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505905}
-
Ahmed Fakhry authored
We started getting some feedback reports about Night Light not working properly but they're not useful since Night Light doesn't log anything at all. This CL adds some logs in the potential areas where problems are more likely to occur, such as geolocation. BUG=768902 Change-Id: If836f856126f4d2a9f2179873b217b944ca42674 Reviewed-on: https://chromium-review.googlesource.com/696191 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#505904}
-
Justin Donnelly authored
Swapping title and URL is already done for the experimental vertical layout. This new flag (chrome://flags/#omnibox-ui-swap-title-and-url) is intended to enable the same behavior in the default horizontal layout. Bug: Change-Id: I6c2eca5ca11fef7518a88704b56de03e38f4f001 Reviewed-on: https://chromium-review.googlesource.com/695822Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#505903}
-
Mathieu Perreault authored
Bug: 767931 Test: existing Change-Id: I3289af3bf4644f8bea05cbe23d14574f0a17a414 Reviewed-on: https://chromium-review.googlesource.com/693089 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505902}
-
Will Chen authored
The legacy test framework has a mechanism for enabling experiments at the startup of DevTools, and this brings parity in the new test framework. In the long-term, there should be a better solution as this is very confusing for first-time DevTools test contributors and is a code smell. Bug: 667560 Change-Id: I230453e16b3d06f6ee9ada99c0beb793f244d8c5 Reviewed-on: https://chromium-review.googlesource.com/695910Reviewed-by:
Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#505901}
-
Bill Budge authored
- Refactors GetRandomPageBase to make it easier to understand. - Adds handling for architectures and OS'es needed by V8. - Increases random bits on Windows 64 bit to 48 for 8.10 or greater, 44 for older versions of Windows. - Adds unit tests. Bug: chromium:756050 Change-Id: I3d27aeb9e243cfdda005662dc6df710bdbcabaaa Reviewed-on: https://chromium-review.googlesource.com/688741 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#505900}
-
Lei Zhang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2f8eedac96fae027fd4621b5b8b2e357971b618f Reviewed-on: https://chromium-review.googlesource.com/689854 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#505899}
-
Khushal authored
If the renderer can not run an image animation at the requested frame rate, frames in the animation are skipped when trying to catch up to the desired frame. Add an UMA to measure this to assess the smoothness of these animations. Bug: 735741 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d00dbeb6455f8e5badebbdec3403677ec2db462 Reviewed-on: https://chromium-review.googlesource.com/668016 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505898}
-
Emil A Eklund authored
Bug: 769681 Change-Id: I28e9597aa2d1888f9890bb37d536b1e3b3886330 Reviewed-on: https://chromium-review.googlesource.com/692956Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#505897}
-
sebsg authored
Bug: 748223 Change-Id: I93fd4f4e326fe5b272ae4b8816a3c744621b3949 Reviewed-on: https://chromium-review.googlesource.com/675768 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#505896}
-
Yoland Yan authored
RestrictionSkipCheck should initialize CommandLine if it is not initialized for checking device type. Bug: 755825 Change-Id: Ied37da84ead33b6f2208c61ab5ed07f7b008d3a0 Reviewed-on: https://chromium-review.googlesource.com/616255 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#505895}
-
Will Chen authored
The new protocol test harness has replaced the need for this old protocol test harness. Bug: 734762 Change-Id: I388780e8c8d9b76f4272e78a1e55cafec605bfe2 Reviewed-on: https://chromium-review.googlesource.com/696039Reviewed-by:
-
Dirk Pranke authored
The file had "/usr/bin/python2", but that doesn't exist on the mac. This changes the line to "/usr/bin/env python" which is what we normally recommend; python == python2 on nearly every distribution. R=mmoroz@chromium.org Change-Id: I67f37864d8a5e80cbf79b5ff52b00041974d2ae9 Reviewed-on: https://chromium-review.googlesource.com/696137 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#505893}
-
Chris Watkins authored
If overlays are supported by the device, MCVD now requests OverlayInfo updates during lazy init and continues initialization when it gets the first one. If overlays are not supported it skips making any calls to AndroidVideoSurfaceChooser and uses a surface texture. Bug: 660942 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5fb4a008f7bf2932cec96570f6b5782a1d327474 Reviewed-on: https://chromium-review.googlesource.com/689416 Commit-Queue: Chris Watkins <watk@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#505892}
-
Yuke Liao authored
The per directory html report generation step may take up to a minute without printing out anything, and to avoid confusions, the script should explain to the users that it's doing. Bug: 757515 Change-Id: I7c1c02dee62942c9d70cd18fe0b43f047ca50517 Reviewed-on: https://chromium-review.googlesource.com/696326Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505891}
-
Peter Boström authored
Changes the RenderText default password character to be a bullet on all platforms instead of just Mac, as part of Harmony unification of UI. This changes the ash LoginPasswordView from using the U+2219 bullet operator glyph to the RenderText default bullet glyph. Removes SetPasswordReplacementChar as it is no longer meaningfully used. BUG=chromium:654115, chromium:770402 Change-Id: Ia323917a7dcf3a4b303d74d3488b3da7bf2d65ca Reviewed-on: https://chromium-review.googlesource.com/693279 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505890}
-
Becky Zhou authored
Set tab stack button to not clickable if new tab bottom sheet is on show. This will prevent tab stack button being clicked after new tab button is clicked that changes the toolbar to tab switcher mode. Bug: 747785 Change-Id: Ie7df8acc034bf9dcb3330dd1e235030b561f3060 Reviewed-on: https://chromium-review.googlesource.com/695867 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505889}
-
Bret Sepulveda authored
Since Flash is now the only supported plugin, this patch removes all the generic language in the dialog and makes it specific to Flash. This patch also deletes some related strings that were unused. Bug: 652030 Change-Id: Iadd4eb43305f269456c59a06132c9d9c2184c6e3 Reviewed-on: https://chromium-review.googlesource.com/685806Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#505888}
-
Lei Tian authored
When CCT bottom bar is shown, the contextual search peeking bar is hidden beneath it. The correct behavior should be when contextual search bar is shown, CCT bottom bar should be dismissed. To fix the problem, add a ContextualSearchObserver from the CustomTabBottomBarDelegate to know when the contextual search bar is shown/hidden, then hide/show bottom bar based on the observer's callbacks. BUG=684675 Change-Id: Iad53e7b8e83afcf127c7adcf1965cd4f75bc0afa Reviewed-on: https://chromium-review.googlesource.com/693343Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#505887}
-
Charles Harrison authored
This will help as a reference point for other visibility metrics at the tab layer (namely popups and tab-unders). This CL contains a minor refactor, so that the ScopedVisibilityTrackers no longer own their tick clocks. Bug: 661629 Change-Id: I879fe751661876442b609bad9008d16af52ba2f1 Reviewed-on: https://chromium-review.googlesource.com/694741 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505886}
-
Khushal authored
This reverts commit fe24d7f3. Since we rasterize the SkPicture with decoded images in the test, we need to initialize its pixels. Fix that. R=enne@chromium.org TBR=chrishtr@chromium.org Bug: 735741,728359 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I10989e2bc28594c9fa8e291559ae2753e65de29d Reviewed-on: https://chromium-review.googlesource.com/695449Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#505885}
-
Evan Stade authored
The showApps property is only used by ntp4.js, which despite its name is the apps page, which is non-Chrome OS desktop only. Bug: 770866 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16e313cb01f28dbe76cc42f79f42d6bb4d126f7c Reviewed-on: https://chromium-review.googlesource.com/695710Reviewed-by:
-
pdr authored
With Root Layer Scrolling (RLS), the local frame contents are not scrolled because scrolling is handled by the layout view. This patch updates ClipByVisualViewport to apply the scroll offset itself (for both RLS and !RLS) instead of using RootFrameToContents. Bug: 769490 Change-Id: I3bff26b74f9672882bb8c564067f7e6630bbabf1 Reviewed-on: https://chromium-review.googlesource.com/695720Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505883}
-
Achuith Bhandarkar authored
* Add WizardController::SkipEnrollmentPromptsForTesting to skip enrollment prompts. * Do not automatically log in after enrollment. * Some additional logging. BUG=chromium:651249 TEST=enterprise_FakeEnrollment Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie8516d3b97055c9435697a0071ddf66e5e7dac07 Reviewed-on: https://chromium-review.googlesource.com/696296Reviewed-by:
-
Conley Owens authored
This test may be simplified by using a promise_test rather than an async_test. Additionally, using promise_test will simplify the transition to new mojo bindings and the migration to Web Platform Tests. BUG=769412 Change-Id: I4ae41fa5e5fb43ee611cefc8527bb2e078f1bb71 Reviewed-on: https://chromium-review.googlesource.com/690602Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#505881}
-
Mitsuru Oshima authored
BUG=None Change-Id: Ib8982c19f02e36181b0936d1ed63cffdbb5ad108 Reviewed-on: https://chromium-review.googlesource.com/695716Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Otherwise crash can occur. R=pfeldman@chromium.org Bug: chromium:757778 Change-Id: Idbe43f15bf620af41738e6e27c7a5ddf5bbf3067 Reviewed-on: https://chromium-review.googlesource.com/685270 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ken Rockot authored
Removes a bunch of long-unused entries and adds a new one for some upcoming internal-only stuff. TBR=yzshen@chromium.org Bug: 673417 Change-Id: I380283ed7b2daae36f6c35529d8ea8a7fda7040d Reviewed-on: https://chromium-review.googlesource.com/696129Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505878}
-
Jonathan Ross authored
This reverts commit e724b177. Reason for revert: There have been a series of flakes on the trybots, that were no occurring on the Mojo FYI bots. Removing these tests from the trybots until we can find out why. Original change's description: > Add Telemetry to linux-chromiumos bot > > We've been running telemetry_unittests and telemetry_perf_unittests on the Mojo > FYI bots. They've been cycling green for a week, so we'd like to add them to > the main linux_chromeos bot. > > TBR=sky@chromium.org > > Bug: 758065 > Change-Id: I6ea2c3f619237124ebba5b691ac08bffb93652a6 > Reviewed-on: https://chromium-review.googlesource.com/657858 > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503031} TBR=sadrul@chromium.org,sky@chromium.org,jonross@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758065 Change-Id: I682ef5e4c7ac45384ce4b4c435ab19f23f0b80ec Reviewed-on: https://chromium-review.googlesource.com/696301Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#505877}
-
WC Leung authored
GetAvatarIcon, GetAvatarIconIndex, SetAvatarIconIndex, and GetHighResAvatar are migrated to ProfileAttributesEntry. Old accessors are still here (with some extra comment) because they are still used by ProfileInfoCache tests. Two high-res avatar tests are migrated and one test about avatar icon index is added. An existing observer notifier method in ProfileAttributesStorage is changed because it was not good enough. Bug: 305720 Change-Id: I93b3e765cd1131f7ddb905c884db6d23390786bb Reviewed-on: https://chromium-review.googlesource.com/694062Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: WC Leung <lwchkg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505876}
-
Ryan Sturm authored
Bug: 768256 Change-Id: Ie965ca7eae7fa094e23e0d9e294a341136975300 Reviewed-on: https://chromium-review.googlesource.com/683241Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505875}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: Ic44b6d3465e3affd405f188c7743fbe543f846c4 Reviewed-on: https://chromium-review.googlesource.com/688898Reviewed-by:
-
Erik Luo authored
Objects such as 'NodeList', 'HTMLAllCollection', and 'Arguments' are all 'array'-subtype, and require the same formatting logic as normal arrays. However, unlike normal Arrays, they should print their name as part of their result. For example, 'NodeList(5) [...]' instead of '(5) [...]'. Screenshot: https://imgur.com/a/I41jb Bug: 769998 Change-Id: I898e4e2be6c9a1bc5f05c341ab2bcc83e57deb2d Reviewed-on: https://chromium-review.googlesource.com/691355 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
David Tseng authored
When a ChromeVox user touch explores, the resulting hit node is sometimes a container. For example, <div> <div> hello </div> </div> The outer div can be much larger than the inner div. Since the div itself isn't usually encountered during keyboard navigation, it is safe to re-target the hover that touches it into an object inside. e.g. 'a' once and can't touch both its container and the text inside. Test: touch explore in the vk. Verify we only ever hear the key Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iae6a43c436f37b2adf3ee4c82f824d6e6bfbec2f Reviewed-on: https://chromium-review.googlesource.com/695905Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505872}
-
Dominik Laskowski authored
The RenderPass::output_rect and host window bounds for SurfaceTreeHost were set to the content size of the root surface. Hence, surfaces were clipped to the viewport (0, 0) × (W, H), where (W, H) is the size of the root surface. The root surface of ARC windows is sized to match the Android display. This CL computes the output_rect as the bounding box of the surface tree, and resizes the host window to match the output_rect. Bug: b:64893967 Test: Windows whose bounds exceed the bottom/right edges of the display are not clipped in overview mode. Change-Id: I51ddf7405e703f5c546aec88a01cc004d105b18a Reviewed-on: https://chromium-review.googlesource.com/639472 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505871}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/951b1119d4c7..c2ae41abd16a $ git log 951b1119d..c2ae41abd --date=short --no-merges --format='%ad %ae %s' 2017-10-02 rharrison Replace GetWord_LSBFirst with FXWORD_GET_LSBFIRST Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I5a1ab9282e05f355622b5d2f5abb183c7872a8b1 Reviewed-on: https://chromium-review.googlesource.com/695719 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505870}
-
Peter Qiu authored
Software decoder will always convert mono to stereo, so setup the output backend to stereo in the case of mono input. Bug: b/67158736 Test: manual Change-Id: Ibaa59b1a5c8532f28e7a8e2d82352942e4508110 Reviewed-on: https://chromium-review.googlesource.com/695847Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505869}
-
Yoland Yan authored
In JUnit3, CommandLine is initialized before a test run, we should do the same to avoid test flakiness. Bug: 640116 Change-Id: If9ac3945680060125cfc86b63cf79a91e21d13dc Reviewed-on: https://chromium-review.googlesource.com/685811Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505868}
-
Brett Wilson authored
The current_buffer_ member variable always points to the front of the queue. The code can be simplified slightly be removing it. Change-Id: I4c4101b91d8df7a0640547b3f6f8ecd7dfcd0049 Reviewed-on: https://chromium-review.googlesource.com/695813Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505867}
-
