Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 01 Dec, 2017 4 commits
    • Scott Graham's avatar
      Revert "Convert UKM tests to express expectations over specific entries." · 16af3fb6
      Scott Graham authored 
      This reverts commit 290a7939.

Reason for revert: Appears to be flaking on Windows, filed https://bugs.chromium.org/p/chromium/issues/detail?id=790806 for followup.

Original change's description:
> Convert UKM tests to express expectations over specific entries.
> 
> As part of the switch to using shared SourceIds, we will start
> associating the same URL with multiple SourceIds, and this will
> break all tests that currently use GetSourceForUrl and similar.
> 
> This avoids that by converting existing tests to use a new test
> recorder API which lets test express expectations over the entries
> they are recording.
> 
> Bug: 761524
> TBR=bmcquade
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I43f0e09e026fa1373869ea5530427f88f6317a7a
> Reviewed-on: https://chromium-review.googlesource.com/774120
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520398}

TBR=avi@chromium.org,raymes@chromium.org,dalecurtis@chromium.org,vmpstr@chromium.org,petewil@chromium.org,vasilii@chromium.org,mathp@chromium.org,asvitkine@chromium.org,erikchen@chromium.org,hajimehoshi@chromium.org,mlamouri@chromium.org,tdresser@chromium.org,holte@chromium.org,bmcquade@chromium.org

Change-Id: I1b57d01ba3ff23637d3069e4e280f923fbc6f255
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/802357Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520760}
      16af3fb6
    • Brett Wilson's avatar
      Separate tab icon and throbber into a separate view. · 0e161fe5
      Brett Wilson authored 
      This class handles the favicon, loading throbber, attention indicator,
and sad tab animations. The separation makes the Tab class cleaner and
allows this complex view to be re-used in the experimental tab class
in the future.

The network state enum was moved out from TabRendererData into its
own class. It was updated to an enum class with new-style naming.

Throbber stepping was moved to be entirely within the tab strip rather
than round-tripping through the TabStripController.

Change-Id: I063c0540e423ebbba3798a546ef58ef7616d629a
Reviewed-on: https://chromium-review.googlesource.com/792451Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520759}
      0e161fe5
    • Zhongyi Shi's avatar
      Add a different config param to control connection migration v2 on · f4683a37
      Zhongyi Shi authored 
      path degrading

Bug: 774622
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0c3841858a2f285414c0fc6cb8808ebea06a26b4
Reviewed-on: https://chromium-review.googlesource.com/794810
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarMisha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520758}
      f4683a37
    • Devlin Cronin's avatar
      [Extensions Bindings] Check context validity before instantating an API · bf360a39
      Devlin Cronin authored 
      Check if the context is still valid before creating a new API object
through the lazy accessor on the Chrome object.

Bug: 788088
Change-Id: If23e5648f2d240af0186a0289c14892268d271f2
Reviewed-on: https://chromium-review.googlesource.com/794015Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520757}
      bf360a39
  3. 30 Nov, 2017 36 commits