- 07 Jun, 2019 40 commits
-
-
Yi Su authored
This CL adds template args for CRWWKScriptMessageRouter._handlers to make it more readable. Bug: 956511 Change-Id: Iba9dfc5fb0068bb1e2966de5c40b667b1e53145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649494Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#667225}
-
Kyle Horimoto authored
Before this CL the UI looked like this: When you connect your devices you agree that your Chromebook can: * Install apps on your Chromebook * ... This sounds a bit awkward, since "your Chromebook" is repeated twice. This CL changes the first bullet point to "Automatically install apps" instead. Bug: 950691 Change-Id: Ibbe2a203f7a2a921541c09eabe393c7b0ad1f615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650121 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#667224}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe18de506097..ac53c42b09f3 git log fe18de506097..ac53c42b09f3 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@ac53c42b09f3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ia9cd9d8d92054d8da165e6c6ae35b3ec49d146d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667223}
-
Adam Raine authored
In the input data structure passed to PaintWorkletProxyClient::Paint I added a structure to take the CSSStyleValueVector structure parsed_input_arguments_ from CSSPaintValue. The CSSStyleValues needed to be converted into a vector of CrossThreadStyleValue which is converted back to a CSSStyleValueVector. Bug: 946519 Change-Id: I0fd02b88e5f105afc5c3269088bd82c6f72b0eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645894 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#667222}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 8 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::QueryMostVisitedURLs thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change QueryMostVisitedURLsCallback callback to be invoked with MostVisitedURLList passed by value instead as a const pointer thus allowing to remove an helper function - change QueryMostVisitedURLsCallback to a base::OnceCallback<...> - change HistoryBackend::QueryMostVisitedURLs to return the result by value instead of via an out parameter Bug: 812523, 714018 Change-Id: Ia020a8d780945c84b5ce674c239aff4da915925a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634872Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#667221}
-
Jenny Zhang authored
Bug: 963448 Change-Id: Ied98c28e35bca8bdd03f8ee2c328eb566590d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648741Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#667220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b407e1a0b5bf..ed65dc4302f8 git log b407e1a0b5bf..ed65dc4302f8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 syoussefi@chromium.org Vulkan: implement glSampleCoverage Created with: gclient setdep -r src/third_party/angle@ed65dc4302f8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Change-Id: I2975f133b4d60557024a4eda1eb40052326c252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649665Reviewed-by:
-
shrekshao authored
By comparing OpenGL ES 3.0, 3.1, and 3.2 spec side by side, we could safely assert that floating-point is core in and only in GL ES 3.2. Thus we should advertise EXT_float_blend enable float 32 blending on GL ES 3.2 backend regardless of whether it is listed. * ES 3.0, section 4.1.7: Blending applies only if the color buffer has a fixed-point format. If the color buffer has an integer format, proceed to the next operation. * ES 3.1, section 15.1.5: Blending applies only if the color buffer has a fixed-point ~~or floating-point~~ (it’s striked through in the original source), format. If the color buffer has an integer format, proceed to the next operation. * ES 3.2, section 15.1.5: Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation Bug: 964208, 970532 Change-Id: I7b7ec375f6b0ac34276d6cfec92c4956d7c1f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649055 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#667218}
-
Kai Ninomiya authored
Deduplicating this string lifetime logic should make it much less error prone. Bug: 971819 Change-Id: I55361dc44aebb665ddace76a6602a71e0a7fc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648713Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#667217}
-
Oystein Eftevaag authored
First step towards migrating the profiler to Perfetto. R=ssid@chromium.org Bug: 967008 Change-Id: If714e13b2796728766b4f010593a223dd1f24c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629177Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#667216}
-
Erik Chen authored
This allows the macOS toolchain to avoid using xcrun to find the path for strip. Bug: 971452 Change-Id: I7d7b87462ee33201b57a75bfa58e5fbf8ddaee5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649187Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667215}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=afakhry@chromium.org Change-Id: I089353dab84610c892f13338e3de419caddf0b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649508 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667214}
-
Etienne Pierre-doray authored
Change-Id: I87b3d1d7d5493115d8f305c4707ba0b1924c1132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648035 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#667213}
-
Sidney San Martín authored
In r661714, I changed -[RenderWidgetHostViewCocoa selectedRange] to account for the selection offset. But, it turns out that's already accounted for; I mis-interpreted some other behavior. This change effectively reverts that one (7b4466da) but keeps the new test case. Bug: 42434 Change-Id: I4c738abd5207d447260c98d6293a560f9694d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649143 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Erik Chen authored
Bug: 971452 Change-Id: If3c2939e0b4cc7c1f9b4b9b880e2a9288ba40fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649148Reviewed-by:
-
Erik Chen authored
Bug: 965663 Change-Id: Ib69070af18655d0cd94bc21a9f82c359d0db33e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649065Reviewed-by:
-
Alex Cooper authored
If a user suspends an OpenVR immersive session whether by dropping to a home environment (like the WMR home), or by pressing the "system" button on the controller to show the OpenVR/Vive menu, and then re-enters the session, the controllers would no longer be visualized. This appears to be occuring because while the controller stayed connected, the OpenVRRenderLoop was not able to query it's state, and therefore stopped reporting input information on the controller. When the controller re-connected, the RenderLoop would resume sending data about the controller back up, but did not send a new description because it thought it had been connected all along. In XRSession, when a new XRInputSource was created, it defaulted to being created as a "Gaze" source with no handedness. With no override from the description, it stayed that way; clicks would work on the gaze target, but no controllers/pointers would be rendered. The fix here is to simply mark the controller as inactive if it does not have state, thus ensuring that a new description is sent up when the controller is again tracked/has state. While updating this change, it was discovered that the tests report all devices as connected, and so connecting/disconnecting a controller on the test side would not prompt the device to be registered in product code as newly connected (where it's device type is updated), so it was always ignored if it was ever disconnected. This change modifies the WaitGetPoses method (where GetInputSources gets it's data), to properly report the connected state of controllers. Bug: 934355 Change-Id: Ia61c7568916cc9446366e085e74b55c413c5f6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648654Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#667209}
-
chrome://signin-internalsAlex Ilin authored
My previous CL https://crrev.com/c/1648164 used base::TimeFormatWithPattern() to get a date string in a fixed format. However, base::TimeFormatWithPattern() freely modifies the pattern to make it correspond to the system date format. This CL uses base::TimeToISO8601() for date formatting instead of base::TimeFormatWithPattern(). Bug: 852037 Change-Id: Id63cd5582d5a3259251c5f9d292378511545b662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649173 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#667208}
-
Wez authored
Bug: 971927 Change-Id: I7c3f8c3340bec731fae7cadb9e8a03cc9c2dc0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649029 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#667207}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Ief71174e37070489b6a9c89b28a6950334bd0dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649539 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3ff3ecc72ae4..1faba755ff77 git log 3ff3ecc72ae4..1faba755ff77 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 tsepez@chromium.org Prevent CPDF_Type3Font from knowing that CPDF_Type3Char has a form. Created with: gclient setdep -r src/third_party/pdfium@1faba755ff77 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I16c4eb040107582e4471cbebdd8c5612307b25c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649383Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Updates in Tab-to-Grid transition animation: - Do not show the selected blue border in the grid when the tab resizes - Fade in the selected blue border along with the GTS final fading-in Bug: 971522 Change-Id: If788855ce4659226900759517cf7f8e9ab536e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648835 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/311b8025e35c..af0e045c2ee1 git log 311b8025e35c..af0e045c2ee1 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 saklein@chromium.org BinhostService: Refactor PrepareBinhostUploads and RegenBuildCache Created with: gclient setdep -r src/third_party/chromite@af0e045c2ee1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I880543ee4b810d7b5d231d763d229281e4f52c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649060Reviewed-by:
-
Mythri A authored
Bug: chromium:958441 Change-Id: I89a2d24a57d72c53844b39ed4eabe3198f394bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646791 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#667202}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=chili@chromium.org Change-Id: Id6421b96347e3bfac890f039bcda4aa8329f27b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649578 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#667201}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //ui. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 970209 Change-Id: Ia41e90dc60687f1adb07f0552141e31a4dee83c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648189 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667200}
-
Lindsay Pasricha authored
CIPD packages: infra_internal/ios/xcode/mac 10e1001 infra_internal/ios/xcode/ios 10e1001 Bug: 971671 Change-Id: I64b42e4990a6b8a3a0ee45527a8a3e0deba7c2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646666Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#667199}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=khorimoto@chromium.org Change-Id: I409da52d966a61ce1fe734a06293a4607487687a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649675 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667198}
-
chrome://policyTien Mai authored
A new key "chromeMetadata" will be added to the JSON exported by the chrome://policy page. This new key will contain the following information: "chromeMetadata": { "OS": "Windows 10 OS Version 1709 (Build 16299.1146)", "application": "Google Chrome", "revision": "3e139c3d-refs/heads/master@{#665955}", "version": "77.0.3815.0 (Developer Build) (64-bit)" } Bug: 963506 Change-Id: I0b5fa3ef1904508285a94acbff45dde3fc232aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642817Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#667197}
-
Xianzhu Wang authored
Bug: 969383 Change-Id: Ib29aebde466289ff80b3c693ee90b690ab627ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625869Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667196}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/073b8ac2ff8e..4c5c8ab626d5 git log 073b8ac2ff8e..4c5c8ab626d5 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 ehmaldonado@chromium.org Reland "Reland "gclient: Require a target ref when applying patches."" Created with: gclient setdep -r src/third_party/depot_tools@4c5c8ab626d5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: I2cf625fbce81d11c18eb2fc66ed20bd6e2916a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649063Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=yucliu@chromium.org Change-Id: Idbad32ad54c52846e28dbd56841e4c97b8c44fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649170 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667194}
-
Wei-Yin Chen (陳威尹) authored
Updates in both Tab-to-Grid and Grid-to-Tab transition animations: - Stops showing the tab decoration when the tab resizes - Fade in/fade out the GTS in the background when the tab resizes - Update interpolator for tab resizing Updates in Tab-to-Grid transition animation: - Duration of GTS final fading-in: 218ms -> 50ms - Delay the fading-in of Tab Switcher top toolbar to the second half of the animation Bug: 971522 Change-Id: Ifc34437cb6691b18f0e4c63439b464b637927310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646741 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Erik Chen authored
RecordMemoryStats(RECORD_MEMORY_STATS_TAB_DISCARDED) is only called in one location, and the author indicated that it is unnecessary. Change-Id: I8ecd64337cacbf279e148dd80a4dbbcac872d187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639040Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667192}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=piman@chromium.org Change-Id: Ida93c455e32bf058063b6bf48800b289c972823b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649326 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#667191}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=penghuang@chromium.org Bug: 616447 Change-Id: I42fb5b8d372a39dfe0493d49e09caeea571bd59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637458 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#667190}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=braveyao@chromium.org Change-Id: I574c959c6ab245e188386d0cbad5d8b3c2b4c789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649512 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#667189}
-
Robert Ogden authored
Removes: * feature * previews type * assoc params * triggering logic PreviewsState bit will come in the next CL. Bug: 944286 Change-Id: I65410f30d1efa574a391d61723fd6788b2d2d66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642018 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#667188}
-
Etienne Pierre-doray authored
Change-Id: I4f5b8ba6150924d7ae7a33c4aed9b8ee764b442c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647891Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667187}
-
Josh Nohle authored
Children of the base CryptAuthDeviceSyncer class will implement the CryptAuth v2 DeviceSync flow, which includes uploading local device metadata, receiving remote device metadata, receiving device feature statuses--supported/unsupported and enabled/disabled--for multidevice (BetterTogether) features, and sharing the group private key with remote devices. The metadata and group private key exchanges are end-to-end encrypted. The analogous class for v2 Enrollment is CryptAuthV2Enroller. See design at https://go/cros-devicesync-v2-syncer. Bug: 951969 Change-Id: Ie069759d72f096ce97ef081a43b7f118ed9ea574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648837 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
