- 22 Oct, 2018 40 commits
-
-
Jacob Dufault authored
Also improve accessibility labels when hovering over the fingerprint label, i.e., the label visually displays "Too many attempts" but ChromeVox will read "Too many fingerprint attempts". Bug: 881579 Change-Id: I37cb944e1cfe5703a92e6a63463e7ecea1d8a53c Reviewed-on: https://chromium-review.googlesource.com/c/1289442 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601698}
-
Victor Costan authored
Change-Id: I7eba57be3c04b8c8d7963e2043bc3992e7193484 Reviewed-on: https://chromium-review.googlesource.com/c/1293031Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601697}
-
Elly Fong-Jones authored
This change: 1) Has MenuController reset the closure animation once ::Cancel runs, since it is legal for the MenuController to remain alive after ::Cancel (in fact this is how submenus work); 2) Has the menu closure animation in ::RepostEventAndCancel() target the active submenu instead of the root submenu when closing the outermost menu. into invisibility but in fact only the outermost one is really dismissed, leaving the other menu windows with invisible mouse capture. Bug: 893085,897045 Change-Id: I839710cc525856b14bd3995707ab253cb3258f5f Reviewed-on: https://chromium-review.googlesource.com/c/1293792Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601696}
-
liberato@chromium.org authored
Change-Id: Iea3633c88104b251078facf0047b30e95b81a7be Bug: 897786 Reviewed-on: https://chromium-review.googlesource.com/c/1294290Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#601695}
-
Peter Wen authored
Bug: None Change-Id: Ifc1def99f63ce16a7cac6eb4b595342d22550dfb Reviewed-on: https://chromium-review.googlesource.com/c/1294472Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601694}
-
Tom Anderson authored
In the stack trace for bug 880073 indicates SelectFileDialogImplGTK is being used after it is destroyed. This can happen when the SelectFileDialog::Listener deletes the select dialog in the callback from SelectFileDialogImplGTK::FileSelected. While I'm unable to reproduce the crash, this CL is a speculative fix for the above scenario. BUG=880073 R=sky Change-Id: I649e41bea44e2b4fddb17abe6608cb0828fff0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1292408Reviewed-by:
-
Wei Li authored
UI DevTools track aura's WindowTreeHost initialization to track all the windows created as root windows. However, we didn't track their deletion for proper cleanup. So it is possible that when we use those root windows to create children and trees, some of them were already released which caused crashes. This CL adds tracking of windows being destroyed, so that we can properly remove the window from our list. BUG=896470 Change-Id: I5411001c4c30fea6703d76ae6be8bed61259fce7 Reviewed-on: https://chromium-review.googlesource.com/c/1289706Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601692}
-
James Darpinian authored
In http://crrev.com/c/1279354, I didn't consider that the bound read framebuffer can be NULL when reading from the default framebuffer. Bug: 897402, 890002 Change-Id: Id033ee7108d6bdceb9646e3e36595bfe667625a1 Reviewed-on: https://chromium-review.googlesource.com/c/1294401Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#601691}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iee07ebf7dc5564295c94035a752601df75d7f13f Reviewed-on: https://chromium-review.googlesource.com/c/1294223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601690}
-
Nico Weber authored
Bug: none Change-Id: Icbcc1d240a410b1a2cfd7fa6519cac269346c8ce Reviewed-on: https://chromium-review.googlesource.com/c/1293553Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601689}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/20bbfb6f4da6..0ba35798c393 git log 20bbfb6f4da6..0ba35798c393 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 stevenperron@google.com Fix dead branch elim infinite loop. (#1997) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0ba35798c393 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I55f4576bdbc89b4ba465b153847d2cb99e30129b Reviewed-on: https://chromium-review.googlesource.com/c/1294218Reviewed-by:
-
Matt Mueller authored
This is a reland of e211b725, with fix for NetworkContextTest.CertReporting (restored original behavior of the test using a testserver to listen for the pkp report). Original change's description: > Remove HTTP-Based Public Key Pinning header parsing and persistence code. > > And related code that uses it. > > Cronet depends on the base dynamic PKP support, so is not removed here. > > Based on https://crrev.com/c/1005960 by palmer & nharper. > > Bug: 779166 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I44044a3960174fcba1f1e120b18cbef3ff769812 > Reviewed-on: https://chromium-review.googlesource.com/c/1260483 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598657} TBR=jam@chromium.org Bug: 779166 Change-Id: I2e3b4dbab9cbbc95606c1cf7051b112fc5ba8cc4 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1277963 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601687}
-
Ethan Xu authored
This CL updates the ShellAPK (but not Chrome) to support POST share targets. In particular, this CL: - Adds needed <meta-data> tags to AndroidManifest.xml - Updates how the start URL is computed for share intents - Sends activity class name of selected share target to Chrome in launch intent. Chrome needs this to know which share target activity to read the <meta-data> from. BUG=885314 Change-Id: Ie8732a8477d722ebdb81595c602b289fab0c7a27 Reviewed-on: https://chromium-review.googlesource.com/c/1281691 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601686}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f38cb6d39af1..5a2069501490 git log f38cb6d39af1..5a2069501490 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 jmadill@chromium.org GL: Move draw functions from Renderer to Context. Created with: gclient setdep -r src/third_party/angle@5a2069501490 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I725cc01fc745617b2f29fe11c4f92e2ef0abccd3 Reviewed-on: https://chromium-review.googlesource.com/c/1294221Reviewed-by:
-
Fady Samuel authored
This is dead code. This CL deletes it. Bug: none Change-Id: I4618a80319afceb4b373f3f3932873ca44852cc2 Reviewed-on: https://chromium-review.googlesource.com/c/1294403Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601684}
-
Yi Gu authored
Mark the following tests timeout: * accessibility/element-role-mapping-normal.html * accessibility/table-header-column-row.html An owner has been assigned in the bug. TBR=bsep@chromium.org NOTRY=true Bug: 897849 Change-Id: I62b628293c6652d27cd99865dfadff598b09b1e0 Reviewed-on: https://chromium-review.googlesource.com/c/1294590Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601683}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/67b011d22c1b..68b2df7cf1e2 git log 67b011d22c1b..68b2df7cf1e2 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 yinwa@webrtc.org Make protection_overhead_rate configurable through field trial. 2018-10-22 philipel@webrtc.org Don't decode frames with an older timestamp than the last decoded timestamp. 2018-10-22 alessiob@webrtc.org Revert "Remove deprecated barcode scanning functionality" Created with: gclient setdep -r src/third_party/webrtc@68b2df7cf1e2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ef73e53f0982d4916cb3cda311895f20b4c7cdc Reviewed-on: https://chromium-review.googlesource.com/c/1294216Reviewed-by:
-
Robert Ogden authored
Bug: 768597 Change-Id: I158e1d708a58736277faff7fe73fee4001b018be Reviewed-on: https://chromium-review.googlesource.com/c/1294405Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#601681}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ea46bbbe607b..d28f8451a549 git log ea46bbbe607b..d28f8451a549 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 fmayer@google.com Merge "profiling: Explain sampling interval in README." 2018-10-22 primiano@google.com Merge "Fix docs links" 2018-10-22 hjd@google.com Merge "perfetto-ui: Add preset configuration" Created with: gclient setdep -r src/third_party/perfetto@d28f8451a549 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id95fb8b47d82162d7add9e26cc137ff7514dc5ca Reviewed-on: https://chromium-review.googlesource.com/c/1294209Reviewed-by:
-
Xiaohan Wang authored
Also fix mime types used in pipeline_integration_test.cc which should be 10-bit. Bug: 884898 Test: Add more tests. Change-Id: I16c5f4fd22c219a88a94c4d8727f5d1a676c3e10 Reviewed-on: https://chromium-review.googlesource.com/c/1290519Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601679}
-
Scott Violet authored
It's flaky on ChromeOS as well. BUG=877109 TEST=test only change TBR=aee@chromium.org Change-Id: Ibd12f914131ddeef465ab5c1b802c2cc0cb94aba Reviewed-on: https://chromium-review.googlesource.com/c/1294089Reviewed-by:
-
Darwin Huang authored
Bug: 896479 Change-Id: Iff647d3091677341f027d275884538583a56e965 Reviewed-on: https://chromium-review.googlesource.com/c/1287187Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601677}
-
Tobias Sargeant authored
Bug: 897266 Change-Id: Icc0f7b1671031f76e2781ed2e6e217c50f0925e6 Reviewed-on: https://chromium-review.googlesource.com/c/1292469Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601676}
-
Tarun Bansal authored
Use Network Quality Tracker (NQT) in network metrics provider instead of the network quality estimator (NQE). NQT works when network servicification is enabled or disabled. NQE works only when network servicification is disabled. Note that NQT is to be used on UI thread, while NQE was on IO thread, which makes the code a bit simpler. Bug: 882482 Change-Id: Ic5d9c3080ce74992efe1ddaa069fbbb04a255fe4 Reviewed-on: https://chromium-review.googlesource.com/c/1286969 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601675}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7f9ec980c66..d19984aa7d87 Created with: gclient setdep -r src-internal@d19984aa7d87 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I04c615f7f9656ef8d0bd88390fce4e88c8e15aae Reviewed-on: https://chromium-review.googlesource.com/c/1294217Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601674}
-
Andrew Luo authored
Bug: 895052 Change-Id: Ief6e441c3b9f00436cb7a52dee15d6dc2db29e17 Reviewed-on: https://chromium-review.googlesource.com/c/1279431 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601673}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/294861ff957a..a089bb07b4a8 git log 294861ff957a..a089bb07b4a8 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 mtklein@google.com focus is_3x3() in SkColorSpace.cpp 2018-10-22 bsalomon@google.com Reland "Reland "Revert "Use OpenGL sampler objects when available.""" 2018-10-22 jvanverth@google.com Check correct number of planes in queryYUVA8 2018-10-22 borenet@google.com [infra] Increase maximum attempts for build, test, perf, calmbench tasks 2018-10-22 halcanary@google.com SkPDF: fix typo s/ProcSets/ProcSet/ 2018-10-22 mtklein@google.com move SFDot6 inverse table into SkAnalyticEdge 2018-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 17dfe1b679af..8a587714cb9f (2 commits) 2018-10-22 mtklein@google.com cut out the rest of blend modes in flutter 2018-10-22 bsalomon@google.com Revert "Reland "Revert "Use OpenGL sampler objects when available.""" 2018-10-22 mtklein@google.com clean up SK_LEGACY_COMPLEX_XFERMODES 2018-10-22 brianosman@google.com Guarded version of change to lazy image readPixels Created with: gclient setdep -r src/third_party/skia@a089bb07b4a8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897427,chromium:897395 TBR=brianosman@chromium.org Change-Id: I2e3152e5ca3077a874fa8f445ab825ec46dae60e Reviewed-on: https://chromium-review.googlesource.com/c/1293714Reviewed-by:
-
Bret Sepulveda authored
This patch removes unused code: * Deletes TabRendererData.app, which is never set. * Deletes experimental context menu items CommandSelectByDomain and CommandSelectByOpener, which are unused. * Deletes TabStripModel::WebContentsData.group_, which is unused. * Deletes several private methods of TabStripModel, which were unused as a result of the above changes. This patch also does some associated cleanup to comments and names. Change-Id: I2b43c5e549d240c39a73da60e47f583059e9d3c5 Reviewed-on: https://chromium-review.googlesource.com/c/1285512Reviewed-by:
-
Jingkui Wang authored
Capture capabilities and events Bug: 895553 Test: build/run events_unittests Change-Id: I9c09a8646017ad36b0f4c61c39f4ad20121b61aa Reviewed-on: https://chromium-review.googlesource.com/c/1290090Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601670}
-
Shimi Zhang authored
Add basic support for SuggestionSpan.FLAG_AUTO_CORRESION flag, make it show underline for this type. Bug: 869261 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6db973826ebf761902506905d31968ec4b78819a Reviewed-on: https://chromium-review.googlesource.com/c/1285312 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601669}
-
Stephen Martinis authored
My previous CL missed this line. TBR=nednguyen Bug: 896175 Change-Id: I2f37aca90820754caa1b4eb7186b654657d15ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1294206Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#601668}
-
Mike Reed authored
to that skia api Bug: skia:8487 Change-Id: I00bce640b6c34736f0e89988421965ba86464689 Reviewed-on: https://chromium-review.googlesource.com/c/1291816Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#601667}
-
Kevin Marshall authored
Fix Netstack interface churn. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org TBR=mmenke@chromium.org Change-Id: I0981c684165556a55715a55e9225f04ab0685d78 Reviewed-on: https://chromium-review.googlesource.com/c/1294208 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601666}
-
Dianna Hu authored
This API is intended to remove discrepancies with Google3, and to comply with Chromium presubmits that suggest to use base::size() instead of arraysize (https://crbug.com/837308). This change borrows gladly from https://crrev.com/c/1288849, which introduced the analogous API for SPDY. This change also fixes some formatting to appease $ git cl lint. I will backport this change to Google3. Bug: 488484 Change-Id: I51be11a2ee62cc084291a4ebf959460d71f17374 Reviewed-on: https://chromium-review.googlesource.com/c/1292434 Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601665}
-
Yi Gu authored
There are more tests failing on chrome_public_test_vr_apk. Add peconn@ to TBR because a similar patch was reviewed by Peter. See crrev.com/c/1292884 TBR=peconn@chromium.org NOTRY=true Bug: 894796 Change-Id: Icb52936f590ec42ccd382d129628e3497ff8cb38 Reviewed-on: https://chromium-review.googlesource.com/c/1294402Reviewed-by:
-
Geoff Lang authored
The target was validated that it was one of the TextureTarget types but not that the type was valid for the current context. This generated GL errors when querying the size of a 3D texture in an ES2 context. BUG=897453 BUG=892288 Change-Id: Ia6cafaf021751876148acdaf0ee96dc51353e98a Reviewed-on: https://chromium-review.googlesource.com/c/1293754Reviewed-by:
-
John Z Wu authored
Since there many be multiple objects interested in data changes, it's more natural to use an observer pattern instead. Change-Id: Ib7e291626bf3f3dce23a73ebc329f96bc8f9deb9 Reviewed-on: https://chromium-review.googlesource.com/c/1293990 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#601662}
-
Roger Tawa authored
Improve handling of google account to username mapping, taking into account that the email address of a google account can change. Bug: 894604, 885278 Change-Id: If0013e717819f3edaad0c2e485af9c124b11c787 Reviewed-on: https://chromium-review.googlesource.com/c/1284695 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601661}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/1293791, Deterministic Linux should stay green with -pie, and it makes that bot more like its dbg variant (.sos already use position-independent code and ASLR) and like the Windows deterministic bot. Bug: 870584 Change-Id: I730437f3d1160016d3cdf78921990cf2d4b9a40a Reviewed-on: https://chromium-review.googlesource.com/c/1294289Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601660}
-
David Tseng authored
This was re-introduced by https://chromium-review.googlesource.com/c/1208450 was previously fixed by https://chromium-review.googlesource.com/1243283 Originally regressed/caused in https://chromium-review.googlesource.com/1100553 TBR=nektar,dmazzoni Change-Id: I1d698f2c102d6fe8b2cb1c5234ebca0d69455dc9 Reviewed-on: https://chromium-review.googlesource.com/c/1294291Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601659}
-
