- 08 Jan, 2021 40 commits
-
-
Marc Treib authored
Bug: 1121258 Change-Id: Iafa37aa2e99ced4bedd4e220df0769c02b973874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595742 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#841448}
-
Andreea Costinas authored
MGS and Kiosk are pre-configured browsing sessions that aren’t tied to a user. This CL enables reusing the proxy credentials set via device policy SystemProxySettings to authenticate MGS/Kiosk devices to a remote proxy. go/system-proxy-share-policy-credentials Bug: 1132840 Tests: unittests, browsertests Change-Id: I197ec95bfd7da138aff5dd02caf2fe0921ed9df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596344Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#841447}
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: I0d19f0dad84f128c554ace6942d4ec4e5e96e34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611740 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#841446}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/589e3dd96b0c..d0433378a468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fhorschig@google.com Change-Id: I52f11fcf0e0da446f831ce1650920c40087463aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841445}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610074312-912225aaa44122e4b1a4b8a45da36dc4daa402b9.profdata to chrome-win32-master-1610085457-9d25c44b81df119265a48970c3964c59f218f094.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic38a49518b27fe9c177462f0b4828c31d431d6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841444}
-
Delan Azabani authored
This implements the style support only, behind a flag, based on the ::target-text counterpart in <https://crrev.com/c/2463563>. The paint code for querying these selectors and paint invalidation, as well as the changes needed to limit the acceptable properties (à la <https://crrev.com/c/2489657>), will be written in another CL. Bug: 1035708 Change-Id: I77e530fbbb78fb20c05325ef75babde91e5ef831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606878 Auto-Submit: Delan Azabani <dazabani@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/master@{#841443}
-
Greg Thompson authored
It tells us that failures are due to I/O errors, access denied errors, and other things we can't do anything about (likely odd drivers, too). R=chromium-metrics-reviews@google.com, gab@chromium.org Bug: 1156213 Change-Id: If4fb97d44d8b9a59db48239c68e69a56f59cd462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609143 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#841442}
-
Maya Lekova authored
The feature is enabled by default, as is the current state of the flag in V8. This CL is not intended to change the default behavior, but to allow us to quickly turn the feature off in case of any performance regressions. Bug: v8:10765, chromium:1157044 Change-Id: Ib46d487ba094f08c27354c53f8b98e220fec627b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596264 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841441}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4681cecb4151..1607b3aa8ccd 2021-01-08 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-08T04:02:26). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1538678ee6d16803fd26f736adb9b612193dd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616924Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies base::string16 to be an alias for std::u16string on non-Windows platforms. This allows the removal of a custom std::char_traits specialization for uint16_t, and now also allows the creation of base::string16s from char literals on all platforms, removing most of the need for helpers like base::ASCIIToUTF16. Lastly, this change also updates blink::WebUChar, ensuring it continues to be the exact same type as base::char16. Bug: 911896 Change-Id: Ifef35543e10cfee2b25f11984be289553532626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#841439}
-
Nohemi Fernandez authored
In order to unify the Identity communication across Chrome platforms we expose the user's given name as an Identity property. Bug: 1148764 Change-Id: I96eb98e1ab6ce5f5f2fe5a01cb68b3e9744e63ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615158 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#841438}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/ui/webui/settings/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I423bf0ec29479c7942c4e4c5558f9e6ba68b3ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611267Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841437}
-
Heng-Ruey Hsu authored
This is a reland of 3fc522ff. Original change's description: > Refactor delegate to support multiple clients and manipulate buffers > from corresponding clients according to the stream type. > > Bug: b:151047537 > Test: Manually test > Change-Id: I511be4f20f495a973141a7199f4b4c3c50871f5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351932 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835102} TBR=wtlee@chromium.org Bug: b:151047537 Test: Manually test, test pass on krane. Change-Id: I3ed17b631fa8f0bea63c4ad616c64ca2ee8ca77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612313Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841436}
-
Colin Blundell authored
This CL prepares for the upcoming usage of Gaia-keyed URL lookups in Weblayer by turning SafeBrowsingTokenFetcher into an interface and its implementation into a SafeBrowsingPrimaryAccountTokenFetcher subclass. This layer of abstraction is needed as WebLayer will not fetch access tokens via IdentityManager as the current implementation does. A followup CL will abstract the remaining dependences on //components/signin from safe_browsing_token_fetcher.h. Bug: 1080748 Change-Id: Ib9c0cb63a3e1364611c21a3cc069bab7bdba0e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613968 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841435}
-
Taylor Brandstetter authored
This branch now contains three cherry picked commits: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..a3c3ef666b7a Bug: chromium:1163228 Change-Id: Icd506393d323f0fa1dbeb12546a224d09c4a77be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617212Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841434}
-
David Jean authored
Also includes two #ifdef-out of deprecated code unrelated to orientation. Bug: 1131852 Change-Id: Ia229a421d0b9f9e9d655791d43b0cb59c0b0e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612898 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#841433}
-
Manuel Rego Casasnovas authored
The :focus-visible tests were modified recently, but that introduced some leaks that were detected by "WebKit Linux Leak" bot. The tests that were failing are using test_driver.click(). This patch modifies the tests, so they pass without issues when passing --enable-leak-detection to tools/run_web_tests.py in a release build. Bug: 1163172 Change-Id: I9b8b1d0459bf7598fc3330495f3cc3ea95d36dae Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,leak_detection_linux Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617818Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841432}
-
Wei Lee authored
There are some use cases which are not guarded by the lock, which might cause race condition since |camera_info_| might be accessed from different threads. In addition, when VendorTagOpsDelegate is reset, we should have a way to let caller know that the initialization state is reset so that we won't wait forever. Bug: b/174126439 Test: Build successfully Change-Id: I270c0989f04896b1fc3df28aa2243dce799b93ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602964Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841431}
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: Iecb78851b28f90934fb0127b8210ceac5f886457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611097Reviewed-by:
-
Friedrich Horschig authored
The test seems to leak objects only occasionally, e.g. (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,8], "numberOfLiveDocuments":[1,4], "numberOfLiveNodes":[4,2204], "numberOfLiveResourceFetchers":[1,4]}), text diff) NOTRY=true TBR=petermarshall@chromium.org Bug: 1046784 Change-Id: Iba2c7b27242a330ad1307ab6a2ea9c1fcec343e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617839Reviewed-by:Peter Marshall <petermarshall@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841429}
-
Boris Sazonov authored
Changes AccountManagerAsh to use ReceiverSet instead of a single Receiver. This allows having multiple clients talking to the same AccountManagerAsh instance and also prepares the upcoming unification of AccountManagerFacade implementations. AccountManagerAsh ownership will be revised in subsequent CLs. Bug: 1161699, 1148448 Change-Id: Ida66bce494df802bf5ce4fd99f78d081a9540b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614788Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841428}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iaa235f3695bf7ff8303127bda64765ab3da7d7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617621Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841427}
-
Ewann authored
This CL uses a UILabel to display the site URL instead of an NSString, to control auto-resizing. Bug: 1104198 Change-Id: I9c0d508ed209d6bd598584b6ed74a8ecca4b0510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603749 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841426}
-
Alice Wang authored
This CL simplifies the calling logic of child account status fetching by removing the unnecessary abstraction layers and add unit tests for child account status check. This is a pure refactoring and there is no behavior change. Bug: 1161702 Change-Id: I14bed1f58a433b8b788c73104b4aa4a4729c65b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602419 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841425}
-
Anastasiia N authored
Add `ShowAddAccountDialog` and `ShowReauthAccountDialog` methods to `AccountManagerFacade`. Bug: 1140469 Change-Id: I0d3d1d25b30d872412972fba039379f349fe59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550669 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
jchen10 authored
This uses GpuMemoryBufferVideoFramePool to import software video frames. Bug: 1142754 Change-Id: Ic1a7849ca7a833ecf255892ba962ce2207b57546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603036Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#841423}
-
Alexander Timin authored
This is a reland of 20ec4591 Original change's description: > Reland "[tracing] Align --trace-startup and --enable-tracing." > > This is a reland of 0823dbae > > Original change's description: > > [tracing] Align --trace-startup and --enable-tracing. > > > > Use StartupTracingController both for --trace-startup (primary use case: > > browser startup perf profiling) and --enable-tracing (primary use case: > > browser test tracing). > > > > Due to historical reasons both flags are kept, but now their behaviour > > is mostly the same. If both are present, --trace-startup takes > > precedence. > > > > Differences: > > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > > continues until the browser is closed. (--trace-startup-duration overrides > > both). > > - `trace-startup-file` always treats the path as absolute, while if > > `enable-tracing-output` ends with /, it uses the provided value as the > > directory and generates the base name based on the current runtime > > metadata. > > > > R=skyostil@chromium.org,eseckler@chromium.org > > BUG=1157954 > > > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839992} > > TBR=skyostil@chromium.org,eseckler@chromium.org,nasko@chromium.org > > Bug: 1157954 > Change-Id: Ic16992026beebddea39c8a6b247b4301512057e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609139 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840015} TBR=eseckler@chromium.org,skyostil@chromium.org Bug: 1157954 Change-Id: Iab58e0a581f9744138c962d4574ec8fa6d6097ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615539 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#841422}
-
Nasko Oskov authored
This CL updates the documentation for WebUI to reflect recent changes that make it safe to use <iframe> to embed web content in a WebUI page. Bug: 1002276 Change-Id: I1d61d99dd6f71b868f3ae05d3e37c801c6095d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613888 Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841421}
-
Gauthier Ambard authored
This CL adds a test to navigate back/forward to an error page and check that the page correctly reloads. Bug: none Change-Id: I758c2cb5734fbbca9eb075e86e4ab3d44834ecdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615159Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80399af7a213..51690fcadbed 2021-01-08 bmeurer@chromium.org Roll js_protocol.pdl ('wasm' type and 'executeWasmEvaluator' removal). 2021-01-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159402,chromium:1162062 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id9ab18a028b1b81a43dbee70347e48ce7dc02cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617653Reviewed-by:
-
Friedrich Horschig authored
The test passes in ~2 out of 10 runs. Therefore, disabling it for now. NOTRY=true TBR=masonfreed@chromium.org Bug: 1164166 Change-Id: I152bb598f20c8ff63cb36fcb9f4729bff8043dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617700Reviewed-by:
-
Omar Morsi authored
Before this CL, a VPN device state was always being returned from CrosNetworkConfig::GetDeviceStateList even if no VPN services exist. The main reason behind that was to use this state to propagate the VPN disablement state to the UI code. This CL changes this behavior such that a VPN device state is returned if a VPN service exists or the VPN is prohibited by policy. Bug: 1156816 Change-Id: Ie5c894183d205a92a0bedb890bfcd69daeff3e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615038Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#841417}
-
Jun Kokatsu authored
This change clean up unnecessary test cases in the NoTrustedTypesViolation test. Also added few things that makes debugging of the test failure more easier. Bug: 1115643 Change-Id: Ib8ad416fa3af48ab3dd7eb01785e1ffcd34bb50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612397Reviewed-by:
-
Michael Lippautz authored
- Fix cppgc traits for TraceWrapperV8Reference - Fix ThreadState compilation - Fix String resolution Bug: 1056170 Change-Id: I95f6ce324b632465e936a0b6d00aab082e28507c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616199Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841415}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610063718-75764fb6f7cc7a2d4d8119e0952784a5ac3fa72a.profdata to chrome-linux-master-1610085553-90a8ab5c2cfb6eb3765af407df5af94b81fb1c7d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c230835a89834537386fcb9840dd89c800f6a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617648Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit e05911e4. Reason for revert: https://crbug.com1164259 WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > webhid: Mark the API stable > > Updates runtime_enabled_features.json5 and the stable webexposed tests > to mark the WebHID API stable on desktop platforms. > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/rL1csFYD1Ms > > Bug: 890096 > Change-Id: I36a6b62475dd9de01a4dbf013b2be00e8901359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610995 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841185} TBR=chrishtr@chromium.org,mattreynolds@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I16463f8d4b8e9e4893217f5349d2a8a9f7aa76f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616200Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7ce1cd243f2..cb3bcf88e382 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ebb8289a to f936dc21 (446 revisions) 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from fac169113df7 to 00fcab636a05 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I7a0f1725759bcac61e44c9d9ad291282ca9e0794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617309Reviewed-by:
-
Nazerke authored
The crash report shows that the crash of |addConstraintsToTabStrip| is on the iphones only. This CL removes the adding the constraints to the tabstrip from the viewDidLoad, as currently it's crashing on it while it's trying to add the constraints to the tabstripview which is nil on the iphones. Now it is moved to the point when the tabstripview is added, which does not let it run on the iphones as it's not needed and causes crashes. Bug: 1152059, 1128249 Change-Id: Ic161b0d687b828ec57889c455d171c4f6a5fcf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611977Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48240126b9fe..589e3dd96b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Id21e75bdc6dd85b316c84554c85e272b37776c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617311Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/176266123 Test: Manually toggle different grid line type from toggle button and grid settings. Change-Id: I59dfb3b46415ad0b1a6206ecf4a31344479f0ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611152 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
-
