GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7f890a8e..3a72085d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I43d3bfa8e0fb28198b785f058b1959fe2e93c3f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977280Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726662}

Change-Id: I2d8894b19ac6f697059bc8ce1c2f64358a051826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977002Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726661}

This reverts commit f5232c5d.

Reason for revert: Broke linux-chromeos-chrome build.
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/531

Original change's description:
> Create base class for AssistantUiElement views.
> 
> This is part of a multi-CL effort to clean up the AssistantUiElement
> modeling/rendering pipeline. Once complete, UiElementContainerView will
> only know about AssistantUiElementViews, not inheriting subclasses.
> 
> More details in the bug.
> 
> Bug: b:145003512
> Change-Id: I6b9b96af2f7f7e73a19785d58104049f287616df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953700
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726629}

TBR=xiaohuic@chromium.org,dmblack@google.com

Change-Id: I20b002539e39ca441bda91a3e4ffa4169b49dd38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:145003512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977881Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726660}

This reverts commit 7511f14a.

Reason for revert: The previous CL crrev.com/c/1953700 broke linux-chromeos-chrome build.
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/531


Original change's description:
> Remove animator implementations from UiElementContainerView.
> 
> This is part of a multi-CL effort to clean up the Assistant UI element
> modeling/rendering pipeline. This CL simply moves the ElementAnimator
> implementations that were previously in UiElementContaienrView into
> AssistantUiElement. In the future, UiElementContainerView will have no
> concept of AssistantTextElementView or AssistantCardElementView, it
> will only understand AssistantUiElementView.
> 
> More details of the effort in the bug.
> 
> Bug: b:145003512
> Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726636}

TBR=xiaohuic@chromium.org,dmblack@google.com

Change-Id: Ib1e0546a266a5c516bdb646d552dba950b1829ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:145003512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977880Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726659}

Adds thread safety annotations to SharedImageBacking and
SharedImageManager. These should make it much harder to forget to take
locks (or to double-lock) in the future.

Bug: 1003686
Change-Id: Ia50ed5e1bfa599d8d363c275f039f2e57609ba79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977301
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726658}

This CL replaces .mojom.h with .mojom-forward.h in some sub-directories
of chrome/browser to reduce the pre-processed size of header files and
shorter build time. The sub-directories are following,

 - chrome/browser/autofill
 - chrome/browser/background_sync
 - chrome/browser/banners
 - chrome/browser/battery/
 - chrome/browser/bitmap_fetcher
 - chrome/browser/browsing_data

This CL has no behavior changes.

Bug: 1001360
Change-Id: I946d6b412c598116a76a4618f4366919d7c2186d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971292
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726657}

Problem: When a tab navigates away from a page and then back again, if
the page goes into bfcache, JS dialogs no longer appear.

Cause: In SwapOutOldFrame, before deciding whether the page goes into
bfcache we call SuppressFurtherDialogs but if the page is going into
bfcache, this prevents all future dialogs from appearing.

Fix: Replace IsWaitingForUnloadACK with !is_active() on the renderer
side when deciding whether to show a dialog or immediately drop it and
reply to the renderer as if the dialog was dismissed.

After discussion and digging, altimin@ thinks this is safe. We will stop
showing new dialogs as intended.

The concern about nested event loops at the point of entry to bfcache is
not a worry as the dialog nested event loop does nothing except handle
the dialog response IPC, everything else is queued for the outer loop.

Dialogs already stop blocking in JS when the user switches tabs (the
dialog stays on-screen but the JS call to e.g. window.alert() returns.
So no site should be relying on their dialog being dismissed by real user
interaction.

This adds a will_enter_back_forward_cache_callback_for_testing_ callback
to allow more control of the timing of the JS run. The test that uses it
fails if I replace !is_active with IsWaitingForUnloadACK.

Bug: 1030133
Change-Id: I25ab4518399d82187028bbefb22b5722475d0cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955245
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726656}

Replace usages of java_files with sources in above directory's gn files,
and automatically format.

Bug: 1035074
Change-Id: I71ba271c9752c3b3224a84dcb846868de66079b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977302Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726655}

Replace usages of java_files with sources in above directory's gn files,
and automatically format.

Bug: 1035074
Change-Id: I3923e1d2ee851e491ec35cd07186405b979bd0ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977197Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726654}

Replace usages of java_files with sources in above directory's gn files,
and automatically format.

Bug: 1035074
Change-Id: I0599344d6f00b9a2668dc4fc8cb3b8acab50c819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977195Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726653}

Replace usages of java_files with sources in above directory's gn files,
and automatically format.

Bug: 1035074
Change-Id: Iac1b3ad1d3acd47e895cc6b0283a89bbd2f63c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977379Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726652}

Replace usages of java_files with sources in above directory's gn files,
and automatically format.

Bug: 1035074
Change-Id: Ibf2cefba17f5570a5869c2122646b261ae26f296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977303Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726651}

crrev.com/c/1949841 introduces VideoEncoderInfo. The info may be
useful for libwebrtc. The goal is to acquire VideoEncoderInfo of
hw encoders running in GPU process.
This CL is the second step, which enables to pass VideoEncoderInfo
via mojo.

Bug: 1031965
Test: webrtc.DecoderPerf.h264_hw
Test: webrtc.PeerConnection*
Change-Id: I55e985a92637f16e888c88e1682d5ec7178101f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973440Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726650}

This CL is a temporary solution to tabs not animating in when
using the new tab button in the tab strip. This produced 0 bugs
out of 150 tabs.

Bug: 1035678
Change-Id: Id31233ae07356a798a3897f5c7043248819639fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975070
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726649}

PathManager kept paths in absolute paths (to be precise, relative paths
from out/Default).  But in case of code generation, we frequently use
paths relative to project's root ("//" in GN) or generated root
(out/Default/gen), e.g. include paths and include guards.

This CL makes PathManager to keep most paths in relative styles, and
adds an API to convert to absolute paths.


Bug: 839389
Change-Id: I83ebd5b5a63a673e1ca25d821100b99816c08510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973433
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726648}

This reverts commit 8e917b47.

Reason for revert: Causing presubmit failure with messages about the chromium.gpu waterfall configuration.
Example: https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/691375

Original change's description:
> [code coverage] Bot definitions for Windows coverage tryjob
> 
> Add definitions for tester machines for Windows coverage.
> 
> Add buildbot definitions so the tryjob can run tests.
> 
> Bug: 1033753
> Change-Id: I3d933b1beaedd24ad206c9e5d2528ed5e4496b67
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972753
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726609}

TBR=ynovikov@chromium.org,agable@chromium.org,kbr@chromium.org,nodir@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org,sajjadm@chromium.org

Change-Id: Ib343ed787d0324d1eaf796fe2ee9ca2742d1cdc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1033753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976145Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726647}

We by default use the webui installer. In addition, the deprecated
CrostiniInstallerView has been removed. So, this flag is useless now.


Bug: 1026199
Change-Id: I99d45670f39bc032cc017bfe03a4117b294040b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963595
Commit-Queue: Jason Lin <lxj@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726646}

https://skia.googlesource.com/skia.git/+log/6e6b4dd7d3e2..7e2dea568299

git log 6e6b4dd7d3e2..7e2dea568299 --date=short --first-parent --format='%ad %ae %s'
2019-12-19 mtklein@google.com SkColorFilter::onProgram()
2019-12-19 bsalomon@google.com GrGLSLShaderBuilder::appendTextureLookupAndBlend
2019-12-19 fmalita@chromium.org [skottie] Treat unknown effects as warnings

Created with:
  gclient setdep -r src/third_party/skia@7e2dea568299

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: I651c8c88a914d86517f69190758f7d070cf368c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977340Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726645}

libwebrtc can know the information about encoders that are not
contained in the library, by webrtc::EncoderInfo. In the current
chrome implementation, the structure stops in RtcVideoEncoder and
thus the filled information doesn't respect the hw encoders.

This Cl introduces VideoEncoderInfo. It is similar to
webrtc::EncoderInfo. The information is filled in and dealt with
the structure in chrome code.

Bug: 1031965
Test: webrtc.DecoderPerf.h264_hw
Test: webrtc.PeerConnection*
Change-Id: I5305d69be7ff8b7406be6493125f535cd5473ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972742Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726644}

Previously, when a non-NDEF tag comes in proximity, NDEFWriter#push()
does nothing and still keeps in pending state.

This CL switches to reject NDEFWriter#push() in such case so that WebDev
can get a sense of what's happening.

BUG=520391

Change-Id: I17569910466e75f12ff4e37c29180e2a9af9db13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967745
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#726643}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/330a8816909a..21b29fed64d8


Created with:
  gclient setdep -r src-internal@21b29fed64d8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1028270,chromium:866147
Tbr: jbudorick@google.com
Change-Id: I5008b43a7841f43bd9e51c71c1719b871053b545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977679Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726642}

Added browser tests for hit testing, implemented in 1927578.

Bug: 973095
Bug: fuchsia:16642
Change-Id: I1b4b6638b53b2aa604ac98fc0765266090fa4e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929977Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726641}

This CL removes unnecessary .mojom.h includes in chrome/browser/chromeos/app
to reduce the pre-processed size of header files and shorter build time.

This CL has no behavior changes.

Bug: 1001360
Change-Id: I21c9d79b222af1e4ab397d5b0e7ef0c033029242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975373Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726640}

TBR=olivierrobin@chromium.org

Bug: 1036071
Change-Id: I8e6896706e05aa197aa763bba9e7c85d2a01d3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976136
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726639}

This change addresses an old problem where suggestion icons and text were
slightly misaligned.

Change-Id: Ie2b9eb70cbfccf37787bc181fdf6bd23dced20b7
Doc: http://doc/1S80-WgirGxZaV3u4917MF6av7AbQpOIhWwrRxRo-eok
Bug: 986584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977003Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#726638}

If BrowserView::Layout() gets called multiple times while sliding
the top controls is in progress, it could break sliding altogether,
or at least will make its initiation janky.

This CL allows only a single layout to go through once sliding begins.

BUG=1034047, 950981
TEST=Manually, and expanded an existing test.

Change-Id: I7b906fc2956aa455b573083d7cdaa40812141bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968320Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726637}

This is part of a multi-CL effort to clean up the Assistant UI element
modeling/rendering pipeline. This CL simply moves the ElementAnimator
implementations that were previously in UiElementContaienrView into
AssistantUiElement. In the future, UiElementContainerView will have no
concept of AssistantTextElementView or AssistantCardElementView, it
will only understand AssistantUiElementView.

More details of the effort in the bug.

Bug: b:145003512
Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726636}

Adds some JS resources served under chrome://resources/, which are
included by other WebUI pages like chrome://gpu.

Bug: 1017316
Change-Id: Iaa76bc6d561dea2fef63d4145e8224c35ae9b30c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976592Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726635}

EvaluationContext had |bool had_type_conversion_error| field, and we had to copy
the field manually whenever we cloned an EvaluationContext object to propagate
an error to the top-level EvaluationContext.
This CL changes the field to a mutable reference to bool, and it is shared
between cloned EvaluationContext objects.

Change-Id: I5f7e71a25337cfaf413ca98fccc9d3f16a04dba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975472
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726634}

Same-document navigations shouldn't clear content status flags,
because if there was mixed content on the page, it's still there after
a same-document navigation.

In many same-document navigation cases, this fix doesn't matter
because content status flags are copied as part of cloning the
original NavigationEntry to create the new one (see the
NavigationEntry::CloneAndReplace call in
NavigationControllerImpl::RendererDidNavigateToNewPage). However, not
all same-document navigations involve cloning an existing entry, and
in these cases it is important to copy over the previous entry's
content status flags. (See linked bug for an example.)

Bug: 959571
Change-Id: I353995ea153b10736020e24f29eca6f7e7be9ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977395
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726633}

https://chromium.googlesource.com/angle/angle.git/+log/7b55aac3b366..fe2ed33a56dd

git log 7b55aac3b366..fe2ed33a56dd --date=short --first-parent --format='%ad %ae %s'
2019-12-19 syoussefi@chromium.org Translator: Output memory qualifiers in OutputTree
2019-12-19 lehoangq@gmail.com Metal: correctly clamp stencil reference values

Created with:
  gclient setdep -r src/third_party/angle@fe2ed33a56dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: I49ae1998ba6882b04a2d5ece0f1da3b3da6b75c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977320Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726632}

This CL takes care of the crash when preview tab is closed by 'close all
incognito tabs' from Android notification UI. There are 2 problems:

1) |destroy| of BottomSheetContent that preview tab is built with needs
   to invoked only by BottomSheetController when the controller finds
   it not used any more. Removes the redundant (and unnecessary) destruction
   in the preview tab coordinator.
2) An incognito profile instance shared by multiple ProfileDestroyers
   was destroyed twice when it is triggered from
   RenderProcessHostObserver::RenderProcessHostDestroyed. This CL delays
   the actual destruction task all the way to the ProfileDestroyer dtor
   (which ensures the pending destroyer list is updated properly before
   the deletion), and uses DestroyOffTheRecordProfileNow to null out
   the pending object's pointer to the profile to be deleted, which
   helps avoid UAF.

Bug: 1029677
Change-Id: I2710bb5ec2c35973da362c850434f71753175a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971031
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726631}

This CL adds Assistant key to the supported accelerator list used
in AutotestPrivateActivateAcceleratorFunction, so that we can mimic
the key press to open/close the Assistant UI in the integration test
through that API.

Related CL using this API:
https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1975040

Misc: fixes Linter warnings.

Bug: b/145218971
Test: local compile.
Change-Id: Icafcaea356e55319ff7ccf4300a2b6a2ee697d7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977192
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726630}

This is part of a multi-CL effort to clean up the AssistantUiElement
modeling/rendering pipeline. Once complete, UiElementContainerView will
only know about AssistantUiElementViews, not inheriting subclasses.

More details in the bug.

Bug: b:145003512
Change-Id: I6b9b96af2f7f7e73a19785d58104049f287616df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953700
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726629}

Changes the effective clock rate by interpolating samples online; does
not require memory allocation. Intended to replace our AudioResampler.

Test: cast_media_unittests
Change-Id: I6563672f936c0d7e9cdf687f42fb42f1bbec1863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974600
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726628}

This change sets the default value for host model features to be an value
that the prediction model can interpret as unknown (-1 in this case). This
will improve the model accuracy when host model features are unvailable
for the current navigation.

Bug: 1036025
Change-Id: Iff7dab042829a540c06854f9ea7e84e187dbc7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977189Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726627}

Using wpt-import in Chromium a436532f.
With Chromium commits locally applied on WPT:
c15c1083 "Add test that datachannels close when connection does."
9899425d "[css-layout-api] IntrinsicSizes Implementation"
d75fede5 "[EventTiming] Fix crossiframe test"
93b03639 "Roll WebGPU CTS"
01fd8522 "XPath: Fix normalize-space()"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ibedf0d608dbd96588e655809068e60c32d6a2458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976852Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726626}

Bug: 1007788
Change-Id: Ic449af55f727461f70e7d130f0d489f86a731572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974297
Commit-Queue: Anand Mistry <amistry@chromium.org>
Auto-Submit: Anand Mistry <amistry@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726625}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ifcbca772e2434935a7d78b43cbe75f2ff3170dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726624}

ImageEditorCoordinator will be renamed to ImageEditorDialogCoordinator
and will be used to create the editor DialogFragment
(ImageEditorCoordinator is used internally by the DialogFragment).

Bug: 1024586
Change-Id: I29822893395022bdb661f535d87dbac35757b4d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975110Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726623}