- 21 Aug, 2020 19 commits
-
-
Ian Kilpatrick authored
LayoutTheme::ShouldUseFallbackTheme should always be returning false, as LayoutThemeMobile was the only place returning true - presumably for an iOS configuration at some point. Removes all FallbackTheme related methods, and classes. There should be no behaviour change. Change-Id: I1d336016a1823a53a977ad764706d68fd19ff9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363846Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800391}
-
Joe DeBlasio authored
This CL adds an enterprise policy that allows selective allowlisting of domains from lookalike warnings. Bug: 1116279 Change-Id: I4f670ba43f7ce4f9da37798cbaf64a9f41c40724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363861 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#800390}
-
Dana Fried authored
Because we now show the caption bar and caption buttons in Windows in tablet mode in order to provide a dedicated grab handle for moving to/ from split-screen mode (and protect user gestures to open the tabstrip) there is now empty space above the toolbar. Filling this empty space with the window title: - makes us consistent with PWA windows - provides access to the page title without opening the tabstrip Currently, this change only affects Windows and not ChromeOS. Screenshot (Google only): https://photos.google.com/share/AF1QipP8IFSTPydtpfbRM5vXfqQEfVDPVwq1kJDBMtCwes8AqxEqUdjIwsi5i2v1hUpmFg?key=WFkxdDVZR2ktU3c2dWNPU1lCRFRJSk55TGUtTDFR Bug: 1116651 Change-Id: Ib90149c6d46bf740505d1a06be824b85d3e5dee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364958Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#800389}
-
Eric Orth authored
Better reflects the modern purpose of the class since it hasn't actually done any pooling since the "default" pool was disabled years ago in crrev.com/14225015 (and deleted recently in crrev.com/c/2357615). Bug: 1116579 Change-Id: I8822065709e423a50404a178a8ee942cd7d24f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363849 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800388}
-
Varun Khaneja authored
See go/protego-versioned-proto for more details about the motivation. TODOs: 1. Add UMA metrics. Will do that seprately to keep this CL small and the reviewer list short. 3. Add the response_provider field in the proto Bug: 1119928 Change-Id: Ie15d59b7f4e0b4c0fd236d9c665ad82f02ae2cdd Fixed: 1119928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367443Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800387}
-
Daniel Rubery authored
This CL prepares the CertificateReportingServiceFactory for the launch of Safe Browsing per-profile NetworkContexts. Since it does not need cookies, we will be using the profile-wide SharedURLLoaderFactory, and setting the credentials_mode to omit credentials. Bug: 1049833 Change-Id: If479c178501f93523697248bc484e28ab515aa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357465 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#800386}
-
Alfonso Garza authored
Fix issue when deleting from a textfield and an emoji is present, where the last character would get deleted. Also moves card holder name down in the list of items as requested by UX. The main issue, which also has other unintended side effects, is that |reconfigureCellsForItems| is called while the text is being edited. This causes the cell to be redrawn and the cursor to change. By doing this call in TableViewTextEditItemDelegate as opposed to before the text changes we resolve the issue of the last character being deleted instead of the correct one. There is a smaller issue that remains and is not trivial to fix: after deletion the cursor is moved to the end of the text. This also exists in other textfields. Bug: 1114718 Change-Id: Id035e5b3c066801a3e156360f010380104564931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360514 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#800385}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iab5fa05bc49bec9e9d9dc234cb8a78f97dec40f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800384}
-
Shengfa Lin authored
Chrome changed its install path in 85 to C:\Program Files We are only searching for C:\Program Files (x86) This is to check C:\Program Files as well Bug: chromedriver:3577 Change-Id: I5ad423197017b96a801517b0787873dda5a67b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368163Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#800383}
-
sczs authored
Bug: 1085419 Change-Id: Ie4c211b2b725f8ae5b82bb8a7e2c545fbd162d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367737 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#800382}
-
Nick Burris authored
Set the separator color to the themed color rather than explicitly. This also ensures the separator is displayed properly in dark mode. Bug: 1110322 Change-Id: If5118967106eccdced837fcad8a45757a68d2315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368177Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#800381}
-
Hidehiko Abe authored
The current code hits static initializer check. Moved to a function so that it will be initialized on demand. Bug: 1119650 Test: Ran linux-rel tryjob. Change-Id: Id77428a3754892c6f17fab48030d9f44673e37ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364155Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#800380}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7fe82b28. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." d25ea9f6 "Copy and destroy frames on encode()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ib1b324f89a42a438ce34c7a7871e4a0fd407da3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368252Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800379}
-
Weilun Shi authored
Upon presubmit, will perform the following checks if histograms.xml, obsolete_histograms.xml or enums.xml is changed. - Validate prefix and pretty-print if histograms.xml is changed. - Pretty-print if enums.xml is changed. - Validate histograms contained are all obsolete if obsolete_histograms.xml is changed. Amended relevant files to take in relative path to a distributed histograms directory as system argument. Bug: 692201 Change-Id: I1797c0b65b53462cbb73820d8416a28651d1c65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359714 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#800378}
-
Michael Crouse authored
This change reworks the decision and hint logic to prepare for integrating with the optimization guide. The observer functions with an asynchronous callback so that hints can come either from the optimization guide or the current hint mechanism via Finch. The next change will start the integration with the optimization guide behind a flag. Bug: 1117064 Change-Id: I320635e795aafa2db2b2d413f766f94a4077cb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367024Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#800377}
-
Brandon Wylie authored
Bug: 1106862 Change-Id: Icfa00b176f54701caf7e6eadb4c6f4f749d40c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348016 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#800376}
-
Sebastien Lalancette authored
Recent Tabs should not have any overlap with Incognito. Bug: 1119377 Change-Id: Ic28d1c8ad7309e09e94478913956c8534bebe061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367973 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#800375}
-
Yue Zhang authored
This CL updates the content description of cards in grid tab switcher so that when focus on a group card, it should announce "expand [name] tab group with X tabs". Note that if there is no customized title, the [name] field should be empty. Bug: 1111942 Change-Id: I4630deeb5a0f0fe60707722af2b34e6dd4eff002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367028 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800374}
-
Lucía Cantú-Miller authored
ChromeDriver's list of emulated mobile devices that are supported should be re-generated for it to be up to date. Bug: chromedriver:3474 Change-Id: I11f9ca5598199bb80e13720ade0ba0d1e6c9b326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368157Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800373}
-
- 20 Aug, 2020 21 commits
-
-
Yue Zhang authored
This CL makes the views behind dialog scrim unselectable through View#setImportantForAccessibility. Since the parent view of the dialog view is CoordinatorLayout which is the same as those of CompositorViewHolder, toolbar, etc, this CL makes all other views in the same hierachy unselectable when dialog is open, and restores the importance when dialog is closed. Bug: 1101561 Change-Id: Iba726c3118d959e730108f44fc3e97b137a660b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364795 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800372}
-
Viktor Semeniuk authored
This change adds special handling for federated and blocked origin. Federated credentials are displayed without password field and blocked origins are displayed only with website value. Bug: 1075494 Change-Id: Iefa3e7d117a1ddc7abd24ba189f0a2b903bd9d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360081 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#800371}
-
Peng Huang authored
disable_by_gl_renderer: a string contain patterns to be used to match with gl renderer string. If any pattern in the string matches, vulkan will be disabled. force_enable_by_gl_renderer: similar to disable_by_gl_renderer, but if any pattern matches, vulkan will be enabled even if the GPU is blocklisted. params: Bug: 1022495 Change-Id: I04c1affd7c3c22baa4aa0bc048463f8f0a80d3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361042 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800370}
-
Charlene Yan authored
This reverts commit 91d6b1a9. Reason for revert: Suspecting this CL for closing the tree Unfortunately the compile error log is not very descriptive https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15804? Original change's description: > Add histograms_index file to record all available histograms xmls > > This histograms_index file provides a convenient way for a job to know > all of the histogram files without having to search for them. As we > split up histograms, we need a way to locate all available histograms > xmls and thus we need this index file. > > This cl also adds a PRESUBMIT check to make sure this index file is > up-to-date. > > Bug: 1116807 > Change-Id: Ifc55e421092448b5cecaa573f02e651a098428bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359234 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Auto-Submit: Weilun Shi <sweilun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800357} TBR=bcwhite@chromium.org,holte@chromium.org,sweilun@chromium.org Change-Id: Ia072d6f1f0bc23e73f9281631659ba1f6d52bb12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368416Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800369}
-
Matt Menke authored
This reverts commit b930822c. Reason for revert: Causing build failures due to conflict with https://chromium-review.googlesource.com/c/chromium/src/+/2364075 See, e.g., https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/538575? Original change's description: > [webcodecs] Implement Audio/VideoDecoder error callback. > > This is implemented in terms of an |is_closed_| state, which prevents > reentrancy during shutdown. > > Bug: 1045247 > Change-Id: I69e8bd095979f6571fbe95b298f91166b61dc9f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363998 > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800282} TBR=sandersd@chromium.org,chcunningham@chromium.org Change-Id: Ibff1740b70035b8242c15314cd760976d5a1efc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368456Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800368}
-
Trent Begin authored
The chrome mojom files for cros_healthd have gotten out of sync. This CL adds the following: - NetworkResult to the telemetry probe - kServiceUnavailable to probe error enum - kUnsupported to the routine status enum Bug: chromium:1084663, chromium:1115524 Change-Id: Ida1c79fb872152bf94bd77cbcfd33c9473a39279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346916 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#800367}
-
Lei Zhang authored
Add DCHECKs to make sure events have the right type. e.g. MouseInputEvent has its type field set to one of the InputEventType::kMouse* types. Bug: 1091834 Change-Id: I45f2d8b45435e38e2802a5e887bd1c286b4e5c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367117Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800366} -
Tommy Martino authored
This addresses a bug where the title and search bar overlapped in the NavigationItem in rare cases. Making the call to readd the search bar before the call to update the title style fixes the behavior, though the title style now won't change until the user interacts with the screen. It's hard to say exactly *why* this fixes the issue without some more knowledge of how UINavigationItem works internally, which we obviously don't have, but my hunch (and the reason I tried this approach) is that changing the title style triggers a re-layout of some kind. Bug: 1116407 Change-Id: I774a1fc9a77a71c01626ddef4dc2586575318a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367974Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#800365}
-
Marijn Kruisselbrink authored
FileSystemURL doesn't round-trip well through GURL, and it's much simpler to generate a child URL directly from the parent FileSystemURL anyway, so simplify NativeFileSystemDirectoryHandleImpl::GetChildURL to skip the conversions to/from GURL. Bug: 1093653 Change-Id: I13d515ca3e25ed7c8deca1ceb913b7dea58ed67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362768 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800364}
-
Lucía Cantú-Miller authored
Delete chrome/test/chromedriver/embed_extension_in_cpp.py, which is not used anymore. Edit chrome/test/chromedriver/chrome/navigation_tracker.cc, to remove kAutomationExtensionBackgroundPage. Bug: chromedriver:3376 Change-Id: Ia1a9c17263e682de7a57a826a0e1d7042ea6db02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367772Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800363}
-
Charlene Yan authored
This reverts commit 7fe82b28. Reason for revert: This caused a breakage and closed the tree Original change's description: > Roll Fuchsia AEMU from cG1zzefbD... to jrNR_ot01... > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll > Please CC chonggu@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: chonggu@google.com > Change-Id: Ie36b7fb24ee930592df6dfe1b94ff2428d4e3f0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366476 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800316} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chonggu@google.com Change-Id: I989aa94c71e1df949a2fa5d51c1fde14e6181102 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368453Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800362}
-
Zhenyao Mo authored
This is a reland of b7c98d05 Original change's description: > Work around where BRGA8 overlays are supported but not reported. > > On Intel GPUs where YUV hardware overlays are supported, BRGA8 > overlays seem to be supported, but the system fails to report > that. > > BUG=1119491 > TEST=manual, gpu_unittests > R=magchen@chromium.org > > Change-Id: I304aef3731f142c13c945ca22ce0df81afbcd21d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364580 > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Maggie Chen <magchen@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799901} Bug: 1119491 Change-Id: I1dc05b5f07e5ab8c8b6dcf5e45feaf0a28fe3531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367699Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800361}
-
Mohammad Refaat authored
All histograms updated on this CL are important and are being used to monitor the performance of APIs/Features CookieStore performance: IOS.Cookies.GetCookiesForURLCallResult IOS.Cookies.GetCookiesForURLCallStoreType App launching / App Spam detection performance IOS.RepeatedExternalAppPromptResponse Tab.ExternalApplicationOpened IOS.StoreKitLoadedSuccessfully Downloads success rate IOS.OpenIn.DownloadResult Bug: 1084097, 1084108, 1041527, 1077793, 1052998 Change-Id: Idd1f8f62885628e82d84de6cc6532e18b176ec1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366664Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#800360}
-
zhaoyangli authored
Add the test arg to iOS code coverage runner so that iOS disabled tests will be written to a file, parsed in test runner and reported to result json file. Use coverage builder as this is relative static information that's suitable to run on coverage CI builder. Note: This arg currently only works for outputting disabled GTests. Bug: 1065022 Change-Id: I6481e271b970397829f0f8301bd1089c7a0a6076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364029Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800359}
-
Xianzhu Wang authored
Bug: 878025 Change-Id: I8e65b6989cd6085d2b10717a46bfbccd54f735f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368155Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800358}
-
Weilun Shi authored
This histograms_index file provides a convenient way for a job to know all of the histogram files without having to search for them. As we split up histograms, we need a way to locate all available histograms xmls and thus we need this index file. This cl also adds a PRESUBMIT check to make sure this index file is up-to-date. Bug: 1116807 Change-Id: Ifc55e421092448b5cecaa573f02e651a098428bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359234Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#800357}
-
Shakti Sahu authored
Bug: 1116106 Change-Id: Ia8a5ab2d0fbbcb40e2df88161b7897783e80567d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354797 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800356}
-
Nicolas Ouellet-Payeur authored
Extension updates and force-installed extensions can trigger many installs at the same time, which is pretty slow. This CL mitigates that by launching multiple `CrxInstaller's in parallel, but still using a shared `SequencedTaskRunner' for parts of the installation that can encounter race conditions. DD: go/cbe-parallel-extension-installs Before/after comparison: https://imgur.com/a/Bfainaz Bug: 1103447 Change-Id: I5799b2f22985a34062abe6e74dac9fc56f135edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335639 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800355}
-
Chris Lu authored
Bug: 790886 Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#800354}
-
Junichi Uekawa authored
In Debian testing, lib32gcc1 is replaced by lib32gcc-s1 and no longer installable. BUG=chromium:1119692 TEST=./install-build-deps on rodete. Change-Id: I47a8e9d07ac0478a33cf31c6d8566a0e0f98aad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366381 Auto-Submit: Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#800353}
-
Patrick Monette authored
Bug: 993029 Change-Id: I898a87e8ea515778f1edcb518ada06ddf3d8e8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355089Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#800352}
-