- 10 May, 2019 40 commits
-
-
Tim Song authored
Currently, the notification bar abruptly disappears after the second to last notification is dismissed, which is quite jarring. This same animation will also be used when the clear all animation is updated to spec. Video: https://screencast.googleplex.com/cast/NDg3MjczMzQ3MzExMjA2NHw3ZmNmNGY5OC01Yw TEST=manually verified, updated unit test BUG=958276 Change-Id: I55bfeb4b23c1c2bda47ccd21dbef5a5955a62675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592701 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#658683}
-
Emil A Eklund authored
LayoutNG is a new layout engine for Blink designed to support modern web applications with predictable performance characteristics and extensible behavior. Fixes a large number of interoperability and correctness bugs. The goal of this field configuration and the finch trial is to allow for early metrics gathering in preparation for enabling LayoutNG by default. Bug: 591099 Change-Id: I566824fadbc8f022cb013db1566deb5b23f91537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590608 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658682}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c693cce42dc..f185df0cfd8c Created with: gclient setdep -r src-internal@f185df0cfd8c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: Ia64cb3a64dc001302fa3059e43ed17af3af3d669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606104Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658681}
-
Staphany Park authored
Without these changes, rolling Googletest results in compilation errors: https://crrev.com/c/1597689/1. TBR=ajwong, avi, morlovich, piman, rdevlin.cronin, xhwang Change-Id: Ic9c2c9c2b328ad1e501745dffd196a2386e99e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605840Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#658680}
-
sczs authored
- Creates InfobarContainer protocol so the ChildCoordinators can communicate with the ContainerCoordinator. Uses this to inform it they've stopped. - Nils the InfobarDelegate on stop. Bug: 911864 Change-Id: I108fbaa3e7a4b0ee73c4cf2e57ee3d969eba473d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605148Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#658679}
-
Annie Sullivan authored
Bug: 961725 Change-Id: I0b993083c4f222014675bbb3c7e4f7c9750a755b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603267Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb549d80..ee8d4aca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ab0cac5f951a4b203233519d0871c9b72ce3f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604325Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658677}
-
Christopher Cameron authored
Select the blink::WebThemeEngine at run-time. Delete references to long-deleted files. Bug: 961342 Change-Id: I3eecfb24b0fc31da4e7b90634ba7ccc1079b1f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602857Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#658676}
-
Mikel Astiz authored
This reverts commit 956715c7. Reason for revert: precautionary measure for canary releases over the weekend, to prevent the directory being deleted for users that haven't yet migrated to prefs. Original change's description: > Fix sync protocol violation about birthday requirements > > The sync (store) birthday can only be empty during the very initial > interactions with the server, when control datatypes are downloaded, > after enabling sync (or the user signing in, for sync-the-transport > mode). > > If, during startup, the birthday is empty, we should throw away all > sync metadata and redownload everything. One way to do so is to > regenerate the cache GUID, which datatypes detect as mismatch and > leads to all sync metadata being cleared. > > As can seen in newly added tests, the scenario seems hard to > reproduce, but we have server-side evidence that some users run into > this issue (and would even DCHECK-fail for DCHECK-enabled builds). > > Bug: 923285 > Change-Id: If9e4807a086001931fd65f3e12a1ab53c4a33c9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599456 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658540} TBR=treib@chromium.org,mastiz@chromium.org Change-Id: I4e65fcfa02d9e0cefe753839b0d56ecad8de0170 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606161Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658675}
-
Koji Ishii authored
This patch determines boundary shaping criteria more correctly. This change includes "must" criteria in the current spec: https://drafts.csswg.org/css-text-3/#boundary-shaping and also honor what HarfBuzz requires. 6 tests turn to pass. 3 tests need rebaseline because borders around "A" prevents kerning between space+A. Bug: 636993 Change-Id: I65f6cdb3cb32bccffa225641383abe25fce6abb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599062 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658674}
-
Erik Luo authored
Moves distance info into InspectorHighlight, which can be tested over protocol. Bug: 946873 Change-Id: Ica3cde18b2e993df843e1ff4491a8e8ca2358f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590453 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658673}
-
Dana Fried authored
Missed a typo and a comment on the original CL. Bug: 951907 Change-Id: If7ccecae4d23255e2dfc4f38779e20b3c0123dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605155 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658672}
-
Sébastien Séguin-Gagnon authored
Bug: 961776 Change-Id: I3d6d22599657bbcdef61370410d3deb002783fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605509 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
-
Yue Li authored
The policy indicator icon was not correctly shown and this cl fixes it. Bug: b/132281249 Test: Local build Change-Id: I28d31b3bf1b8e4876ecceb76d80f7f6186d3f4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601386Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#658670}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. pointerevent_support.js keeps many commonly used functions in the pointer event tests. There are click function for all input types, touch, mouse and pen. So I make the current touch tap function to a general "clickInTarget" function for all inputs. Bug: 606367 Change-Id: I8da3e8910c6ec0128a40d38ce6ac21bf24c449a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604328Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#658669}
-
Xiaocheng Hu authored
PreviousLinePosition() and NextLinePosition() are subroutines of SelectionModifier and only used there. Hence, this patch moves the two functions, together with their helper functions, to selection_modifier_line.cc for better code structure. This is also preparation for implementing hit test based up and down caret movements. Note: One VisibleUnitLineTest tests an exposed subroutine of PreviousLinePosition, which is inappropriate. This patch changes it to test up caret movement instead. Bug: 950728 Change-Id: Ia8a59e8de4bef53c5b4708c59e6995c9d6021687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603211 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658668}
-
Matthew Jones authored
This patch also removes the logic for the unused variations of the experiment and adds some basic unit tests for the feature. Bug: 894211,956095 Change-Id: I189c542e54d12db430a701b2c6feb62e59a978c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597693Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#658667}
-
Ryan Hamilton authored
Disable in-connection version negotiation in QUIC and change P2PQuicTransport to use a single supported version BUG=961472 Change-Id: I9db2ed94b6de916e6834c7169575f2f46aa3ebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603824Reviewed-by:
Seth Hampson <shampson@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#658666}
-
Caitlin Fischer authored
The contains_address bool previously determined which type of icon to add to a suggestion in the autofill-use-improved-label-disambiguation experiment. Ultimately, one icon was chosen, so contains_address is unused. This CL changes the boolean to store whether a LabelFormatter in the experiment was successfully created. If so, an icon is added. This change is necessary because unexpected forms, such as those without name fields, add an icon to suggestions that are not made with a LabelFormatter. However, in these cases it is preferred to not show the icons. Screenshot: https://screenshot.googleplex.com/7gsK2RE8Wu9 Bug: 951174 Change-Id: I8aa1434506d2639cf59677f53cf1540eeffd37b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602733 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658665}
-
Dana Fried authored
In normal browser cases, when the user backs out of the page info dialog, in some cases focus needs to be returned to the security chip/ location bar. In PWA/focus mode, since the page/app info dialog is launched from the three-dot app menu, focus needs to instead return to the web contents pane. (See attached bug for example.) This is a more general fix to a spot fix introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1362499 to solve issue 910067. We create a general system because the behavior is (a) substantively different depending on the calling context, and (b) often relies on code/access to views specific to the caller. Bug: 949066 Change-Id: Ideb8fdcb8ec09c580845b3c83c44eb3ab6c76ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600081 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658664}
-
Andrew Grieve authored
Script is almost working, but uploading .ndjson to the wrong directory. Bug: 873714 Change-Id: If75f693be6cbeafc4dbe4995208bbe76feaf4313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605153Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#658663}
-
Fredrik Söderquist authored
Put the setup of the broken image and placeholder elements in a helper class to make it easier to decipher what is being done, and also what depends on the ComputedStyle object and not. Bug: 953707 Change-Id: I675539611e5160e4e31523a1dbcea830fe5c7f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604267 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#658662}
-
Charlie Andrews authored
This reverts commit 24cade5c. Reason for revert: Breakage fixed before this CL took effect NOTRY=true TBR=sullivan@chromium.org CC=tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org Bug: 961434 Original change's description: > Disable browse:shopping:lazada and amazon where failing on Android Go > > NOTRY=true > TBR=sullivan@chromium.org > CC=tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org > > Bug: 96434 > Change-Id: Ic34d4f6221eecd7907273526a11021d57556a3a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603544 > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658269} TBR=sullivan@chromium.org,charliea@chromium.org Change-Id: Iec64491f99aab830af0d1ab136182b7ea16e9485 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 96434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605156Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#658661}
-
Gayane Petrosyan authored
Bug: 960982 Change-Id: I34059e493332e6dca9ed9e1fa91babd916523948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601636 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658660}
-
Mario Sanchez Prada authored
This API is not used anywhere yet so let's remove it for now and will re-add it back in the future when it's actually needed. Bug: 919392, 957520 Change-Id: I5bbf6dc8fa8ddeac53ee408d162429da148410e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587026Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#658659}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I6e16e5740f7a244306d8c3b0c0dcab7131ca7d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600550Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#658658}
-
Evan Stade authored
1. Ash's CastConfigController and mojom::CastConfigClient are merged into an interface called CastConfigController, implemented by Chrome. 2. CastConfigControllerObserver and mojom::CastConfig are combined into CastConfigController::Observer. Functional changes: 1. CastDetailedView becomes an observer of CastConfigController. This is because UnifiedCastDetailedViewController appears to have been observing on behalf of CastDetailedView, yet never actually added itself as a CastConfigController observer. 2. CastConfigMediaRouter is created before Shell and shut down after it. This is required for clients in Ash to be able to start observing it during their construction/init phase. Bug: 958194 Change-Id: If05134507d13be593e2bb1c8b531c74e9d115ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601704Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7fe5a06d9f15..cb9bf9ac9dc2 git log 7fe5a06d9f15..cb9bf9ac9dc2 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 chrisforbes@google.com Add remaining required SPIRV extension names Created with: gclient setdep -r src/third_party/swiftshader@cb9bf9ac9dc2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130937460 TBR=swiftshader-team+autoroll@google.com Change-Id: I5ed9a73e7c536c9c3263a9170ae28f93afa2d887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658656}
-
François Doray authored
Change-Id: Ic01fe39af680c38914d649c7b1dccc415091b3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586234 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#658655}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9c05e647cb98..0e1901c5709f git log 9c05e647cb98..0e1901c5709f --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Fix os.path.exists on symlink." Created with: gclient setdep -r src/third_party/perfetto@0e1901c5709f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9a26471e1f9395286f3e4c6baf3fdb0e47f67610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606101Reviewed-by:
-
Olivier Robin authored
The conversion needs to take care of std::string containing binary data for PDFs. SysUTF8ToNSString only converts std::string containing strings. Bug: 961741, 942292 Change-Id: I6cd5db9a914f5d752e7589421f83e876707a73b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605916 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#658653}
-
dpapad authored
Previously a gzipped_resource_file_map_source/header Grit output was used to determine which component extension resources are gzipped. This is no longer necessary. This is in preparation of deleting gzipped_resource_file_map_source Grit output completely. Specifically: - Modify chrome_url_request_util.cc to use ResourceBundle::IsGzipped. - Remove ComponentExtensionResourceInfo struct and update all signatures, basically reverting a lot of the changes made at r627283, since they are no longer necessary. - Remove last usages of type="gzipped_resource_file_map_source" in grd files. Bug: 961063 Change-Id: Ifc9d1535c96e4a168b3d45f3c831976e52c9444a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601481Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#658652}
-
Ehsan Karamad authored
From the preliminary UMA on Canary (FocusWithoutActivation*) and given the security concerns with programmatic focus this CL will disallow (programmatic) focus from sub frames that are sandboxed, or detected to be ads. Bug: 954349 Change-Id: I35d59008739112379fb53e6b20469856289f052e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601344 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658651}
-
Nate Chapin authored
It appears that this was only necessary because we weren't cancelling the javascript url execution if document.open() was called. This was fixed in https://chromium.googlesource.com/chromium/src/+/4b6c1ccdd1ec5df078905f511913a42f0b3bc5b0 Bug: 923585 Change-Id: Ia11aec5ad6fe6dacf9edd7b26813ef6b43e15344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593494 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
John Budorick authored
This reverts commit bb6ea0af. Reason for revert: need to target the correct internal pool. Original change's description: > Add sizes.py isolated_script to chromium.chrome bots. > > These are all already running sizes.py via SizesStep. Once this > lands, I'll remove the SizesStep invocations. > > Bug: 961548 > Change-Id: I72b28170ad529e9d7de2c54d8ab7c35000ff3349 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604471 > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658613} TBR=agrieve@chromium.org,jbudorick@chromium.org Change-Id: I5bfc4b982efeb6d684568cd03d2433f3fca462fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605512Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#658649}
-
Koji Ishii authored
This patch fixes AX name property for image list marker. This code path is covered in DumpAccessibilityTreeTest.AccessibilityListMarkerStyles/blink in content_browsertests. Bug: 725277 Change-Id: I9cea71830f79eaa922bbd2491cfa90b157367d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605825 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Emil A Eklund authored
Remove the virtual LayoutNG test suite in preparation for launch, in the meantime the dedicated linux_Layout_tests_layout_ng bot provide coverage for LayoutNG. As soon as the flag is on other bots will switch to NG one at a time, to minimize unnecessary, repetitive test expectation updates. Bug: 961437 Change-Id: Ie826c80ccfbec2eb4e0ca9bb40d63252b1fab184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604047Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658647}
-
David Maunder authored
Add more tests for Task IDs and integrate with Task ID metadata passed from Java layer for cross-tab navigations. Task IDs track navigations and relationships between navigations. These are typically tracked via NavigationEntryCommitted() on WebContentsObserver. However, support does not exist for a cross-tab navigation. To improve Task ID tracking, this data is passed from the Java layer but is only currently supported in Android. Bug: 958463 Change-Id: If85cf9d5fb6013f09e4ee648b4d5bd57e88f2a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600732 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658646}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I076f80229a09f8ff8faec8b6d677fd0e5f5310f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601621Reviewed-by:
-
Rouslan Solomakhin authored
This patch separates the implementation of mojom::PaymentHandlerHost interface from payments::PaymentRequest into its own class payments::PaymentHandlerHost, so it can be used from Java in an upcoming patch. Instead of payments::PaymentRequest being a mojom::PaymentHandlerHost, payments::PaymentRequest now has a private member payments::PaymentHandlerHost, which implements the mojom::PaymentHandlerHost interface. Bug: 884680 Change-Id: I581bd73243be1302f72973b7ce01b5c397efc537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604311Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658644}
-
