GitLab

This also makes some minor modifications (add trailing periods, eliminate
unneeded comment, etc.).

BUG=563793
TEST=none

Review-Url: https://codereview.chromium.org/2389703004
Cr-Commit-Position: refs/heads/master@{#422718}

https://chromium.googlesource.com/chromium/src/+/8d329a8b3

BUG=651940
TBR=malaykeshav@chromium.org

Review URL: https://codereview.chromium.org/2389113002 .

Cr-Commit-Position: refs/heads/master@{#422717}

These settings no longer hook up to actual data; they just return
'allow' always, and setting them has no effect. Updated documentation.

This is because Chrome now (and has for awhile) ignores these settings
and always permits these actions without asking the user.

BUG=591896

Review-Url: https://codereview.chromium.org/2358893004
Cr-Commit-Position: refs/heads/master@{#422716}

BUG=652535
TBR=ikilpatrick@chromium.org

Review-Url: https://codereview.chromium.org/2384393002
Cr-Commit-Position: refs/heads/master@{#422715}

We add/remove/etc animations to AnimationPlayer now.
ElementAnimations is a light helper class.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2377223002
Cr-Commit-Position: refs/heads/master@{#422714}

In following CL, I accidentally skipped null check for |innerNode|:
https://chromium.googlesource.com/chromium/src/+/66f8f14f5560949660ad6efc0b00484d8342a
15e%5E%21/#F4

This has caused null-ref error.

BUG=633073

Review-Url: https://codereview.chromium.org/2390613002
Cr-Commit-Position: refs/heads/master@{#422713}

This CL rolls the DEPS to pull in the latest cros_system_api, which adds
the constant for the SetAdvertisingIntervals method. It also fixes a few
nits from the CL that added the setAdvertisingIntervals code,
https://codereview.chromium.org/2353133005/

R=ortuno@chromium.org
BUG=637231

Review-Url: https://codereview.chromium.org/2390063002
Cr-Commit-Position: refs/heads/master@{#422712}

We don't need to preserve the state of cc::ElementAnimations between
detach/attach. All state lives in cc::AnimationPlayer now.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2363733004
Cr-Commit-Position: refs/heads/master@{#422711}

Use enclosingLayoutRect instead of enclosingIntRect in SVGLayoutSupport::transformPaintInvalidationRect()

https://bugs.chromium.org/p/chromium/issues/detail?id=651521#c2:
The purpose of the original enclosingIntRect() might be to avoid
unwanted inward-snapping due to FloatRect -> LayoutRect conversion.

Change it to enclosingLayoutRect. Also changed PaintInvalidator to
use enclosingLayoutRect when converting from FloatRect to
LayoutRect.

BUG=651521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2380403002
Cr-Commit-Position: refs/heads/master@{#422710}

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2357533002
Cr-Commit-Position: refs/heads/master@{#422709}

As spec'd by https://drafts.fxtf.org/filters-2/#BackdropFilterProperty

BUG=497522

Review-Url: https://codereview.chromium.org/2379803003
Cr-Commit-Position: refs/heads/master@{#422708}

Android apps can use the broadcast to start automatically. This
Change disable ACTION_BOOT_COMPLETED broadcast for 3rd party
applications.

BUG=650313

TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*"

Review-Url: https://codereview.chromium.org/2359003004
Cr-Commit-Position: refs/heads/master@{#422707}

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2382103006
Cr-Commit-Position: refs/heads/master@{#422706}

https://chromium.googlesource.com/chromium/src/+/234079c8f

BUG=627588
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2391813003 .

Cr-Commit-Position: refs/heads/master@{#422705}

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2349643003
Cr-Commit-Position: refs/heads/master@{#422704}

This CL refactors WebappRegistry and WebappDataStorage to make most of
the methods synchronous. WebappRegistry is now a singleton instance that
is instantiated at browser startup. This allows all SharedPreferences files to
be pre-warmed before the class is used; new web apps open new
SharedPreferences on a background thread when registered, after which the
preferences are cached automatically.

Most static methods on WebappRegistry and WebappDataStorage have been
converted to instance methods or removed. This makes the code much
cleaner and more efficient; each static method had to independently open
their SharedPreferences, which minimally performs a stat() on the
underlying XML file to see if it has changed. Now the singleton
WebappRegistry caches all WebappDataStorage objects on startup and
whenever new ones are added. This reduces disk IO overhead.

This CL allows all calls to SharedPreferences.Editor.apply() in
WebappRegistry and WebappDataStorage to occur on the main thread,
mostly removing the need for unwieldy callback interfaces and bare
pointer passing across the JNI.

BUG=633791

Review-Url: https://codereview.chromium.org/2351113005
Cr-Commit-Position: refs/heads/master@{#422703}

WTF::Strings are not null-terminated, so this error would cause a single
character to be read past the end of the string, if the string ends in an
unfinished escape sequence.

(This parser is not currently used by any code in blink)

This also adds a test that would have caught this error, if run on an MSAN
bot, and fixes the same code in the DevTools parser. The DevTools parser
would not trigger an out-of-bounds read in the same situation, since it
operates on null-terminated string data.

Also added is the fuzzer which caught the issue in the first place.

BUG=651166
R=dgozman@chromium.org, mmoroz@chromium.org, pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/2380823002 .

Cr-Commit-Position: refs/heads/master@{#422702}

ARC standalone project was cancelled. Let's remove that code.

BUG=None
TEST=trybots

Review-Url: https://codereview.chromium.org/2384173004
Cr-Commit-Position: refs/heads/master@{#422701}

OnMemoryStateChange() callback is invoked on the UI thread but we can't
call GetDefaultMemoryLimit() from the UI thread. Store the default limit
on construction.

BUG=652557

Review-Url: https://codereview.chromium.org/2388403002
Cr-Commit-Position: refs/heads/master@{#422700}

TestSimpleTaskRunner::GetPendingTasks copies whole set of the pending
task for each invocation. That prevents a migration to the non-copyable
Callback.
This CL replaces it with newly added TakePendingTasks and others.

BUG=554299
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2331423002
Cr-Commit-Position: refs/heads/master@{#422699}

When the memory coordinator is enabled, SdchOwner becomes a client of
the memory coordinator instead of installing MemoryPressureListener.

In the implmentation of this CL, both MemoryPressureListener and
MemoryCoordinatorClient are installed regardless of the flag, but as
default MemoryCoordinator is not enabled and when MemoryCoordinator is
enabled by a flag, it is planed to suppress MemoryPressureMonitor
features.

Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b#

BUG=639700

Review-Url: https://codereview.chromium.org/2390603002
Cr-Commit-Position: refs/heads/master@{#422698}

When the memory coordinator is enabled, SSLClientSessionCache becomes a
client of the memory coordinator instead of installing
MemoryPressureListener.

In the implmentation of this CL, both MemoryPressureListener and
MemoryCoordinatorClient are installed regardless of the flag, but as
default MemoryCoordinator is not enabled and when MemoryCoordinator is
enabled by a flag, it is planed to suppress MemoryPressureMonitor
features.

Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b#

BUG=639700

Review-Url: https://codereview.chromium.org/2384703002
Cr-Commit-Position: refs/heads/master@{#422697}

This CL fixes a use-after-free in SocketPump::Init() in
content/browser/devtools/protocol/tethering_handler.cc

BUG=652522

Review-Url: https://codereview.chromium.org/2390883003
Cr-Commit-Position: refs/heads/master@{#422696}

The changes to CLD3 are:
- tuning the probability threshold for deciding if a prediction
  is reliable or not
- improving the text processing in the function FindLanguage
  which is currently not used in Chrome

BUG=652538

Review-Url: https://codereview.chromium.org/2392443002
Cr-Commit-Position: refs/heads/master@{#422695}

When running 'chrome --mash' on device, all the resource files necessary
for ash, mus etc. apps are already in the resource files used for regular
chrome. So instead of deploying separate resource files for these apps,
just load chrome's resource files, before initializing the app.

BUG=628715, 633656

Review-Url: https://codereview.chromium.org/2387233002
Cr-Commit-Position: refs/heads/master@{#422694}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ca6b6b16..714e94ae

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2386343003
Cr-Commit-Position: refs/heads/master@{#422693}

BUG=563793

Review-Url: https://codereview.chromium.org/2384263003
Cr-Commit-Position: refs/heads/master@{#422692}

- Greater code organization.
- Promotion of files being "include-what-you-use" clean. Less files now need
  to include "net_log.h"; these files are no longer susceptible to having their
  includes hidden by the many inner includes of "net_log.h".
- All touched files are also now forward-clean re: NetLog,
  NetLogCaptureMode and the new, extracted classes.

Here is the new structuring:
  - NetLogSource (net_log_source.h/.cc)
  - NetLogEntry, NetLogEntryData (net_log_entry.h/.cc)
  - NetLogWithSource (net_log_with_source.h/.cc)

***Did not extract NetLog::ThreadSafeObserver into its own class since
   NetLog::ThreadSafeObserver and NetLog are interrelated enough to keep
   NetLog::ThreadSafeObserver as an inner class.

Further Notes:
1) On top of scripting, all files were checked manually, ensuring:
     - Forwards/including added only when appropriate. No extras added.
     - "net_log.h" include removals done correctly. No "net_log.h"-hiding
       to occur as a result of new changes.

2) Just as any .cc file will not do the include/forward if the paired .h file
   already has the include/forward, *_unittests.cc, *_browsertest.cc and
   *_test.cc files exhibit the same behavior when they have a paired .h file.

3) Override methods' types do not add to logic for inserting forwards, since it
   is guaranteed that the base class has the forward.
     - Saw this done in codebase several times, so making sure to
       follow the same rule.

4) A big change was the mass adjustment for the include-hiding of
   NetLogCaptureMode by net_log.h includes. Now the NetLogCaptureMode class is
   being properly forwarded/included in all files changed by the original
   NetLog inner classes extraction work.

5) Many NetLog/NetLogWithSource includes/forwards were added across codebase.
   All instances of files seeing their NetLog/NetLogWithSource include/forward
   being hidden by their own includes should now be gone. This is to promote
   greater flexibility in future changes upon the codebase.

BUG=473710
R=eroman@chromium.org,tfarina@chromium.org
TBR=droger@chromium.org, hirono@chromium.org, rdevlin.cronin@chromium.org, skyostil@chromium.org, wez@chromium.org, juliatuttle@chromium.org, sergeyu@chromium.org, dgozman@chromium.org, hubbe@chromium.org, rdsmith@chromium.org, stevenjb@chromium.org, scheib@chromium.org, bengr@chromium.org, alokp@chromium.org, raymes@chromium.org, samuong@chromium.org, creis@chromium.org, scottbyer@chromium.org, zea@chromium.org, mmenke@chromium.org, eranm@chromium.org

Review-Url: https://codereview.chromium.org/2333923004
Cr-Commit-Position: refs/heads/master@{#422691}

BUG=649795

Review-Url: https://codereview.chromium.org/2381063003
Cr-Commit-Position: refs/heads/master@{#422690}

cached-69296-expected.html was created slightly incorrectly, causing
cached-69296.html to fail.

BUG=613728

Review-Url: https://codereview.chromium.org/2387273002
Cr-Commit-Position: refs/heads/master@{#422689}

This CL takes us two steps along the long windy road to an out of
process display compositor.

1. In the near future, SurfaceIds will be allocated in clients in order to
avoid sync IPCs for offscreen canvas. Thus, we need to reduce our
reliance on SurfaceIdAllocator. SurfaceIdAllocator is often used simply
to find out the frame_sink_id(). This CL gives owners of
SurfaceIdAllocator a FrameSinkId directly and removes that accessor
from the ID allocator. This significantly reduces usage of
SurfaceIdAllocator.

2. SurfaceFactory's role was not well defined previously. It practice, it
corresponds to a single CompositorFrameSink but in tests, surface IDs
with different FrameSinkIds were submitting CompositorFrames to
the same SurfaceFactory. This CL establishes the invariant that a
SurfaceFactory belongs to a single CompositorFrameSink. In the near
future, we won't need to pass a SurfaceFactory a full SurfaceId
anymore, we can simply give it the "LocalFrameId" part and assume
a constant FrameSinkId. This will reduce the the data needed to send to
FrameSinkObservers from SurfaceFactories and from frame sources to
SurfaceFactories.

BUG=647852
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2383373002
Cr-Commit-Position: refs/heads/master@{#422688}

Cr-Commit-Position: refs/heads/master@{#422687}

BUG=636490

Review-Url: https://codereview.chromium.org/2370943003
Cr-Commit-Position: refs/heads/master@{#422686}

BUG=651897

Review-Url: https://codereview.chromium.org/2386153004
Cr-Commit-Position: refs/heads/master@{#422685}

Recalculate overscroll when shrinking the page, so we don't end up with
a scrollbar for the empty space below us.

BUG=none
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2382603002
Cr-Commit-Position: refs/heads/master@{#422684}

Add HeliumResult-to-string mapping for easier logging.
Add unit tests for string conversion functions.

R=lethalantidote@chromium.org,gcasto@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2385913002
Cr-Commit-Position: refs/heads/master@{#422683}

Review-Url: https://codereview.chromium.org/2378103006
Cr-Commit-Position: refs/heads/master@{#422682}

It's important to check this return value to make sure that
deserialization actually succeeded.

BUG=652129

Review-Url: https://codereview.chromium.org/2392713002
Cr-Commit-Position: refs/heads/master@{#422681}

Otherwise we'll end up with error that gets larger according to the percentage.

Note that subpixel accumulation is already plumbed through for transforms in
other ways.

BUG=627588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2386263002
Cr-Commit-Position: refs/heads/master@{#422680}

This sets up the framework for a LayerTreeHostRemote that implements
the LayerTreeHost API when the compositor is running across a network
boundary.

This change only sets the framework for running/scheduling main frame
updates and pushing the serialized state using the
CompositorProtoStateSink. Subsequent patches will add state
serialization.

BUG=648442,652502
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225
Review-Url: https://codereview.chromium.org/2362073002
Cr-Original-Commit-Position: refs/heads/master@{#422555}
Cr-Commit-Position: refs/heads/master@{#422679}