- 30 Jun, 2020 40 commits
-
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I0349ddcf227357da19936e5c6c5908b9229aaf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276230 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784148}
-
Etienne Pierre-doray authored
To re-use the same logic in ThreadProfiler and TracingSamplerProfiler. Bug: 1098119 Change-Id: I3ae23af070e8a9798a2cc771c8fc347bb4fc3570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269741 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#784147}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/608e0dbc1073..c9336155e045 2020-06-30 sque@google.com infra: Do not start/stop Goma for gcc builders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093641 Tbr: jophba@chromium.org Change-Id: Id2bfa95708e7966bb1988cc07f25d1337a0cc64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784146}
-
Yue Ru Sun authored
This patch fixes the crash on debugging build when visiting chrome://ukm due to CheckFeatureIdentity(UkmSamplingRate) failure. COMPONENT_EXPORT makes the definition of the base::Feature UkmSamplingRate from ukm_recorder_impl.cc exported and shared by the libraries that reference it, ensuring there's only one copy of the base::Feature in memory. Bug-id: b/160004246 Change-Id: Icda0e0a403538a263f8132afc19dd0cb455395db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274240 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#784145}
-
Dominic Mazzoni authored
We let all of the ImageAnnotationService.* histograms expire because we weren't using them post-launch, but two of these would be useful for an M85 launch because we expect it to affect the average number of queries sent by each user. Bug: 1091538 Change-Id: Ic03beccaff7b8c41d36c4db0c4f6f598f12eebb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271013 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#784144}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I5f728078d3bf620b1f1707cabab912b9bff2d3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276405Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784143}
-
Philip Rogers authored
This patch cleans up flakiness caused by video-overlay-scroll.html which had a fullscreenchange event handler that fired twice, but was only intended to fire once in the test. The test used waitForEventAndEnd which continued calling the event handler after the test ended. This patch updates this function to waitForEventOnceAndEnd which makes it clear that the event handler will be removed after firing once. The root-cause of this flakiness is being fixed in https://crrev.com/c/2275348 and this patch is just followup cleanup. Bug: 1048597 Change-Id: I4b7473879085e5a7f91875f4daa53a2891c9274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275350Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784142}
-
Leonid Baraz authored
Change-Id: I343e0cc357dc0f1d6d7e179af6183ed0e3a2d001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276229Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#784141}
-
Dominique Fauteux-Chapleau authored
This is a new field in that policy that allows a minimum size to avoid scanning small strings. This also adds a UMA metric to track data entry sizes. Bug: 1093348 Change-Id: I3f390563560c9e3ced1ecfe91ed95a74edb725f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268378Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784140}
-
Morten Stenshorne authored
Need to check if page breaks are applicable before applying them. Bug: 1100308, 1053768 Change-Id: I987bf4ce42f7d0f5128cb01c30824214d9c12ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276432Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#784139}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/769129fb29fc..de4aedaec33c $ git log 769129fb2..de4aedaec --date=short --no-merges --format='%ad %ae %s' 2020-06-26 marpan vp9-svc: Fix to setting frame size for dynamic resize 2020-06-23 marpan vp9-svc: Allow scale_references for single layer svc 2020-06-18 jzern tools/lint-hunks.py: skip third_party files 2020-06-17 jzern update googletest to v1.10.0 2020-06-18 jzern vp9_skip_loopfilter_test: make Init() return a bool Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: Ib7048b0c6d3445637799d1a73868d1d41f2cc880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276343Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#784138}
-
Ryan Daum authored
Follow-up after fixing the JNI classname; unfortunately previous CL was mistakenly thought to fix the issue but the bug remained. This CL fixes: * Classname signature (missing $) * Method signature (extraneous ';') * Calling method (Should be CallVoidMethod) Tested on physical Android things device. Bug: internal b/159235968 Test: manual on device Change-Id: I5907ab842740e697e80d757a2f96485ba63c7f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276242Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#784137}
-
Parastoo Geranmayeh authored
TBR=rdevlin.cronin@chromium.org Bug: 1101043 Change-Id: I3800f216129dc04895c821db5bfda7887d91878d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275900Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#784136}
-
Avi Drissman authored
WebContents has both IsFullscreenForCurrentTab() and IsFullscreen(). It really only needs one. Consolidate them both into IsFullscreen(). Bug: 1100727 Change-Id: I3c578653089979b8dee9045f0d6b441cda975ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275148 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784135}
-
James Zern authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/bf190c43e5c7..ba8dd2919fca $ git log bf190c43e..ba8dd2919 --date=short --no-merges --format='%ad %ae %s' 2020-06-25 jzern detect fuzzing w/FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION 2020-06-24 jzern fix kDefaultRestorationTypeCdf size 2020-06-23 vigneshv film_grain: Avoid some implicit bool->int conversions 2020-06-23 vigneshv trivial: Isolate some declarations 2020-06-23 vigneshv tile: Move some functions out of Tile class 2020-06-23 vigneshv film_grain: Remove multiplication by 1 2020-06-23 jzern GetMaskBlendFunc,cosmetics: simplify lookup index 2020-06-23 vigneshv decoder_impl: Move some functions out of DecoderImpl 2020-06-23 vigneshv decoder_impl: Remove AllocateCurrentFrame 2020-06-23 vigneshv deblock, trivial: Add a const declaration (...) 2020-05-14 jzern dsp/CdefFilter,cosmetics: make src pointer uint16_t 2020-05-14 jzern ApplyCdefForOneUnit: fix implicit int -> bool conv 2020-05-14 vigneshv trivial: Rename output_frames_ to output_frame_queue_ 2020-05-13 vigneshv Add support for outputting all layers 2020-05-13 linfengz trivial: reduce block buffer size 2020-05-13 linfengz dsp,trivial: add comments in sfg sse4 2020-05-13 jzern fuzzer_temp_file.h: fix unused function warning 2020-05-13 slavarnway arm: Improve CdefFilter_NEON() 2020-05-12 linfengz make PrepareLoopRestorationBlock() a static member of PostFilter 2020-05-12 vigneshv deblock: Change the plane ordering Created with: roll-dep src/third_party/libgav1/src Change-Id: I8ae7a8bfcec3009072b89682700d73b315aebd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274961Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#784134}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c62a7b034c0..09dbeff19a9d 2020-06-30 johnstiles@google.com Update SkModeColorFilter to support an input FP. 2020-06-30 robertphillips@google.com Make asDirectContext return a GrDirectContext 2020-06-30 johnstiles@google.com Redesign GrXfermodeFragmentProcessor to use one FP instead of two. 2020-06-30 bsalomon@google.com Fix release build of viewer with Vulkan 2020-06-30 mtklein@google.com careful constants map handling 2020-06-30 jmbetancourt@google.com performance increase by not drawing on do nothing frames 2020-06-30 csmartdalton@google.com Use SkTPin instead of std::clamp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I8e911be33ec2d42c7ea829a352609d33056b1645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784133}
-
Jonah Ryan-Davis authored
After landing fixes for multithreaded context use in ANGLE's GL backend, this test suite can be re-enabled. Dawn gl_tests will be changed to use passthrough on Linux, because that's what's being shipped on stable. For now, Mac dawn gl_tests will continue to use the validating command decoder. Bug: chromium:1090853 Bug: angleproject:4725 Bug: chromium:1099770 Bug: chromium:1099763 Bug: chromium:1099766 Bug: chromium:1099768 Bug: chromium:1100970 Bug: chromium:1100975 Bug: chromium:1100980 Change-Id: I55bc99e95a7d66756fe305fa1e73e28f4228687b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270598 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#784132}
-
James Long authored
The code has been refactored to use MVC to communicate data throughout the page, seeing the addition of Page{Model, Controller} classes. The visualization code (renderGraph) has also been refactored into a view, with some changes made to align better with idiomatic d3 (using data joins). The simulation speed has also been modified to use a quadratic ease in/out to make the animation of new nodes more natural. Bug: 1093962 Change-Id: I47d02c7fd9135c4537cc3c715acb88240e997ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274284 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#784131}
-
Balazs Engedy authored
Make the description of PluginsAllowedForUrls and PluginsBlockedForUrls reflect that wildcards are no longer supported in patterns, and update the example. Bug: 1073883, 1101038 Change-Id: Id6e441d4b8c3989cbcdc6878de480658b221fd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270211 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784130}
-
David Bertoni authored
This test was disabled a long time ago. It passed with flying colors through 3000 iterations on the bots. Bug: 239022 Change-Id: If83572595b1b75e495796b89a496a099bff913bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264028Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784129}
-
David Bertoni authored
This test was disabled as flaky many years ago. It survived 3000 iterations on the bots without flaking. Bug: 238667 Change-Id: Iccca0a869263a8e3025b374a0f89d512ddb255c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265184Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784128}
-
Peng Huang authored
Bug: 1087063 Change-Id: I9ca40e9f4f6164157d39ae314d87addcbd3b6204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276222Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784127}
-
Kyle Horimoto authored
Prevents need for other reviewers to stamp misc CrOS files changed in a CL. Change-Id: Ib01eb2efd7d3770e9e3ca268cc13370a2b7a87b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274841 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784126}
-
Joe Mason authored
Also fixes use after free when the decorator is removed from the graph. R=chrisha Bug: 1080672 Change-Id: I0c6a6bac4d82baa3d27b462ca3426d467cb655da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268588 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784125}
-
Charlene Yan authored
IsFirstVisibleTab is a misnomer and IsLastVisibleTab is not used. Changed name to IsTabFirst to match pattern of other methods. Bug: 1018230 Change-Id: Ib39349fbff60f1d3a39e0a708f2c1fa566ae03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275156Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784124}
-
Chris Cunningham authored
Bug: 751838 Change-Id: Id02455bb7215e048d6f1cdbf1ddcea594e54a6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273481 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784123}
-
Chong Gu authored
Fix incorrectly added tags for Fuchsia filters. Change-Id: Ic5d4b708f99f5af81b80315a00bcccf60bb324ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274330Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#784122}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/237a776bc179..7ec6f400ea25 2020-06-30 hjd@google.com Merge "ui: Unify quantization size choice" 2020-06-30 hjd@google.com Merge "ui: Fix presubmit" 2020-06-30 treehugger-gerrit@google.com Merge changes I5f127003,If0c6afe9 2020-06-30 treehugger-gerrit@google.com Merge "Add superclass field to the classes table" 2020-06-30 treehugger-gerrit@google.com Merge "Use power profile for core mappings" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia3e495d4ce7cc3a6a06b54658c56db87c13d01d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784121}
-
Gavin Williams authored
This CL creates a dedicated function for handling up/down key presses when focus is on the print preview dropdown. To match the <select> element's behavior, when at the bottom of the dropdown list, pressing down will not wrap back to the top. And vice versa. Bug: 1059607 Change-Id: I89d977617745ba2412eeed08f0312fc6f0f01d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273497 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784120}
-
Sasha McIntosh authored
When an SkImage is created with YUV planes, the caller is responsible for lifetime of those planes. This change ensures that texture backed PaintImages maintain a reference to the YUV planes |sk_planes_| used to generate an SkImage as well as the |sk_image_| itself. Bug: 1091347 Change-Id: If253b3f4d047432dc4ab48d99563168ee7d5ea1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264259 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784119}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic4e73dd90a476fee76673e6ff5c9985bde43087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784118}
-
Wei-Yin Chen (陳威尹) authored
Bug: 925965 Change-Id: Ieba151adfdfcf5b2419ba9396766426ea943703f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274973 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#784117}
-
Li Lin authored
Quick Answer result is cached when getting it from the server. The result type is then used for logging purpose. Currently, the result doesn't get reset when user select a new text. If users perform actions before the result came back from the server, the cached result type is used for logging. This CL reset the result when user select a new text and trigger QuickAnswers. Bug: b/160244136 Test: Manual test Change-Id: I526684755b7876aa0b6df12513ead9284a5454c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276513Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784116}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: If620bd17399f0e20c6a2e37b09209dcfbbe6078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159949Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784115}
-
Dylan Cutler authored
This reverts the manual instrumentation done in: https://chromium-review.googlesource.com/c/chromium/src/+/2186997 In favor of bindings-based instrumentation introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2245048 Bug: 973801 Change-Id: I0b562c6326689bd084f8a217aa805fa3495fae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267421Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#784114}
-
Becca Hughes authored
Fix the bug by checking we have not reached the end before accessing. BUG=1095560 Change-Id: I309237562ddd5058c3b3b99d58a03c526cf49b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276511 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784113}
-
Francois Doray authored
OneCopyRasterBufferProvider::Playback() acquires the GpuChannelHost, which is also acquired from high priority tasks. It should not run at background thread priority because that can cause priority inversions, as shown by Slow Reports (see the bug). A follow-up CL https://crrev.com/c/2157659 adds a DCHECK to ensure that the GpuChannelHost lock does not cause other priority inversions than the one fixed in this CL. Bug: 1072756 Change-Id: I3cd7bd9a67e15c0079db35aeab3d1805e2b61835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240141 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784112}
-
Steven Bingler authored
Increase the expiry date to M90. Bug: 1072566 Change-Id: Ic6da0060ec9717bc4733e86141abfe7a5842dcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275465Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784111}
-
Philip Rogers authored
Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, dirtying TestRunner state for the next test. A navigation to about:blank is done after every test. This patch resets the TestRunner state after the navigation to about:blank, when we are sure no test javascript can change TestRunner state. This fixes a class of flaky bugs. This behavior happened with video-overlay-scroll.html which would set a custom layout dump (setCustomTextOutput) in a fullscreenchange event handler. This event handler was not removed at the end of the test (this will be fixed in a followup), and would run a second time, after the custom text output setting was reset. This caused later tests to run with custom text output from video-overlay-scroll.html. With this patch, video-scrolled-iframe.html is no longer flaky. Code in WebFrameTestProxy::BeginNavigation to intercept navigations relied on TestRunner::PolicyDelegateEnabled being reset before it ran. This patch now skips WebFrameTestProxy::BeginNavigation when the test is not running. Bug: 1048597 Change-Id: I888f7cc2ae91d7d3cfdd143a7573f62cb052c1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275348Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/584a47eb..df954ac3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16a4e1093dcb4fe8968b434729059a93a6b809b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275463Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784109}
-